)]}'
{"cinder/tests/unit/volume/drivers/hpe/test_hpe3par.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"b01314cab79be354219a27fb12186ec1d8571d8f","unresolved":true,"context_lines":[{"line_number":3565,"context_line":"                self.standard_logout)"},{"line_number":3566,"context_line":""},{"line_number":3567,"context_line":"    @mock.patch.object(volume_types, \u0027get_volume_type\u0027)"},{"line_number":3568,"context_line":"    def test_create_volume_from_snapshot_as_child_and_extend("},{"line_number":3569,"context_line":"            self, _mock_volume_types):"},{"line_number":3570,"context_line":"        # setup_mock_client drive with default configuration"},{"line_number":3571,"context_line":"        # and return the mock HTTP 3PAR client"}],"source_content_type":"text/x-python","patch_set":2,"id":"488040d1_6b8d3056","line":3568,"updated":"2021-03-26 07:09:28.000000000","message":"code of test_create_volume_from_snapshot_as_child_and_extend and test_create_volume_from_snapshot_as_base_and_extend are same and the only difference is \"volume_type_hos[\u0027extra_specs\u0027][\u0027convert_to_base\u0027] \u003d False\". For this ddt can be used to optimize the code.","commit_id":"cb6bfb24683a38422e419636138e11a186aa1756"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"7cf405ab700de46bc2f9453ccf19d8c00944458e","unresolved":true,"context_lines":[{"line_number":276,"context_line":"        4.0.7 - Handle force detach case. bug #1686745"},{"line_number":277,"context_line":"        4.0.8 - Set proper backend on subsequent operation, after group"},{"line_number":278,"context_line":"                failover. bug #1773069"},{"line_number":279,"context_line":"        4.0.11 - Added extra spec hpe3par:convert_to_base"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":2,"id":"c50d7337_446dd2a2","line":279,"updated":"2021-04-06 14:24:58.000000000","message":"guess we\u0027re bumping to 4.0.11 because master had .9 an .10 already ; not sure if this is common or happened before","commit_id":"cb6bfb24683a38422e419636138e11a186aa1756"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"b01314cab79be354219a27fb12186ec1d8571d8f","unresolved":true,"context_lines":[{"line_number":2085,"context_line":""},{"line_number":2086,"context_line":"        # by default, set convert_to_base to False"},{"line_number":2087,"context_line":"        convert_to_base \u003d self._get_boolean_key_value("},{"line_number":2088,"context_line":"            hpe3par_keys, \u0027convert_to_base\u0027, False)"},{"line_number":2089,"context_line":""},{"line_number":2090,"context_line":"        # if provisioning is not set use thin"},{"line_number":2091,"context_line":"        default_prov \u003d self.valid_prov_values[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7694f3cc_774561ad","line":2088,"range":{"start_line":2088,"start_character":45,"end_line":2088,"end_character":50},"updated":"2021-03-26 07:09:28.000000000","message":"By default get_boolean_key_value takes input as False, I think no need to pass False again.","commit_id":"cb6bfb24683a38422e419636138e11a186aa1756"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"b01314cab79be354219a27fb12186ec1d8571d8f","unresolved":true,"context_lines":[{"line_number":2623,"context_line":""},{"line_number":2624,"context_line":"            # by default, set convert_to_base to False"},{"line_number":2625,"context_line":"            convert_to_base \u003d self._get_boolean_key_value("},{"line_number":2626,"context_line":"                hpe3par_keys, \u0027convert_to_base\u0027, False)"},{"line_number":2627,"context_line":""},{"line_number":2628,"context_line":"            LOG.debug(\"convert_to_base: %(convert)s\","},{"line_number":2629,"context_line":"                      {\u0027convert\u0027: convert_to_base})"}],"source_content_type":"text/x-python","patch_set":2,"id":"baa80538_9987a1b0","line":2626,"range":{"start_line":2626,"start_character":49,"end_line":2626,"end_character":54},"updated":"2021-03-26 07:09:28.000000000","message":"By default get_boolean_key_value takes input as False, I think no need to pass False again.","commit_id":"cb6bfb24683a38422e419636138e11a186aa1756"}]}
