)]}'
{"cinder/tests/unit/volume/drivers/netapp/dataontap/test_nfs_base.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d3dbeabca4091a9212d670cb9d9f9a3ea85a1e28","unresolved":true,"context_lines":[{"line_number":282,"context_line":"        self.mock_object(self.driver, \u0027_is_flexgroup\u0027,"},{"line_number":283,"context_line":"                         return_value\u003dis_flexgroup)"},{"line_number":284,"context_line":"        self.mock_object(self.driver, \u0027_is_flexgroup_clone_file_supported\u0027,"},{"line_number":285,"context_line":"                         return_value\u003dnot is_flexgroup)"},{"line_number":286,"context_line":"        mock_super_create \u003d self.mock_object("},{"line_number":287,"context_line":"            nfs.NfsDriver, \u0027create_volume_from_snapshot\u0027,"},{"line_number":288,"context_line":"            return_value\u003dprovider_location)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8f4ceb0a_2b47d1e9","line":285,"updated":"2021-03-23 21:14:00.000000000","message":"Because of the way you set the values, you never test the situation where both _is_flexgroup and _is_flexgroup_clone_file_supported both return true.  It\u0027s not a big deal because I think your main concern is to make sure you don\u0027t try to use backend cloning on a group that doesn\u0027t support it, and worst case, you might be using the generic cloning for a flexgroup that actually could support backend cloning.  But you might want to enhance the tests at some point.","commit_id":"bb444d4a4761f780b946f9ababa7d6d332eff3e3"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/utils/test_capabilities.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9230646eb89851c68f6db72350e06012867b6008","unresolved":true,"context_lines":[{"line_number":599,"context_line":""},{"line_number":600,"context_line":"        is_fg_returned \u003d self.ssc_library.is_flexgroup(pool_name)"},{"line_number":601,"context_line":""},{"line_number":602,"context_line":"        self.assertEqual(is_fg_returned, is_fg)"},{"line_number":603,"context_line":""},{"line_number":604,"context_line":"    @ddt.data(True, False)"},{"line_number":605,"context_line":"    def test_contains_flexgroup(self, contains_fg):"}],"source_content_type":"text/x-python","patch_set":2,"id":"f5155f01_2c2ae54c","line":602,"range":{"start_line":602,"start_character":25,"end_line":602,"end_character":47},"updated":"2021-03-24 14:16:03.000000000","message":"assertEqual arg order should be (EXPECTED_VALUE, ACTUAL_VALUE)","commit_id":"bb444d4a4761f780b946f9ababa7d6d332eff3e3"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9230646eb89851c68f6db72350e06012867b6008","unresolved":true,"context_lines":[{"line_number":611,"context_line":""},{"line_number":612,"context_line":"        contains_fg_returned \u003d self.ssc_library.contains_flexgroup_pool()"},{"line_number":613,"context_line":""},{"line_number":614,"context_line":"        self.assertEqual(contains_fg_returned, contains_fg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"c36337b5_787097c4","line":614,"updated":"2021-03-24 14:16:03.000000000","message":"same","commit_id":"bb444d4a4761f780b946f9ababa7d6d332eff3e3"}]}
