)]}'
{"cinder/tests/unit/backup/test_backup.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5f009f27eeea9cc60b1c3837c94a9016a23e8cd2","unresolved":true,"context_lines":[{"line_number":889,"context_line":"                                         mock_get_backup_device,"},{"line_number":890,"context_line":"                                         mock_get_conn,"},{"line_number":891,"context_line":"                                         mock_remove_export):"},{"line_number":892,"context_line":"        self.override_config(\u0027backup_use_same_host\u0027, True)"},{"line_number":893,"context_line":"        vol_size \u003d 1"},{"line_number":894,"context_line":"        vol_id \u003d self._create_volume_db_entry(size\u003dvol_size,"},{"line_number":895,"context_line":"                                              previous_status\u003d\u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7aadfb43_3040536f","line":892,"range":{"start_line":892,"start_character":0,"end_line":892,"end_character":58},"updated":"2021-03-25 13:01:05.000000000","message":"Do we need this to avoid going through the scheduler or something?","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"624d8b454dcc4f2844c240b345d0ddba309f266f","unresolved":true,"context_lines":[{"line_number":889,"context_line":"                                         mock_get_backup_device,"},{"line_number":890,"context_line":"                                         mock_get_conn,"},{"line_number":891,"context_line":"                                         mock_remove_export):"},{"line_number":892,"context_line":"        self.override_config(\u0027backup_use_same_host\u0027, True)"},{"line_number":893,"context_line":"        vol_size \u003d 1"},{"line_number":894,"context_line":"        vol_id \u003d self._create_volume_db_entry(size\u003dvol_size,"},{"line_number":895,"context_line":"                                              previous_status\u003d\u0027in-use\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"02cab853_3654e224","line":892,"range":{"start_line":892,"start_character":0,"end_line":892,"end_character":58},"in_reply_to":"7aadfb43_3040536f","updated":"2021-03-25 14:33:56.000000000","message":"Dunno, this was just cloned from test_create_backup_with_temp_snapshot below.","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5f009f27eeea9cc60b1c3837c94a9016a23e8cd2","unresolved":true,"context_lines":[{"line_number":895,"context_line":"                                              previous_status\u003d\u0027in-use\u0027)"},{"line_number":896,"context_line":"        backup \u003d self._create_backup_db_entry(volume_id\u003dvol_id)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        vol \u003d objects.Volume.get_by_id(self.ctxt, vol_id)"},{"line_number":899,"context_line":"        mock_get_backup_device.return_value \u003d ("},{"line_number":900,"context_line":"            objects.BackupDeviceInfo.from_primitive({"},{"line_number":901,"context_line":"                \u0027backup_device\u0027: vol, \u0027secure_enabled\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"f71c7c8c_6e3ce1d2","line":898,"range":{"start_line":898,"start_character":8,"end_line":898,"end_character":57},"updated":"2021-03-25 13:01:05.000000000","message":"nit: I think we have a method that creates de DB entry and returns an OVO in a single call.","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"624d8b454dcc4f2844c240b345d0ddba309f266f","unresolved":true,"context_lines":[{"line_number":895,"context_line":"                                              previous_status\u003d\u0027in-use\u0027)"},{"line_number":896,"context_line":"        backup \u003d self._create_backup_db_entry(volume_id\u003dvol_id)"},{"line_number":897,"context_line":""},{"line_number":898,"context_line":"        vol \u003d objects.Volume.get_by_id(self.ctxt, vol_id)"},{"line_number":899,"context_line":"        mock_get_backup_device.return_value \u003d ("},{"line_number":900,"context_line":"            objects.BackupDeviceInfo.from_primitive({"},{"line_number":901,"context_line":"                \u0027backup_device\u0027: vol, \u0027secure_enabled\u0027: False,"}],"source_content_type":"text/x-python","patch_set":1,"id":"18ea8c4d_e73653c4","line":898,"range":{"start_line":898,"start_character":8,"end_line":898,"end_character":57},"in_reply_to":"f71c7c8c_6e3ce1d2","updated":"2021-03-25 14:33:56.000000000","message":"^","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5f009f27eeea9cc60b1c3837c94a9016a23e8cd2","unresolved":true,"context_lines":[{"line_number":918,"context_line":"        mock_connect_device.return_value \u003d attach_info"},{"line_number":919,"context_line":"        properties \u003d {}"},{"line_number":920,"context_line":"        mock_get_conn.return_value \u003d properties"},{"line_number":921,"context_line":"        mock_open.return_value \u003d open(\u0027/dev/null\u0027, \u0027rb\u0027)"},{"line_number":922,"context_line":""},{"line_number":923,"context_line":"        self.backup_mgr.create_backup(self.ctxt, backup)"},{"line_number":924,"context_line":"        mock_temporary_chown.assert_called_once_with(\u0027/dev/null\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eae158d4_620d647e","line":921,"range":{"start_line":921,"start_character":1,"end_line":921,"end_character":56},"updated":"2021-03-25 13:01:05.000000000","message":"This doesn\u0027t look too clean, we could use mock_open or maybe a MagickMock(spec\u003dfile)","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5f009f27eeea9cc60b1c3837c94a9016a23e8cd2","unresolved":true,"context_lines":[{"line_number":931,"context_line":"        mock_remove_export.assert_called_once_with("},{"line_number":932,"context_line":"            self.ctxt, mock.ANY, sync\u003dTrue)"},{"line_number":933,"context_line":"        vol \u003d objects.Volume.get_by_id(self.ctxt, vol_id)"},{"line_number":934,"context_line":"        self.assertEqual(\u0027in-use\u0027, vol[\u0027status\u0027])"},{"line_number":935,"context_line":"        self.assertEqual(\u0027backing-up\u0027, vol[\u0027previous_status\u0027])"},{"line_number":936,"context_line":"        backup \u003d objects.Backup.get_by_id(self.ctxt, backup.id)"},{"line_number":937,"context_line":"        self.assertEqual(fields.BackupStatus.AVAILABLE, backup.status)"}],"source_content_type":"text/x-python","patch_set":1,"id":"4ada8d4a_723577f9","line":934,"range":{"start_line":934,"start_character":35,"end_line":934,"end_character":48},"updated":"2021-03-25 13:01:05.000000000","message":"nit: vol.status","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5f009f27eeea9cc60b1c3837c94a9016a23e8cd2","unresolved":true,"context_lines":[{"line_number":932,"context_line":"            self.ctxt, mock.ANY, sync\u003dTrue)"},{"line_number":933,"context_line":"        vol \u003d objects.Volume.get_by_id(self.ctxt, vol_id)"},{"line_number":934,"context_line":"        self.assertEqual(\u0027in-use\u0027, vol[\u0027status\u0027])"},{"line_number":935,"context_line":"        self.assertEqual(\u0027backing-up\u0027, vol[\u0027previous_status\u0027])"},{"line_number":936,"context_line":"        backup \u003d objects.Backup.get_by_id(self.ctxt, backup.id)"},{"line_number":937,"context_line":"        self.assertEqual(fields.BackupStatus.AVAILABLE, backup.status)"},{"line_number":938,"context_line":"        self.assertEqual(vol_size, backup.size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a018f4e1_fd889dcf","line":935,"range":{"start_line":935,"start_character":39,"end_line":935,"end_character":61},"updated":"2021-03-25 13:01:05.000000000","message":"nit: vol.previous_status","commit_id":"748ea6e8e735270475bd583eed4fa2c273e611e5"}]}