)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"28749fe63a032dcd49a188c334a9c6bed67aa4a8","unresolved":true,"context_lines":[{"line_number":10,"context_line":"Device Label no longer exists"},{"line_number":11,"context_line":"2. Allow for non-existent dict values in the metadata for"},{"line_number":12,"context_line":"manage existing volume operation."},{"line_number":13,"context_line":"3. Fix problematic unit tests were sample data can mutate."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: If465bc719cea2d4e85b37527f3f7ac916b5de638"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"fb98d5f1_d7e3026c","line":13,"range":{"start_line":13,"start_character":30,"end_line":13,"end_character":34},"updated":"2021-08-04 16:31:36.000000000","message":"nit: where","commit_id":"1405767165b0efd7e198960a03d0084dcc57fdb2"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"28749fe63a032dcd49a188c334a9c6bed67aa4a8","unresolved":true,"context_lines":[{"line_number":6857,"context_line":"                        six.text_type(v) for v in snap_id_list),"},{"line_number":6858,"context_line":"                    \u0027is_snap_id\u0027: self.rest.is_snap_id}"},{"line_number":6859,"context_line":"        if device_label:"},{"line_number":6860,"context_line":"            metadata.update({\u0027SourceDeviceLabel\u0027: device_label})"},{"line_number":6861,"context_line":"        return metadata"},{"line_number":6862,"context_line":""},{"line_number":6863,"context_line":"    def _check_and_add_tags_to_storage_array("}],"source_content_type":"text/x-python","patch_set":3,"id":"e6ed597d_fc93c463","line":6860,"updated":"2021-08-04 16:31:36.000000000","message":"nit: probably more efficient/readable to just use the index notation here:\n\n    metadata[\u0027SourceDeviceLabel\u0027] \u003d device_label","commit_id":"1405767165b0efd7e198960a03d0084dcc57fdb2"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c714bdcc18cfecc4757723aa752b2fbddbf10a60","unresolved":true,"context_lines":[{"line_number":7069,"context_line":"        \"\"\""},{"line_number":7070,"context_line":"        snap_id_list \u003d list()"},{"line_number":7071,"context_line":"        snap_info \u003d self.rest.get_volume_snap_info(array, device_id)"},{"line_number":7072,"context_line":"        device_name \u003d snap_info.get(\u0027deviceName\u0027)"},{"line_number":7073,"context_line":"        snapshot_src_list \u003d snap_info.get(\u0027snapshotSrcs\u0027)"},{"line_number":7074,"context_line":"        for snapshot_src in snapshot_src_list:"},{"line_number":7075,"context_line":"            if snap_name \u003d\u003d snapshot_src.get(\u0027snapshotName\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b8b8c19_1fb1b987","line":7072,"updated":"2021-08-06 20:32:40.000000000","message":"Sorry to be a pest about this patch, but using the get() here kind of implies that you\u0027re expecting it might be possible for snap_info[\u0027deviceName\u0027] to not exist.  If that\u0027s the case, then you will be trying to call split() on None at line 7080.\n\nMaybe change 7080 to\n\n    device_label \u003d device_name.split(\u0027:\u0027)[1] if device_name else None\n\nOn the other hand, the old code assumed that device_name would always be there, so maybe this isn\u0027t something to worry about if people have been reporting IndexErrors but not AttributeErrors.","commit_id":"763ff01c70ddd787f17e6800ba9b20279991b82b"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"61bafddad35e9bf7c1e24137364ba4dc631f5c71","unresolved":true,"context_lines":[{"line_number":7069,"context_line":"        \"\"\""},{"line_number":7070,"context_line":"        snap_id_list \u003d list()"},{"line_number":7071,"context_line":"        snap_info \u003d self.rest.get_volume_snap_info(array, device_id)"},{"line_number":7072,"context_line":"        device_name \u003d snap_info.get(\u0027deviceName\u0027)"},{"line_number":7073,"context_line":"        snapshot_src_list \u003d snap_info.get(\u0027snapshotSrcs\u0027)"},{"line_number":7074,"context_line":"        for snapshot_src in snapshot_src_list:"},{"line_number":7075,"context_line":"            if snap_name \u003d\u003d snapshot_src.get(\u0027snapshotName\u0027):"}],"source_content_type":"text/x-python","patch_set":4,"id":"24e9c06d_5138595f","line":7072,"in_reply_to":"5b8b8c19_1fb1b987","updated":"2021-08-09 16:22:53.000000000","message":"We always expect it to be there but I think you have a really good point and it would not hurt to make this change.","commit_id":"763ff01c70ddd787f17e6800ba9b20279991b82b"}]}