)]}'
{"api-ref/source/v3/attachments.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4165268369aef69e756a637a6c4dc8cde1e03861","unresolved":true,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   - project_id: project_id_path"},{"line_number":255,"context_line":"   - attachment: attachment"},{"line_number":256,"context_line":"   - instance_uuid: instance_uuid_req"},{"line_number":257,"context_line":"   - connector: connector"},{"line_number":258,"context_line":"   - volume_uuid: volume_id_attachment"},{"line_number":259,"context_line":"   - mode: attach_mode"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"2a551833_04392934","line":256,"range":{"start_line":256,"start_character":20,"end_line":256,"end_character":37},"updated":"2021-03-29 20:20:18.000000000","message":"you can change this to just \u0027instance_uuid\u0027","commit_id":"838edad498d28e06fede1363a09c490772e8224e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1da778bd6054fdf9bdc7313fd7e0eb9a4fed1782","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   - project_id: project_id_path"},{"line_number":255,"context_line":"   - attachment: attachment"},{"line_number":256,"context_line":"   - instance_uuid: instance_uuid_req"},{"line_number":257,"context_line":"   - connector: connector"},{"line_number":258,"context_line":"   - volume_uuid: volume_id_attachment"},{"line_number":259,"context_line":"   - mode: attach_mode"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"06ecde05_6945285b","line":256,"range":{"start_line":256,"start_character":20,"end_line":256,"end_character":37},"in_reply_to":"2a551833_04392934","updated":"2021-03-30 05:29:50.000000000","message":"Done","commit_id":"838edad498d28e06fede1363a09c490772e8224e"}],"cinder/api/schemas/attachments.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4165268369aef69e756a637a6c4dc8cde1e03861","unresolved":true,"context_lines":[{"line_number":75,"context_line":"    },"},{"line_number":76,"context_line":"    \u0027required\u0027: [\u0027attachment\u0027],"},{"line_number":77,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"4b5f943c_c6dafaf4","line":78,"updated":"2021-03-29 20:20:18.000000000","message":"since the only change you\u0027re making to the \"regular\" create schema is to add the mode, I think this would be better as:\n\n  create_v354 \u003d copy.deepcopy(create)\n  create_v354[\u0027properties\u0027][\u0027attachment\u0027][\u0027properties\u0027][\u0027mode\u0027] \u003d {\u0027type\u0027: \u0027string\u0027, \u0027enum\u0027: [\u0027rw\u0027, \u0027ro\u0027]}","commit_id":"838edad498d28e06fede1363a09c490772e8224e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1da778bd6054fdf9bdc7313fd7e0eb9a4fed1782","unresolved":false,"context_lines":[{"line_number":75,"context_line":"    },"},{"line_number":76,"context_line":"    \u0027required\u0027: [\u0027attachment\u0027],"},{"line_number":77,"context_line":"    \u0027additionalProperties\u0027: False,"},{"line_number":78,"context_line":"}"}],"source_content_type":"text/x-python","patch_set":2,"id":"cfe1d581_0751d432","line":78,"in_reply_to":"4b5f943c_c6dafaf4","updated":"2021-03-30 05:29:50.000000000","message":"Done","commit_id":"838edad498d28e06fede1363a09c490772e8224e"}],"cinder/api/v3/attachments.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4165268369aef69e756a637a6c4dc8cde1e03861","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        information (connector data) at the time of the call."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        NOTE: In Nova terms server \u003d\u003d instance, the server_id parameter"},{"line_number":132,"context_line":"        referenced below is the UUID of the Instance, for non-nova consumers"},{"line_number":133,"context_line":"        this can be a server UUID or some other arbitrary unique identifier."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        Expected format of the input parameter \u0027body\u0027:"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5d9a0495_6af0b761","line":133,"range":{"start_line":132,"start_character":54,"end_line":133,"end_character":75},"updated":"2021-03-29 20:20:18.000000000","message":"This has been the workaround for the bug you\u0027re fixing.","commit_id":"838edad498d28e06fede1363a09c490772e8224e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1da778bd6054fdf9bdc7313fd7e0eb9a4fed1782","unresolved":true,"context_lines":[{"line_number":129,"context_line":"        information (connector data) at the time of the call."},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"        NOTE: In Nova terms server \u003d\u003d instance, the server_id parameter"},{"line_number":132,"context_line":"        referenced below is the UUID of the Instance, for non-nova consumers"},{"line_number":133,"context_line":"        this can be a server UUID or some other arbitrary unique identifier."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        Expected format of the input parameter \u0027body\u0027:"},{"line_number":136,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2db978dc_51d0ceee","line":133,"range":{"start_line":132,"start_character":54,"end_line":133,"end_character":75},"in_reply_to":"5d9a0495_6af0b761","updated":"2021-03-30 05:29:50.000000000","message":"Yeah, the main purpose of this uuid seems to be keeping a link to the resource to which the attachment is made. Incase of instance-uuid, there are some special handling cases, but incase of glance we do the attachment temporarily and already keep a track of the volume image relationship in both databases so my initial thought of passing image-id here didn\u0027t look reasonable to me now.","commit_id":"838edad498d28e06fede1363a09c490772e8224e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4165268369aef69e756a637a6c4dc8cde1e03861","unresolved":true,"context_lines":[{"line_number":140,"context_line":"                \"attachment\":"},{"line_number":141,"context_line":"                {"},{"line_number":142,"context_line":"                    \"volume_uuid\": \"volume-uuid\","},{"line_number":143,"context_line":"                    \"instance_uuid\": \"nova-server-uuid\","},{"line_number":144,"context_line":"                    \"connector\": \"null|\u003cconnector-object\u003e\""},{"line_number":145,"context_line":"                }"},{"line_number":146,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":2,"id":"09fbe811_9e5e8013","line":143,"range":{"start_line":143,"start_character":37,"end_line":143,"end_character":55},"updated":"2021-03-29 20:20:18.000000000","message":"Should probably update this.","commit_id":"838edad498d28e06fede1363a09c490772e8224e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"1da778bd6054fdf9bdc7313fd7e0eb9a4fed1782","unresolved":false,"context_lines":[{"line_number":140,"context_line":"                \"attachment\":"},{"line_number":141,"context_line":"                {"},{"line_number":142,"context_line":"                    \"volume_uuid\": \"volume-uuid\","},{"line_number":143,"context_line":"                    \"instance_uuid\": \"nova-server-uuid\","},{"line_number":144,"context_line":"                    \"connector\": \"null|\u003cconnector-object\u003e\""},{"line_number":145,"context_line":"                }"},{"line_number":146,"context_line":"            }"}],"source_content_type":"text/x-python","patch_set":2,"id":"0d97af7f_347fb60d","line":143,"range":{"start_line":143,"start_character":37,"end_line":143,"end_character":55},"in_reply_to":"09fbe811_9e5e8013","updated":"2021-03-30 05:29:50.000000000","message":"Done","commit_id":"838edad498d28e06fede1363a09c490772e8224e"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2b7d49f08015065ffbde33afb038ee67b3f935f","unresolved":true,"context_lines":[{"line_number":108,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"},{"line_number":109,"context_line":"    @wsgi.response(HTTPStatus.OK)"},{"line_number":110,"context_line":"    @validation.schema(attachment.create, mv.NEW_ATTACH,"},{"line_number":111,"context_line":"                       mv.SUPPORT_VOLUME_SCHEMA_CHANGES)"},{"line_number":112,"context_line":"    @validation.schema(attachment.create_v354, mv.ATTACHMENT_CREATE_MODE_ARG)"},{"line_number":113,"context_line":"    def create(self, req, body):"},{"line_number":114,"context_line":"        \"\"\"Create an attachment."}],"source_content_type":"text/x-python","patch_set":5,"id":"19015ca1_564f7356","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":56},"updated":"2021-06-16 14:34:36.000000000","message":"-1: Please use `mv.get_prior_version(mv.ATTACHMENT_CREATE_MODE_ARG)` instead, as it is easier to see the meaning of the max mv value.","commit_id":"8203171702b1c8a80894236420a79aa402d4e54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f7fce074f84b631959e1b5c1b45967f2e8e2baf","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    @wsgi.Controller.api_version(mv.NEW_ATTACH)"},{"line_number":109,"context_line":"    @wsgi.response(HTTPStatus.OK)"},{"line_number":110,"context_line":"    @validation.schema(attachment.create, mv.NEW_ATTACH,"},{"line_number":111,"context_line":"                       mv.SUPPORT_VOLUME_SCHEMA_CHANGES)"},{"line_number":112,"context_line":"    @validation.schema(attachment.create_v354, mv.ATTACHMENT_CREATE_MODE_ARG)"},{"line_number":113,"context_line":"    def create(self, req, body):"},{"line_number":114,"context_line":"        \"\"\"Create an attachment."}],"source_content_type":"text/x-python","patch_set":5,"id":"3dd949eb_3f9662d6","line":111,"range":{"start_line":111,"start_character":22,"end_line":111,"end_character":56},"in_reply_to":"19015ca1_564f7356","updated":"2021-06-16 15:28:00.000000000","message":"Done","commit_id":"8203171702b1c8a80894236420a79aa402d4e54d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2b7d49f08015065ffbde33afb038ee67b3f935f","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        NOTE: In Nova terms server \u003d\u003d instance, the server_id parameter"},{"line_number":132,"context_line":"        referenced below is the UUID of the Instance, for non-nova consumers"},{"line_number":133,"context_line":"        this can be a server UUID or some other arbitrary unique identifier."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        TODO: Add info about added support of passing the mode argument in"},{"line_number":136,"context_line":"        request introduced in microversion 3.54 and also mention it in the"},{"line_number":137,"context_line":"        json below"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        Expected format of the input parameter \u0027body\u0027:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        .. code-block:: json"}],"source_content_type":"text/x-python","patch_set":5,"id":"8e9c3a74_9da5d5dc","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":0},"updated":"2021-06-16 14:34:36.000000000","message":"?: Why are we adding a TODO instead of doing it now?","commit_id":"8203171702b1c8a80894236420a79aa402d4e54d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6f7fce074f84b631959e1b5c1b45967f2e8e2baf","unresolved":true,"context_lines":[{"line_number":131,"context_line":"        NOTE: In Nova terms server \u003d\u003d instance, the server_id parameter"},{"line_number":132,"context_line":"        referenced below is the UUID of the Instance, for non-nova consumers"},{"line_number":133,"context_line":"        this can be a server UUID or some other arbitrary unique identifier."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        TODO: Add info about added support of passing the mode argument in"},{"line_number":136,"context_line":"        request introduced in microversion 3.54 and also mention it in the"},{"line_number":137,"context_line":"        json below"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        Expected format of the input parameter \u0027body\u0027:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        .. code-block:: json"}],"source_content_type":"text/x-python","patch_set":5,"id":"982c37a8_02dde7d4","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":0},"in_reply_to":"8e9c3a74_9da5d5dc","updated":"2021-06-16 15:28:00.000000000","message":"I skipped it since we might want to rewrite this docstring with the mv changes we have since 3.27. anyway will update mode part in next PS","commit_id":"8203171702b1c8a80894236420a79aa402d4e54d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7af0bfa8e8f58a30b358109ce8d7f3f4bb763f1b","unresolved":false,"context_lines":[{"line_number":131,"context_line":"        NOTE: In Nova terms server \u003d\u003d instance, the server_id parameter"},{"line_number":132,"context_line":"        referenced below is the UUID of the Instance, for non-nova consumers"},{"line_number":133,"context_line":"        this can be a server UUID or some other arbitrary unique identifier."},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"        TODO: Add info about added support of passing the mode argument in"},{"line_number":136,"context_line":"        request introduced in microversion 3.54 and also mention it in the"},{"line_number":137,"context_line":"        json below"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"        Expected format of the input parameter \u0027body\u0027:"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"        .. code-block:: json"}],"source_content_type":"text/x-python","patch_set":5,"id":"feefd73a_67fa7f89","line":138,"range":{"start_line":134,"start_character":0,"end_line":138,"end_character":0},"in_reply_to":"982c37a8_02dde7d4","updated":"2021-06-16 15:39:29.000000000","message":"Done","commit_id":"8203171702b1c8a80894236420a79aa402d4e54d"}]}