)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Fixed volume extend issue for volumes"},{"line_number":10,"context_line":"with replication enabled by avoiding volume remote-copy relationship"},{"line_number":11,"context_line":"deletion and creation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1920870"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"7209b1f4_4e017565","line":11,"updated":"2021-09-14 05:34:21.000000000","message":"nit: between","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Fixed volume extend issue for volumes"},{"line_number":10,"context_line":"with replication enabled by avoiding volume remote-copy relationship"},{"line_number":11,"context_line":"deletion and creation."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1920870"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"1cd7296a_317d821d","line":11,"in_reply_to":"7209b1f4_4e017565","updated":"2021-09-14 14:19:46.000000000","message":"Updated commit message.","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ddbe8c5580ed1c4ddc54d4d1cab69ba99a3c9d23","unresolved":true,"context_lines":[{"line_number":9940,"context_line":"    def test_ch_rcrelationship_cyclingmode(self):"},{"line_number":9941,"context_line":"        with mock.patch.object("},{"line_number":9942,"context_line":"                storwize_svc_common.StorwizeSSH,"},{"line_number":9943,"context_line":"                \u0027run_ssh_assert_no_output\u0027) as run_ssh_assert_no_output:"},{"line_number":9944,"context_line":"            run_ssh_assert_no_output.return_value \u003d None"},{"line_number":9945,"context_line":"            ret \u003d self.storwize_ssh.ch_rcrelationship_cyclingmode(\u0027rcrel0\u0027,"},{"line_number":9946,"context_line":"                                                                  \u0027multi\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"61a0a5cf_3f9d8818","line":9943,"range":{"start_line":9943,"start_character":17,"end_line":9943,"end_character":41},"updated":"2021-09-14 16:40:28.000000000","message":"it would be better to assert that this method is called or not, we could have 2 cases, where cyclingmode has a value i.e. \u0027multi\u0027 or \u0027none\u0027 and in second case cyclingmode would have a value None","commit_id":"bdcee852321ee414d79da8a0ed9bd95f3369bd9d"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"016f96c3d7fd5152cf56127b73892171a2173f99","unresolved":true,"context_lines":[{"line_number":346,"context_line":"        ssh_cmd.append(rc_rel)"},{"line_number":347,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def ch_rcrelationship_cyclingmode(self, relationship,"},{"line_number":350,"context_line":"                                      cyclingmode):"},{"line_number":351,"context_line":"        # Note: Can only change one attribute at a time,"},{"line_number":352,"context_line":"        # so define two ch_rcrelationship_xxx here"}],"source_content_type":"text/x-python","patch_set":3,"id":"8f670d20_fe415784","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":37},"updated":"2021-05-14 17:15:08.000000000","message":"This method can be merged with \"ch_rcrelationship_cycleperiod\" by taking new input parameter.\n\"ch_rcrelationship_cycleperiod\" is used in only one place and the name can be changed if the name is contradicting.","commit_id":"05ef31a38bed098d6f6291f4dedba7e4951e89a6"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"f22ac7033a298477d20400e5ef1aa0d5a61a267a","unresolved":false,"context_lines":[{"line_number":346,"context_line":"        ssh_cmd.append(rc_rel)"},{"line_number":347,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    def ch_rcrelationship_cyclingmode(self, relationship,"},{"line_number":350,"context_line":"                                      cyclingmode):"},{"line_number":351,"context_line":"        # Note: Can only change one attribute at a time,"},{"line_number":352,"context_line":"        # so define two ch_rcrelationship_xxx here"}],"source_content_type":"text/x-python","patch_set":3,"id":"bd25fe7c_ab0ed5f2","line":349,"range":{"start_line":349,"start_character":8,"end_line":349,"end_character":37},"in_reply_to":"8f670d20_fe415784","updated":"2021-05-24 09:07:14.000000000","message":"No need to merge. Defined this function in a separate way, as we need to pass only one attribute at a time in order to update the RC relationship, which makes it simple to deal this functionality, and did not see any other benefit of optimizing.","commit_id":"05ef31a38bed098d6f6291f4dedba7e4951e89a6"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"016f96c3d7fd5152cf56127b73892171a2173f99","unresolved":true,"context_lines":[{"line_number":3719,"context_line":"            LOG.warning(\u0027_extend_volume_op: Extending a volume with \u0027"},{"line_number":3720,"context_line":"                        \u0027remote copy is not recommended.\u0027)"},{"line_number":3721,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3722,"context_line":"            master_helper \u003d self._master_backend_helpers"},{"line_number":3723,"context_line":"            target_helper \u003d self._aux_backend_helpers"},{"line_number":3724,"context_line":"            try:"},{"line_number":3725,"context_line":"                tgt_vol \u003d (storwize_const.REPLICA_AUX_VOL_PREFIX +"}],"source_content_type":"text/x-python","patch_set":3,"id":"70bf3f47_976981e0","line":3722,"range":{"start_line":3722,"start_character":12,"end_line":3722,"end_character":25},"updated":"2021-05-14 17:15:08.000000000","message":"Here local variable is used and In this patch \"https://review.opendev.org/c/openstack/cinder/+/774594\", class member variable is used. \n\nBoth the patches has changes in \"_extend_volume_op\". Use the same local variable or else this will create a unknown issues.","commit_id":"05ef31a38bed098d6f6291f4dedba7e4951e89a6"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"f22ac7033a298477d20400e5ef1aa0d5a61a267a","unresolved":false,"context_lines":[{"line_number":3719,"context_line":"            LOG.warning(\u0027_extend_volume_op: Extending a volume with \u0027"},{"line_number":3720,"context_line":"                        \u0027remote copy is not recommended.\u0027)"},{"line_number":3721,"context_line":"            cyclingmode \u003d rel_info[\u0027cycling_mode\u0027]"},{"line_number":3722,"context_line":"            master_helper \u003d self._master_backend_helpers"},{"line_number":3723,"context_line":"            target_helper \u003d self._aux_backend_helpers"},{"line_number":3724,"context_line":"            try:"},{"line_number":3725,"context_line":"                tgt_vol \u003d (storwize_const.REPLICA_AUX_VOL_PREFIX +"}],"source_content_type":"text/x-python","patch_set":3,"id":"ee9467b2_857fc9f8","line":3722,"range":{"start_line":3722,"start_character":12,"end_line":3722,"end_character":25},"in_reply_to":"70bf3f47_976981e0","updated":"2021-05-24 09:07:14.000000000","message":"Need modifications in the other patchset.","commit_id":"05ef31a38bed098d6f6291f4dedba7e4951e89a6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"26db7dbf85a41b5a457b26a82f5a5f2956b1302b","unresolved":true,"context_lines":[{"line_number":3842,"context_line":"                                six.text_type(int(new_size)), \u0027gb\u0027,"},{"line_number":3843,"context_line":"                                src_attr[\u0027mdisk_grp_name\u0027], src_change_opts)"},{"line_number":3844,"context_line":""},{"line_number":3845,"context_line":"                        # Create target chnage volume if it doesn\u0027t exist"},{"line_number":3846,"context_line":"                        target_change_attr \u003d ("},{"line_number":3847,"context_line":"                            target_helper.get_vdisk_attributes(tgt_change_vol))"},{"line_number":3848,"context_line":"                        if not target_change_attr:"}],"source_content_type":"text/x-python","patch_set":7,"id":"aa39e360_087b28ed","line":3845,"range":{"start_line":3845,"start_character":40,"end_line":3845,"end_character":46},"updated":"2021-09-08 09:41:59.000000000","message":"typo: change\nSame typo at line 3900","commit_id":"441a336e582b7fc379d077776117d9241f6f0aa4"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"367aefd301477b99c35db5bb2dae7ea474c63cbf","unresolved":false,"context_lines":[{"line_number":3842,"context_line":"                                six.text_type(int(new_size)), \u0027gb\u0027,"},{"line_number":3843,"context_line":"                                src_attr[\u0027mdisk_grp_name\u0027], src_change_opts)"},{"line_number":3844,"context_line":""},{"line_number":3845,"context_line":"                        # Create target chnage volume if it doesn\u0027t exist"},{"line_number":3846,"context_line":"                        target_change_attr \u003d ("},{"line_number":3847,"context_line":"                            target_helper.get_vdisk_attributes(tgt_change_vol))"},{"line_number":3848,"context_line":"                        if not target_change_attr:"}],"source_content_type":"text/x-python","patch_set":7,"id":"53103b82_63fd9492","line":3845,"range":{"start_line":3845,"start_character":40,"end_line":3845,"end_character":46},"in_reply_to":"aa39e360_087b28ed","updated":"2021-09-08 13:17:47.000000000","message":"Done","commit_id":"441a336e582b7fc379d077776117d9241f6f0aa4"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"26db7dbf85a41b5a457b26a82f5a5f2956b1302b","unresolved":true,"context_lines":[{"line_number":3881,"context_line":"                        rel_info[\u0027cycling_mode\u0027] if rel_info else \u0027multi\u0027)"},{"line_number":3882,"context_line":"                    if (storwize_const.GMCV_MULTI \u003d\u003d cyclingmode and"},{"line_number":3883,"context_line":"                            cyclingmode !\u003d new_cyclingmode):"},{"line_number":3884,"context_line":"                        # Create source change volume if it doesn\u0027t exist"},{"line_number":3885,"context_line":"                        src_attr \u003d master_helper.get_vdisk_attributes("},{"line_number":3886,"context_line":"                            volume[\u0027name\u0027])"},{"line_number":3887,"context_line":"                        src_change_attr \u003d master_helper.get_vdisk_attributes("},{"line_number":3888,"context_line":"                            source_change_vol)"},{"line_number":3889,"context_line":"                        if not src_change_attr:"},{"line_number":3890,"context_line":"                            src_change_opts \u003d self._get_vdisk_params("},{"line_number":3891,"context_line":"                                volume[\u0027volume_type_id\u0027])"},{"line_number":3892,"context_line":"                            src_change_opts[\u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3893,"context_line":"                            # Change volumes would usually be thin-provisioned"},{"line_number":3894,"context_line":"                            src_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3895,"context_line":"                            master_helper.create_vdisk("},{"line_number":3896,"context_line":"                                source_change_vol,"},{"line_number":3897,"context_line":"                                six.text_type(volume[\u0027size\u0027]), \u0027gb\u0027,"},{"line_number":3898,"context_line":"                                src_attr[\u0027mdisk_grp_name\u0027], src_change_opts)"},{"line_number":3899,"context_line":""},{"line_number":3900,"context_line":"                        # Create target chnage volume if it doesn\u0027t exist"},{"line_number":3901,"context_line":"                        target_change_attr \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"f5995916_f5813d18","line":3898,"range":{"start_line":3884,"start_character":0,"end_line":3898,"end_character":76},"updated":"2021-09-08 09:41:59.000000000","message":"This block of code (lines 3884 to 3898) is same as lines 3829 to 3843.\nIt would be better to create a function for common code.","commit_id":"441a336e582b7fc379d077776117d9241f6f0aa4"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"367aefd301477b99c35db5bb2dae7ea474c63cbf","unresolved":false,"context_lines":[{"line_number":3881,"context_line":"                        rel_info[\u0027cycling_mode\u0027] if rel_info else \u0027multi\u0027)"},{"line_number":3882,"context_line":"                    if (storwize_const.GMCV_MULTI \u003d\u003d cyclingmode and"},{"line_number":3883,"context_line":"                            cyclingmode !\u003d new_cyclingmode):"},{"line_number":3884,"context_line":"                        # Create source change volume if it doesn\u0027t exist"},{"line_number":3885,"context_line":"                        src_attr \u003d master_helper.get_vdisk_attributes("},{"line_number":3886,"context_line":"                            volume[\u0027name\u0027])"},{"line_number":3887,"context_line":"                        src_change_attr \u003d master_helper.get_vdisk_attributes("},{"line_number":3888,"context_line":"                            source_change_vol)"},{"line_number":3889,"context_line":"                        if not src_change_attr:"},{"line_number":3890,"context_line":"                            src_change_opts \u003d self._get_vdisk_params("},{"line_number":3891,"context_line":"                                volume[\u0027volume_type_id\u0027])"},{"line_number":3892,"context_line":"                            src_change_opts[\u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3893,"context_line":"                            # Change volumes would usually be thin-provisioned"},{"line_number":3894,"context_line":"                            src_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3895,"context_line":"                            master_helper.create_vdisk("},{"line_number":3896,"context_line":"                                source_change_vol,"},{"line_number":3897,"context_line":"                                six.text_type(volume[\u0027size\u0027]), \u0027gb\u0027,"},{"line_number":3898,"context_line":"                                src_attr[\u0027mdisk_grp_name\u0027], src_change_opts)"},{"line_number":3899,"context_line":""},{"line_number":3900,"context_line":"                        # Create target chnage volume if it doesn\u0027t exist"},{"line_number":3901,"context_line":"                        target_change_attr \u003d ("}],"source_content_type":"text/x-python","patch_set":7,"id":"f3e01b90_78cf8095","line":3898,"range":{"start_line":3884,"start_character":0,"end_line":3898,"end_character":76},"in_reply_to":"f5995916_f5813d18","updated":"2021-09-08 13:17:47.000000000","message":"Created a new function to avoid complete code repetition.","commit_id":"441a336e582b7fc379d077776117d9241f6f0aa4"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"26db7dbf85a41b5a457b26a82f5a5f2956b1302b","unresolved":true,"context_lines":[{"line_number":3897,"context_line":"                                six.text_type(volume[\u0027size\u0027]), \u0027gb\u0027,"},{"line_number":3898,"context_line":"                                src_attr[\u0027mdisk_grp_name\u0027], src_change_opts)"},{"line_number":3899,"context_line":""},{"line_number":3900,"context_line":"                        # Create target chnage volume if it doesn\u0027t exist"},{"line_number":3901,"context_line":"                        target_change_attr \u003d ("},{"line_number":3902,"context_line":"                            target_helper.get_vdisk_attributes(tgt_change_vol))"},{"line_number":3903,"context_line":"                        if not target_change_attr:"},{"line_number":3904,"context_line":"                            target_change_opts \u003d self._get_vdisk_params("},{"line_number":3905,"context_line":"                                volume[\u0027volume_type_id\u0027])"},{"line_number":3906,"context_line":"                            target_change_pool \u003d self._replica_target.get("},{"line_number":3907,"context_line":"                                \u0027pool_name\u0027)"},{"line_number":3908,"context_line":"                            target_change_opts["},{"line_number":3909,"context_line":"                                \u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3910,"context_line":"                            # Change Volumes would usually be thin-provisioned"},{"line_number":3911,"context_line":"                            target_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3912,"context_line":"                            target_helper.create_vdisk("},{"line_number":3913,"context_line":"                                tgt_change_vol, six.text_type(volume[\u0027size\u0027]),"},{"line_number":3914,"context_line":"                                \u0027gb\u0027, target_change_pool, target_change_opts)"},{"line_number":3915,"context_line":""},{"line_number":3916,"context_line":"                        # Update gmcv volume cyclingmode to \u0027multi\u0027"},{"line_number":3917,"context_line":"                        master_helper.stop_relationship(volume.name)"},{"line_number":3918,"context_line":"                        master_helper.change_relationship_cyclingmode("},{"line_number":3919,"context_line":"                            volume.name, \u0027multi\u0027)"},{"line_number":3920,"context_line":""},{"line_number":3921,"context_line":"                        # Set source_change_volume and target_change_volume"},{"line_number":3922,"context_line":"                        master_helper.change_relationship_changevolume("},{"line_number":3923,"context_line":"                            volume.name, source_change_vol, True)"},{"line_number":3924,"context_line":"                        target_helper.change_relationship_changevolume("},{"line_number":3925,"context_line":"                            tgt_vol, tgt_change_vol, False)"},{"line_number":3926,"context_line":""},{"line_number":3927,"context_line":"                        # Start gmcv relationship"},{"line_number":3928,"context_line":"                        master_helper.start_relationship(volume.name)"},{"line_number":3929,"context_line":""},{"line_number":3930,"context_line":"                    LOG.error(msg)"},{"line_number":3931,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"cbf683e1_1f906af1","line":3928,"range":{"start_line":3900,"start_character":0,"end_line":3928,"end_character":69},"updated":"2021-09-08 09:41:59.000000000","message":"Here also function can be created for common code.\nThis block of code is same as lines 3845 to 3873.","commit_id":"441a336e582b7fc379d077776117d9241f6f0aa4"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"367aefd301477b99c35db5bb2dae7ea474c63cbf","unresolved":false,"context_lines":[{"line_number":3897,"context_line":"                                six.text_type(volume[\u0027size\u0027]), \u0027gb\u0027,"},{"line_number":3898,"context_line":"                                src_attr[\u0027mdisk_grp_name\u0027], src_change_opts)"},{"line_number":3899,"context_line":""},{"line_number":3900,"context_line":"                        # Create target chnage volume if it doesn\u0027t exist"},{"line_number":3901,"context_line":"                        target_change_attr \u003d ("},{"line_number":3902,"context_line":"                            target_helper.get_vdisk_attributes(tgt_change_vol))"},{"line_number":3903,"context_line":"                        if not target_change_attr:"},{"line_number":3904,"context_line":"                            target_change_opts \u003d self._get_vdisk_params("},{"line_number":3905,"context_line":"                                volume[\u0027volume_type_id\u0027])"},{"line_number":3906,"context_line":"                            target_change_pool \u003d self._replica_target.get("},{"line_number":3907,"context_line":"                                \u0027pool_name\u0027)"},{"line_number":3908,"context_line":"                            target_change_opts["},{"line_number":3909,"context_line":"                                \u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3910,"context_line":"                            # Change Volumes would usually be thin-provisioned"},{"line_number":3911,"context_line":"                            target_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3912,"context_line":"                            target_helper.create_vdisk("},{"line_number":3913,"context_line":"                                tgt_change_vol, six.text_type(volume[\u0027size\u0027]),"},{"line_number":3914,"context_line":"                                \u0027gb\u0027, target_change_pool, target_change_opts)"},{"line_number":3915,"context_line":""},{"line_number":3916,"context_line":"                        # Update gmcv volume cyclingmode to \u0027multi\u0027"},{"line_number":3917,"context_line":"                        master_helper.stop_relationship(volume.name)"},{"line_number":3918,"context_line":"                        master_helper.change_relationship_cyclingmode("},{"line_number":3919,"context_line":"                            volume.name, \u0027multi\u0027)"},{"line_number":3920,"context_line":""},{"line_number":3921,"context_line":"                        # Set source_change_volume and target_change_volume"},{"line_number":3922,"context_line":"                        master_helper.change_relationship_changevolume("},{"line_number":3923,"context_line":"                            volume.name, source_change_vol, True)"},{"line_number":3924,"context_line":"                        target_helper.change_relationship_changevolume("},{"line_number":3925,"context_line":"                            tgt_vol, tgt_change_vol, False)"},{"line_number":3926,"context_line":""},{"line_number":3927,"context_line":"                        # Start gmcv relationship"},{"line_number":3928,"context_line":"                        master_helper.start_relationship(volume.name)"},{"line_number":3929,"context_line":""},{"line_number":3930,"context_line":"                    LOG.error(msg)"},{"line_number":3931,"context_line":"                    raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ebcc8c11_57a5500f","line":3928,"range":{"start_line":3900,"start_character":0,"end_line":3928,"end_character":69},"in_reply_to":"cbf683e1_1f906af1","updated":"2021-09-08 13:17:47.000000000","message":"Addressed by creating a new function.","commit_id":"441a336e582b7fc379d077776117d9241f6f0aa4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bf89aaec43dd97568e86696b9d3534e80c70c720","unresolved":true,"context_lines":[{"line_number":373,"context_line":"        if cyclingmode:"},{"line_number":374,"context_line":"            ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcrelationship\u0027]"},{"line_number":375,"context_line":"            ssh_cmd.extend([\u0027-cyclingmode\u0027,"},{"line_number":376,"context_line":"                            six.text_type(cyclingmode)])"},{"line_number":377,"context_line":"            ssh_cmd.append(relationship)"},{"line_number":378,"context_line":"            self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"e04b349a_02979665","line":376,"range":{"start_line":376,"start_character":28,"end_line":376,"end_character":41},"updated":"2021-09-13 13:24:46.000000000","message":"Can just use str() if needed here since we no longer support python 2.","commit_id":"7e60047846a41651e8ff2a1d5580e6496c29fab4"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e9edfd49be50d806ae81250ef2b873090d902ece","unresolved":false,"context_lines":[{"line_number":373,"context_line":"        if cyclingmode:"},{"line_number":374,"context_line":"            ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcrelationship\u0027]"},{"line_number":375,"context_line":"            ssh_cmd.extend([\u0027-cyclingmode\u0027,"},{"line_number":376,"context_line":"                            six.text_type(cyclingmode)])"},{"line_number":377,"context_line":"            ssh_cmd.append(relationship)"},{"line_number":378,"context_line":"            self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":379,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"f8432ee5_7782e382","line":376,"range":{"start_line":376,"start_character":28,"end_line":376,"end_character":41},"in_reply_to":"e04b349a_02979665","updated":"2021-09-13 13:53:09.000000000","message":"Done","commit_id":"7e60047846a41651e8ff2a1d5580e6496c29fab4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bf89aaec43dd97568e86696b9d3534e80c70c720","unresolved":true,"context_lines":[{"line_number":3961,"context_line":"            # Change volumes would usually be thin-provisioned"},{"line_number":3962,"context_line":"            src_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3963,"context_line":"            master_helper.create_vdisk(src_change_vol,"},{"line_number":3964,"context_line":"                                       six.text_type(int(size)), \u0027gb\u0027,"},{"line_number":3965,"context_line":"                                       src_attr[\u0027mdisk_grp_name\u0027],"},{"line_number":3966,"context_line":"                                       src_change_opts)"},{"line_number":3967,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"6f705e23_535668fe","line":3964,"range":{"start_line":3964,"start_character":39,"end_line":3964,"end_character":52},"updated":"2021-09-13 13:24:46.000000000","message":"str","commit_id":"7e60047846a41651e8ff2a1d5580e6496c29fab4"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e9edfd49be50d806ae81250ef2b873090d902ece","unresolved":false,"context_lines":[{"line_number":3961,"context_line":"            # Change volumes would usually be thin-provisioned"},{"line_number":3962,"context_line":"            src_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3963,"context_line":"            master_helper.create_vdisk(src_change_vol,"},{"line_number":3964,"context_line":"                                       six.text_type(int(size)), \u0027gb\u0027,"},{"line_number":3965,"context_line":"                                       src_attr[\u0027mdisk_grp_name\u0027],"},{"line_number":3966,"context_line":"                                       src_change_opts)"},{"line_number":3967,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"08386acd_dafa13f9","line":3964,"range":{"start_line":3964,"start_character":39,"end_line":3964,"end_character":52},"in_reply_to":"6f705e23_535668fe","updated":"2021-09-13 13:53:09.000000000","message":"Done","commit_id":"7e60047846a41651e8ff2a1d5580e6496c29fab4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"bf89aaec43dd97568e86696b9d3534e80c70c720","unresolved":true,"context_lines":[{"line_number":3976,"context_line":"            # Change Volumes would usually be thin-provisioned"},{"line_number":3977,"context_line":"            target_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3978,"context_line":"            target_helper.create_vdisk(tgt_change_vol,"},{"line_number":3979,"context_line":"                                       six.text_type(int(size)), \u0027gb\u0027,"},{"line_number":3980,"context_line":"                                       target_change_pool, target_change_opts)"},{"line_number":3981,"context_line":""},{"line_number":3982,"context_line":"        # Update volume cyclingmode to \u0027multi\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"263c51bf_d2a43eb2","line":3979,"range":{"start_line":3979,"start_character":39,"end_line":3979,"end_character":52},"updated":"2021-09-13 13:24:46.000000000","message":"str","commit_id":"7e60047846a41651e8ff2a1d5580e6496c29fab4"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e9edfd49be50d806ae81250ef2b873090d902ece","unresolved":false,"context_lines":[{"line_number":3976,"context_line":"            # Change Volumes would usually be thin-provisioned"},{"line_number":3977,"context_line":"            target_change_opts[\u0027autoexpand\u0027] \u003d True"},{"line_number":3978,"context_line":"            target_helper.create_vdisk(tgt_change_vol,"},{"line_number":3979,"context_line":"                                       six.text_type(int(size)), \u0027gb\u0027,"},{"line_number":3980,"context_line":"                                       target_change_pool, target_change_opts)"},{"line_number":3981,"context_line":""},{"line_number":3982,"context_line":"        # Update volume cyclingmode to \u0027multi\u0027"}],"source_content_type":"text/x-python","patch_set":8,"id":"ec438b36_dd281204","line":3979,"range":{"start_line":3979,"start_character":39,"end_line":3979,"end_character":52},"in_reply_to":"263c51bf_d2a43eb2","updated":"2021-09-13 13:53:09.000000000","message":"Done","commit_id":"7e60047846a41651e8ff2a1d5580e6496c29fab4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":366,"context_line":"        ssh_cmd.append(rc_rel)"},{"line_number":367,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def ch_rcrelationship_cyclingmode(self, relationship,"},{"line_number":370,"context_line":"                                      cyclingmode):"},{"line_number":371,"context_line":"        # Note: Can only change one attribute at a time,"},{"line_number":372,"context_line":"        # so define three ch_rcrelationship_xxx here"}],"source_content_type":"text/x-python","patch_set":9,"id":"1c008203_c7716f13","line":369,"updated":"2021-09-14 05:34:21.000000000","message":"missing unit test coverage for this method","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        ssh_cmd.append(rc_rel)"},{"line_number":367,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    def ch_rcrelationship_cyclingmode(self, relationship,"},{"line_number":370,"context_line":"                                      cyclingmode):"},{"line_number":371,"context_line":"        # Note: Can only change one attribute at a time,"},{"line_number":372,"context_line":"        # so define three ch_rcrelationship_xxx here"}],"source_content_type":"text/x-python","patch_set":9,"id":"f61f2aa7_7aceb210","line":369,"in_reply_to":"1c008203_c7716f13","updated":"2021-09-14 14:19:46.000000000","message":"Done","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":2491,"context_line":"            self.ssh.ch_rcrelationship_cycleperiod(vol_attrs[\u0027RC_name\u0027],"},{"line_number":2492,"context_line":"                                                   cycle_period_seconds)"},{"line_number":2493,"context_line":""},{"line_number":2494,"context_line":"    def change_relationship_cyclingmode(self, volume_name, cyclingmode):"},{"line_number":2495,"context_line":"        vol_attrs \u003d self.get_vdisk_attributes(volume_name)"},{"line_number":2496,"context_line":"        if vol_attrs[\u0027RC_name\u0027] and cyclingmode:"},{"line_number":2497,"context_line":"            self.ssh.ch_rcrelationship_cyclingmode(vol_attrs[\u0027RC_name\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"ae701b5d_bbaf4e1d","line":2494,"updated":"2021-09-14 05:34:21.000000000","message":"missing unit test coverage for this method","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":2491,"context_line":"            self.ssh.ch_rcrelationship_cycleperiod(vol_attrs[\u0027RC_name\u0027],"},{"line_number":2492,"context_line":"                                                   cycle_period_seconds)"},{"line_number":2493,"context_line":""},{"line_number":2494,"context_line":"    def change_relationship_cyclingmode(self, volume_name, cyclingmode):"},{"line_number":2495,"context_line":"        vol_attrs \u003d self.get_vdisk_attributes(volume_name)"},{"line_number":2496,"context_line":"        if vol_attrs[\u0027RC_name\u0027] and cyclingmode:"},{"line_number":2497,"context_line":"            self.ssh.ch_rcrelationship_cyclingmode(vol_attrs[\u0027RC_name\u0027],"}],"source_content_type":"text/x-python","patch_set":9,"id":"607d9ca9_d84e4d1a","line":2494,"in_reply_to":"ae701b5d_bbaf4e1d","updated":"2021-09-14 14:19:46.000000000","message":"Done","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3883,"context_line":"                        # Update gmcv volume cyclingmode to \u0027none\u0027"},{"line_number":3884,"context_line":"                        master_helper.stop_relationship(volume.name)"},{"line_number":3885,"context_line":"                        master_helper.change_relationship_cyclingmode("},{"line_number":3886,"context_line":"                            volume.name, \u0027none\u0027)"},{"line_number":3887,"context_line":"                        master_helper.start_relationship(volume.name)"},{"line_number":3888,"context_line":""},{"line_number":3889,"context_line":"                        tgt_change_vol \u003d ("}],"source_content_type":"text/x-python","patch_set":9,"id":"d971bfdb_c0c8383d","line":3886,"range":{"start_line":3886,"start_character":41,"end_line":3886,"end_character":47},"updated":"2021-09-14 05:34:21.000000000","message":"I think we do realize that this is different from python None and will evaluate to True on L#2496 and L#373","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3883,"context_line":"                        # Update gmcv volume cyclingmode to \u0027none\u0027"},{"line_number":3884,"context_line":"                        master_helper.stop_relationship(volume.name)"},{"line_number":3885,"context_line":"                        master_helper.change_relationship_cyclingmode("},{"line_number":3886,"context_line":"                            volume.name, \u0027none\u0027)"},{"line_number":3887,"context_line":"                        master_helper.start_relationship(volume.name)"},{"line_number":3888,"context_line":""},{"line_number":3889,"context_line":"                        tgt_change_vol \u003d ("}],"source_content_type":"text/x-python","patch_set":9,"id":"f6dedd98_1e19e6da","line":3886,"range":{"start_line":3886,"start_character":41,"end_line":3886,"end_character":47},"in_reply_to":"d971bfdb_c0c8383d","updated":"2021-09-14 14:19:46.000000000","message":"That is the string we need to evaluate and is different from python None. \nHere is the ref output:\n\u003elsrcrelationship rcrel12\nid 153\nname rcrel12\nmaster_vdisk_name volume-05f13f79-009f-44e9-8b7f-975fae27dbfb\naux_vdisk_name aux_volume-05f13f79-009f-44e9-8b7f-975fae27dbfb\nprimary master\nstate consistent_synchronized\ncopy_type global\ncycling_mode none","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3946,"context_line":"                    context.get_admin_context(),"},{"line_number":3947,"context_line":"                    volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3948,"context_line":""},{"line_number":3949,"context_line":"    def _convert_global_mirror_volume_to_gmcv(self, volume, target_vol, size):"},{"line_number":3950,"context_line":"        master_helper \u003d self._master_backend_helpers"},{"line_number":3951,"context_line":"        target_helper \u003d self._aux_backend_helpers"},{"line_number":3952,"context_line":"        tgt_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + target_vol)"}],"source_content_type":"text/x-python","patch_set":9,"id":"b0d28ffb_b20dcf01","line":3949,"updated":"2021-09-14 05:34:21.000000000","message":"missing unit test coverage for this method","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3946,"context_line":"                    context.get_admin_context(),"},{"line_number":3947,"context_line":"                    volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3948,"context_line":""},{"line_number":3949,"context_line":"    def _convert_global_mirror_volume_to_gmcv(self, volume, target_vol, size):"},{"line_number":3950,"context_line":"        master_helper \u003d self._master_backend_helpers"},{"line_number":3951,"context_line":"        target_helper \u003d self._aux_backend_helpers"},{"line_number":3952,"context_line":"        tgt_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + target_vol)"}],"source_content_type":"text/x-python","patch_set":9,"id":"2d704b80_13f351c9","line":3949,"in_reply_to":"b0d28ffb_b20dcf01","updated":"2021-09-14 14:19:46.000000000","message":"Done","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3952,"context_line":"        tgt_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + target_vol)"},{"line_number":3953,"context_line":"        src_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + volume.name)"},{"line_number":3954,"context_line":""},{"line_number":3955,"context_line":"        # Create source change volume if it doesn\u0027t exist"},{"line_number":3956,"context_line":"        src_attr \u003d master_helper.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":3957,"context_line":"        src_change_attr \u003d master_helper.get_vdisk_attributes(src_change_vol)"},{"line_number":3958,"context_line":"        if not src_change_attr:"}],"source_content_type":"text/x-python","patch_set":9,"id":"b3937c95_8c73365c","line":3955,"range":{"start_line":3955,"start_character":17,"end_line":3955,"end_character":37},"updated":"2021-09-14 05:34:21.000000000","message":"I think here we mean the source volume that we are extending but \u0027source change volume\u0027 doesn\u0027t seem to convey that","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3952,"context_line":"        tgt_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + target_vol)"},{"line_number":3953,"context_line":"        src_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + volume.name)"},{"line_number":3954,"context_line":""},{"line_number":3955,"context_line":"        # Create source change volume if it doesn\u0027t exist"},{"line_number":3956,"context_line":"        src_attr \u003d master_helper.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":3957,"context_line":"        src_change_attr \u003d master_helper.get_vdisk_attributes(src_change_vol)"},{"line_number":3958,"context_line":"        if not src_change_attr:"}],"source_content_type":"text/x-python","patch_set":9,"id":"d1c09b5f_312f5f4c","line":3955,"range":{"start_line":3955,"start_character":17,"end_line":3955,"end_character":37},"in_reply_to":"b3937c95_8c73365c","updated":"2021-09-14 14:19:46.000000000","message":"As we are creating source_change_volume(#3963), given a comment regarding this block of instructions to specify about source_change_volume creation which is followed by target_change_volume creation. So, we thought that \u0027source change volume\u0027 is the correct word in this context.","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3953,"context_line":"        src_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + volume.name)"},{"line_number":3954,"context_line":""},{"line_number":3955,"context_line":"        # Create source change volume if it doesn\u0027t exist"},{"line_number":3956,"context_line":"        src_attr \u003d master_helper.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":3957,"context_line":"        src_change_attr \u003d master_helper.get_vdisk_attributes(src_change_vol)"},{"line_number":3958,"context_line":"        if not src_change_attr:"},{"line_number":3959,"context_line":"            src_change_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"7c465be7_48e7f696","line":3956,"range":{"start_line":3956,"start_character":54,"end_line":3956,"end_character":68},"updated":"2021-09-14 05:34:21.000000000","message":"I\u0027m not sure this is correct, we are passing an OVO on L#3910 and previously use volume.name in that method and the same object here we are referencing as dictionary","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3953,"context_line":"        src_change_vol \u003d (storwize_const.REPLICA_CHG_VOL_PREFIX + volume.name)"},{"line_number":3954,"context_line":""},{"line_number":3955,"context_line":"        # Create source change volume if it doesn\u0027t exist"},{"line_number":3956,"context_line":"        src_attr \u003d master_helper.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":3957,"context_line":"        src_change_attr \u003d master_helper.get_vdisk_attributes(src_change_vol)"},{"line_number":3958,"context_line":"        if not src_change_attr:"},{"line_number":3959,"context_line":"            src_change_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027])"}],"source_content_type":"text/x-python","patch_set":9,"id":"9bca0098_86e0fe13","line":3956,"range":{"start_line":3956,"start_character":54,"end_line":3956,"end_character":68},"in_reply_to":"7c465be7_48e7f696","updated":"2021-09-14 14:19:46.000000000","message":"Done","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3956,"context_line":"        src_attr \u003d master_helper.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":3957,"context_line":"        src_change_attr \u003d master_helper.get_vdisk_attributes(src_change_vol)"},{"line_number":3958,"context_line":"        if not src_change_attr:"},{"line_number":3959,"context_line":"            src_change_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027])"},{"line_number":3960,"context_line":"            src_change_opts[\u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3961,"context_line":"            # Change volumes would usually be thin-provisioned"},{"line_number":3962,"context_line":"            src_change_opts[\u0027autoexpand\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"d3fa4af0_1d5b2aef","line":3959,"range":{"start_line":3959,"start_character":53,"end_line":3959,"end_character":77},"updated":"2021-09-14 05:34:21.000000000","message":"see comment above regarding OVO","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3956,"context_line":"        src_attr \u003d master_helper.get_vdisk_attributes(volume[\u0027name\u0027])"},{"line_number":3957,"context_line":"        src_change_attr \u003d master_helper.get_vdisk_attributes(src_change_vol)"},{"line_number":3958,"context_line":"        if not src_change_attr:"},{"line_number":3959,"context_line":"            src_change_opts \u003d self._get_vdisk_params(volume[\u0027volume_type_id\u0027])"},{"line_number":3960,"context_line":"            src_change_opts[\u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3961,"context_line":"            # Change volumes would usually be thin-provisioned"},{"line_number":3962,"context_line":"            src_change_opts[\u0027autoexpand\u0027] \u003d True"}],"source_content_type":"text/x-python","patch_set":9,"id":"bc16e522_708724d9","line":3959,"range":{"start_line":3959,"start_character":53,"end_line":3959,"end_character":77},"in_reply_to":"d3fa4af0_1d5b2aef","updated":"2021-09-14 14:19:46.000000000","message":"Done","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3969,"context_line":"            target_helper.get_vdisk_attributes(tgt_change_vol))"},{"line_number":3970,"context_line":"        if not target_change_attr:"},{"line_number":3971,"context_line":"            target_change_opts \u003d self._get_vdisk_params("},{"line_number":3972,"context_line":"                volume[\u0027volume_type_id\u0027])"},{"line_number":3973,"context_line":"            target_change_pool \u003d self._replica_target.get(\u0027pool_name\u0027)"},{"line_number":3974,"context_line":"            target_change_opts[\u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3975,"context_line":"            # Change Volumes would usually be thin-provisioned"}],"source_content_type":"text/x-python","patch_set":9,"id":"84c9bb8e_b8667a61","line":3972,"range":{"start_line":3972,"start_character":16,"end_line":3972,"end_character":40},"updated":"2021-09-14 05:34:21.000000000","message":"same, this should be volume.volume_type_id","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3969,"context_line":"            target_helper.get_vdisk_attributes(tgt_change_vol))"},{"line_number":3970,"context_line":"        if not target_change_attr:"},{"line_number":3971,"context_line":"            target_change_opts \u003d self._get_vdisk_params("},{"line_number":3972,"context_line":"                volume[\u0027volume_type_id\u0027])"},{"line_number":3973,"context_line":"            target_change_pool \u003d self._replica_target.get(\u0027pool_name\u0027)"},{"line_number":3974,"context_line":"            target_change_opts[\u0027iogrp\u0027] \u003d src_attr[\u0027IO_group_id\u0027]"},{"line_number":3975,"context_line":"            # Change Volumes would usually be thin-provisioned"}],"source_content_type":"text/x-python","patch_set":9,"id":"72e54716_21280922","line":3972,"range":{"start_line":3972,"start_character":16,"end_line":3972,"end_character":40},"in_reply_to":"84c9bb8e_b8667a61","updated":"2021-09-14 14:19:46.000000000","message":"Done","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"001f0b9db6d285083e32fbe17282a287b0da7374","unresolved":true,"context_lines":[{"line_number":3979,"context_line":""},{"line_number":3980,"context_line":"        # Update volume cyclingmode to \u0027multi\u0027"},{"line_number":3981,"context_line":"        master_helper.stop_relationship(volume.name)"},{"line_number":3982,"context_line":"        master_helper.change_relationship_cyclingmode(volume.name, \u0027multi\u0027)"},{"line_number":3983,"context_line":"        # Set source_change_volume and target_change_volume"},{"line_number":3984,"context_line":"        master_helper.change_relationship_changevolume(volume.name,"},{"line_number":3985,"context_line":"                                                       src_change_vol, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"93e56bbd_e74a281a","line":3982,"range":{"start_line":3982,"start_character":54,"end_line":3982,"end_character":65},"updated":"2021-09-14 05:34:21.000000000","message":"here again we reference it as volume object, which is correct, but should also be done in above cases","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"b2b52fd0d232979d487aa46279dbe8d15ad02fd1","unresolved":false,"context_lines":[{"line_number":3979,"context_line":""},{"line_number":3980,"context_line":"        # Update volume cyclingmode to \u0027multi\u0027"},{"line_number":3981,"context_line":"        master_helper.stop_relationship(volume.name)"},{"line_number":3982,"context_line":"        master_helper.change_relationship_cyclingmode(volume.name, \u0027multi\u0027)"},{"line_number":3983,"context_line":"        # Set source_change_volume and target_change_volume"},{"line_number":3984,"context_line":"        master_helper.change_relationship_changevolume(volume.name,"},{"line_number":3985,"context_line":"                                                       src_change_vol, True)"}],"source_content_type":"text/x-python","patch_set":9,"id":"9c895125_32f6268a","line":3982,"range":{"start_line":3982,"start_character":54,"end_line":3982,"end_character":65},"in_reply_to":"93e56bbd_e74a281a","updated":"2021-09-14 14:19:46.000000000","message":"Thanks. Updated all the above cases.","commit_id":"e7aa0fe17260c6c73ef4b17e11060561eab55f6e"}]}