)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"6f0fa59e042a33b2cc7f88d54484b080f5ae3694","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF] Fixed add volumes to clone group issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Adding of volume to a group"},{"line_number":10,"context_line":"which was created from group snapshot of another consistency"},{"line_number":11,"context_line":"group fails and group goes into error state."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d3f4b7ea_3e143a8f","line":9,"updated":"2021-04-05 15:27:12.000000000","message":"Rephrase it as \"Addition of volumes to a group fails if the group is cloned from a group-snapshot or another group due to absence of rccg in back-end.\n\nFixed the issue by creating,updating the rccg in the back-end\"","commit_id":"8251e45a1f60d95a021d5e4b36c01df3d2498f61"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"c7aa08e3dbca750edde5f7286d01eed3becbb661","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF] Fixed add volumes to clone group issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Adding of volume to a group"},{"line_number":10,"context_line":"which was created from group snapshot of another consistency"},{"line_number":11,"context_line":"group fails and group goes into error state."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ee2a092d_4f383b0d","line":9,"in_reply_to":"d3f4b7ea_3e143a8f","updated":"2021-04-06 04:58:06.000000000","message":"I have updated the commit message . please review Manoj","commit_id":"8251e45a1f60d95a021d5e4b36c01df3d2498f61"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":11,"context_line":"due to absence of rccg in back-end."},{"line_number":12,"context_line":"Fixed the issue by creating,updating the rccg in the back-end."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"closes bug: #1920912"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: I335d33ca6219d18a9d4bb345c7e21b1e5a1b0f75"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"743b446f_e2c6d7d0","line":14,"range":{"start_line":14,"start_character":0,"end_line":14,"end_character":10},"updated":"2021-04-14 06:36:52.000000000","message":"Change it to \"Closes-Bug\"","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6848,"context_line":"        model_update, volumes_model_update \u003d ("},{"line_number":6849,"context_line":"            self.driver.create_group_from_src(self.ctxt, group, volumes, None,"},{"line_number":6850,"context_line":"                                              None, source_cg, source_vols))"},{"line_number":6851,"context_line":"        self.assertFalse(create_rccg.called)"},{"line_number":6852,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":6853,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":6854,"context_line":"                         \"CG create from src created failed\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"011846bc_487079a0","line":6851,"range":{"start_line":6851,"start_character":8,"end_line":6851,"end_character":44},"updated":"2021-04-14 06:36:52.000000000","message":"replace this statement with \"create_rccg.assert_not_called()\"","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6866,"context_line":"            self.driver.create_group_from_src(self.ctxt, group, volumes,"},{"line_number":6867,"context_line":"                                              group_snapshot, snapshots,"},{"line_number":6868,"context_line":"                                              None, None))"},{"line_number":6869,"context_line":"        self.assertFalse(create_rccg.called)"},{"line_number":6870,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":6871,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":6872,"context_line":"                         \"CG create from src created failed\")"}],"source_content_type":"text/x-python","patch_set":5,"id":"08be339d_6554ea6e","line":6869,"range":{"start_line":6869,"start_character":8,"end_line":6869,"end_character":44},"updated":"2021-04-14 06:36:52.000000000","message":"replace this statement with \"create_rccg.assert_not_called()\"","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6879,"context_line":"        for each_vol in model_update[1]:"},{"line_number":6880,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6881,"context_line":""},{"line_number":6882,"context_line":"        self.driver.update_group(self.ctxt, group, volumes, [])"},{"line_number":6883,"context_line":"        model_update \u003d self.driver.delete_group_snapshot(self.ctxt,"},{"line_number":6884,"context_line":"                                                         group_snapshot,"},{"line_number":6885,"context_line":"                                                         snapshots)"}],"source_content_type":"text/x-python","patch_set":5,"id":"955fd60d_0953a88e","line":6882,"range":{"start_line":6882,"start_character":20,"end_line":6882,"end_character":32},"updated":"2021-04-14 06:36:52.000000000","message":"After updating group, add validations for expected functions to be called.","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6880,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6881,"context_line":""},{"line_number":6882,"context_line":"        self.driver.update_group(self.ctxt, group, volumes, [])"},{"line_number":6883,"context_line":"        model_update \u003d self.driver.delete_group_snapshot(self.ctxt,"},{"line_number":6884,"context_line":"                                                         group_snapshot,"},{"line_number":6885,"context_line":"                                                         snapshots)"},{"line_number":6886,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"}],"source_content_type":"text/x-python","patch_set":5,"id":"0e9dd18c_cfb391ac","line":6883,"range":{"start_line":6883,"start_character":35,"end_line":6883,"end_character":56},"updated":"2021-04-14 06:36:52.000000000","message":"same as above.","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6897,"context_line":"    @mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":6898,"context_line":"                       \u0027create_rccg\u0027)"},{"line_number":6899,"context_line":"    @ddt.unpack"},{"line_number":6900,"context_line":"    def test_storwize_group_from_src_rccg(self, rccg_spec, opts, create_rccg):"},{"line_number":6901,"context_line":"        # Valid case for create cg from src"},{"line_number":6902,"context_line":"        type_ref \u003d volume_types.create(self.ctxt, \u0027testtype\u0027, None)"},{"line_number":6903,"context_line":"        spec \u003d {\u0027consistent_group_snapshot_enabled\u0027: \u0027\u003cis\u003e True\u0027}"}],"source_content_type":"text/x-python","patch_set":5,"id":"e5a6fe83_78611509","line":6900,"range":{"start_line":6900,"start_character":8,"end_line":6900,"end_character":41},"updated":"2021-04-14 06:36:52.000000000","message":"rename it to \"test_storwize_create_group_from_src_rccg\"","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6901,"context_line":"        # Valid case for create cg from src"},{"line_number":6902,"context_line":"        type_ref \u003d volume_types.create(self.ctxt, \u0027testtype\u0027, None)"},{"line_number":6903,"context_line":"        spec \u003d {\u0027consistent_group_snapshot_enabled\u0027: \u0027\u003cis\u003e True\u0027}"},{"line_number":6904,"context_line":"        cg_type_ref \u003d group_types.create(self.ctxt, \u0027cg_type\u0027, spec)"},{"line_number":6905,"context_line":"        pool \u003d _get_test_pool()"},{"line_number":6906,"context_line":"        # Create cg in db"},{"line_number":6907,"context_line":"        group \u003d self._create_group_in_db(volume_type_ids\u003d[type_ref.id],"}],"source_content_type":"text/x-python","patch_set":5,"id":"e8d85599_9989e04f","line":6904,"range":{"start_line":6904,"start_character":8,"end_line":6904,"end_character":19},"updated":"2021-04-14 06:36:52.000000000","message":"here the cg type created is for normal volume and expecting rccg to be created on backend.\nCreate the \u0027consistent_group_replication_enabled\u0027 group and expect rccg to be created on backend.","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6936,"context_line":"            self.driver.create_group_from_src(self.ctxt, group, volumes, None,"},{"line_number":6937,"context_line":"                                              None, source_cg, source_vols))"},{"line_number":6938,"context_line":"        if \u0027consistent_group_replication_enabled\u0027 in rccg_spec:"},{"line_number":6939,"context_line":"            create_rccg(opts[\u0027rccg_name\u0027], opts[\u0027system_name\u0027])"},{"line_number":6940,"context_line":"            create_rccg.assert_called_with(opts[\u0027rccg_name\u0027],"},{"line_number":6941,"context_line":"                                           opts[\u0027system_name\u0027])"},{"line_number":6942,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"a570d976_c7e283dd","line":6939,"range":{"start_line":6939,"start_character":12,"end_line":6939,"end_character":23},"updated":"2021-04-14 06:36:52.000000000","message":"create_rccg should not be called manually, it should be called when create_group_from_src is called.","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6960,"context_line":"                                              group_snapshot, snapshots,"},{"line_number":6961,"context_line":"                                              None, None))"},{"line_number":6962,"context_line":"        if \u0027consistent_group_replication_enabled\u0027 in rccg_spec:"},{"line_number":6963,"context_line":"            create_rccg(opts[\u0027rccg_name\u0027], opts[\u0027system_name\u0027])"},{"line_number":6964,"context_line":"            create_rccg.assert_called_with(opts[\u0027rccg_name\u0027],"},{"line_number":6965,"context_line":"                                           opts[\u0027system_name\u0027])"},{"line_number":6966,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":5,"id":"8ec2ef21_f10fbacd","line":6963,"range":{"start_line":6963,"start_character":12,"end_line":6963,"end_character":23},"updated":"2021-04-14 06:36:52.000000000","message":"same as above comment at line 6939.","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6971,"context_line":"        for each_vol in volumes_model_update:"},{"line_number":6972,"context_line":"            self.assertEqual(\u0027available\u0027, each_vol[\u0027status\u0027])"},{"line_number":6973,"context_line":""},{"line_number":6974,"context_line":"        model_update \u003d self.driver.delete_group(self.ctxt, group, volumes)"},{"line_number":6975,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":6976,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":6977,"context_line":"        for each_vol in model_update[1]:"}],"source_content_type":"text/x-python","patch_set":5,"id":"82574d73_6617c4dc","line":6974,"range":{"start_line":6974,"start_character":35,"end_line":6974,"end_character":48},"updated":"2021-04-14 06:36:52.000000000","message":"same as above comment at line 6882","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"052b5adf7536014998e7545f59a8d7f610057123","unresolved":true,"context_lines":[{"line_number":6977,"context_line":"        for each_vol in model_update[1]:"},{"line_number":6978,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6979,"context_line":""},{"line_number":6980,"context_line":"        self.driver.update_group(self.ctxt, group, volumes, [])"},{"line_number":6981,"context_line":"        model_update \u003d self.driver.delete_group_snapshot(self.ctxt,"},{"line_number":6982,"context_line":"                                                         group_snapshot,"},{"line_number":6983,"context_line":"                                                         snapshots)"}],"source_content_type":"text/x-python","patch_set":5,"id":"7e1948cd_9f5e5409","line":6980,"range":{"start_line":6980,"start_character":20,"end_line":6980,"end_character":32},"updated":"2021-04-14 06:36:52.000000000","message":"same as above comment at line 6882","commit_id":"c318d96b4bc3b6619c9698e9bd3c56c9b197c932"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":6849,"context_line":"        model_update, volumes_model_update \u003d ("},{"line_number":6850,"context_line":"            self.driver.create_group_from_src(self.ctxt, group, volumes, None,"},{"line_number":6851,"context_line":"                                              None, source_cg, source_vols))"},{"line_number":6852,"context_line":"        create_rccg.assert_not_called()"},{"line_number":6853,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":6854,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":6855,"context_line":"                         \"CG create from src created failed\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"f90fc739_147aef4b","line":6852,"updated":"2021-05-14 12:28:35.000000000","message":"Add the test cases without mocking create_rccg call.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":6867,"context_line":"            self.driver.create_group_from_src(self.ctxt, group, volumes,"},{"line_number":6868,"context_line":"                                              group_snapshot, snapshots,"},{"line_number":6869,"context_line":"                                              None, None))"},{"line_number":6870,"context_line":"        create_rccg.assert_not_called()"},{"line_number":6871,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":6872,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":6873,"context_line":"                         \"CG create from src created failed\")"}],"source_content_type":"text/x-python","patch_set":11,"id":"e0a52033_155401d1","line":6870,"updated":"2021-05-14 12:28:35.000000000","message":"Same as above.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":6880,"context_line":"        for each_vol in model_update[1]:"},{"line_number":6881,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6882,"context_line":""},{"line_number":6883,"context_line":"        self.driver.update_group(self.ctxt, group, volumes, [])"},{"line_number":6884,"context_line":"        model_update \u003d self.driver.delete_group_snapshot(self.ctxt,"},{"line_number":6885,"context_line":"                                                         group_snapshot,"},{"line_number":6886,"context_line":"                                                         snapshots)"}],"source_content_type":"text/x-python","patch_set":11,"id":"377c2108_cdd7f28a","line":6883,"updated":"2021-05-14 12:28:35.000000000","message":"why the volumes are added to group after deleting the group, What is the reason for this.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12197,"context_line":""},{"line_number":12198,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027,"},{"line_number":12199,"context_line":"                new\u003dtestutils.ZeroIntervalLoopingCall)"},{"line_number":12200,"context_line":"    def test_create_group_from_src_grp(self):"},{"line_number":12201,"context_line":"        self.driver.configuration.set_override(\u0027replication_device\u0027,"},{"line_number":12202,"context_line":"                                               [self.rep_target])"},{"line_number":12203,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"1e4d317b_31656af7","line":12200,"range":{"start_line":12200,"start_character":8,"end_line":12200,"end_character":38},"updated":"2021-05-14 12:28:35.000000000","message":"add unit tests with invalid inputs like the volumes not created in the backend, empty group, snapshots not created in backed. Check and add if invalid inputs cases can be added.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12203,"context_line":""},{"line_number":12204,"context_line":"        pool \u003d _get_test_pool()"},{"line_number":12205,"context_line":""},{"line_number":12206,"context_line":"        vol_type_ids \u003d [self.gm_type.id, self.mm_type.id,"},{"line_number":12207,"context_line":"                        self.gmcv_default_type.id]"},{"line_number":12208,"context_line":""},{"line_number":12209,"context_line":"        for vol_type_id in vol_type_ids:"}],"source_content_type":"text/x-python","patch_set":11,"id":"32d65654_efb142f3","line":12206,"updated":"2021-05-14 12:28:35.000000000","message":"use ddt to execute it as different test cases for the volume types mentioned.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12237,"context_line":""},{"line_number":12238,"context_line":"            add_volumes \u003d [src_vol1, src_vol2]"},{"line_number":12239,"context_line":"            del_volumes \u003d []"},{"line_number":12240,"context_line":"            # add GMCV volume to group"},{"line_number":12241,"context_line":"            (model_update, add_volumes_update,"},{"line_number":12242,"context_line":"             remove_volumes_update) \u003d self.driver.update_group(self.ctxt,"},{"line_number":12243,"context_line":"                                                               src_group,"}],"source_content_type":"text/x-python","patch_set":11,"id":"c7b8c924_73f43da6","line":12240,"range":{"start_line":12240,"start_character":14,"end_line":12240,"end_character":38},"updated":"2021-05-14 12:28:35.000000000","message":"This unit test is common for different mirror volume types, update the comment.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12244,"context_line":"                                                               add_volumes,"},{"line_number":12245,"context_line":"                                                               del_volumes)"},{"line_number":12246,"context_line":""},{"line_number":12247,"context_line":"            # Clone group for gmcv source group"},{"line_number":12248,"context_line":"            clone_group \u003d ("},{"line_number":12249,"context_line":"                testutils.create_group("},{"line_number":12250,"context_line":"                    self.ctxt, volume_type_ids\u003d[vol_type_id],"}],"source_content_type":"text/x-python","patch_set":11,"id":"f426e08f_c0fa6b74","line":12247,"range":{"start_line":12247,"start_character":14,"end_line":12247,"end_character":47},"updated":"2021-05-14 12:28:35.000000000","message":"same as above.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12264,"context_line":"            clone_volumes \u003d self.db.volume_get_all_by_generic_group("},{"line_number":12265,"context_line":"                self.ctxt.elevated(), clone_group.id)"},{"line_number":12266,"context_line":""},{"line_number":12267,"context_line":"            # Create gmcv group from source gmcv group"},{"line_number":12268,"context_line":"            model_update, volumes_model_update \u003d ("},{"line_number":12269,"context_line":"                self.driver.create_group_from_src(self.ctxt, clone_group,"},{"line_number":12270,"context_line":"                                                  clone_volumes, None, None,"}],"source_content_type":"text/x-python","patch_set":11,"id":"541b6223_d1364479","line":12267,"range":{"start_line":12267,"start_character":14,"end_line":12267,"end_character":54},"updated":"2021-05-14 12:28:35.000000000","message":"same as above comment.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12280,"context_line":"            self.driver.delete_group(self.ctxt, clone_group,"},{"line_number":12281,"context_line":"                                     [clone_vol1, clone_vol2])"},{"line_number":12282,"context_line":"            with (mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":12283,"context_line":"                  \u0027create_rccg\u0027)) as create_rccg:"},{"line_number":12284,"context_line":"                # Create GMCV group from source GMCV group"},{"line_number":12285,"context_line":"                model_update, volumes_model_update \u003d ("},{"line_number":12286,"context_line":"                    self.driver.create_group_from_src(self.ctxt, clone_group,"}],"source_content_type":"text/x-python","patch_set":11,"id":"be0e2156_9d4dfe49","line":12283,"range":{"start_line":12283,"start_character":19,"end_line":12283,"end_character":30},"updated":"2021-05-14 12:28:35.000000000","message":"mock the \"update_group\" call also, since the \"update_group\" call is added in \"create_group_from_src\"","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12281,"context_line":"                                     [clone_vol1, clone_vol2])"},{"line_number":12282,"context_line":"            with (mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":12283,"context_line":"                  \u0027create_rccg\u0027)) as create_rccg:"},{"line_number":12284,"context_line":"                # Create GMCV group from source GMCV group"},{"line_number":12285,"context_line":"                model_update, volumes_model_update \u003d ("},{"line_number":12286,"context_line":"                    self.driver.create_group_from_src(self.ctxt, clone_group,"},{"line_number":12287,"context_line":"                                                      clone_volumes, None,"}],"source_content_type":"text/x-python","patch_set":11,"id":"34754c08_afa57a41","line":12284,"range":{"start_line":12284,"start_character":18,"end_line":12284,"end_character":58},"updated":"2021-05-14 12:28:35.000000000","message":"same as above comment","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12300,"context_line":""},{"line_number":12301,"context_line":"        pool \u003d _get_test_pool()"},{"line_number":12302,"context_line":""},{"line_number":12303,"context_line":"        vol_type_ids \u003d [self.gm_type.id, self.mm_type.id,"},{"line_number":12304,"context_line":"                        self.gmcv_default_type.id]"},{"line_number":12305,"context_line":""},{"line_number":12306,"context_line":"        for vol_type_id in vol_type_ids:"},{"line_number":12307,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"cc5061e8_2356f22c","line":12304,"range":{"start_line":12303,"start_character":8,"end_line":12304,"end_character":50},"updated":"2021-05-14 12:28:35.000000000","message":"use ddt to execute it as different unit tests.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12333,"context_line":"            add_volumes \u003d [src_vol1, src_vol2]"},{"line_number":12334,"context_line":"            del_volumes \u003d []"},{"line_number":12335,"context_line":""},{"line_number":12336,"context_line":"            # add GMCV volume to group"},{"line_number":12337,"context_line":"            (model_update, add_volumes_update,"},{"line_number":12338,"context_line":"                remove_volumes_update) \u003d self.driver.update_group(self.ctxt,"},{"line_number":12339,"context_line":"                                                                  src_group,"}],"source_content_type":"text/x-python","patch_set":11,"id":"0d8d5c34_45767ba1","line":12336,"range":{"start_line":12336,"start_character":14,"end_line":12336,"end_character":38},"updated":"2021-05-14 12:28:35.000000000","message":"update the comment.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12340,"context_line":"                                                                  add_volumes,"},{"line_number":12341,"context_line":"                                                                  del_volumes)"},{"line_number":12342,"context_line":""},{"line_number":12343,"context_line":"            # Clone group for gmcv source group"},{"line_number":12344,"context_line":"            clone_group \u003d ("},{"line_number":12345,"context_line":"                testutils.create_group("},{"line_number":12346,"context_line":"                    self.ctxt, volume_type_ids\u003d[vol_type_id],"}],"source_content_type":"text/x-python","patch_set":11,"id":"ddbb1e8b_dafdd4fb","line":12343,"range":{"start_line":12343,"start_character":14,"end_line":12343,"end_character":47},"updated":"2021-05-14 12:28:35.000000000","message":"same as above comment","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12360,"context_line":"            clone_volumes \u003d self.db.volume_get_all_by_generic_group("},{"line_number":12361,"context_line":"                self.ctxt.elevated(), clone_group.id)"},{"line_number":12362,"context_line":""},{"line_number":12363,"context_line":"            # Create hyperswap group snapshot"},{"line_number":12364,"context_line":"            group_snapshot, snapshots \u003d self._create_group_snapshot("},{"line_number":12365,"context_line":"                src_group.id, group_type_id\u003dself.rccg_type.id)"},{"line_number":12366,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"ea980eb3_ffa0631d","line":12363,"range":{"start_line":12363,"start_character":14,"end_line":12363,"end_character":45},"updated":"2021-05-14 12:28:35.000000000","message":"hyperswap group snapshot or replication group snapshot.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12364,"context_line":"            group_snapshot, snapshots \u003d self._create_group_snapshot("},{"line_number":12365,"context_line":"                src_group.id, group_type_id\u003dself.rccg_type.id)"},{"line_number":12366,"context_line":""},{"line_number":12367,"context_line":"            # Create gmcv group from source gmcv group snapshot"},{"line_number":12368,"context_line":"            model_update, volumes_model_update \u003d ("},{"line_number":12369,"context_line":"                self.driver.create_group_from_src(self.ctxt, clone_group,"},{"line_number":12370,"context_line":"                                                  clone_volumes,"}],"source_content_type":"text/x-python","patch_set":11,"id":"dc72fe2e_11521dd4","line":12367,"range":{"start_line":12367,"start_character":14,"end_line":12367,"end_character":63},"updated":"2021-05-14 12:28:35.000000000","message":"update the comment.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12380,"context_line":"            self.driver.delete_group(self.ctxt, clone_group,"},{"line_number":12381,"context_line":"                                     [clone_vol1, clone_vol2])"},{"line_number":12382,"context_line":"            with (mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":12383,"context_line":"                  \u0027create_rccg\u0027)) as create_rccg:"},{"line_number":12384,"context_line":"                # Create GMCV group from source GMCV group"},{"line_number":12385,"context_line":"                model_update, volumes_model_update \u003d ("},{"line_number":12386,"context_line":"                    self.driver.create_group_from_src(self.ctxt, clone_group,"}],"source_content_type":"text/x-python","patch_set":11,"id":"fe48d8c4_1c83e616","line":12383,"range":{"start_line":12383,"start_character":19,"end_line":12383,"end_character":30},"updated":"2021-05-14 12:28:35.000000000","message":"mock the \"update_group\" call also, since the \"update_group\" call is added in \"create_group_from_src\"","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":12381,"context_line":"                                     [clone_vol1, clone_vol2])"},{"line_number":12382,"context_line":"            with (mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":12383,"context_line":"                  \u0027create_rccg\u0027)) as create_rccg:"},{"line_number":12384,"context_line":"                # Create GMCV group from source GMCV group"},{"line_number":12385,"context_line":"                model_update, volumes_model_update \u003d ("},{"line_number":12386,"context_line":"                    self.driver.create_group_from_src(self.ctxt, clone_group,"},{"line_number":12387,"context_line":"                                                      clone_volumes,"}],"source_content_type":"text/x-python","patch_set":11,"id":"100b597a_6b551b0e","line":12384,"range":{"start_line":12384,"start_character":18,"end_line":12384,"end_character":58},"updated":"2021-05-14 12:28:35.000000000","message":"update the comment.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"2ec6e35f8442a249cfa12cb7719afed5cef84e4f","unresolved":true,"context_lines":[{"line_number":5996,"context_line":"                                            fake_opts_old]"},{"line_number":5997,"context_line":"            self.driver.retype(ctxt, volume, new_type, diff, host)"},{"line_number":5998,"context_line":"            update_vdisk_qos.assert_called_with(volume[\u0027name\u0027],"},{"line_number":5999,"context_line":""},{"line_number":6000,"context_line":"                                                fake_opts_qos[\u0027qos\u0027],"},{"line_number":6001,"context_line":"                                                volume[\u0027size\u0027])"},{"line_number":6002,"context_line":"            self.assertFalse(disable_vdisk_qos.called)"}],"source_content_type":"text/x-python","patch_set":13,"id":"5ebdc8f7_e38b420f","line":5999,"updated":"2021-06-01 11:14:46.000000000","message":"Remove empty line.","commit_id":"e1fa45a3a96ff5b1b6bf17e614e0b825aa794bf6"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"2ec6e35f8442a249cfa12cb7719afed5cef84e4f","unresolved":true,"context_lines":[{"line_number":6850,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":6851,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":6852,"context_line":"                         \"CG create from src created failed\")"},{"line_number":6853,"context_line":""},{"line_number":6854,"context_line":"        for each_vol in volumes_model_update:"},{"line_number":6855,"context_line":"            self.assertEqual(\u0027available\u0027, each_vol[\u0027status\u0027])"},{"line_number":6856,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"26ebee26_480bf2f7","line":6853,"updated":"2021-06-01 11:14:46.000000000","message":"Same.","commit_id":"e1fa45a3a96ff5b1b6bf17e614e0b825aa794bf6"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"2ec6e35f8442a249cfa12cb7719afed5cef84e4f","unresolved":true,"context_lines":[{"line_number":6856,"context_line":""},{"line_number":6857,"context_line":"        # Delete the Group"},{"line_number":6858,"context_line":"        model_update \u003d self.driver.delete_group(self.ctxt, group, volumes)"},{"line_number":6859,"context_line":""},{"line_number":6860,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":6861,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":6862,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"43d06ed6_feed0778","line":6859,"updated":"2021-06-01 11:14:46.000000000","message":"same","commit_id":"e1fa45a3a96ff5b1b6bf17e614e0b825aa794bf6"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"2ec6e35f8442a249cfa12cb7719afed5cef84e4f","unresolved":true,"context_lines":[{"line_number":6889,"context_line":"        self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":6890,"context_line":"                         model_update[\u0027status\u0027],"},{"line_number":6891,"context_line":"                         \"CG create from src created failed\")"},{"line_number":6892,"context_line":""},{"line_number":6893,"context_line":"        for each_vol in volumes_model_update:"},{"line_number":6894,"context_line":"            self.assertEqual(\u0027available\u0027, each_vol[\u0027status\u0027])"},{"line_number":6895,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"5d4dc6c2_16351cce","line":6892,"updated":"2021-06-01 11:14:46.000000000","message":"same","commit_id":"e1fa45a3a96ff5b1b6bf17e614e0b825aa794bf6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"372c3aef7128bc4091875bbd58808f0dae1dd82d","unresolved":true,"context_lines":[{"line_number":6856,"context_line":"        model_update \u003d self.driver.delete_group(self.ctxt, group, volumes)"},{"line_number":6857,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":6858,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":6859,"context_line":""},{"line_number":6860,"context_line":"        for each_vol in model_update[1]:"},{"line_number":6861,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6862,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"c0a81105_f30cc948","line":6859,"updated":"2021-08-02 14:30:39.000000000","message":"nit: I\u0027d remove this empty line so that it\u0027s clear that lines 6860-6861 are part of the \"Delete the Group\" and aren\u0027t starting a new phase of the test\n\n(same nit at lines 6874 and 6877 ... this test has a lot of stuff going on in it, so readability is important)","commit_id":"9cd128f071e06bec67e234041b171499c91d1387"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"372c3aef7128bc4091875bbd58808f0dae1dd82d","unresolved":true,"context_lines":[{"line_number":6860,"context_line":"        for each_vol in model_update[1]:"},{"line_number":6861,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6862,"context_line":""},{"line_number":6863,"context_line":"        with (mock.patch.object(storwize_svc_common.StorwizeHelpers,"},{"line_number":6864,"context_line":"              \u0027create_rccg\u0027)) as create_rccg:"},{"line_number":6865,"context_line":"            # Create cg from source cg"},{"line_number":6866,"context_line":"            model_update, volumes_model_update \u003d ("},{"line_number":6867,"context_line":"                self.driver.create_group_from_src(self.ctxt, group, volumes,"},{"line_number":6868,"context_line":"                                                  None, None, source_cg,"},{"line_number":6869,"context_line":"                                                  source_vols))"},{"line_number":6870,"context_line":"            create_rccg.assert_not_called()"},{"line_number":6871,"context_line":""},{"line_number":6872,"context_line":"        # Delete the Group"},{"line_number":6873,"context_line":"        model_update \u003d self.driver.delete_group(self.ctxt, group, volumes)"},{"line_number":6874,"context_line":""},{"line_number":6875,"context_line":"        self.assertEqual(fields.GroupStatus.DELETED,"},{"line_number":6876,"context_line":"                         model_update[0][\u0027status\u0027])"},{"line_number":6877,"context_line":""},{"line_number":6878,"context_line":"        for each_vol in model_update[1]:"},{"line_number":6879,"context_line":"            self.assertEqual(\u0027deleted\u0027, each_vol[\u0027status\u0027])"},{"line_number":6880,"context_line":""},{"line_number":6881,"context_line":"        # Create cg from cg snapshot"},{"line_number":6882,"context_line":"        model_update, volumes_model_update \u003d ("}],"source_content_type":"text/x-python","patch_set":14,"id":"7f042870_650bbc78","line":6879,"range":{"start_line":6863,"start_character":0,"end_line":6879,"end_character":59},"updated":"2021-08-02 14:30:39.000000000","message":"What exactly is this block testing that couldn\u0027t have been checked for in lines 6845-6861?","commit_id":"9cd128f071e06bec67e234041b171499c91d1387"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"372c3aef7128bc4091875bbd58808f0dae1dd82d","unresolved":true,"context_lines":[{"line_number":12215,"context_line":"        if vol_spec[\u0027replication_enabled\u0027] \u003d\u003d \u0027\u003cis\u003e True\u0027:"},{"line_number":12216,"context_line":"            self.assertEqual(fields.GroupStatus.AVAILABLE,"},{"line_number":12217,"context_line":"                             model_update[\u0027status\u0027])"},{"line_number":12218,"context_line":"        elif vol_spec[\u0027replication_enabled\u0027] \u003d\u003d \u0027\u003cis\u003e False\u0027:"},{"line_number":12219,"context_line":"            self.assertEqual(fields.GroupStatus.ERROR, model_update[\u0027status\u0027])"},{"line_number":12220,"context_line":""},{"line_number":12221,"context_line":"    @ddt.data(({\u0027volume_type\u0027: \u0027mm\u0027}),"}],"source_content_type":"text/x-python","patch_set":14,"id":"45e3c5ac_071a3090","line":12218,"range":{"start_line":12218,"start_character":8,"end_line":12218,"end_character":12},"updated":"2021-08-02 14:30:39.000000000","message":"I don\u0027t like this elif ... I suggest just having \u0027else:\u0027 here.  (The idea is that there should never be a test where it\u0027s possible that nothing will be asserted.)","commit_id":"9cd128f071e06bec67e234041b171499c91d1387"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"6f0fa59e042a33b2cc7f88d54484b080f5ae3694","unresolved":true,"context_lines":[{"line_number":5826,"context_line":"                        context, vol, volumes_model[volumes.index(vol)]))"},{"line_number":5827,"context_line":""},{"line_number":5828,"context_line":"            opts \u003d self._get_vdisk_params(vol[\u0027volume_type_id\u0027],"},{"line_number":5829,"context_line":"                                          volume_metadata\u003dvol.get("},{"line_number":5830,"context_line":"                                          \u0027volume_metadata\u0027))"},{"line_number":5831,"context_line":"            if opts[\u0027qos\u0027]:"},{"line_number":5832,"context_line":"                # Updating QoS properties for a volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"1d97bd9f_f2b28406","line":5829,"updated":"2021-04-05 15:27:12.000000000","message":"please revert this change as it not adding any value.","commit_id":"8251e45a1f60d95a021d5e4b36c01df3d2498f61"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"c7aa08e3dbca750edde5f7286d01eed3becbb661","unresolved":false,"context_lines":[{"line_number":5826,"context_line":"                        context, vol, volumes_model[volumes.index(vol)]))"},{"line_number":5827,"context_line":""},{"line_number":5828,"context_line":"            opts \u003d self._get_vdisk_params(vol[\u0027volume_type_id\u0027],"},{"line_number":5829,"context_line":"                                          volume_metadata\u003dvol.get("},{"line_number":5830,"context_line":"                                          \u0027volume_metadata\u0027))"},{"line_number":5831,"context_line":"            if opts[\u0027qos\u0027]:"},{"line_number":5832,"context_line":"                # Updating QoS properties for a volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"91353ed8_e8751071","line":5829,"in_reply_to":"1d97bd9f_f2b28406","updated":"2021-04-06 04:58:06.000000000","message":"I have reverted this Change pls review Manoj","commit_id":"8251e45a1f60d95a021d5e4b36c01df3d2498f61"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":5829,"context_line":"                volumes_model[volumes.index(vol)] \u003d ("},{"line_number":5830,"context_line":"                    self._qos_model_update("},{"line_number":5831,"context_line":"                        volumes_model[volumes.index(vol)], vol))"},{"line_number":5832,"context_line":"        self.update_group(context, group, add_volumes\u003dvolumes,"},{"line_number":5833,"context_line":"                          remove_volumes\u003d[])"},{"line_number":5834,"context_line":"        LOG.debug(\"Leave: create_group_from_src.\")"},{"line_number":5835,"context_line":"        return model_update, volumes_model"}],"source_content_type":"text/x-python","patch_set":11,"id":"53eb796d_6a6809cd","line":5832,"range":{"start_line":5832,"start_character":13,"end_line":5832,"end_character":25},"updated":"2021-05-14 12:28:35.000000000","message":"update_group call is not required for normal volumes and HyperSwap volumes.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"2a19644a2153fe5a58bd29d69e6321fc6965fb2e","unresolved":true,"context_lines":[{"line_number":5829,"context_line":"                volumes_model[volumes.index(vol)] \u003d ("},{"line_number":5830,"context_line":"                    self._qos_model_update("},{"line_number":5831,"context_line":"                        volumes_model[volumes.index(vol)], vol))"},{"line_number":5832,"context_line":"        self.update_group(context, group, add_volumes\u003dvolumes,"},{"line_number":5833,"context_line":"                          remove_volumes\u003d[])"},{"line_number":5834,"context_line":"        LOG.debug(\"Leave: create_group_from_src.\")"},{"line_number":5835,"context_line":"        return model_update, volumes_model"}],"source_content_type":"text/x-python","patch_set":11,"id":"d1d26fb1_207bc377","line":5832,"range":{"start_line":5832,"start_character":13,"end_line":5832,"end_character":25},"in_reply_to":"53eb796d_6a6809cd","updated":"2021-05-17 08:26:35.000000000","message":"yes,even though hyperswap and non-rep calls wont do anything additioal, we should not call then uncecessarily. we should me the above if block to here and add this line inside the if block","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"}],"releasenotes/notes/bug-1920912-add_volumes_to_clone_group_fix-1cc9668ea077831e.yaml":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"96eba5e1f00e26a18cb0bb607dd7c63e6ffb4472","unresolved":true,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    Bug #1920912 \u003chttps://bugs.launchpad.net/cinder/+bug/1920912\u003e`_:"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Fixed rccg create issue"},{"line_number":5,"context_line":"    while adding volumes to a group where that group is cloned from"},{"line_number":6,"context_line":"    group snapshot or another source group."}],"source_content_type":"text/x-yaml","patch_set":11,"id":"0048bc33_4488e5d1","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":41},"updated":"2021-05-14 12:28:35.000000000","message":"This statement should come first and then bug id.","commit_id":"35f61753140de051c64dc8b188dfbcff9b40f25b"}]}