)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"42f7f9ef405e6ad32ac18b996a792203c24e3d2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8153c1db_9275976a","updated":"2022-06-28 22:15:31.000000000","message":"Carlos, should this be backported to the older branches?","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"70ada9e82a65f10761c8d4dfd53df6ee6d0b2c46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"497d0994_9b9d8f7d","updated":"2022-06-17 15:59:38.000000000","message":"Did a recheck, but should be fine (iSCSI CI passed on the last run in June 2021).  Fix looks like it should work for both newer and legacy ontap systems.","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"6ed0c56639f22a7963eb64bb3040da900a088126","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5d32a3ac_7cf461bf","updated":"2022-04-08 18:41:40.000000000","message":"LGTM, this fix has been proposed long time ago, if there are no more suggestions to add, I think it could be merged.","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9166d713d62f99fa9a3cbc6265725d4ac91b3265","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"8ae47b1b_a4718974","updated":"2022-06-17 15:56:59.000000000","message":"run-NetApp CI","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dba2fb6a8e79e3d629711d3ece0235a93a6a4e87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"74a6a652_ca6553e3","in_reply_to":"8153c1db_9275976a","updated":"2022-06-29 10:42:29.000000000","message":"Yes, it should, Luigi... I remember people hitting this issue in quite old branches, so worth it to push the backports. I\u0027m on it :)","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_api.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9c92b3144bfd275968b53a49b010f55fddc99a98","unresolved":true,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    @ddt.data(b\u0027Password:\u0027,"},{"line_number":512,"context_line":"              b\u0027Password: \u0027,"},{"line_number":513,"context_line":"              b\u0027Password: \\n\\n\u0027)"},{"line_number":514,"context_line":"    def test_execute_command_with_prompt(self, response):"},{"line_number":515,"context_line":"        ssh \u003d mock.Mock(paramiko.SSHClient)"},{"line_number":516,"context_line":"        stdin, stdout, stderr \u003d self._mock_ssh_channel_files(paramiko.Channel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ce493692_1b240d1a","line":513,"updated":"2021-04-12 21:23:23.000000000","message":"You could add a test case here that has something before \"Password\".","commit_id":"758a081c50a9a5d6aefb1a19b45fe73e0614a3b5"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"f5ecae6c0e9eed77ffdc6e907f30e2ed7e07e6bc","unresolved":true,"context_lines":[{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    @ddt.data(b\u0027Password:\u0027,"},{"line_number":512,"context_line":"              b\u0027Password: \u0027,"},{"line_number":513,"context_line":"              b\u0027Password: \\n\\n\u0027)"},{"line_number":514,"context_line":"    def test_execute_command_with_prompt(self, response):"},{"line_number":515,"context_line":"        ssh \u003d mock.Mock(paramiko.SSHClient)"},{"line_number":516,"context_line":"        stdin, stdout, stderr \u003d self._mock_ssh_channel_files(paramiko.Channel)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3eda99ae_ab1c5862","line":513,"in_reply_to":"ce493692_1b240d1a","updated":"2021-04-13 14:15:44.000000000","message":"Oh, that\u0027s a nice test scenario to have. Thanks for suggesting :)","commit_id":"758a081c50a9a5d6aefb1a19b45fe73e0614a3b5"}],"cinder/volume/drivers/netapp/dataontap/client/api.py":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ca8167ed92ef76711c5f4729a958512a59e8a5be","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        stdin, stdout, stderr \u003d client.exec_command(command)"},{"line_number":602,"context_line":"        self._wait_on_stdout(stdout, timeout)"},{"line_number":603,"context_line":"        response \u003d stdout.channel.recv(999)"},{"line_number":604,"context_line":"        if expected_prompt_text not in response.strip().decode():"},{"line_number":605,"context_line":"            msg \u003d _(\"Unexpected output. Expected [%(expected)s] but \""},{"line_number":606,"context_line":"                    \"received [%(output)s]\") % {"},{"line_number":607,"context_line":"                \u0027expected\u0027: expected_prompt_text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"74f0c07c_8ea3d004","line":604,"updated":"2021-09-17 15:33:24.000000000","message":"couldn\u0027t this broad search led to false positives?","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"ee2188de8b5708382e2aced499ed861d1711caa6","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        stdin, stdout, stderr \u003d client.exec_command(command)"},{"line_number":602,"context_line":"        self._wait_on_stdout(stdout, timeout)"},{"line_number":603,"context_line":"        response \u003d stdout.channel.recv(999)"},{"line_number":604,"context_line":"        if expected_prompt_text not in response.strip().decode():"},{"line_number":605,"context_line":"            msg \u003d _(\"Unexpected output. Expected [%(expected)s] but \""},{"line_number":606,"context_line":"                    \"received [%(output)s]\") % {"},{"line_number":607,"context_line":"                \u0027expected\u0027: expected_prompt_text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb05e936_b038ebfc","line":604,"in_reply_to":"3c85ae86_b52ada5d","updated":"2021-09-22 07:46:01.000000000","message":"I see, thanks. So it is a very limited use case where the message a) isn\u0027t hopefully going to change again in the future and b) can\u0027t really differ from that pattern.","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":29632,"name":"Carlos Eduardo","email":"ces.eduardo98@gmail.com","username":"silvacarlos"},"change_message_id":"dfda1fa3f6d9318c824a689d6b8184169b192b0c","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        stdin, stdout, stderr \u003d client.exec_command(command)"},{"line_number":602,"context_line":"        self._wait_on_stdout(stdout, timeout)"},{"line_number":603,"context_line":"        response \u003d stdout.channel.recv(999)"},{"line_number":604,"context_line":"        if expected_prompt_text not in response.strip().decode():"},{"line_number":605,"context_line":"            msg \u003d _(\"Unexpected output. Expected [%(expected)s] but \""},{"line_number":606,"context_line":"                    \"received [%(output)s]\") % {"},{"line_number":607,"context_line":"                \u0027expected\u0027: expected_prompt_text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3c85ae86_b52ada5d","line":604,"in_reply_to":"74f0c07c_8ea3d004","updated":"2021-09-21 21:51:45.000000000","message":"Thinking about the current scenarios where this function is being called, and thinking about its purpose of executing a command and responding to a prompt, I\u0027m unsure if that would happen...\nThe broad search can also prevent from this bug happening again in case ONTAP just decides to answer even more things.\nIn a login scenario (which is the only thing being done with this function in the code), ONTAP used to respond only: \n\"Password:\"\nAfter some ONTAP releases (and if the last login info display was enabled by the cluster admin), it started responding:\n\"Last login attempt \u003cdate and time\u003e \\n\nPassword:\"\nSo if we make this specific searches now as it was in the past, depending on how it is modified, there might be need to modify this in the future too, in case ONTAP starts reporting even more stuff in the login.","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9166d713d62f99fa9a3cbc6265725d4ac91b3265","unresolved":true,"context_lines":[{"line_number":601,"context_line":"        stdin, stdout, stderr \u003d client.exec_command(command)"},{"line_number":602,"context_line":"        self._wait_on_stdout(stdout, timeout)"},{"line_number":603,"context_line":"        response \u003d stdout.channel.recv(999)"},{"line_number":604,"context_line":"        if expected_prompt_text not in response.strip().decode():"},{"line_number":605,"context_line":"            msg \u003d _(\"Unexpected output. Expected [%(expected)s] but \""},{"line_number":606,"context_line":"                    \"received [%(output)s]\") % {"},{"line_number":607,"context_line":"                \u0027expected\u0027: expected_prompt_text,"}],"source_content_type":"text/x-python","patch_set":2,"id":"a051c848_9491d1b5","line":604,"in_reply_to":"fb05e936_b038ebfc","updated":"2022-06-17 15:56:59.000000000","message":"Luigi is correct to point this out, because it\u0027s kind of fragile, but I\u0027m not sure what else you can do here.","commit_id":"a5c80032f623b4a593612bc159257a2f52fe285e"}]}