)]}'
{"cinder/openstack/common/excutils.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"34287cd94622c98b2434ff31dcb753c12cbb872a","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    def __exit__(self, exc_type, exc_val, exc_tb):"},{"line_number":74,"context_line":"        if exc_type is not None:"},{"line_number":75,"context_line":"            if self.reraise:"},{"line_number":76,"context_line":"                logging.error(_LE(\u0027Original exception being dropped: %s\u0027),"},{"line_number":77,"context_line":"                              traceback.format_exception(self.type_,"},{"line_number":78,"context_line":"                                                         self.value,"},{"line_number":79,"context_line":"                                                         self.tb))"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_40892d25","line":76,"updated":"2014-08-19 17:48:18.000000000","message":"We aren\u0027t using this logging translation in cinder... I assume it does no harm in oslo bits","commit_id":"1295436fdec7ca490450845d2647b61cfb72d350"}],"cinder/tests/test_policy.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"06c59c21e82ec8e26f06ea9f04bd425e937d42d7","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Test of Policy Engine For Cinder.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os.path"},{"line_number":20,"context_line":"import urllib2"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_c03ffd23","side":"PARENT","line":17,"updated":"2014-08-19 17:51:43.000000000","message":"So we\u0027re not unit testing policy any more? That does not seem to be a good plan.","commit_id":"77b655c0596e2247266dc3f3b86d076a6858aeea"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7e00da3caa3ac240b6a3fcafd5ede03d7b0a3b79","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Test of Policy Engine For Cinder.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os.path"},{"line_number":20,"context_line":"import urllib2"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_ec120f08","side":"PARENT","line":17,"in_reply_to":"1abeadc6_c03ffd23","updated":"2014-08-20 14:16:54.000000000","message":"The policy code is already tested inside oslo-incubator","commit_id":"77b655c0596e2247266dc3f3b86d076a6858aeea"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"98449e985b6ae6b1dec855ea740a3647c76709f1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":15,"context_line":"#    under the License."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"Test of Policy Engine For Cinder.\"\"\""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"import os.path"},{"line_number":20,"context_line":"import urllib2"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_32cfac57","side":"PARENT","line":17,"in_reply_to":"1abeadc6_ec120f08","updated":"2014-08-22 14:23:05.000000000","message":"But if those unit tests change because the interfaces change, cinder has no way of finding out. I think keeping unit tests that test our assumptions of the oslo code are valuable.\n\nThat said, the unit tests below might well not be the right tests, and it is a general problem with our use of OSLO, and not going to be fixed here, I\u0027ll add it to the cinder hardening list for next cycle","commit_id":"77b655c0596e2247266dc3f3b86d076a6858aeea"}],"cinder/tests/test_utils.py":[{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"06c59c21e82ec8e26f06ea9f04bd425e937d42d7","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.assertEqual(generated_url, actual_url)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @mock.patch(\u0027__builtin__.open\u0027)"},{"line_number":371,"context_line":"    @mock.patch(\u0027os.path.getmtime\u0027, return_value\u003d1)"},{"line_number":372,"context_line":"    def test_read_cached_file(self, mock_mtime, mock_open):"},{"line_number":373,"context_line":"        fake_file \u003d \"/this/is/a/fake\""},{"line_number":374,"context_line":"        cache_data \u003d {\"data\": 1123, \"mtime\": 2}"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_c0f8dd7e","side":"PARENT","line":371,"updated":"2014-08-19 17:51:43.000000000","message":"Keeping these as a test of our assumptions of the oslo code is not necessarily unreasonable?","commit_id":"77b655c0596e2247266dc3f3b86d076a6858aeea"},{"author":{"_account_id":1207,"name":"Duncan Thomas","email":"duncan.thomas@gmail.com","username":"duncan-thomas"},"change_message_id":"98449e985b6ae6b1dec855ea740a3647c76709f1","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.assertEqual(generated_url, actual_url)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @mock.patch(\u0027__builtin__.open\u0027)"},{"line_number":371,"context_line":"    @mock.patch(\u0027os.path.getmtime\u0027, return_value\u003d1)"},{"line_number":372,"context_line":"    def test_read_cached_file(self, mock_mtime, mock_open):"},{"line_number":373,"context_line":"        fake_file \u003d \"/this/is/a/fake\""},{"line_number":374,"context_line":"        cache_data \u003d {\"data\": 1123, \"mtime\": 2}"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_dcc04a52","side":"PARENT","line":371,"in_reply_to":"1abeadc6_2c1fa709","updated":"2014-08-22 14:23:05.000000000","message":"But the tests can be changed in the oslo without anybody ever finding out that cinder needs updating until something breaks in production.... Cinder testing our assumptions of the behaviour of oslo code is definitely a good idea. For now I\u0027ve added it to the list of hardening for next cycle ( https://etherpad.openstack.org/p/cinder-kilo-stabilisation-work ) - if you have any thoughts, I encourage you to chime in there","commit_id":"77b655c0596e2247266dc3f3b86d076a6858aeea"},{"author":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"change_message_id":"7e00da3caa3ac240b6a3fcafd5ede03d7b0a3b79","unresolved":false,"context_lines":[{"line_number":368,"context_line":"        self.assertEqual(generated_url, actual_url)"},{"line_number":369,"context_line":""},{"line_number":370,"context_line":"    @mock.patch(\u0027__builtin__.open\u0027)"},{"line_number":371,"context_line":"    @mock.patch(\u0027os.path.getmtime\u0027, return_value\u003d1)"},{"line_number":372,"context_line":"    def test_read_cached_file(self, mock_mtime, mock_open):"},{"line_number":373,"context_line":"        fake_file \u003d \"/this/is/a/fake\""},{"line_number":374,"context_line":"        cache_data \u003d {\"data\": 1123, \"mtime\": 2}"}],"source_content_type":"text/x-python","patch_set":18,"id":"1abeadc6_2c1fa709","side":"PARENT","line":371,"in_reply_to":"1abeadc6_c0f8dd7e","updated":"2014-08-20 14:16:54.000000000","message":"It\u0027s useless to port these tests as they exist in oslo already.","commit_id":"77b655c0596e2247266dc3f3b86d076a6858aeea"}]}