)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ea31822fb9bd6059fc99fa6bb4eafb56cad534d","unresolved":true,"context_lines":[{"line_number":15,"context_line":"that is too small given that of the source image and the clone fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch adds a function in our driver\u0027s clone logic to select the"},{"line_number":18,"context_line":"larger of the two strip unit values (used to compute order) so that the"},{"line_number":19,"context_line":"desired stripe unit is respected."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Additionally, we are also seeing this bug because Glance\u0027s default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b306d623_0aa01ac0","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":23},"updated":"2021-07-22 14:03:40.000000000","message":"typo: \"stripe\"","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"eeab907c3992f4c6234a6bf3ff3f519570a9b90a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"that is too small given that of the source image and the clone fails."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch adds a function in our driver\u0027s clone logic to select the"},{"line_number":18,"context_line":"larger of the two strip unit values (used to compute order) so that the"},{"line_number":19,"context_line":"desired stripe unit is respected."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Additionally, we are also seeing this bug because Glance\u0027s default"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"151cd9ba_f27e175e","line":18,"range":{"start_line":18,"start_character":18,"end_line":18,"end_character":23},"in_reply_to":"b306d623_0aa01ac0","updated":"2021-07-25 21:28:36.000000000","message":"Ok","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ea31822fb9bd6059fc99fa6bb4eafb56cad534d","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch adds a function in our driver\u0027s clone logic to select the"},{"line_number":18,"context_line":"larger of the two strip unit values (used to compute order) so that the"},{"line_number":19,"context_line":"desired stripe unit is respected."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Additionally, we are also seeing this bug because Glance\u0027s default"},{"line_number":22,"context_line":"stripe width is different (larger) from Cinder\u0027s."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"ed60f005_286d9c0f","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"updated":"2021-07-22 14:03:40.000000000","message":"nit: maybe \u0027appropriate\u0027?  (Presumably the \"desired\" stripe unit (from the cinder perspective) would be the value of the config option, and we won\u0027t be using that any more if it\u0027s too small).\n\nOther than that nit, btw, this is a great commit message.","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"eeab907c3992f4c6234a6bf3ff3f519570a9b90a","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch adds a function in our driver\u0027s clone logic to select the"},{"line_number":18,"context_line":"larger of the two strip unit values (used to compute order) so that the"},{"line_number":19,"context_line":"desired stripe unit is respected."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Additionally, we are also seeing this bug because Glance\u0027s default"},{"line_number":22,"context_line":"stripe width is different (larger) from Cinder\u0027s."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"4b933a5c_3b8f73f5","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":7},"in_reply_to":"ed60f005_286d9c0f","updated":"2021-07-25 21:28:36.000000000","message":"Addressed in next update.","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":32523,"name":"Ching Kuo","display_name":"Gene Kuo","email":"igene@igene.tw","username":"genekuo"},"change_message_id":"b7afd38f24027f7f05c92c48124034537ea3f7b7","unresolved":true,"context_lines":[{"line_number":894,"context_line":"        with mock.patch.object(driver, \u0027LOG\u0027) as mock_log:"},{"line_number":895,"context_line":"            with mock.patch.object(self.driver.rbd.Image(), \u0027stripe_unit\u0027) as \\"},{"line_number":896,"context_line":"                    mock_rbd_image_stripe_unit:"},{"line_number":897,"context_line":"                mock_rbd_image_stripe_unit.return_value \u003d 4"},{"line_number":898,"context_line":"                self.driver.create_volume_from_snapshot(self.volume_a,"},{"line_number":899,"context_line":"                                                        snapshot)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ed92113a_8902ecd8","line":897,"updated":"2021-07-01 13:58:44.000000000","message":"the unit of stripe_unit return value should be in bytes\nIn this case if the rbd_store_chunk_size in glance is set as 4, the value of stripe unit should be 4194304","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"490196502f276a96d46aeb94e2d6ae48170a293f","unresolved":true,"context_lines":[{"line_number":894,"context_line":"        with mock.patch.object(driver, \u0027LOG\u0027) as mock_log:"},{"line_number":895,"context_line":"            with mock.patch.object(self.driver.rbd.Image(), \u0027stripe_unit\u0027) as \\"},{"line_number":896,"context_line":"                    mock_rbd_image_stripe_unit:"},{"line_number":897,"context_line":"                mock_rbd_image_stripe_unit.return_value \u003d 4"},{"line_number":898,"context_line":"                self.driver.create_volume_from_snapshot(self.volume_a,"},{"line_number":899,"context_line":"                                                        snapshot)"},{"line_number":900,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"45e41463_5087defe","line":897,"in_reply_to":"ed92113a_8902ecd8","updated":"2021-07-25 14:03:02.000000000","message":"Yes, you\u0027re right.","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":32523,"name":"Ching Kuo","display_name":"Gene Kuo","email":"igene@igene.tw","username":"genekuo"},"change_message_id":"b7afd38f24027f7f05c92c48124034537ea3f7b7","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"        self.assertEqual(cfg_file, self.driver.keyring_file)"},{"line_number":1752,"context_line":"        self.assertIsNone(self.driver.keyring_data)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    @ddt.data({\u0027rbd_chunk_size\u0027: 1, \u0027order\u0027: 20},"},{"line_number":1755,"context_line":"              {\u0027rbd_chunk_size\u0027: 8, \u0027order\u0027: 23},"},{"line_number":1756,"context_line":"              {\u0027rbd_chunk_size\u0027: 32, \u0027order\u0027: 25})"},{"line_number":1757,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":7,"id":"b8d288f8_fd15309e","line":1754,"updated":"2021-07-01 13:58:44.000000000","message":"the order should be set as 22 if the chunk size of image is 4 (stripe unit 4194304), as your patch modify the behavior to choose the higher one (4\u003e1)","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"a5ba30ded35d52cf040782a654aa7ea7026bbadb","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"        self.assertEqual(cfg_file, self.driver.keyring_file)"},{"line_number":1752,"context_line":"        self.assertIsNone(self.driver.keyring_data)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    @ddt.data({\u0027rbd_chunk_size\u0027: 1, \u0027order\u0027: 20},"},{"line_number":1755,"context_line":"              {\u0027rbd_chunk_size\u0027: 8, \u0027order\u0027: 23},"},{"line_number":1756,"context_line":"              {\u0027rbd_chunk_size\u0027: 32, \u0027order\u0027: 25})"},{"line_number":1757,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":7,"id":"068c969e_99b8ecce","line":1754,"in_reply_to":"6472e3e7_d287f1e4","updated":"2021-07-25 15:13:16.000000000","message":"That\u0027s true.  I may break it out to a separate function for readability,\nlet\u0027s see.","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":32523,"name":"Ching Kuo","display_name":"Gene Kuo","email":"igene@igene.tw","username":"genekuo"},"change_message_id":"e6a90211a9ac1de5d49132851ec0a730b8a205c1","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"        self.assertEqual(cfg_file, self.driver.keyring_file)"},{"line_number":1752,"context_line":"        self.assertIsNone(self.driver.keyring_data)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    @ddt.data({\u0027rbd_chunk_size\u0027: 1, \u0027order\u0027: 20},"},{"line_number":1755,"context_line":"              {\u0027rbd_chunk_size\u0027: 8, \u0027order\u0027: 23},"},{"line_number":1756,"context_line":"              {\u0027rbd_chunk_size\u0027: 32, \u0027order\u0027: 25})"},{"line_number":1757,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":7,"id":"6472e3e7_d287f1e4","line":1754,"in_reply_to":"9b1d774e_16231585","updated":"2021-07-25 14:16:53.000000000","message":"Yes, that\u0027s what I meant.\nAn easy way is to set the strip unit return value to the correct value (4194304) in line 1780 then the rbd_chunk_size 1 test case will include the changed logic.","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":9236,"name":"Jon Bernard","email":"jobernar@redhat.com","username":"jbernard"},"change_message_id":"490196502f276a96d46aeb94e2d6ae48170a293f","unresolved":true,"context_lines":[{"line_number":1751,"context_line":"        self.assertEqual(cfg_file, self.driver.keyring_file)"},{"line_number":1752,"context_line":"        self.assertIsNone(self.driver.keyring_data)"},{"line_number":1753,"context_line":""},{"line_number":1754,"context_line":"    @ddt.data({\u0027rbd_chunk_size\u0027: 1, \u0027order\u0027: 20},"},{"line_number":1755,"context_line":"              {\u0027rbd_chunk_size\u0027: 8, \u0027order\u0027: 23},"},{"line_number":1756,"context_line":"              {\u0027rbd_chunk_size\u0027: 32, \u0027order\u0027: 25})"},{"line_number":1757,"context_line":"    @ddt.unpack"}],"source_content_type":"text/x-python","patch_set":7,"id":"9b1d774e_16231585","line":1754,"in_reply_to":"b8d288f8_fd15309e","updated":"2021-07-25 14:03:02.000000000","message":"I think what you\u0027re saying is there should be a function that tests\nclone() of an image with a larger stripe unit to verify the changed\nlogic is working.  I agree, this function is missing and should be added\nbefore this patch should be merged (I\u0027ll have this in the next update).","commit_id":"b887cce3b028c57536d3c14066335029f4a4f9ca"},{"author":{"_account_id":32523,"name":"Ching Kuo","display_name":"Gene Kuo","email":"igene@igene.tw","username":"genekuo"},"change_message_id":"2b0a7eb5a280b41795fa2cc68d689a2797629dbb","unresolved":true,"context_lines":[{"line_number":1784,"context_line":""},{"line_number":1785,"context_line":"    @ddt.data({\u0027rbd_chunk_size\u0027: 1, \u0027order\u0027: 20},"},{"line_number":1786,"context_line":"              {\u0027rbd_chunk_size\u0027: 8, \u0027order\u0027: 23},"},{"line_number":1787,"context_line":"              {\u0027rbd_chunk_size\u0027: 32, \u0027order\u0027: 25})"},{"line_number":1788,"context_line":"    @ddt.unpack"},{"line_number":1789,"context_line":"    @common_mocks"},{"line_number":1790,"context_line":"    @mock.patch.object(driver.RBDDriver, \u0027_enable_replication\u0027)"}],"source_content_type":"text/x-python","patch_set":9,"id":"4230c81a_ade45527","line":1787,"updated":"2021-07-25 21:40:49.000000000","message":"After the update `order` is not used in this test. I think it will be safe to remove it from parameters.","commit_id":"99043b883b601e6922850660c9afccb55cbe336b"}]}