)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"44d2f498a9ef41403be03d424338174e6b93f542","unresolved":true,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"The field will be reported when listing and showing resources and can be"},{"line_number":13,"context_line":"used when filtering as well."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The field is exposed in the REST API as `consumes_quota` to prevent"},{"line_number":16,"context_line":"confusion for users and admins, since exposing it as `use_quota` may"},{"line_number":17,"context_line":"give them the wrong impression that they can set it up for their own"},{"line_number":18,"context_line":"purposes."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"For users we say what is happening with the quota for that resource -it"},{"line_number":21,"context_line":"consumes or doesn\u0027t consume quota-, whereas internally we express"},{"line_number":22,"context_line":"instruction to the core code -whether to use quota or not-, hence the"},{"line_number":23,"context_line":"difference in the naming."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"APIImpact"},{"line_number":26,"context_line":"DocImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":11,"id":"376f7ac8_fc31a588","line":23,"range":{"start_line":14,"start_character":0,"end_line":23,"end_character":25},"updated":"2021-08-26 13:06:55.000000000","message":"This is a good explanation, and worth pointing out explicitly.  I hope everyone reads it!","commit_id":"508f1b66a5b0869aa114db7a2803948ee7a06629"}],"api-ref/source/v3/parameters.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":216,"context_line":"  type: boolean"},{"line_number":217,"context_line":"filter_consumes_quota:"},{"line_number":218,"context_line":"  description: |"},{"line_number":219,"context_line":"    Filters results by consumes_quota field.  Resources that don\u0027t use quotas"},{"line_number":220,"context_line":"    are usually temporary internal resources created to perform an operation."},{"line_number":221,"context_line":"    Default is to not filter by it.  This filter may be disabled in"},{"line_number":222,"context_line":"    ``etc/cinder/resource_filters.json``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"e4ca8c15_db4f23be","line":219,"range":{"start_line":219,"start_character":23,"end_line":219,"end_character":37},"updated":"2021-08-26 03:31:54.000000000","message":"Maybe double backticks to make it display in monospace font?","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"644c118c9118bc721114220917ffde0b91377dfb","unresolved":false,"context_lines":[{"line_number":216,"context_line":"  type: boolean"},{"line_number":217,"context_line":"filter_consumes_quota:"},{"line_number":218,"context_line":"  description: |"},{"line_number":219,"context_line":"    Filters results by consumes_quota field.  Resources that don\u0027t use quotas"},{"line_number":220,"context_line":"    are usually temporary internal resources created to perform an operation."},{"line_number":221,"context_line":"    Default is to not filter by it.  This filter may be disabled in"},{"line_number":222,"context_line":"    ``etc/cinder/resource_filters.json``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b9e741d7_3b137c5a","line":219,"range":{"start_line":219,"start_character":23,"end_line":219,"end_character":37},"in_reply_to":"e4ca8c15_db4f23be","updated":"2021-08-26 12:37:21.000000000","message":"Done","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":218,"context_line":"  description: |"},{"line_number":219,"context_line":"    Filters results by consumes_quota field.  Resources that don\u0027t use quotas"},{"line_number":220,"context_line":"    are usually temporary internal resources created to perform an operation."},{"line_number":221,"context_line":"    Default is to not filter by it.  This filter may be disabled in"},{"line_number":222,"context_line":"    ``etc/cinder/resource_filters.json``."},{"line_number":223,"context_line":"  in: query"},{"line_number":224,"context_line":"  required: false"},{"line_number":225,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"c7b609a8_ff72081f","line":222,"range":{"start_line":221,"start_character":37,"end_line":222,"end_character":40},"updated":"2021-08-26 03:31:54.000000000","message":"Since end users don\u0027t have access to the config file, I suggest something like:\n\n  See :ref:`List Resource Filters \u003cresource-filters\u003e` to determine whether this filter is available in your cloud.","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"644c118c9118bc721114220917ffde0b91377dfb","unresolved":false,"context_lines":[{"line_number":218,"context_line":"  description: |"},{"line_number":219,"context_line":"    Filters results by consumes_quota field.  Resources that don\u0027t use quotas"},{"line_number":220,"context_line":"    are usually temporary internal resources created to perform an operation."},{"line_number":221,"context_line":"    Default is to not filter by it.  This filter may be disabled in"},{"line_number":222,"context_line":"    ``etc/cinder/resource_filters.json``."},{"line_number":223,"context_line":"  in: query"},{"line_number":224,"context_line":"  required: false"},{"line_number":225,"context_line":"  type: boolean"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"aadf4822_dff1bd1a","line":222,"range":{"start_line":221,"start_character":37,"end_line":222,"end_character":40},"in_reply_to":"c7b609a8_ff72081f","updated":"2021-08-26 12:37:21.000000000","message":"Done","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"1ff0702c91e3a36a2fa4aad1a91f621c99db88c4","unresolved":true,"context_lines":[{"line_number":855,"context_line":"  type: string"},{"line_number":856,"context_line":"consumes_quota:"},{"line_number":857,"context_line":"  description: |"},{"line_number":858,"context_line":"    Whether this resource consumes quota or not.  Resources that not counted"},{"line_number":859,"context_line":"    for quota usage are usually temporary internal resources created to perform"},{"line_number":860,"context_line":"    an operation."},{"line_number":861,"context_line":"  in: body"}],"source_content_type":"text/x-yaml","patch_set":13,"id":"0af6c072_ca46b2de","line":858,"range":{"start_line":858,"start_character":50,"end_line":858,"end_character":68},"updated":"2021-08-26 19:16:28.000000000","message":"nit:  Resources that are not","commit_id":"ec44fc89997624c692635d5fae8fba4ca5d9aa02"}],"api-ref/source/v3/resource-filters.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Resource Filters (resource_filters)"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"37113c2b_bdd70036","line":2,"updated":"2021-08-26 03:31:54.000000000","message":"add\n  .. _resource-filters:\n\nhere","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"644c118c9118bc721114220917ffde0b91377dfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":".. -*- rst -*-"},{"line_number":2,"context_line":""},{"line_number":3,"context_line":"Resource Filters (resource_filters)"},{"line_number":4,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":10,"id":"f92e6533_238e17bf","line":2,"in_reply_to":"37113c2b_bdd70036","updated":"2021-08-26 12:37:21.000000000","message":"Done","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":94,"context_line":"    @common.process_general_filtering(\u0027volume\u0027)"},{"line_number":95,"context_line":"    def _process_volume_filtering(self, context\u003dNone, filters\u003dNone,"},{"line_number":96,"context_line":"                                  req_version\u003dNone):"},{"line_number":97,"context_line":"        for version, field in self.MV_ADDED_FILTERS:"},{"line_number":98,"context_line":"            if req_version.matches(None, version):"},{"line_number":99,"context_line":"                filters.pop(field, None)"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"d5cf7ea9_5f434174","line":97,"updated":"2021-08-26 03:31:54.000000000","message":"This is an elegant way to handle this.","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"}],"cinder/tests/unit/api/v3/test_volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @ddt.data((\u0027true\u0027, 0), (\u0027false\u0027, 1))"},{"line_number":347,"context_line":"    @ddt.unpack"},{"line_number":348,"context_line":"    def test_volume_list_with_quota_filter(self, use_quota, expected_index):"},{"line_number":349,"context_line":"        volumes \u003d (test_utils.create_volume(self.ctxt, host\u003d\u0027test_host1\u0027,"},{"line_number":350,"context_line":"                                            cluster_name\u003d\u0027cluster1\u0027,"},{"line_number":351,"context_line":"                                            volume_type_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"e68f156b_cc9314c9","line":348,"updated":"2021-08-26 03:31:54.000000000","message":"Do we have a test that shows that if the filter isn\u0027t included, the use_quota field is ignored?","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"644c118c9118bc721114220917ffde0b91377dfb","unresolved":false,"context_lines":[{"line_number":345,"context_line":""},{"line_number":346,"context_line":"    @ddt.data((\u0027true\u0027, 0), (\u0027false\u0027, 1))"},{"line_number":347,"context_line":"    @ddt.unpack"},{"line_number":348,"context_line":"    def test_volume_list_with_quota_filter(self, use_quota, expected_index):"},{"line_number":349,"context_line":"        volumes \u003d (test_utils.create_volume(self.ctxt, host\u003d\u0027test_host1\u0027,"},{"line_number":350,"context_line":"                                            cluster_name\u003d\u0027cluster1\u0027,"},{"line_number":351,"context_line":"                                            volume_type_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"1fdbcfc5_93f22852","line":348,"in_reply_to":"e68f156b_cc9314c9","updated":"2021-08-26 12:37:21.000000000","message":"Done","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"}],"releasenotes/notes/mv-use_quota-b8e010f8f68a1eaa.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting with API microversion 3.65, a ``use_quota`` field"},{"line_number":5,"context_line":"    is included in the response body of volumes and snapshots to indicate"},{"line_number":6,"context_line":"    whether the volume is using quota or not, this field can be used as a"},{"line_number":7,"context_line":"    listing filter.  Only temporary resources created internally by cinder will"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"0fc6ecb2_41be0cfd","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":54},"updated":"2021-08-26 03:31:54.000000000","message":"consumes_quota","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"644c118c9118bc721114220917ffde0b91377dfb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting with API microversion 3.65, a ``use_quota`` field"},{"line_number":5,"context_line":"    is included in the response body of volumes and snapshots to indicate"},{"line_number":6,"context_line":"    whether the volume is using quota or not, this field can be used as a"},{"line_number":7,"context_line":"    listing filter.  Only temporary resources created internally by cinder will"}],"source_content_type":"text/x-yaml","patch_set":10,"id":"312f7404_7aacc2e5","line":4,"range":{"start_line":4,"start_character":45,"end_line":4,"end_character":54},"in_reply_to":"0fc6ecb2_41be0cfd","updated":"2021-08-26 12:37:21.000000000","message":"Done","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f2051397805b23a40cb003b33114b80964a75e2d","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting with API microversion 3.65, a ``use_quota`` field"},{"line_number":5,"context_line":"    is included in the response body of volumes and snapshots to indicate"},{"line_number":6,"context_line":"    whether the volume is using quota or not, this field can be used as a"},{"line_number":7,"context_line":"    listing filter.  Only temporary resources created internally by cinder will"},{"line_number":8,"context_line":"    have the value set to ``false``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"6523a042_1fd693a7","line":7,"range":{"start_line":6,"start_character":44,"end_line":7,"end_character":18},"updated":"2021-08-26 03:31:54.000000000","message":"I suggest removing this from here, adding a blank line after line 8, and saying:\n\nAdditionally, ``consumes_quota`` can be used as a listing filter for volumes and snapshots.  Its availability is controlled by its inclusion in ``etc/cinder/resource_filters.json``, where it is included by default.  The default listing behavior is not to use this filter.","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"644c118c9118bc721114220917ffde0b91377dfb","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Starting with API microversion 3.65, a ``use_quota`` field"},{"line_number":5,"context_line":"    is included in the response body of volumes and snapshots to indicate"},{"line_number":6,"context_line":"    whether the volume is using quota or not, this field can be used as a"},{"line_number":7,"context_line":"    listing filter.  Only temporary resources created internally by cinder will"},{"line_number":8,"context_line":"    have the value set to ``false``."}],"source_content_type":"text/x-yaml","patch_set":10,"id":"b66a735e_318c593e","line":7,"range":{"start_line":6,"start_character":44,"end_line":7,"end_character":18},"in_reply_to":"6523a042_1fd693a7","updated":"2021-08-26 12:37:21.000000000","message":"Done","commit_id":"fb05d0999258961d13eeaf385cbeb6d92f035fd5"}]}