)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bf7ead6cf21f6fdea50555f3a614e5db7d80cd0f","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF] Manage GMCV volumes on separate pools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Providing support to IBM Storwize cinder driver to manage GMCV"},{"line_number":10,"context_line":"changed volumes on a separate child pool while primary and auxiliary"},{"line_number":11,"context_line":"volumes remain on the specified storage pool."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"2b2b4997_759d72c3","line":9,"updated":"2021-05-15 12:20:34.000000000","message":"Add [Spectrum Virtualize Family] tag before description.","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"1d92cbe030788f9c02bf5c020373b7f49fb3ef57","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF] Manage GMCV volumes on separate pools"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Providing support to IBM Storwize cinder driver to manage GMCV"},{"line_number":10,"context_line":"changed volumes on a separate child pool while primary and auxiliary"},{"line_number":11,"context_line":"volumes remain on the specified storage pool."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"73a6fd71_b5951f5a","line":9,"in_reply_to":"2b2b4997_759d72c3","updated":"2021-05-20 16:12:10.000000000","message":"Updated.","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"45824d481d18284b1cd46201593b524d7724fcaa","unresolved":true,"context_lines":[{"line_number":12396,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027,"},{"line_number":12397,"context_line":"                new\u003dtestutils.ZeroIntervalLoopingCall)"},{"line_number":12398,"context_line":"    @ddt.unpack"},{"line_number":12399,"context_line":"    def test_create_group_from_src_with_gmcv_volume_with_childpool("},{"line_number":12400,"context_line":"            self, svc_src_childpool, svc_tgt_childpool):"},{"line_number":12401,"context_line":"        # Set replication target"},{"line_number":12402,"context_line":"        self.driver.configuration.set_override(\u0027replication_device\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"9b707107_88f99746","line":12399,"updated":"2021-07-20 14:59:36.000000000","message":"This is a very large test, is it possible to could be broken down further so if the asserts fail early at least other functionality can still be tested (with use of mocks).  Suggestion only, you possibly wish to test end to end.  Setting to -1 so you can see and respond.  Happy to remove the -1 if needs be.","commit_id":"4d408325fcd383ffe5a5b943979fd5de508bb22f"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"72326b04744c0ab6ccdb02c79375b531e708c534","unresolved":false,"context_lines":[{"line_number":12396,"context_line":"    @mock.patch(\u0027oslo_service.loopingcall.FixedIntervalLoopingCall\u0027,"},{"line_number":12397,"context_line":"                new\u003dtestutils.ZeroIntervalLoopingCall)"},{"line_number":12398,"context_line":"    @ddt.unpack"},{"line_number":12399,"context_line":"    def test_create_group_from_src_with_gmcv_volume_with_childpool("},{"line_number":12400,"context_line":"            self, svc_src_childpool, svc_tgt_childpool):"},{"line_number":12401,"context_line":"        # Set replication target"},{"line_number":12402,"context_line":"        self.driver.configuration.set_override(\u0027replication_device\u0027,"}],"source_content_type":"text/x-python","patch_set":9,"id":"b1f876b8_32d78402","line":12399,"in_reply_to":"9b707107_88f99746","updated":"2021-07-28 16:06:48.000000000","message":"I fully agree with you that looking wise it seems huge as the main functionality has a lot of dependencies coming earlier. Even though I split it down to other functions, no much difference of lines as targeted functionality is in the end. In my opinion, better to leave it as it is. I have tested this testcase end-to-end. Please remove -1 if you agree with my point.","commit_id":"4d408325fcd383ffe5a5b943979fd5de508bb22f"}],"cinder/volume/drivers/ibm/storwize_svc/replication.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bf7ead6cf21f6fdea50555f3a614e5db7d80cd0f","unresolved":true,"context_lines":[{"line_number":163,"context_line":"                                  target_vol_name)"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            if new_type:"},{"line_number":166,"context_line":"                new_type_opts \u003d self.driver._get_vdisk_params("},{"line_number":167,"context_line":"                    new_type[\u0027id\u0027], volume_type\u003dnew_type)"},{"line_number":168,"context_line":"            src_attr \u003d self.driver._helpers.get_vdisk_attributes("},{"line_number":169,"context_line":"                vref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"71ec58c7_2099c7db","line":166,"range":{"start_line":166,"start_character":16,"end_line":166,"end_character":29},"updated":"2021-05-15 12:20:34.000000000","message":"Declare variable before If, declaring it inside if may end the scope.","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"1d92cbe030788f9c02bf5c020373b7f49fb3ef57","unresolved":false,"context_lines":[{"line_number":163,"context_line":"                                  target_vol_name)"},{"line_number":164,"context_line":"        try:"},{"line_number":165,"context_line":"            if new_type:"},{"line_number":166,"context_line":"                new_type_opts \u003d self.driver._get_vdisk_params("},{"line_number":167,"context_line":"                    new_type[\u0027id\u0027], volume_type\u003dnew_type)"},{"line_number":168,"context_line":"            src_attr \u003d self.driver._helpers.get_vdisk_attributes("},{"line_number":169,"context_line":"                vref[\u0027name\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"92959027_9a0daa5a","line":166,"range":{"start_line":166,"start_character":16,"end_line":166,"end_character":29},"in_reply_to":"71ec58c7_2099c7db","updated":"2021-05-20 16:12:10.000000000","message":"Variable scope will not end up if we declare or define it in IF block.","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bf7ead6cf21f6fdea50555f3a614e5db7d80cd0f","unresolved":true,"context_lines":[{"line_number":130,"context_line":"    cfg.StrOpt(\u0027storwize_svc_src_child_pool\u0027,"},{"line_number":131,"context_line":"               default\u003dNone,"},{"line_number":132,"context_line":"               help\u003d\u0027Specifies the name of the source child pool in which\u0027"},{"line_number":133,"context_line":"                    \u0027changed volume is stored.\u0027),"},{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"},{"line_number":136,"context_line":"               help\u003d\u0027Specifies the name of the target child pool in which\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"f2cd9a6c_4416f95f","line":133,"range":{"start_line":133,"start_character":21,"end_line":133,"end_character":45},"updated":"2021-05-15 12:20:34.000000000","message":"change it to \"change volume is stored\" or \"change volumes are created\".","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"1d92cbe030788f9c02bf5c020373b7f49fb3ef57","unresolved":false,"context_lines":[{"line_number":130,"context_line":"    cfg.StrOpt(\u0027storwize_svc_src_child_pool\u0027,"},{"line_number":131,"context_line":"               default\u003dNone,"},{"line_number":132,"context_line":"               help\u003d\u0027Specifies the name of the source child pool in which\u0027"},{"line_number":133,"context_line":"                    \u0027changed volume is stored.\u0027),"},{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"},{"line_number":136,"context_line":"               help\u003d\u0027Specifies the name of the target child pool in which\u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"965d05c5_8af19bd3","line":133,"range":{"start_line":133,"start_character":21,"end_line":133,"end_character":45},"in_reply_to":"f2cd9a6c_4416f95f","updated":"2021-05-20 16:12:10.000000000","message":"Done","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bf7ead6cf21f6fdea50555f3a614e5db7d80cd0f","unresolved":true,"context_lines":[{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"},{"line_number":136,"context_line":"               help\u003d\u0027Specifies the name of the target child pool in which\u0027"},{"line_number":137,"context_line":"                    \u0027changed volume is stored.\u0027),"},{"line_number":138,"context_line":"    cfg.StrOpt(\u0027storwize_peer_pool\u0027,"},{"line_number":139,"context_line":"               default\u003dNone,"},{"line_number":140,"context_line":"               help\u003d\u0027Specifies the name of the peer pool for hyperswap \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"c7ab34b2_5077593d","line":137,"range":{"start_line":137,"start_character":21,"end_line":137,"end_character":46},"updated":"2021-05-15 12:20:34.000000000","message":"same as above comment.","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"1d92cbe030788f9c02bf5c020373b7f49fb3ef57","unresolved":false,"context_lines":[{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"},{"line_number":136,"context_line":"               help\u003d\u0027Specifies the name of the target child pool in which\u0027"},{"line_number":137,"context_line":"                    \u0027changed volume is stored.\u0027),"},{"line_number":138,"context_line":"    cfg.StrOpt(\u0027storwize_peer_pool\u0027,"},{"line_number":139,"context_line":"               default\u003dNone,"},{"line_number":140,"context_line":"               help\u003d\u0027Specifies the name of the peer pool for hyperswap \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"b50cccc1_32554fa2","line":137,"range":{"start_line":137,"start_character":21,"end_line":137,"end_character":46},"in_reply_to":"c7ab34b2_5077593d","updated":"2021-05-20 16:12:10.000000000","message":"Done","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e59561fcf8179a2fcccd993338c8ff7a08360099","unresolved":true,"context_lines":[{"line_number":129,"context_line":"                    \u0027is stored. Example: \"pool2\"\u0027),"},{"line_number":130,"context_line":"    cfg.StrOpt(\u0027storwize_svc_src_child_pool\u0027,"},{"line_number":131,"context_line":"               default\u003dNone,"},{"line_number":132,"context_line":"               help\u003d\u0027Specifies the name of the source child pool in which\u0027"},{"line_number":133,"context_line":"                    \u0027global mirror source change volume is stored.\u0027),"},{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5308535d_44649d5b","line":132,"range":{"start_line":132,"start_character":68,"end_line":132,"end_character":74},"updated":"2021-08-30 17:32:08.000000000","message":"missing \u0027space\u0027 at EOL.","commit_id":"9a884389110290d17c019f1e5792ff18062603f2"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e3c2782696947687ea220c1c4d36c2fbf69067c7","unresolved":false,"context_lines":[{"line_number":129,"context_line":"                    \u0027is stored. Example: \"pool2\"\u0027),"},{"line_number":130,"context_line":"    cfg.StrOpt(\u0027storwize_svc_src_child_pool\u0027,"},{"line_number":131,"context_line":"               default\u003dNone,"},{"line_number":132,"context_line":"               help\u003d\u0027Specifies the name of the source child pool in which\u0027"},{"line_number":133,"context_line":"                    \u0027global mirror source change volume is stored.\u0027),"},{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"8068fd90_fbd2bd5d","line":132,"range":{"start_line":132,"start_character":68,"end_line":132,"end_character":74},"in_reply_to":"5308535d_44649d5b","updated":"2021-08-31 07:52:26.000000000","message":"Done","commit_id":"9a884389110290d17c019f1e5792ff18062603f2"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e59561fcf8179a2fcccd993338c8ff7a08360099","unresolved":true,"context_lines":[{"line_number":133,"context_line":"                    \u0027global mirror source change volume is stored.\u0027),"},{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"},{"line_number":136,"context_line":"               help\u003d\u0027Specifies the name of the target child pool in which\u0027"},{"line_number":137,"context_line":"                    \u0027global mirror auxiliary change volume is stored.\u0027),"},{"line_number":138,"context_line":"    cfg.StrOpt(\u0027storwize_peer_pool\u0027,"},{"line_number":139,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"ef23a967_56de670d","line":136,"range":{"start_line":136,"start_character":68,"end_line":136,"end_character":74},"updated":"2021-08-30 17:32:08.000000000","message":"Missing space at EOL.","commit_id":"9a884389110290d17c019f1e5792ff18062603f2"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"e3c2782696947687ea220c1c4d36c2fbf69067c7","unresolved":false,"context_lines":[{"line_number":133,"context_line":"                    \u0027global mirror source change volume is stored.\u0027),"},{"line_number":134,"context_line":"    cfg.StrOpt(\u0027storwize_svc_target_child_pool\u0027,"},{"line_number":135,"context_line":"               default\u003dNone,"},{"line_number":136,"context_line":"               help\u003d\u0027Specifies the name of the target child pool in which\u0027"},{"line_number":137,"context_line":"                    \u0027global mirror auxiliary change volume is stored.\u0027),"},{"line_number":138,"context_line":"    cfg.StrOpt(\u0027storwize_peer_pool\u0027,"},{"line_number":139,"context_line":"               default\u003dNone,"}],"source_content_type":"text/x-python","patch_set":10,"id":"09c0a5e4_882c1d8b","line":136,"range":{"start_line":136,"start_character":68,"end_line":136,"end_character":74},"in_reply_to":"ef23a967_56de670d","updated":"2021-08-31 07:52:26.000000000","message":"Done","commit_id":"9a884389110290d17c019f1e5792ff18062603f2"}],"releasenotes/notes/svf-manage-gmcv-change-volumes-on-childpools-9d2217e1e6f07a0e.yaml":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bf7ead6cf21f6fdea50555f3a614e5db7d80cd0f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Add support to manage GMCV volumes "},{"line_number":5,"context_line":"    on separate storage pools."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fbf32443_536b7af6","line":4,"range":{"start_line":4,"start_character":77,"end_line":4,"end_character":78},"updated":"2021-05-15 12:20:34.000000000","message":"remove the extra space at the end.","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"1d92cbe030788f9c02bf5c020373b7f49fb3ef57","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver: Add support to manage GMCV volumes "},{"line_number":5,"context_line":"    on separate storage pools."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"8189979d_293af841","line":4,"range":{"start_line":4,"start_character":77,"end_line":4,"end_character":78},"in_reply_to":"fbf32443_536b7af6","updated":"2021-05-20 16:12:10.000000000","message":"Done","commit_id":"143f3f35d590b6781ae23b608609fadd6d8cbac5"}]}