)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"bd556a93162cfc8b12ab01762f61f1f2951e9d09","unresolved":true,"context_lines":[{"line_number":11,"context_line":"raised."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue by chaging the exception"},{"line_number":14,"context_line":"to SnapshotIsBusy."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1925230"},{"line_number":17,"context_line":"Change-Id: I53c138b197104ab37f9f880a1209a3130b4f509b"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"9666607b_aa57cd54","line":14,"range":{"start_line":14,"start_character":3,"end_line":14,"end_character":17},"updated":"2021-06-01 11:31:44.000000000","message":"VolumeHasSnapshot exception is raised.","commit_id":"cc595e23078ff11ffcf237dee826abe3c553ef24"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"96f2b23dedabd012751bbd1f1b700ded6eef9c1d","unresolved":true,"context_lines":[{"line_number":10,"context_line":"with snapshot to HyperSwap volume, InvalidInput exception was"},{"line_number":11,"context_line":"raised."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue by chaging the exception"},{"line_number":14,"context_line":"to VolumeHasSnapshot."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1925230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"228e72b8_576edf6c","line":13,"updated":"2021-07-29 06:52:44.000000000","message":"spell check: changing","commit_id":"a4e6d19b5a96b87470aee5c152ff7c0723bbf062"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"fca968d3abb4378d0f58d5a838d73a1380b33d65","unresolved":false,"context_lines":[{"line_number":10,"context_line":"with snapshot to HyperSwap volume, InvalidInput exception was"},{"line_number":11,"context_line":"raised."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This patch fixes the issue by chaging the exception"},{"line_number":14,"context_line":"to VolumeHasSnapshot."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1925230"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a3d91a8e_ef55aaff","line":13,"in_reply_to":"228e72b8_576edf6c","updated":"2021-07-30 04:20:05.000000000","message":"Addressed review comment.","commit_id":"a4e6d19b5a96b87470aee5c152ff7c0723bbf062"}],"cinder/exception.py":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"972140906e5cc88da1660edfa03bf3af9ba493cb","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"class VolumeHasSnapshot(CinderException):"},{"line_number":442,"context_line":"    message \u003d _(\"Retyping volume %(volume_name)s that has snapshot\")"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"class SnapshotIsBusy(CinderException):"}],"source_content_type":"text/x-python","patch_set":6,"id":"e800b41b_5a83c564","line":442,"range":{"start_line":442,"start_character":17,"end_line":442,"end_character":25},"updated":"2021-08-24 20:18:16.000000000","message":"I\u0027m not sure if we need a new one. Maybe you can use `exception.InvalidVolume(reason\u003dmsg)` to keep it consistent with the current code. https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L3081","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4ff29cd5a69c6571a5480299da1f98bdd1f4e4f4","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"class VolumeHasSnapshot(CinderException):"},{"line_number":442,"context_line":"    message \u003d _(\"Retyping volume %(volume_name)s that has snapshot\")"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"class SnapshotIsBusy(CinderException):"}],"source_content_type":"text/x-python","patch_set":6,"id":"c57178a4_3be5c392","line":442,"range":{"start_line":442,"start_character":17,"end_line":442,"end_character":31},"updated":"2021-09-15 14:07:09.000000000","message":"This new exception text is misleading because we do generally support retyping volumes that have snapshots.  It would be better to just use InvalidVolume and supply your message rather than adding this exception.","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8afe1d5716997df469cc8887d67dd1660cd55c83","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"class VolumeHasSnapshot(CinderException):"},{"line_number":442,"context_line":"    message \u003d _(\"Retyping volume %(volume_name)s that has snapshot\")"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"class SnapshotIsBusy(CinderException):"}],"source_content_type":"text/x-python","patch_set":6,"id":"2e2807b4_a8862419","line":442,"range":{"start_line":442,"start_character":17,"end_line":442,"end_character":25},"in_reply_to":"1953ca83_467e9625","updated":"2021-08-31 21:11:16.000000000","message":"you\u0027re trying to add a new exception to general cinder code for an issue that we have already covered as I explained in my review comments[1]. I don’t think this is the right way to go because It will make the code less consistent. However, I’m open to a second opinion on this. And even if this exception were accepted the description should be updated to match the Exception that’s being made.\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/volume/manager.py#L3075","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a459b4f12628b55399f4ff21b183e713ba5a4d41","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"class VolumeHasSnapshot(CinderException):"},{"line_number":442,"context_line":"    message \u003d _(\"Retyping volume %(volume_name)s that has snapshot\")"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"class SnapshotIsBusy(CinderException):"}],"source_content_type":"text/x-python","patch_set":6,"id":"c6261bc5_24efd755","line":442,"range":{"start_line":442,"start_character":17,"end_line":442,"end_character":25},"in_reply_to":"b36ab251_99b41666","updated":"2021-08-25 18:15:33.000000000","message":"In the link in my previous comment it\u0027s using InvalidVolume for a similar reason that VolumeHasSnapshot. I still don\u0027t think this new exception it\u0027s the right way to go. I don\u0027t think the name VolumeHasSnapshot it\u0027s related to retype so this doesn\u0027t look completely correct.","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"d7e8954e10d05d12a3320594ca1eb02dd1b501ce","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"class VolumeHasSnapshot(CinderException):"},{"line_number":442,"context_line":"    message \u003d _(\"Retyping volume %(volume_name)s that has snapshot\")"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"class SnapshotIsBusy(CinderException):"}],"source_content_type":"text/x-python","patch_set":6,"id":"1953ca83_467e9625","line":442,"range":{"start_line":442,"start_character":17,"end_line":442,"end_character":25},"in_reply_to":"c6261bc5_24efd755","updated":"2021-08-26 08:51:13.000000000","message":"I agree with you sofia and I also checked the code InvalidVolume is used in other scenarios like volume is not in available, for in-use volumes. I wanted the unique exception which says the specific volume has snapshots instead of InvalidVolume exception.","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bbdab6d782e06339b932faa0a7dc0b5f4988147d","unresolved":true,"context_lines":[{"line_number":439,"context_line":""},{"line_number":440,"context_line":""},{"line_number":441,"context_line":"class VolumeHasSnapshot(CinderException):"},{"line_number":442,"context_line":"    message \u003d _(\"Retyping volume %(volume_name)s that has snapshot\")"},{"line_number":443,"context_line":""},{"line_number":444,"context_line":""},{"line_number":445,"context_line":"class SnapshotIsBusy(CinderException):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b36ab251_99b41666","line":442,"range":{"start_line":442,"start_character":17,"end_line":442,"end_character":25},"in_reply_to":"e800b41b_5a83c564","updated":"2021-08-25 10:28:37.000000000","message":"Here the scenario is, we are checking for whether volume has snapshots. If the volume has snapshots we are raising exception and wanted the meaning full exception So added this exception. InvalidVolume is used in other scenarios like volume is not in available, for in-use volumes.","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"4311aff2e180fbcebeaa0ae8f8f92d1857e6391f","unresolved":true,"context_lines":[{"line_number":5009,"context_line":"                        raise exception.VolumeDriverException(reason\u003dmsg)"},{"line_number":5010,"context_line":"                if self._helpers._get_vdisk_fc_mappings(volume.name):"},{"line_number":5011,"context_line":"                    msg \u003d _(\u0027Unable to retype: it is not allowed to change a \u0027"},{"line_number":5012,"context_line":"                            \u0027normal volume with snapshots or in-progress \u0027"},{"line_number":5013,"context_line":"                            \u0027fcmaps to a hyperswap volume.\u0027)"},{"line_number":5014,"context_line":"                    LOG.error(msg)"},{"line_number":5015,"context_line":"                    raise exception.SnapshotIsBusy(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"ffc1ffe8_3a072c29","line":5012,"updated":"2021-04-22 07:03:02.000000000","message":"\u0027Unable to Retype: Volume has snapshots or on-going flash copy operations to a hyperswap volume. Retry the retype operation, once the flash Copy operation is completed.\u0027","commit_id":"b228e18a19f0883b0bfff55b2e3b22e0f629cff4"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"174453e52616f37101ff64c144701123781cca77","unresolved":true,"context_lines":[{"line_number":5009,"context_line":"                        raise exception.VolumeDriverException(reason\u003dmsg)"},{"line_number":5010,"context_line":"                if self._helpers._get_vdisk_fc_mappings(volume.name):"},{"line_number":5011,"context_line":"                    msg \u003d _(\u0027Unable to retype: it is not allowed to change a \u0027"},{"line_number":5012,"context_line":"                            \u0027normal volume with snapshots or in-progress \u0027"},{"line_number":5013,"context_line":"                            \u0027fcmaps to a hyperswap volume.\u0027)"},{"line_number":5014,"context_line":"                    LOG.error(msg)"},{"line_number":5015,"context_line":"                    raise exception.SnapshotIsBusy(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fe09ada2_c146f924","line":5012,"in_reply_to":"ffc1ffe8_3a072c29","updated":"2021-04-22 12:04:36.000000000","message":"updated the error message.","commit_id":"b228e18a19f0883b0bfff55b2e3b22e0f629cff4"},{"author":{"_account_id":14806,"name":"Chhavi Agarwal","email":"chhagarw@in.ibm.com","username":"chhagarw"},"change_message_id":"d8c53b48fb99b2a156b9814371347ef0f5aa860c","unresolved":true,"context_lines":[{"line_number":5012,"context_line":"                            \u0027normal volume with snapshots or in-progress \u0027"},{"line_number":5013,"context_line":"                            \u0027fcmaps to a hyperswap volume.\u0027)"},{"line_number":5014,"context_line":"                    LOG.error(msg)"},{"line_number":5015,"context_line":"                    raise exception.SnapshotIsBusy(message\u003dmsg)"},{"line_number":5016,"context_line":"            if (old_opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027 and"},{"line_number":5017,"context_line":"                    old_opts[\u0027peer_pool\u0027] !\u003d new_opts[\u0027peer_pool\u0027]):"},{"line_number":5018,"context_line":"                msg \u003d _(\u0027Unable to retype: it is not allowed to change a \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"82d06b9e_7c440cc0","line":5015,"updated":"2021-04-22 06:52:21.000000000","message":"This exception class is not clear it should be something VolumeFCMapInProgress or SVCVolumeFlashCopyInProgress","commit_id":"b228e18a19f0883b0bfff55b2e3b22e0f629cff4"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"174453e52616f37101ff64c144701123781cca77","unresolved":true,"context_lines":[{"line_number":5012,"context_line":"                            \u0027normal volume with snapshots or in-progress \u0027"},{"line_number":5013,"context_line":"                            \u0027fcmaps to a hyperswap volume.\u0027)"},{"line_number":5014,"context_line":"                    LOG.error(msg)"},{"line_number":5015,"context_line":"                    raise exception.SnapshotIsBusy(message\u003dmsg)"},{"line_number":5016,"context_line":"            if (old_opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027 and"},{"line_number":5017,"context_line":"                    old_opts[\u0027peer_pool\u0027] !\u003d new_opts[\u0027peer_pool\u0027]):"},{"line_number":5018,"context_line":"                msg \u003d _(\u0027Unable to retype: it is not allowed to change a \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"033bdf6b_d18a9785","line":5015,"in_reply_to":"82d06b9e_7c440cc0","updated":"2021-04-22 12:04:36.000000000","message":"Changed the exception to \"VolumeHasSnapshot\".","commit_id":"b228e18a19f0883b0bfff55b2e3b22e0f629cff4"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"972140906e5cc88da1660edfa03bf3af9ba493cb","unresolved":true,"context_lines":[{"line_number":5013,"context_line":"                            \u0027 to a volume. Retry the retype operation, once \u0027"},{"line_number":5014,"context_line":"                            \u0027the flash Copy operation is completed.\u0027)"},{"line_number":5015,"context_line":"                    LOG.error(msg)"},{"line_number":5016,"context_line":"                    raise exception.VolumeHasSnapshot(message\u003dmsg)"},{"line_number":5017,"context_line":"            if (old_opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027 and"},{"line_number":5018,"context_line":"                    old_opts[\u0027peer_pool\u0027] !\u003d new_opts[\u0027peer_pool\u0027]):"},{"line_number":5019,"context_line":"                msg \u003d _(\u0027Unable to retype: it is not allowed to change a \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"a4ae59a6_7149fe9d","line":5016,"range":{"start_line":5016,"start_character":54,"end_line":5016,"end_character":65},"updated":"2021-08-24 20:18:16.000000000","message":"As you defined I think you need to pass the volume_name\u003dvolume_name instead of a message.","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"bbdab6d782e06339b932faa0a7dc0b5f4988147d","unresolved":true,"context_lines":[{"line_number":5013,"context_line":"                            \u0027 to a volume. Retry the retype operation, once \u0027"},{"line_number":5014,"context_line":"                            \u0027the flash Copy operation is completed.\u0027)"},{"line_number":5015,"context_line":"                    LOG.error(msg)"},{"line_number":5016,"context_line":"                    raise exception.VolumeHasSnapshot(message\u003dmsg)"},{"line_number":5017,"context_line":"            if (old_opts[\u0027volume_topology\u0027] \u003d\u003d \u0027hyperswap\u0027 and"},{"line_number":5018,"context_line":"                    old_opts[\u0027peer_pool\u0027] !\u003d new_opts[\u0027peer_pool\u0027]):"},{"line_number":5019,"context_line":"                msg \u003d _(\u0027Unable to retype: it is not allowed to change a \u0027"}],"source_content_type":"text/x-python","patch_set":6,"id":"104a69cd_e923964d","line":5016,"range":{"start_line":5016,"start_character":54,"end_line":5016,"end_character":65},"in_reply_to":"a4ae59a6_7149fe9d","updated":"2021-08-25 10:28:37.000000000","message":"CinderException class will take message and kwargs as input. While raising exception if we want to use the default message in VolumeHasSnapshot exception then we need to give \"volume_name\u003dvolume_name\" and here we override the default message with message at line 5011, so we gave message as input.","commit_id":"ae78a6b7b002b7b8b6d13d00f9db7e20daf3ec88"}]}