)]}'
{"cinder/tests/test_hp3par.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"fbad1a553fd5818105e5c4816a4ef41a9da5f323","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            {\u0027active\u0027: True,"},{"line_number":706,"context_line":"             \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":707,"context_line":"             \u0027lun\u0027: None, \u0027type\u0027: 0}]"},{"line_number":708,"context_line":"        mock_client.getVLUN.return_value \u003d {\u0027lun\u0027: None, \u0027type\u0027: 0}"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        self.driver.terminate_connection("},{"line_number":711,"context_line":"            self.volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FTvk%3D","line":708,"updated":"2014-03-06 22:30:34.000000000","message":"getVLUN no longer needs to be here, if it\u0027s getting called somewhere else then it should be in the expected calls?","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7694893741717154f4a43948965266134a44f216","unresolved":false,"context_lines":[{"line_number":705,"context_line":"            {\u0027active\u0027: True,"},{"line_number":706,"context_line":"             \u0027volumeName\u0027: self.VOLUME_3PAR_NAME,"},{"line_number":707,"context_line":"             \u0027lun\u0027: None, \u0027type\u0027: 0}]"},{"line_number":708,"context_line":"        mock_client.getVLUN.return_value \u003d {\u0027lun\u0027: None, \u0027type\u0027: 0}"},{"line_number":709,"context_line":""},{"line_number":710,"context_line":"        self.driver.terminate_connection("},{"line_number":711,"context_line":"            self.volume,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNiA%3D","line":708,"in_reply_to":"AAAAVn%2F%2FTvk%3D","updated":"2014-03-07 16:01:21.000000000","message":"Done","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"}],"cinder/volume/drivers/san/hp/hp_3par_common.py":[{"author":{"_account_id":6043,"name":"Kurt Martin","email":"kurt.f.martin@hpe.com","username":"kurt-f-martin"},"change_message_id":"440bceadef1cc6a24bba96e58bd20afddeb8144c","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        2.0.5 - Fix extend volume units bug #1284368"},{"line_number":122,"context_line":"        2.0.6 - use loopingcall.wait instead of time.sleep"},{"line_number":123,"context_line":"        2.0.7 - Allow extend volume based on snapshot bug #1285906"},{"line_number":124,"context_line":"        2.0.8 - Fix detach issue for multiple hosts Bug #1288927"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    \"\"\""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FTtY%3D","line":124,"updated":"2014-03-06 22:34:33.000000000","message":"since other changes are required in the test could you also change Bug to bug for consistency.","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7694893741717154f4a43948965266134a44f216","unresolved":false,"context_lines":[{"line_number":121,"context_line":"        2.0.5 - Fix extend volume units bug #1284368"},{"line_number":122,"context_line":"        2.0.6 - use loopingcall.wait instead of time.sleep"},{"line_number":123,"context_line":"        2.0.7 - Allow extend volume based on snapshot bug #1285906"},{"line_number":124,"context_line":"        2.0.8 - Fix detach issue for multiple hosts Bug #1288927"},{"line_number":125,"context_line":""},{"line_number":126,"context_line":"    \"\"\""},{"line_number":127,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNjo%3D","line":124,"in_reply_to":"AAAAVn%2F%2FTtY%3D","updated":"2014-03-07 16:01:21.000000000","message":"what?","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"0cbad7e57bd4f58d2763aab823c005be35699bc7","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        if vlun is None:"},{"line_number":472,"context_line":"            msg \u003d (_(\"3PAR vlun %(name)s not found on host %(host)s\") %"},{"line_number":473,"context_line":"                   {\u0027name\u0027: volume_name, \u0027host\u0027: hostname})"},{"line_number":474,"context_line":"            raise exception.NotFound(message\u003dmsg)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        # VLUN Type of MATCHED_SET 4 requires the port to be provided"},{"line_number":477,"context_line":"        if self.VLUN_TYPE_MATCHED_SET \u003d\u003d vlun[\u0027type\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FR5Q%3D","line":474,"updated":"2014-03-07 03:50:21.000000000","message":"Did you intentionally change this to raise a generic NotFound exception that you don\u0027t handle in the calls?\n\nIt works out in this case because the manager has a broad except that wraps the exception to a BackendException like it sould be but I\u0027m not sure what you\u0027re trying to do here.\n\nI\u0027m also curious what conditions this would occur in, is it an exception, is it a cleanup issue, is it that you don\u0027t know how to figure out where the vlun is?  It\u0027s a big vague as is, it would appear you don\u0027t care because you just choke and let everything blow up but it doesn\u0027t seem well thought out.","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":9624,"name":"Ramy Asselin","email":"ramyasselin@yahoo.com","username":"asselin"},"change_message_id":"51fd95d7d25f68995f847f30272cb1716e08aec1","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        if vlun is None:"},{"line_number":472,"context_line":"            msg \u003d (_(\"3PAR vlun %(name)s not found on host %(host)s\") %"},{"line_number":473,"context_line":"                   {\u0027name\u0027: volume_name, \u0027host\u0027: hostname})"},{"line_number":474,"context_line":"            raise exception.NotFound(message\u003dmsg)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        # VLUN Type of MATCHED_SET 4 requires the port to be provided"},{"line_number":477,"context_line":"        if self.VLUN_TYPE_MATCHED_SET \u003d\u003d vlun[\u0027type\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FTU8%3D","line":474,"updated":"2014-03-06 23:28:35.000000000","message":"Do you want to log this message as a e.g. warning?\nAlso, for the other delete missing volume/snapshot failures, when it\u0027s missing, instead of throwing NotFound, we\u0027ve been suppressing exceptions in order to resync the cinder db to the backend.","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"7694893741717154f4a43948965266134a44f216","unresolved":false,"context_lines":[{"line_number":471,"context_line":"        if vlun is None:"},{"line_number":472,"context_line":"            msg \u003d (_(\"3PAR vlun %(name)s not found on host %(host)s\") %"},{"line_number":473,"context_line":"                   {\u0027name\u0027: volume_name, \u0027host\u0027: hostname})"},{"line_number":474,"context_line":"            raise exception.NotFound(message\u003dmsg)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        # VLUN Type of MATCHED_SET 4 requires the port to be provided"},{"line_number":477,"context_line":"        if self.VLUN_TYPE_MATCHED_SET \u003d\u003d vlun[\u0027type\u0027]:"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FNiY%3D","line":474,"in_reply_to":"AAAAVn%2F%2FR5Q%3D","updated":"2014-03-07 16:01:21.000000000","message":"This is simply a race condition that shouldn\u0027t ever happen.  I\u0027ll just log the error and return without raising.","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"6769e7dde708382d02423b9eb7067ef4eb513a83","unresolved":false,"context_lines":[{"line_number":472,"context_line":"            msg \u003d (_(\"3PAR vlun %(name)s not found on host %(host)s\") %"},{"line_number":473,"context_line":"                   {\u0027name\u0027: volume_name, \u0027host\u0027: hostname})"},{"line_number":474,"context_line":"            raise exception.NotFound(message\u003dmsg)"},{"line_number":475,"context_line":""},{"line_number":476,"context_line":"        # VLUN Type of MATCHED_SET 4 requires the port to be provided"},{"line_number":477,"context_line":"        if self.VLUN_TYPE_MATCHED_SET \u003d\u003d vlun[\u0027type\u0027]:"},{"line_number":478,"context_line":"            self.client.deleteVLUN(volume_name, vlun[\u0027lun\u0027], hostname,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAVn%2F%2FSyk%3D","line":475,"updated":"2014-03-07 00:40:28.000000000","message":"I would agree that a LOG.warning should be thrown here.","commit_id":"8acb76bfc6c6bd3cc5538e4e00f9bc74e840fb52"},{"author":{"_account_id":170,"name":"Mike Perez","email":"thingee@gmail.com","username":"thingee"},"change_message_id":"bef5f3d73f6bece290bee88bfa33b79de053589f","unresolved":false,"context_lines":[{"line_number":459,"context_line":"            if volume_name in vlun[\u0027volumeName\u0027]:"},{"line_number":460,"context_line":"                break"},{"line_number":461,"context_line":""},{"line_number":462,"context_line":"        if vlun is None:"},{"line_number":463,"context_line":"            msg \u003d (_(\"3PAR vlun %(name)s not found on host %(host)s\") %"},{"line_number":464,"context_line":"                   {\u0027name\u0027: volume_name, \u0027host\u0027: hostname})"},{"line_number":465,"context_line":"            LOG.warn(msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAVn%2F%2B%2BHg%3D","line":462,"updated":"2014-03-10 23:43:46.000000000","message":"vlun is going to be set even if there is no match for with volume_name in vlun[\u0027volumeName\u0027]. Is this expected?","commit_id":"5fab01be13f7656268639ca50146034edf7b422c"}]}