)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"16662c1169fd6d563445848df8e26085c4fadd66","unresolved":true,"context_lines":[{"line_number":10,"context_line":"triggers E0213 since \"self\" is missing.  Rename the"},{"line_number":11,"context_line":"first arg to \"self\", and move assert method references"},{"line_number":12,"context_line":"around to keep things working."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I586bb50e09681b7188999fd09c39eeb83a6d313f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"466efc5a_bc786c64","line":13,"updated":"2026-05-07 16:33:48.000000000","message":"I think this commit message is misleading.  (Either that or i am looking at the wrong code!)  It took me a while to figure out what\u0027s going on in this patch, but it looks to me like what you are doing is rolling back the change from https://review.opendev.org/c/openstack/cinder/+/730178 that made the local MyGlanceStubClient class a subclass of test.TestCase instead of object.  But when you do that, the \u0027self\u0027 in the scope of the MyGlanceStubClient class doesn\u0027t inherit any of the properties of test.TestCase.  The really old code had dealt with this by using \u0027inst\u0027 for the name of the new instance argement passed to __init__() (and then \u0027self\u0027 in the scope of the class would still refer to the test instance in which the class is defined, which gets us the behavior we need), but that violates E0213.  My opinion is that this is a legitimate place to ignore E0213, but your solution here works fine, too.  But I also think that the current code (where the local stub client inherits from test.TestCase and uses \u0027self\u0027 as the new instance parameter) respects E0213, so your commit message has some \u0027splaining to do.","commit_id":"8568e686ec3ba01d54b76b7ceb608be8ae792466"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"dbd27a7fba89d36fe981c847938a82a2d384dde2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c5695916_9dcf95fa","updated":"2023-01-18 13:27:30.000000000","message":"LGTM","commit_id":"8568e686ec3ba01d54b76b7ceb608be8ae792466"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"99ec4a30e4bf8f84b70c3f36eb1b186c95835cbd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"778d7e73_6cfc7493","updated":"2023-01-19 11:52:10.000000000","message":"Looks good to me - thank you!","commit_id":"8568e686ec3ba01d54b76b7ceb608be8ae792466"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"ee96d7d1c9cba826ff04a29ff56874ad787d06e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5fe4e55e_19c118cc","updated":"2023-01-20 14:20:50.000000000","message":"Looks like a quick way to solve this +2","commit_id":"8568e686ec3ba01d54b76b7ceb608be8ae792466"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"16662c1169fd6d563445848df8e26085c4fadd66","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"10f6fb72_04541602","updated":"2026-05-07 16:33:48.000000000","message":"See comment inline.","commit_id":"8568e686ec3ba01d54b76b7ceb608be8ae792466"}]}
