)]}'
{"cinder/tests/unit/test_quota.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"23d8447d7150877b921022761057477b332a6a87","unresolved":true,"context_lines":[{"line_number":369,"context_line":"        except KeyError:"},{"line_number":370,"context_line":"            raise exception.QuotaClassNotFound(class_name\u003dquota_class)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def get_default(self, context, resource, parent_project_id\u003dNone):"},{"line_number":373,"context_line":"        self.called.append((\u0027get_default\u0027, context, resource,"},{"line_number":374,"context_line":"                            parent_project_id))"},{"line_number":375,"context_line":"        return resource.default"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_defaults(self, context, resources, parent_project_id\u003dNone):"},{"line_number":378,"context_line":"        self.called.append((\u0027get_defaults\u0027, context, resources,"},{"line_number":379,"context_line":"                            parent_project_id))"},{"line_number":380,"context_line":"        return resources"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def get_class_quotas(self, context, resources, quota_class,"},{"line_number":383,"context_line":"                         defaults\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"f7fc3b02_464b810a","line":380,"range":{"start_line":372,"start_character":0,"end_line":380,"end_character":24},"updated":"2021-05-17 11:32:32.000000000","message":"-1: We should remove these references as well.","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0d777ceb3b02639d5769ae8940125e7ae735936","unresolved":false,"context_lines":[{"line_number":369,"context_line":"        except KeyError:"},{"line_number":370,"context_line":"            raise exception.QuotaClassNotFound(class_name\u003dquota_class)"},{"line_number":371,"context_line":""},{"line_number":372,"context_line":"    def get_default(self, context, resource, parent_project_id\u003dNone):"},{"line_number":373,"context_line":"        self.called.append((\u0027get_default\u0027, context, resource,"},{"line_number":374,"context_line":"                            parent_project_id))"},{"line_number":375,"context_line":"        return resource.default"},{"line_number":376,"context_line":""},{"line_number":377,"context_line":"    def get_defaults(self, context, resources, parent_project_id\u003dNone):"},{"line_number":378,"context_line":"        self.called.append((\u0027get_defaults\u0027, context, resources,"},{"line_number":379,"context_line":"                            parent_project_id))"},{"line_number":380,"context_line":"        return resources"},{"line_number":381,"context_line":""},{"line_number":382,"context_line":"    def get_class_quotas(self, context, resources, quota_class,"},{"line_number":383,"context_line":"                         defaults\u003dTrue):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ceb4ba6e_456a8d7a","line":380,"range":{"start_line":372,"start_character":0,"end_line":380,"end_character":24},"in_reply_to":"f7fc3b02_464b810a","updated":"2021-05-20 17:31:03.000000000","message":"Done","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"23d8447d7150877b921022761057477b332a6a87","unresolved":true,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.assertEqual(20, quota_value)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def test_quota_override_subproject_no_class(self):"},{"line_number":495,"context_line":"        self.flags(quota_volumes\u003d10)"},{"line_number":496,"context_line":"        resource \u003d quota.BaseResource(\u0027test_resource\u0027, \u0027quota_volumes\u0027)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"656dfaee_5e427104","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":47},"updated":"2021-05-17 11:32:32.000000000","message":"?: Shouldn\u0027t we remove this test altogether?","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0d777ceb3b02639d5769ae8940125e7ae735936","unresolved":true,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.assertEqual(20, quota_value)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def test_quota_override_subproject_no_class(self):"},{"line_number":495,"context_line":"        self.flags(quota_volumes\u003d10)"},{"line_number":496,"context_line":"        resource \u003d quota.BaseResource(\u0027test_resource\u0027, \u0027quota_volumes\u0027)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"efe1ced8_a82ac96a","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":47},"in_reply_to":"656dfaee_5e427104","updated":"2021-05-20 17:31:03.000000000","message":"I\u0027m not sure, it\u0027s not clear to me if it\u0027s completely redundant with other unit tests or if it\u0027s actually testing something unique still.","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b15fa803038b9b457b33ebd597d5e404559b9743","unresolved":false,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.assertEqual(20, quota_value)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def test_quota_override_subproject_no_class(self):"},{"line_number":495,"context_line":"        self.flags(quota_volumes\u003d10)"},{"line_number":496,"context_line":"        resource \u003d quota.BaseResource(\u0027test_resource\u0027, \u0027quota_volumes\u0027)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"26e2a020_42cc2a46","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":47},"in_reply_to":"a6df156a_1a2c3e58","updated":"2021-10-13 16:33:56.000000000","message":"Ack","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"94f4eb0623c652cdc5f4be255bd9015421a80fbc","unresolved":true,"context_lines":[{"line_number":491,"context_line":""},{"line_number":492,"context_line":"        self.assertEqual(20, quota_value)"},{"line_number":493,"context_line":""},{"line_number":494,"context_line":"    def test_quota_override_subproject_no_class(self):"},{"line_number":495,"context_line":"        self.flags(quota_volumes\u003d10)"},{"line_number":496,"context_line":"        resource \u003d quota.BaseResource(\u0027test_resource\u0027, \u0027quota_volumes\u0027)"},{"line_number":497,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"a6df156a_1a2c3e58","line":494,"range":{"start_line":494,"start_character":8,"end_line":494,"end_character":47},"in_reply_to":"efe1ced8_a82ac96a","updated":"2021-05-31 10:22:10.000000000","message":"The test was added on a NestedQuota patch ( I3b357464d5e5e0aa065506ac1e9d908e87f45c63 ), and if I understood it correctly, it was testing that a subproject could override the default of the parent project.\n\nNow that there is no hierarchy we can just remove the test.","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"23d8447d7150877b921022761057477b332a6a87","unresolved":true,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_get_defaults(self):"},{"line_number":609,"context_line":"        context \u003d FakeContext(None, None)"},{"line_number":610,"context_line":"        parent_project_id \u003d None"},{"line_number":611,"context_line":"        driver \u003d FakeDriver()"},{"line_number":612,"context_line":"        quota_obj \u003d self._make_quota_obj(driver)"},{"line_number":613,"context_line":"        result \u003d quota_obj.get_defaults(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"b9e7e333_4266d231","line":610,"range":{"start_line":610,"start_character":8,"end_line":610,"end_character":25},"updated":"2021-05-17 11:32:32.000000000","message":"ditto","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0d777ceb3b02639d5769ae8940125e7ae735936","unresolved":false,"context_lines":[{"line_number":607,"context_line":""},{"line_number":608,"context_line":"    def test_get_defaults(self):"},{"line_number":609,"context_line":"        context \u003d FakeContext(None, None)"},{"line_number":610,"context_line":"        parent_project_id \u003d None"},{"line_number":611,"context_line":"        driver \u003d FakeDriver()"},{"line_number":612,"context_line":"        quota_obj \u003d self._make_quota_obj(driver)"},{"line_number":613,"context_line":"        result \u003d quota_obj.get_defaults(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"bbdb9dca_ec8f00b7","line":610,"range":{"start_line":610,"start_character":8,"end_line":610,"end_character":25},"in_reply_to":"b9e7e333_4266d231","updated":"2021-05-20 17:31:03.000000000","message":"Done","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"23d8447d7150877b921022761057477b332a6a87","unresolved":true,"context_lines":[{"line_number":615,"context_line":"        self.assertEqual([(\u0027get_defaults\u0027,"},{"line_number":616,"context_line":"                          context,"},{"line_number":617,"context_line":"                          quota_obj.resources,"},{"line_number":618,"context_line":"                          parent_project_id), ], driver.called)"},{"line_number":619,"context_line":"        self.assertEqual(quota_obj.resources, result)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"    def test_get_class_quotas(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7c04eca1_a9eaffb3","line":618,"range":{"start_line":618,"start_character":26,"end_line":618,"end_character":43},"updated":"2021-05-17 11:32:32.000000000","message":"ditto","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0d777ceb3b02639d5769ae8940125e7ae735936","unresolved":false,"context_lines":[{"line_number":615,"context_line":"        self.assertEqual([(\u0027get_defaults\u0027,"},{"line_number":616,"context_line":"                          context,"},{"line_number":617,"context_line":"                          quota_obj.resources,"},{"line_number":618,"context_line":"                          parent_project_id), ], driver.called)"},{"line_number":619,"context_line":"        self.assertEqual(quota_obj.resources, result)"},{"line_number":620,"context_line":""},{"line_number":621,"context_line":"    def test_get_class_quotas(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"e7fc989b_18fc6ce7","line":618,"range":{"start_line":618,"start_character":26,"end_line":618,"end_character":43},"in_reply_to":"7c04eca1_a9eaffb3","updated":"2021-05-20 17:31:03.000000000","message":"Done","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"23d8447d7150877b921022761057477b332a6a87","unresolved":true,"context_lines":[{"line_number":1170,"context_line":"    def _mock_get_project_quotas(self):"},{"line_number":1171,"context_line":"        def fake_get_project_quotas(context, resources, project_id,"},{"line_number":1172,"context_line":"                                    quota_class\u003dNone, defaults\u003dTrue,"},{"line_number":1173,"context_line":"                                    usages\u003dTrue, parent_project_id\u003dNone):"},{"line_number":1174,"context_line":"            self.calls.append(\u0027get_project_quotas\u0027)"},{"line_number":1175,"context_line":"            return {k: dict(limit\u003dv.default) for k, v in resources.items()}"},{"line_number":1176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ade91a63_0b6d3efa","line":1173,"range":{"start_line":1173,"start_character":49,"end_line":1173,"end_character":72},"updated":"2021-05-17 11:32:32.000000000","message":"ditto","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0d777ceb3b02639d5769ae8940125e7ae735936","unresolved":false,"context_lines":[{"line_number":1170,"context_line":"    def _mock_get_project_quotas(self):"},{"line_number":1171,"context_line":"        def fake_get_project_quotas(context, resources, project_id,"},{"line_number":1172,"context_line":"                                    quota_class\u003dNone, defaults\u003dTrue,"},{"line_number":1173,"context_line":"                                    usages\u003dTrue, parent_project_id\u003dNone):"},{"line_number":1174,"context_line":"            self.calls.append(\u0027get_project_quotas\u0027)"},{"line_number":1175,"context_line":"            return {k: dict(limit\u003dv.default) for k, v in resources.items()}"},{"line_number":1176,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5f3a6214_e514c4f2","line":1173,"range":{"start_line":1173,"start_character":49,"end_line":1173,"end_character":72},"in_reply_to":"ade91a63_0b6d3efa","updated":"2021-05-20 17:31:03.000000000","message":"Done","commit_id":"fe0266362ee54525b25f0db7bd55ffd4ddb44cff"}]}