)]}'
{"cinder/image/cache.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"2743e7342fb42d44726f74ca634c0947271a4426","unresolved":true,"context_lines":[{"line_number":96,"context_line":"                           context: context.RequestContext,"},{"line_number":97,"context_line":"                           volume_ref: \u0027objects.Volume\u0027,"},{"line_number":98,"context_line":"                           image_id: str,"},{"line_number":99,"context_line":"                           image_meta: dict):"},{"line_number":100,"context_line":"        \"\"\"Create a new cache entry for an image."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        This assumes that the volume described by volume_ref has already been"}],"source_content_type":"text/x-python","patch_set":2,"id":"506633fe_4dd8137c","line":99,"updated":"2021-04-30 15:04:59.000000000","message":"return missing\n-\u003e dict","commit_id":"d7593ca44679626407fbbfb278880913c03c5fbd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e6ad082827f53e4dd2cfe08dfbd9185fa797f69f","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                           context: context.RequestContext,"},{"line_number":97,"context_line":"                           volume_ref: \u0027objects.Volume\u0027,"},{"line_number":98,"context_line":"                           image_id: str,"},{"line_number":99,"context_line":"                           image_meta: dict):"},{"line_number":100,"context_line":"        \"\"\"Create a new cache entry for an image."},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"        This assumes that the volume described by volume_ref has already been"}],"source_content_type":"text/x-python","patch_set":2,"id":"612afe97_120a40d2","line":99,"in_reply_to":"506633fe_4dd8137c","updated":"2021-05-10 18:25:42.000000000","message":"Done","commit_id":"d7593ca44679626407fbbfb278880913c03c5fbd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2cf53f8c8da0a7382336fcf6d579a95833c4a77d","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_entry(self,"},{"line_number":65,"context_line":"                  context: context.RequestContext,"},{"line_number":66,"context_line":"                  volume_ref: \u0027objects.Volume\u0027,"},{"line_number":67,"context_line":"                  image_id: str,"},{"line_number":68,"context_line":"                  image_meta: dict) -\u003e Optional[dict]:"},{"line_number":69,"context_line":"        cache_entry \u003d self.db.image_volume_cache_get_and_update_last_used("}],"source_content_type":"text/x-python","patch_set":10,"id":"f4e6ea23_7942134b","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":46},"updated":"2021-08-09 22:28:37.000000000","message":"I\u0027m not clear about why this is quoted, but it doesn\u0027t seem to hurt anything (though it looks weird since context.RequestContext isn\u0027t quoted).","commit_id":"111a6251958dd7be8a13ad3a8a9e2a1b711aa09d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"417e6e60a06de592755c32e0e9c7c9c514e42354","unresolved":true,"context_lines":[{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def get_entry(self,"},{"line_number":65,"context_line":"                  context: context.RequestContext,"},{"line_number":66,"context_line":"                  volume_ref: \u0027objects.Volume\u0027,"},{"line_number":67,"context_line":"                  image_id: str,"},{"line_number":68,"context_line":"                  image_meta: dict) -\u003e Optional[dict]:"},{"line_number":69,"context_line":"        cache_entry \u003d self.db.image_volume_cache_get_and_update_last_used("}],"source_content_type":"text/x-python","patch_set":10,"id":"250cabff_e0a4c1a5","line":66,"range":{"start_line":66,"start_character":30,"end_line":66,"end_character":46},"in_reply_to":"f4e6ea23_7942134b","updated":"2021-08-10 13:19:54.000000000","message":"Early on I was having problems with the mypy run being able to reference objects.Volume as an object/class -- objects.Volume doesn\u0027t exist until the objects system is initialized.  This is very different from how context.RequestContext behaves as a class.  It looks like this is no longer happening here, so I can change this.\n\n(Longer term, we may need some work done to more properly handle types of these dynamically created classes, but I haven\u0027t gotten into that yet.)","commit_id":"111a6251958dd7be8a13ad3a8a9e2a1b711aa09d"}],"cinder/image/glance.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"554a6515edadacbee79a7101eb863f08fce4c1e5","unresolved":true,"context_lines":[{"line_number":90,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"@typing.no_type_check"},{"line_number":94,"context_line":"def _parse_image_ref(image_href):"},{"line_number":95,"context_line":"    \"\"\"Parse an image href into composite parts."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"8c3689e5_52e135ad","line":93,"updated":"2021-06-24 00:47:25.000000000","message":"Why the no_type_check on some of these?","commit_id":"fc069a11f98c29b68c101c02ff3f99c5eed54ecf"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"3edf7b9a945ff7d558b0b5420aadbe7f3190feed","unresolved":true,"context_lines":[{"line_number":90,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":91,"context_line":""},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"@typing.no_type_check"},{"line_number":94,"context_line":"def _parse_image_ref(image_href):"},{"line_number":95,"context_line":"    \"\"\"Parse an image href into composite parts."},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"b75f3d7f_63ce1427","line":93,"in_reply_to":"8c3689e5_52e135ad","updated":"2021-06-30 20:44:25.000000000","message":"mypy has issues with urllib.parse -- I think I can work around this by importing urllib.parse for this file.","commit_id":"fc069a11f98c29b68c101c02ff3f99c5eed54ecf"}]}