)]}'
{"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1c0c0fa4a1233bf2d6395f0dfb039337ecfe251b","unresolved":true,"context_lines":[{"line_number":11936,"context_line":"        (model_update, add_volumes_update,"},{"line_number":11937,"context_line":"         remove_volumes_update) \u003d self.driver.update_group("},{"line_number":11938,"context_line":"            self.ctxt, group, add_vols, [])"},{"line_number":11939,"context_line":"        self.assertTrue(update_rccg_properties.called)"},{"line_number":11940,"context_line":"        self.assertEqual(1, update_rccg_properties.call_count)"},{"line_number":11941,"context_line":"        self.assertEqual(fields.GroupStatus.ERROR, model_update[\u0027status\u0027])"},{"line_number":11942,"context_line":"        self.assertEqual([{\u0027id\u0027: mm_vol.id, \u0027group_id\u0027: group.id}],"}],"source_content_type":"text/x-python","patch_set":4,"id":"72823fe6_23c89c4f","line":11939,"range":{"start_line":11939,"start_character":8,"end_line":11939,"end_character":54},"updated":"2021-08-24 17:26:07.000000000","message":"Replace this statement with update_rccg_properties.assert_called()","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"aa743d9e6d7cd05ebb14c367a64bdcdc00d328e3","unresolved":false,"context_lines":[{"line_number":11936,"context_line":"        (model_update, add_volumes_update,"},{"line_number":11937,"context_line":"         remove_volumes_update) \u003d self.driver.update_group("},{"line_number":11938,"context_line":"            self.ctxt, group, add_vols, [])"},{"line_number":11939,"context_line":"        self.assertTrue(update_rccg_properties.called)"},{"line_number":11940,"context_line":"        self.assertEqual(1, update_rccg_properties.call_count)"},{"line_number":11941,"context_line":"        self.assertEqual(fields.GroupStatus.ERROR, model_update[\u0027status\u0027])"},{"line_number":11942,"context_line":"        self.assertEqual([{\u0027id\u0027: mm_vol.id, \u0027group_id\u0027: group.id}],"}],"source_content_type":"text/x-python","patch_set":4,"id":"b5d673a6_9d2bbc67","line":11939,"range":{"start_line":11939,"start_character":8,"end_line":11939,"end_character":54},"in_reply_to":"72823fe6_23c89c4f","updated":"2021-08-25 08:54:42.000000000","message":"Updated.","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1c0c0fa4a1233bf2d6395f0dfb039337ecfe251b","unresolved":true,"context_lines":[{"line_number":11964,"context_line":"        (model_update, add_volumes_update,"},{"line_number":11965,"context_line":"         remove_volumes_update) \u003d self.driver.update_group("},{"line_number":11966,"context_line":"            self.ctxt, group, add_vols, [])"},{"line_number":11967,"context_line":"        self.assertTrue(update_rccg_properties.called)"},{"line_number":11968,"context_line":"        self.assertEqual(3, update_rccg_properties.call_count)"},{"line_number":11969,"context_line":"        self.assertEqual("},{"line_number":11970,"context_line":"            rccg_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"4ed20a1c_d01eff9d","line":11967,"range":{"start_line":11967,"start_character":8,"end_line":11967,"end_character":54},"updated":"2021-08-24 17:26:07.000000000","message":"Same as above comment.","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"aa743d9e6d7cd05ebb14c367a64bdcdc00d328e3","unresolved":false,"context_lines":[{"line_number":11964,"context_line":"        (model_update, add_volumes_update,"},{"line_number":11965,"context_line":"         remove_volumes_update) \u003d self.driver.update_group("},{"line_number":11966,"context_line":"            self.ctxt, group, add_vols, [])"},{"line_number":11967,"context_line":"        self.assertTrue(update_rccg_properties.called)"},{"line_number":11968,"context_line":"        self.assertEqual(3, update_rccg_properties.call_count)"},{"line_number":11969,"context_line":"        self.assertEqual("},{"line_number":11970,"context_line":"            rccg_name,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ae93c01e_c3af0171","line":11967,"range":{"start_line":11967,"start_character":8,"end_line":11967,"end_character":54},"in_reply_to":"4ed20a1c_d01eff9d","updated":"2021-08-25 08:54:42.000000000","message":"Done","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1c0c0fa4a1233bf2d6395f0dfb039337ecfe251b","unresolved":true,"context_lines":[{"line_number":11983,"context_line":"        (model_update, add_volumes_update,"},{"line_number":11984,"context_line":"         remove_volumes_update) \u003d self.driver.update_group("},{"line_number":11985,"context_line":"            self.ctxt, group, add_volumes\u003dadd_vols, remove_volumes\u003drmv_vols)"},{"line_number":11986,"context_line":"        self.assertTrue(update_rccg_properties.called)"},{"line_number":11987,"context_line":"        self.assertEqual(7, update_rccg_properties.call_count)"},{"line_number":11988,"context_line":"        self.assertIsNone(self.driver._helpers.get_rccg_info(mm_vol1.name))"},{"line_number":11989,"context_line":"        self.assertIsNone(self.driver._helpers.get_rccg_info(mm_vol2.name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"70458c85_6e861e46","line":11986,"range":{"start_line":11986,"start_character":8,"end_line":11986,"end_character":54},"updated":"2021-08-24 17:26:07.000000000","message":"Same as above comment.","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"aa743d9e6d7cd05ebb14c367a64bdcdc00d328e3","unresolved":false,"context_lines":[{"line_number":11983,"context_line":"        (model_update, add_volumes_update,"},{"line_number":11984,"context_line":"         remove_volumes_update) \u003d self.driver.update_group("},{"line_number":11985,"context_line":"            self.ctxt, group, add_volumes\u003dadd_vols, remove_volumes\u003drmv_vols)"},{"line_number":11986,"context_line":"        self.assertTrue(update_rccg_properties.called)"},{"line_number":11987,"context_line":"        self.assertEqual(7, update_rccg_properties.call_count)"},{"line_number":11988,"context_line":"        self.assertIsNone(self.driver._helpers.get_rccg_info(mm_vol1.name))"},{"line_number":11989,"context_line":"        self.assertIsNone(self.driver._helpers.get_rccg_info(mm_vol2.name))"}],"source_content_type":"text/x-python","patch_set":4,"id":"dddd7938_f9f72485","line":11986,"range":{"start_line":11986,"start_character":8,"end_line":11986,"end_character":54},"in_reply_to":"70458c85_6e861e46","updated":"2021-08-25 08:54:42.000000000","message":"Done","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"142bca4d9226c89d041c156acb353e93ce787419","unresolved":true,"context_lines":[{"line_number":3398,"context_line":"            \u0027Consistency Group Name\u0027: \u0027consistency_group_name\u0027}"},{"line_number":3399,"context_line":""},{"line_number":3400,"context_line":"        try:"},{"line_number":3401,"context_line":"            rel_info \u003d self._helpers.get_relationship_info(volume.name)"},{"line_number":3402,"context_line":"        except Exception as ex:"},{"line_number":3403,"context_line":"            LOG.error(\u0027_update_rccg_properties: Failed to fetch relationship \u0027"},{"line_number":3404,"context_line":"                      \u0027details for the volume %(volume)s. Exception: %(err)s.\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"4bff1c9a_e20eb85e","line":3401,"updated":"2021-05-04 04:29:36.000000000","message":"During remove volumes from a group, as we just clear the rccg id and name from the volume metadata. Do we need this svc call?","commit_id":"3ae5690d223874b39ea0151e628643d4a4ab07e7"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1c0c0fa4a1233bf2d6395f0dfb039337ecfe251b","unresolved":true,"context_lines":[{"line_number":3449,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3450,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3451,"context_line":""},{"line_number":3452,"context_line":"        if group:"},{"line_number":3453,"context_line":"            model_update[\u0027metadata\u0027][\u0027consistency_group_name\u0027] \u003d ("},{"line_number":3454,"context_line":"                self._get_rccg_name(group))"},{"line_number":3455,"context_line":"        else:"},{"line_number":3456,"context_line":"            model_update[\u0027metadata\u0027][\u0027consistency_group_name\u0027] \u003d \"\""},{"line_number":3457,"context_line":""},{"line_number":3458,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3459,"context_line":"        self.db.volume_metadata_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"e4ed0b8f_e307cac3","line":3456,"range":{"start_line":3452,"start_character":8,"end_line":3456,"end_character":67},"updated":"2021-08-24 17:26:07.000000000","message":"above lines can be replaced with below code\nrccg \u003d \"\"\nif group:\n    rccg \u003d self._get_rccg_name(group)\n\nmodel_update[\u0027metadata\u0027][\u0027consistency_group_name\u0027] \u003d rccg","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"aa743d9e6d7cd05ebb14c367a64bdcdc00d328e3","unresolved":false,"context_lines":[{"line_number":3449,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3450,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3451,"context_line":""},{"line_number":3452,"context_line":"        if group:"},{"line_number":3453,"context_line":"            model_update[\u0027metadata\u0027][\u0027consistency_group_name\u0027] \u003d ("},{"line_number":3454,"context_line":"                self._get_rccg_name(group))"},{"line_number":3455,"context_line":"        else:"},{"line_number":3456,"context_line":"            model_update[\u0027metadata\u0027][\u0027consistency_group_name\u0027] \u003d \"\""},{"line_number":3457,"context_line":""},{"line_number":3458,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3459,"context_line":"        self.db.volume_metadata_update("}],"source_content_type":"text/x-python","patch_set":4,"id":"4652f8be_4ca276e1","line":3456,"range":{"start_line":3452,"start_character":8,"end_line":3456,"end_character":67},"in_reply_to":"e4ed0b8f_e307cac3","updated":"2021-08-25 08:54:42.000000000","message":"Updated.","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"c878fe3fab75337a9f81ef8fd95623b9ef17e3a4","unresolved":true,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"b2151efe_917df2db","line":3499,"updated":"2021-09-01 05:57:10.000000000","message":"You already updated your tests to mock _update_rccg_properties but I believe this function also requires dedicated unit tests.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"a9cc76a9fe1632d483df74aba3cd47c4feb9c8ed","unresolved":false,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"f99dc56a_b27a7f6d","line":3499,"in_reply_to":"4e37243e_9eb56091","updated":"2021-09-02 14:32:54.000000000","message":"Through UT, we intend to check whether the function is being called or not and validating what exactly the function updates.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"02a1e89e46322bba9e7d70f3521e1ab43766a8ba","unresolved":false,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"4e37243e_9eb56091","line":3499,"in_reply_to":"a2f1abfa_a9df252a","updated":"2021-09-02 14:27:50.000000000","message":"Hi VenkataKrishna, In my opinion testing functions indirectly makes a bit more difficult to understand and to validate exactly what is being tested. I\u0027ve run cover and it shows no issues tho.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"15252d0960a145db56a3ddc472daeeb644731a3e","unresolved":false,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"a2f1abfa_a9df252a","line":3499,"in_reply_to":"b2151efe_917df2db","updated":"2021-09-01 11:29:13.000000000","message":"Instead of going with separate dedicated unit tests, I have updated the same UT to check the major functionality of \u0027_update_rccg_properties\u0027. I hope that this change is addressed in your comment.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"1f0568df1532b8cc25e930995b978d64fbdd8d10","unresolved":false,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":6,"id":"87dbac5b_77a783d8","line":3499,"in_reply_to":"f99dc56a_b27a7f6d","updated":"2021-09-02 14:37:31.000000000","message":"Thanks for the comments. It would be great if you suggest something to make this easier and simple to understand and validate.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"c878fe3fab75337a9f81ef8fd95623b9ef17e3a4","unresolved":true,"context_lines":[{"line_number":3505,"context_line":"        model_update[\u0027metadata\u0027][\u0027Consistency Group Name\u0027] \u003d rccg"},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3508,"context_line":"        self.db.volume_metadata_update("},{"line_number":3509,"context_line":"            ctxt, volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":"    def create_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":6,"id":"4844cc4c_6ddcbb97","line":3508,"updated":"2021-09-01 05:57:10.000000000","message":"Hi @Venkata krishna Thumu, looks like you are adding a db update directly in our driver what looks a bit weird to me, since I\u0027ve never seen something similar in any other driver. I\u0027ve made a quick search and looks like IBM Storwize is the only driver that currently does that. I\u0027m not saying this is wrong, but would be nice if you could provide more details on why this is necessary and if some core could validate it. I wonder if the correct approach for that would be to return the volume updates from driver\u0027s update_group() and let the manager\u0027s code do the db update.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"97f040ec51af37477fdc67074c35e65ed6de2acb","unresolved":true,"context_lines":[{"line_number":3505,"context_line":"        model_update[\u0027metadata\u0027][\u0027Consistency Group Name\u0027] \u003d rccg"},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3508,"context_line":"        self.db.volume_metadata_update("},{"line_number":3509,"context_line":"            ctxt, volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":"    def create_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":6,"id":"aaed4a44_239151ae","line":3508,"in_reply_to":"4844cc4c_6ddcbb97","updated":"2021-09-01 06:13:43.000000000","message":"I searched again and found a few drivers saving changes to volume and snapshot db objects, so maybe this is actually allowed and I just understood it wrong. Anyway it would be nice to rear other\u0027s opinions.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"15252d0960a145db56a3ddc472daeeb644731a3e","unresolved":false,"context_lines":[{"line_number":3505,"context_line":"        model_update[\u0027metadata\u0027][\u0027Consistency Group Name\u0027] \u003d rccg"},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3508,"context_line":"        self.db.volume_metadata_update("},{"line_number":3509,"context_line":"            ctxt, volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":"    def create_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":6,"id":"b2cb7df3_5501240b","line":3508,"in_reply_to":"aaed4a44_239151ae","updated":"2021-09-01 11:29:13.000000000","message":"Here are some reasons why we are adding db update for the RCCG property to metadata in the driver itself. \n1. To handle some scenarios like add more than one volume to a group and operation is failed(for 2nd volume) after a successful first volume turn. In the conventional approach, the database is not updated for the former volume and feeling like not added to the group but actually, it is added.\n2. To continue conventionally (Update metadata and return it), need to fetch the existing volume-metadata from the database, update and return to the volume manager, that would take more effort and calls and this is something that must be updated on top of the existing volume-metadata as it is updated for volume at the time of creation.","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"02a1e89e46322bba9e7d70f3521e1ab43766a8ba","unresolved":false,"context_lines":[{"line_number":3505,"context_line":"        model_update[\u0027metadata\u0027][\u0027Consistency Group Name\u0027] \u003d rccg"},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3508,"context_line":"        self.db.volume_metadata_update("},{"line_number":3509,"context_line":"            ctxt, volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":"    def create_volume(self, volume):"}],"source_content_type":"text/x-python","patch_set":6,"id":"d98f5a71_aab2c7dd","line":3508,"in_reply_to":"b2cb7df3_5501240b","updated":"2021-09-02 14:27:50.000000000","message":"ok thanks for the explanation. 😊","commit_id":"f5b884f514fafcfe6bd3609cad5b63ae73a31219"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e927415cc3f4e0f5b0e31eeb59e06627d52befcc","unresolved":true,"context_lines":[{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3503,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3504,"context_line":"        rccg \u003d self._get_rccg_name(group) if group else \"\""},{"line_number":3505,"context_line":"        model_update[\u0027metadata\u0027][\u0027Consistency Group Name\u0027] \u003d rccg"},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3508,"context_line":"        self.db.volume_metadata_update("},{"line_number":3509,"context_line":"            ctxt, volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":"    def create_volume(self, volume):"},{"line_number":3512,"context_line":"        LOG.debug(\u0027enter: create_volume: volume %s\u0027, volume[\u0027name\u0027])"},{"line_number":3513,"context_line":"        # Create a replication or hyperswap volume with group_id is not"}],"source_content_type":"text/x-python","patch_set":7,"id":"45b18695_41a223b0","line":3510,"range":{"start_line":3500,"start_character":8,"end_line":3510,"end_character":0},"updated":"2021-09-02 10:11:43.000000000","message":"I think we should avoid these database calls and use volume OVO instead\n\n    rccg \u003d self._get_rccg_name(group) if group else \"\"\n    if not volume.metadata:\n        volume.metadata \u003d dict()\n    volume.metadata[\u0027Consistency Group Name\u0027] \u003d rccg\n    volume.save()","commit_id":"fa51222af631ef1663ee988e024cf14554471a5e"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"d16bef33b6c44879d962bb88a66cec656adc596d","unresolved":false,"context_lines":[{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3503,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3504,"context_line":"        rccg \u003d self._get_rccg_name(group) if group else \"\""},{"line_number":3505,"context_line":"        model_update[\u0027metadata\u0027][\u0027Consistency Group Name\u0027] \u003d rccg"},{"line_number":3506,"context_line":""},{"line_number":3507,"context_line":"        # Update the Volume Metadata in the DB"},{"line_number":3508,"context_line":"        self.db.volume_metadata_update("},{"line_number":3509,"context_line":"            ctxt, volume[\u0027id\u0027], model_update[\u0027metadata\u0027], False)"},{"line_number":3510,"context_line":""},{"line_number":3511,"context_line":"    def create_volume(self, volume):"},{"line_number":3512,"context_line":"        LOG.debug(\u0027enter: create_volume: volume %s\u0027, volume[\u0027name\u0027])"},{"line_number":3513,"context_line":"        # Create a replication or hyperswap volume with group_id is not"}],"source_content_type":"text/x-python","patch_set":7,"id":"0dde615f_7211d3fd","line":3510,"range":{"start_line":3500,"start_character":8,"end_line":3510,"end_character":0},"in_reply_to":"45b18695_41a223b0","updated":"2021-09-02 12:30:27.000000000","message":"Done","commit_id":"fa51222af631ef1663ee988e024cf14554471a5e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"286d2ae2f30e22f821f04c0bdf4a01b3057fb290","unresolved":true,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"53149a24_1042d357","line":3499,"range":{"start_line":3499,"start_character":8,"end_line":3499,"end_character":31},"updated":"2021-09-02 14:48:07.000000000","message":"I see this method being mocked in all UTs, we should have a unit test covering this method as well","commit_id":"9f3ae2a343eda8d5c91543a7e35fd3cefc8878d2"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"1f653f93289b1d1669e0e9cf32e1a68bfd11372d","unresolved":true,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"554b357a_7f507805","line":3499,"range":{"start_line":3499,"start_character":8,"end_line":3499,"end_character":31},"in_reply_to":"53149a24_1042d357","updated":"2021-09-02 15:16:02.000000000","message":"hey Rajat I\u0027ve added a comment about it as well. VenkataKrishna is currently testing this function indirectly and tho coverage shows no issues, I believe it makes more difficult for us to understand and to validate exactly what is being tested. I will keep a -1 just for now so we can reach consensus on this.","commit_id":"9f3ae2a343eda8d5c91543a7e35fd3cefc8878d2"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"fa32a18d0bfa4e02c34f60a81f4706a76ce5b577","unresolved":false,"context_lines":[{"line_number":3496,"context_line":"                model_update[\u0027metadata\u0027][key] \u003d rel_info.get(value)"},{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":8,"id":"73c71348_de248a5c","line":3499,"range":{"start_line":3499,"start_character":8,"end_line":3499,"end_character":31},"in_reply_to":"554b357a_7f507805","updated":"2021-09-03 12:13:06.000000000","message":"Hey Fernando, Thanks for the review. Now, I have added a dedicated unit test to validate the method. Please have a look, in your free time.","commit_id":"9f3ae2a343eda8d5c91543a7e35fd3cefc8878d2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"286d2ae2f30e22f821f04c0bdf4a01b3057fb290","unresolved":true,"context_lines":[{"line_number":3497,"context_line":"        return model_update"},{"line_number":3498,"context_line":""},{"line_number":3499,"context_line":"    def _update_rccg_properties(self, ctxt, volume, group\u003dNone):"},{"line_number":3500,"context_line":"        model_update \u003d dict()"},{"line_number":3501,"context_line":"        db_metadata \u003d self.db.volume_metadata_get(ctxt.elevated(),"},{"line_number":3502,"context_line":"                                                  volume[\u0027id\u0027])"},{"line_number":3503,"context_line":"        model_update[\u0027metadata\u0027] \u003d db_metadata if db_metadata else dict()"},{"line_number":3504,"context_line":"        rccg \u003d self._get_rccg_name(group) if group else \"\""},{"line_number":3505,"context_line":"        if not volume.metadata:"},{"line_number":3506,"context_line":"            volume.metadata \u003d dict()"}],"source_content_type":"text/x-python","patch_set":8,"id":"f603fdde_f0914eba","line":3503,"range":{"start_line":3500,"start_character":0,"end_line":3503,"end_character":73},"updated":"2021-09-02 14:48:07.000000000","message":"we don\u0027t need this code anymore, this already exists in volume.metadata\nAlso i assume we are testing this code somewhere in CI or done manually","commit_id":"9f3ae2a343eda8d5c91543a7e35fd3cefc8878d2"}],"releasenotes/notes/bug-1926491-ibm-svf-update-rccg-info-for-mirror-volumes-67fbec05d803745d.yaml":[{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"1c0c0fa4a1233bf2d6395f0dfb039337ecfe251b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver"},{"line_number":5,"context_line":"    `Bug #1926491 \u003chttps://bugs.launchpad.net/cinder/+bug/1926491\u003e`_:"},{"line_number":6,"context_line":"    Updating volume metadata with rccg properties for the volumes with"},{"line_number":7,"context_line":"    replication enabled and added to a consistency group."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"d060f750_a06489c7","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":56},"updated":"2021-08-24 17:26:07.000000000","message":"rccg properties are updated during remove volume from consistency group, I think that information also should be updated in release notes.","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"aa743d9e6d7cd05ebb14c367a64bdcdc00d328e3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    IBM Spectrum Virtualize Family driver"},{"line_number":5,"context_line":"    `Bug #1926491 \u003chttps://bugs.launchpad.net/cinder/+bug/1926491\u003e`_:"},{"line_number":6,"context_line":"    Updating volume metadata with rccg properties for the volumes with"},{"line_number":7,"context_line":"    replication enabled and added to a consistency group."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5bddb4b9_deaeb87c","line":7,"range":{"start_line":7,"start_character":28,"end_line":7,"end_character":56},"in_reply_to":"d060f750_a06489c7","updated":"2021-08-25 08:54:42.000000000","message":"Updated.","commit_id":"e48764e495a733982f6cf9d2abb441289014f998"}]}