)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ee5ade732b0d964bea7382394fa10ae4f301d45a","unresolved":true,"context_lines":[{"line_number":13,"context_line":"controller node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"However currently this backend_host parameter is defined for each"},{"line_number":16,"context_line":"indivisual backend. Thus users need to define the same backend_host"},{"line_number":17,"context_line":"parameter in multiple sections if their deployment have multiple"},{"line_number":18,"context_line":"voume backend. This requirement is very redundant."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4a6cf7a5_965f1e59","line":16,"updated":"2021-05-21 14:18:07.000000000","message":"individual","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"68ac8ceec27614f7f981686039ac1eeea37c329e","unresolved":false,"context_lines":[{"line_number":13,"context_line":"controller node."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"However currently this backend_host parameter is defined for each"},{"line_number":16,"context_line":"indivisual backend. Thus users need to define the same backend_host"},{"line_number":17,"context_line":"parameter in multiple sections if their deployment have multiple"},{"line_number":18,"context_line":"voume backend. This requirement is very redundant."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"82071818_6671ae24","line":16,"in_reply_to":"4a6cf7a5_965f1e59","updated":"2021-05-24 11:53:23.000000000","message":"Done","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ee5ade732b0d964bea7382394fa10ae4f301d45a","unresolved":true,"context_lines":[{"line_number":15,"context_line":"However currently this backend_host parameter is defined for each"},{"line_number":16,"context_line":"indivisual backend. Thus users need to define the same backend_host"},{"line_number":17,"context_line":"parameter in multiple sections if their deployment have multiple"},{"line_number":18,"context_line":"voume backend. This requirement is very redundant."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change adds the backend_host parameter to the backend_defaults"},{"line_number":21,"context_line":"section, so that users can use this single parameter to define a common"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"090d8827_1b0b1252","line":18,"updated":"2021-05-21 14:18:07.000000000","message":"volume","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"68ac8ceec27614f7f981686039ac1eeea37c329e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"However currently this backend_host parameter is defined for each"},{"line_number":16,"context_line":"indivisual backend. Thus users need to define the same backend_host"},{"line_number":17,"context_line":"parameter in multiple sections if their deployment have multiple"},{"line_number":18,"context_line":"voume backend. This requirement is very redundant."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"This change adds the backend_host parameter to the backend_defaults"},{"line_number":21,"context_line":"section, so that users can use this single parameter to define a common"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5b9d1b66_92d0a857","line":18,"in_reply_to":"090d8827_1b0b1252","updated":"2021-05-24 11:53:23.000000000","message":"Done","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33609,"name":"XuQi","display_name":"Inori","email":"xuq.fnstxz@fujitsu.com","username":"inori"},"change_message_id":"b8ba36a888f8dfb208b1b9bab6da29dd25da9d07","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"1dc37a9a_d6da98c6","updated":"2025-01-22 02:24:09.000000000","message":"run-Fujitsu ETERNUS CI","commit_id":"849e04de5e06e28404379d0bb5a0f0c0cc784c11"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd7b1648bb8112adf6fd9ffcd550528fe4cc8df5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"5557d01a_22f117dd","updated":"2025-09-15 20:56:28.000000000","message":"I\u0027m concerned about the release note, but other reviewers may think it\u0027s OK.","commit_id":"d598437e4f1c0eb4ea69316ee9a98135c95eb16e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7dfb433bbdb66c6f280046a6df8de5b0b0949ca8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"5dabf794_f25601f5","updated":"2025-09-16 17:09:21.000000000","message":"Code and unit tests look good, but release note has a typo.","commit_id":"c691ab28cb87d485f4cdf8fe5a234dfacb93ad17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"9bd5ff0b2b0e48b86597baf867f725c8b334e6bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"f3931b2a_e6345b77","updated":"2025-09-16 07:24:55.000000000","message":"One more thing I should have said... thanks for your review, Alan :-)","commit_id":"c691ab28cb87d485f4cdf8fe5a234dfacb93ad17"}],"cinder/cmd/volume.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e29bc05b4d92b947be2f5ff14f4eb418e8c102a2","unresolved":true,"context_lines":[{"line_number":91,"context_line":"def _launch_service(launcher, backend):"},{"line_number":92,"context_line":"    CONF.register_opt(host_opt, group\u003dbackend)"},{"line_number":93,"context_line":"    CONF.register_opt(host_opt, group\u003dSHARED_CONF_GROUP)"},{"line_number":94,"context_line":"    backend_host \u003d (getattr(CONF, SHARED_CONF_GROUP).backend_host or"},{"line_number":95,"context_line":"                    getattr(CONF, backend).backend_host or"},{"line_number":96,"context_line":"                    CONF.host)"},{"line_number":97,"context_line":"    host \u003d \"%s@%s\" % (backend_host, backend)"}],"source_content_type":"text/x-python","patch_set":4,"id":"81c8923e_71841a12","line":94,"updated":"2021-05-24 16:01:30.000000000","message":"The order of precedence doesn\u0027t look right. I think it should be:\n\n1. getattr(CONF, backend).backend_host\n2. getattr(CONF, SHARED_CONF_GROUP).backend_host\n3. CONF.host\n\nThat way a backend that specifically declares its own backend_host will override the value in backend_defaults.","commit_id":"79727c18a5063e3ea787ec0c090519f589e9262e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6fcef54911f422531189ef676f04089519815578","unresolved":false,"context_lines":[{"line_number":91,"context_line":"def _launch_service(launcher, backend):"},{"line_number":92,"context_line":"    CONF.register_opt(host_opt, group\u003dbackend)"},{"line_number":93,"context_line":"    CONF.register_opt(host_opt, group\u003dSHARED_CONF_GROUP)"},{"line_number":94,"context_line":"    backend_host \u003d (getattr(CONF, SHARED_CONF_GROUP).backend_host or"},{"line_number":95,"context_line":"                    getattr(CONF, backend).backend_host or"},{"line_number":96,"context_line":"                    CONF.host)"},{"line_number":97,"context_line":"    host \u003d \"%s@%s\" % (backend_host, backend)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c763cc6d_d19ae73c","line":94,"in_reply_to":"81c8923e_71841a12","updated":"2021-05-25 06:13:22.000000000","message":"You are absolutely correct . Thanks for the catch !","commit_id":"79727c18a5063e3ea787ec0c090519f589e9262e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"e29bc05b4d92b947be2f5ff14f4eb418e8c102a2","unresolved":true,"context_lines":[{"line_number":93,"context_line":"    CONF.register_opt(host_opt, group\u003dSHARED_CONF_GROUP)"},{"line_number":94,"context_line":"    backend_host \u003d (getattr(CONF, SHARED_CONF_GROUP).backend_host or"},{"line_number":95,"context_line":"                    getattr(CONF, backend).backend_host or"},{"line_number":96,"context_line":"                    CONF.host)"},{"line_number":97,"context_line":"    host \u003d \"%s@%s\" % (backend_host, backend)"},{"line_number":98,"context_line":"    # We also want to set cluster to None on empty strings, and we"},{"line_number":99,"context_line":"    # ignore leading and trailing spaces."}],"source_content_type":"text/x-python","patch_set":4,"id":"f32de01c_1e1068ee","line":96,"updated":"2021-05-24 16:01:30.000000000","message":"I prefer the original L93 (backend_host or CONF.host, backend) because it reinforces the notion that backend_host and CONF.host are conceptually different.\n\nPutting it all together:\n\n    backend_host \u003d (getattr(CONF, backend).backend_host or\n                    getattr(CONF, SHARED_CONF_GROUP).backend_host)\n    host \u003d \"%s@%s\" % (backend_host or CONF.host, backend)","commit_id":"79727c18a5063e3ea787ec0c090519f589e9262e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"6fcef54911f422531189ef676f04089519815578","unresolved":false,"context_lines":[{"line_number":93,"context_line":"    CONF.register_opt(host_opt, group\u003dSHARED_CONF_GROUP)"},{"line_number":94,"context_line":"    backend_host \u003d (getattr(CONF, SHARED_CONF_GROUP).backend_host or"},{"line_number":95,"context_line":"                    getattr(CONF, backend).backend_host or"},{"line_number":96,"context_line":"                    CONF.host)"},{"line_number":97,"context_line":"    host \u003d \"%s@%s\" % (backend_host, backend)"},{"line_number":98,"context_line":"    # We also want to set cluster to None on empty strings, and we"},{"line_number":99,"context_line":"    # ignore leading and trailing spaces."}],"source_content_type":"text/x-python","patch_set":4,"id":"3e16b9e1_ece10984","line":96,"in_reply_to":"f32de01c_1e1068ee","updated":"2021-05-25 06:13:22.000000000","message":"That makes sense. Thanks for the suggestion.","commit_id":"79727c18a5063e3ea787ec0c090519f589e9262e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd7b1648bb8112adf6fd9ffcd550528fe4cc8df5","unresolved":true,"context_lines":[{"line_number":102,"context_line":"def _launch_service(launcher: \u0027oslo_service.ProcessLauncher\u0027,"},{"line_number":103,"context_line":"                    backend: str) -\u003e None:"},{"line_number":104,"context_line":"    _register_opts(backend)"},{"line_number":105,"context_line":"    backend_host \u003d (getattr(CONF, backend).backend_host or"},{"line_number":106,"context_line":"                    getattr(CONF, SHARED_CONF_GROUP).backend_host)"},{"line_number":107,"context_line":"    host \u003d \"%s@%s\" % (backend_host or CONF.host, backend)"},{"line_number":108,"context_line":"    # We also want to set cluster to None on empty strings, and we"}],"source_content_type":"text/x-python","patch_set":18,"id":"7bc70e8a_227a9181","line":105,"updated":"2025-09-15 20:56:28.000000000","message":"I considered recommending the option be moved into the cinder.volume.driver options, but it\u0027s also a CLI option (L72) so moving it wouldn\u0027t work.","commit_id":"d598437e4f1c0eb4ea69316ee9a98135c95eb16e"}],"cinder/opts.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"126c996c24366c466f702775e088fcdd46429afd","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def list_opts():"},{"line_number":197,"context_line":"    return ["},{"line_number":198,"context_line":"        (\u0027backend\u0027,"},{"line_number":199,"context_line":"            itertools.chain("},{"line_number":200,"context_line":"                [cinder_cmd_volume.host_opt],"},{"line_number":201,"context_line":"            )),"},{"line_number":202,"context_line":"        (\u0027brcd_fabric_example\u0027,"},{"line_number":203,"context_line":"            itertools.chain("},{"line_number":204,"context_line":"                cinder_zonemanager_drivers_brocade_brcdfabricopts."}],"source_content_type":"text/x-python","patch_set":2,"id":"278fdf04_b8ad25fc","line":201,"range":{"start_line":198,"start_character":0,"end_line":201,"end_character":15},"updated":"2021-05-03 15:29:04.000000000","message":"I\u0027ve not yet identified the commit which added this, I have doubt about this definition.\nIf I understand the current implementation correctly, there is no implementation to pick parameters from the `backend` section.","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7b601215062f8aab51591e4e204f8ee46a499a95","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def list_opts():"},{"line_number":197,"context_line":"    return ["},{"line_number":198,"context_line":"        (\u0027backend\u0027,"},{"line_number":199,"context_line":"            itertools.chain("},{"line_number":200,"context_line":"                [cinder_cmd_volume.host_opt],"},{"line_number":201,"context_line":"            )),"},{"line_number":202,"context_line":"        (\u0027brcd_fabric_example\u0027,"},{"line_number":203,"context_line":"            itertools.chain("},{"line_number":204,"context_line":"                cinder_zonemanager_drivers_brocade_brcdfabricopts."}],"source_content_type":"text/x-python","patch_set":2,"id":"dec6906f_4058b729","line":201,"range":{"start_line":198,"start_character":0,"end_line":201,"end_character":15},"in_reply_to":"195951eb_bc80c882","updated":"2024-04-25 12:30:22.000000000","message":"Hmm I attempted to remove this but this is added back by the generate script for unknwon reason...","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"dd8e57937f9999b70473f6ae2e89f98af8900842","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def list_opts():"},{"line_number":197,"context_line":"    return ["},{"line_number":198,"context_line":"        (\u0027backend\u0027,"},{"line_number":199,"context_line":"            itertools.chain("},{"line_number":200,"context_line":"                [cinder_cmd_volume.host_opt],"},{"line_number":201,"context_line":"            )),"},{"line_number":202,"context_line":"        (\u0027brcd_fabric_example\u0027,"},{"line_number":203,"context_line":"            itertools.chain("},{"line_number":204,"context_line":"                cinder_zonemanager_drivers_brocade_brcdfabricopts."}],"source_content_type":"text/x-python","patch_set":2,"id":"195951eb_bc80c882","line":201,"range":{"start_line":198,"start_character":0,"end_line":201,"end_character":15},"in_reply_to":"278fdf04_b8ad25fc","updated":"2024-04-25 08:22:03.000000000","message":"Done","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"5394cf56233f3fb98c6b6293e2dd22c9f4e1c699","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def list_opts():"},{"line_number":197,"context_line":"    return ["},{"line_number":198,"context_line":"        (\u0027backend\u0027,"},{"line_number":199,"context_line":"            itertools.chain("},{"line_number":200,"context_line":"                [cinder_cmd_volume.host_opt],"},{"line_number":201,"context_line":"            )),"},{"line_number":202,"context_line":"        (\u0027brcd_fabric_example\u0027,"},{"line_number":203,"context_line":"            itertools.chain("},{"line_number":204,"context_line":"                cinder_zonemanager_drivers_brocade_brcdfabricopts."}],"source_content_type":"text/x-python","patch_set":2,"id":"309e164d_12b858b6","line":201,"range":{"start_line":198,"start_character":0,"end_line":201,"end_character":15},"in_reply_to":"c7fdb6e0_9824b09c","updated":"2024-04-26 02:28:25.000000000","message":"That\u0027s a great catch ! Thank you.\n\nI\u0027ve proposed a separate fix for it https://review.opendev.org/c/openstack/cinder/+/917107","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"87c2640365b20638aae7fb022de5ac31c3350516","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"def list_opts():"},{"line_number":197,"context_line":"    return ["},{"line_number":198,"context_line":"        (\u0027backend\u0027,"},{"line_number":199,"context_line":"            itertools.chain("},{"line_number":200,"context_line":"                [cinder_cmd_volume.host_opt],"},{"line_number":201,"context_line":"            )),"},{"line_number":202,"context_line":"        (\u0027brcd_fabric_example\u0027,"},{"line_number":203,"context_line":"            itertools.chain("},{"line_number":204,"context_line":"                cinder_zonemanager_drivers_brocade_brcdfabricopts."}],"source_content_type":"text/x-python","patch_set":2,"id":"c7fdb6e0_9824b09c","line":201,"range":{"start_line":198,"start_character":0,"end_line":201,"end_character":15},"in_reply_to":"dec6906f_4058b729","updated":"2024-04-25 15:54:25.000000000","message":"I\u0027m pretty sure it happens when [1] finds [2].\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/tools/config/generate_cinder_opts.py#L205\n[2] https://opendev.org/openstack/cinder/src/branch/master/cinder/cmd/volume.py#L97\n\nThe config generator thinks it\u0027s found a group named \u0027backend\u0027 when in fact that\u0027s a variable name. The problem can probably be avoided by adding code in generate_cinder_opts.py near L225:\n\n                    if (group_name \u003d\u003d \u0027backend\u0027):\n                        # Skip \u0027backend\u0027 because it\u0027s a variable containing an\n                        # actual backend name.\n                        continue\n\nThat could be done in a follow up patch.","commit_id":"ee067c0cb49d5906f77082cc1be5a59827e7e1f0"}],"cinder/tests/unit/test_cmd.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd7b1648bb8112adf6fd9ffcd550528fe4cc8df5","unresolved":true,"context_lines":[{"line_number":247,"context_line":"        # backend_host parameter should be registered here for overrides"},{"line_number":248,"context_line":"        for backend in backends:"},{"line_number":249,"context_line":"            cinder_volume._register_opts(backend)"},{"line_number":250,"context_line":"        CONF.set_override(\u0027backend_host\u0027, \u0027host2\u0027, \u0027backend_defaults\u0027)"},{"line_number":251,"context_line":"        CONF.set_override(\u0027backend_host\u0027, \u0027host3\u0027, \u0027backend1\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        launcher \u003d get_launcher.return_value"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        cinder_volume.main()"}],"source_content_type":"text/x-python","patch_set":18,"id":"a2ebb7e0_0725dd3a","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":1},"updated":"2025-09-15 20:56:28.000000000","message":"I found the mapping between backends numbered 1 and 2 to backend hosts numbered 2 and 3 a little confusing.\n- backend 1 \u003d\u003e backend host 3\n- backend 2 \u003d\u003e backend host 2\n\nnit maybe? But not cause for -1.","commit_id":"d598437e4f1c0eb4ea69316ee9a98135c95eb16e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7e3fc833516a2f95b20adf7d16135fcc98edc601","unresolved":false,"context_lines":[{"line_number":247,"context_line":"        # backend_host parameter should be registered here for overrides"},{"line_number":248,"context_line":"        for backend in backends:"},{"line_number":249,"context_line":"            cinder_volume._register_opts(backend)"},{"line_number":250,"context_line":"        CONF.set_override(\u0027backend_host\u0027, \u0027host2\u0027, \u0027backend_defaults\u0027)"},{"line_number":251,"context_line":"        CONF.set_override(\u0027backend_host\u0027, \u0027host3\u0027, \u0027backend1\u0027)"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        launcher \u003d get_launcher.return_value"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"        cinder_volume.main()"}],"source_content_type":"text/x-python","patch_set":18,"id":"c7fdf440_f1b6d606","line":252,"range":{"start_line":250,"start_character":0,"end_line":252,"end_character":1},"in_reply_to":"a2ebb7e0_0725dd3a","updated":"2025-09-16 07:23:54.000000000","message":"I\u0027ve updated the name used in tests for better clarity. I hope it looks good to you now.","commit_id":"d598437e4f1c0eb4ea69316ee9a98135c95eb16e"}],"releasenotes/notes/default-backend_host-abccc0fd94f62d90.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"bd7b1648bb8112adf6fd9ffcd550528fe4cc8df5","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``[backend_defaults] backend_host`` parameter has been added. This"},{"line_number":5,"context_line":"    parameter can be used to set the common hostname for all cinder-volume"},{"line_number":6,"context_line":"    services representing indivisual backends."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"d79229f3_3d8346a0","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":72},"updated":"2025-09-15 20:56:28.000000000","message":"I don\u0027t like this wording because to me it suggests \u0027backend_host\u0027 is a new parameter. I would prefer it state the [backend_defaults] section now supports the backend_host parameter. The second sentence looks good.","commit_id":"d598437e4f1c0eb4ea69316ee9a98135c95eb16e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7e3fc833516a2f95b20adf7d16135fcc98edc601","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The new ``[backend_defaults] backend_host`` parameter has been added. This"},{"line_number":5,"context_line":"    parameter can be used to set the common hostname for all cinder-volume"},{"line_number":6,"context_line":"    services representing indivisual backends."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"8872255a_fbfa9fdd","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":72},"in_reply_to":"d79229f3_3d8346a0","updated":"2025-09-16 07:23:54.000000000","message":"I agree with your point. Updated this according to the suggestion, with a minor wording adjustment (parameter -\u003e option).","commit_id":"d598437e4f1c0eb4ea69316ee9a98135c95eb16e"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"7dfb433bbdb66c6f280046a6df8de5b0b0949ca8","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[backend_defaults]`` section now supports the ``backend_host``"},{"line_number":5,"context_line":"    option. This option can be used to define the common hostname for all"},{"line_number":6,"context_line":"    cinder-volume services representing indivisual backends."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"5a2b9031_23c30558","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":50},"updated":"2025-09-16 17:09:21.000000000","message":"sorry, I just noticed this typo (I assume you mean \"individual\")\n\nYou could also simplify the sentence, perhaps like this:\n\n\"This option can be used to define a common hostname for all cinder-volume backends.\"","commit_id":"c691ab28cb87d485f4cdf8fe5a234dfacb93ad17"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1c6613c2197f94378d90cb1f7aaf9fca14656f72","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    The ``[backend_defaults]`` section now supports the ``backend_host``"},{"line_number":5,"context_line":"    option. This option can be used to define the common hostname for all"},{"line_number":6,"context_line":"    cinder-volume services representing indivisual backends."}],"source_content_type":"text/x-yaml","patch_set":19,"id":"ea493e39_b79d8f97","line":6,"range":{"start_line":6,"start_character":40,"end_line":6,"end_character":50},"in_reply_to":"5a2b9031_23c30558","updated":"2025-09-16 17:15:26.000000000","message":"Done","commit_id":"c691ab28cb87d485f4cdf8fe5a234dfacb93ad17"}]}