)]}'
{"bin/cinder-volume":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"c405c1ec515baef9f3f1f24988bd08603737be5e","unresolved":false,"context_lines":[{"line_number":58,"context_line":"         version\u003dversion.version_string())"},{"line_number":59,"context_line":"    logging.setup(\"cinder\")"},{"line_number":60,"context_line":"    utils.monkey_patch()"},{"line_number":61,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":62,"context_line":"        launcher \u003d service"},{"line_number":63,"context_line":"        launcher.launch_service \u003d service.serve"},{"line_number":64,"context_line":"    else:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAVn%2F%2FJ%2BY%3D","line":61,"updated":"2014-03-08 01:27:33.000000000","message":"Could you please add some detailed comments here to make sure this doesn\u0027t happen again?\n\nWe were all under the impression that Windows behavior on the monkey patch would be sufficient, so we should probably have a warning here for the future.\n\nAlso, would be wise to have some sort of unit test that also has some notes in it.  That way somebody would have to ignore TWO  warning to break this again in the future and it\u0027s more likely that reviewers will pay closer attention.","commit_id":"9edf159f48380d2d398b3057294349f9565ed895"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"a8d91138881518344d4414170bdc0de1f7ca6c98","unresolved":false,"context_lines":[{"line_number":58,"context_line":"         version\u003dversion.version_string())"},{"line_number":59,"context_line":"    logging.setup(\"cinder\")"},{"line_number":60,"context_line":"    utils.monkey_patch()"},{"line_number":61,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":62,"context_line":"        launcher \u003d service"},{"line_number":63,"context_line":"        launcher.launch_service \u003d service.serve"},{"line_number":64,"context_line":"    else:"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"AAAAVn%2F%2FIvQ%3D","line":61,"in_reply_to":"AAAAVn%2F%2FJ%2BY%3D","updated":"2014-03-08 11:43:19.000000000","message":"Indeed, preventing eventlet from monkey patching the OS module will keep subprocess.Popen from failing. Unfortunately,\nas ProcessLauncher tries to use \"green pipes\", this will fail on Windows because of the missing support for non-blocking I/O pipes.\n\nOne simple workaround is using ServiceLauncher, this way avoiding the above situation.","commit_id":"9edf159f48380d2d398b3057294349f9565ed895"}],"cinder/tests/test_service.py":[{"author":{"_account_id":2243,"name":"John Griffith","email":"john.griffith8@gmail.com","username":"john-griffith"},"change_message_id":"9f5e9b23bae7563d4dd6cdb7f0d454ccb6e72a6d","unresolved":false,"context_lines":[{"line_number":236,"context_line":"                                     fake_process_launcher())"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_process_launcher_on_windows(self):"},{"line_number":239,"context_line":"        self._test_service_launcher(\u0027nt\u0027)"},{"line_number":240,"context_line":""},{"line_number":241,"context_line":"    def test_process_launcher_on_linux(self):"},{"line_number":242,"context_line":"        self._test_service_launcher(\u0027posix\u0027)"}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAWH%2F%2F5Us%3D","line":239,"updated":"2014-03-13 04:05:03.000000000","message":"I would have rather seen the actual assert check in the corresponding test here.  Having these call the helper and having the assert check there isn\u0027t the easiest to follow and deal with going forward.\n\nAnyway, thanks for addressing this I don\u0027t think it\u0027s worth holding this any longer for a known issue that needs fixed.","commit_id":"7171984aab11cb28af92435bfea264d7faf643fd"}]}