)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c5eb79801c833cefd5a26680c1e9d7d30e7a76ee","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Fix Ceph Backup Driver Python3 Encoding Issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using python3 the Ceph backup driver faces encoding issues."},{"line_number":10,"context_line":"In order to solve this we should start using bitarray for"},{"line_number":11,"context_line":"creating a zero-filled instance with a given length."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1925809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3070e2ed_73f46bf0","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":53},"updated":"2021-05-17 17:34:46.000000000","message":"typo: bytearray","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"},{"author":{"_account_id":36978,"name":"Wu","display_name":"Berlin","email":"1652124020@qq.com","username":"Ber1in.Wu"},"change_message_id":"c485435bb5002814154b6112fa90145ec89ef200","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix Ceph Backup Driver Python3 Encoding Issue"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Using python3 the Ceph backup driver faces encoding issues."},{"line_number":10,"context_line":"In order to solve this we should start using bitarray for"},{"line_number":11,"context_line":"creating a zero-filled instance with a given length."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1925809"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6e5fb723_e3a27a5c","line":10,"range":{"start_line":10,"start_character":45,"end_line":10,"end_character":53},"in_reply_to":"3070e2ed_73f46bf0","updated":"2024-05-21 03:20:09.000000000","message":"Done","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"}],"cinder/backup/drivers/ceph.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5614dad9f643fa60901f56186c82835b564846b","unresolved":true,"context_lines":[{"line_number":385,"context_line":"                chunks \u003d int(length / self.chunk_size)"},{"line_number":386,"context_line":"                for chunk in range(0, chunks):"},{"line_number":387,"context_line":"                    LOG.debug(\"Writing zeroes chunk %d\", chunk)"},{"line_number":388,"context_line":"                    volume.write(zeroes)"},{"line_number":389,"context_line":"                    volume.flush()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"                rem \u003d int(length % self.chunk_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f0eb0a5b_4550805c","line":388,"range":{"start_line":388,"start_character":33,"end_line":388,"end_character":39},"updated":"2021-06-08 05:24:37.000000000","message":"this is bytearray object, should we convert this to str before writing?\nvolume.write(zeroes.decode())","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"},{"author":{"_account_id":36978,"name":"Wu","display_name":"Berlin","email":"1652124020@qq.com","username":"Ber1in.Wu"},"change_message_id":"a2ca440c0e10885d9063c20572480dbc7fcdd2be","unresolved":true,"context_lines":[{"line_number":385,"context_line":"                chunks \u003d int(length / self.chunk_size)"},{"line_number":386,"context_line":"                for chunk in range(0, chunks):"},{"line_number":387,"context_line":"                    LOG.debug(\"Writing zeroes chunk %d\", chunk)"},{"line_number":388,"context_line":"                    volume.write(zeroes)"},{"line_number":389,"context_line":"                    volume.flush()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"                rem \u003d int(length % self.chunk_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f4d0c16f_a49015af","line":388,"range":{"start_line":388,"start_character":33,"end_line":388,"end_character":39},"in_reply_to":"f0eb0a5b_4550805c","updated":"2024-05-20 03:21:08.000000000","message":"No, it is not necessary. The current \u0027\\0\u0027 is str, and volume.write() requires a bytes object in python3.","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"},{"author":{"_account_id":36978,"name":"Wu","display_name":"Berlin","email":"1652124020@qq.com","username":"Ber1in.Wu"},"change_message_id":"c485435bb5002814154b6112fa90145ec89ef200","unresolved":false,"context_lines":[{"line_number":385,"context_line":"                chunks \u003d int(length / self.chunk_size)"},{"line_number":386,"context_line":"                for chunk in range(0, chunks):"},{"line_number":387,"context_line":"                    LOG.debug(\"Writing zeroes chunk %d\", chunk)"},{"line_number":388,"context_line":"                    volume.write(zeroes)"},{"line_number":389,"context_line":"                    volume.flush()"},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"                rem \u003d int(length % self.chunk_size)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6922b961_a7b329f6","line":388,"range":{"start_line":388,"start_character":33,"end_line":388,"end_character":39},"in_reply_to":"f4d0c16f_a49015af","updated":"2024-05-21 03:20:09.000000000","message":"Done","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5614dad9f643fa60901f56186c82835b564846b","unresolved":true,"context_lines":[{"line_number":391,"context_line":"                rem \u003d int(length % self.chunk_size)"},{"line_number":392,"context_line":"                if rem:"},{"line_number":393,"context_line":"                    zeroes \u003d bytearray(rem)"},{"line_number":394,"context_line":"                    volume.write(zeroes)"},{"line_number":395,"context_line":"                    volume.flush()"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _transfer_data(self, src, src_name, dest, dest_name, length):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b88fa1b5_50449a17","line":394,"range":{"start_line":394,"start_character":33,"end_line":394,"end_character":39},"updated":"2021-06-08 05:24:37.000000000","message":"same","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"},{"author":{"_account_id":36978,"name":"Wu","display_name":"Berlin","email":"1652124020@qq.com","username":"Ber1in.Wu"},"change_message_id":"c485435bb5002814154b6112fa90145ec89ef200","unresolved":false,"context_lines":[{"line_number":391,"context_line":"                rem \u003d int(length % self.chunk_size)"},{"line_number":392,"context_line":"                if rem:"},{"line_number":393,"context_line":"                    zeroes \u003d bytearray(rem)"},{"line_number":394,"context_line":"                    volume.write(zeroes)"},{"line_number":395,"context_line":"                    volume.flush()"},{"line_number":396,"context_line":""},{"line_number":397,"context_line":"    def _transfer_data(self, src, src_name, dest, dest_name, length):"}],"source_content_type":"text/x-python","patch_set":1,"id":"37e20bff_09a8e5c8","line":394,"range":{"start_line":394,"start_character":33,"end_line":394,"end_character":39},"in_reply_to":"b88fa1b5_50449a17","updated":"2024-05-21 03:20:09.000000000","message":"Done","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"}],"cinder/tests/unit/backup/drivers/test_backup_ceph.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f5614dad9f643fa60901f56186c82835b564846b","unresolved":true,"context_lines":[{"line_number":987,"context_line":"            self.assertEqual(2, image.flush.call_count)"},{"line_number":988,"context_line":"            self.assertFalse(image.discard.called)"},{"line_number":989,"context_line":"            zeroes \u003d \u0027\\0\u0027 * self.service.chunk_size"},{"line_number":990,"context_line":"            image.write.assert_has_calls([mock.call(zeroes, 0),"},{"line_number":991,"context_line":"                                         mock.call(zeroes, self.chunk_size)])"},{"line_number":992,"context_line":"            self.assertNotEqual(threading.current_thread(),"},{"line_number":993,"context_line":"                                thread_dict[\u0027thread\u0027])"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"9526410b_e0a3a7b3","line":991,"range":{"start_line":990,"start_character":0,"end_line":991,"end_character":77},"updated":"2021-06-08 05:24:37.000000000","message":"This assert expects str to be written and you\u0027re writing bytearray object","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"},{"author":{"_account_id":36978,"name":"Wu","display_name":"Berlin","email":"1652124020@qq.com","username":"Ber1in.Wu"},"change_message_id":"3b3257da5388d778516d84c994cde402b1f9f3cc","unresolved":false,"context_lines":[{"line_number":987,"context_line":"            self.assertEqual(2, image.flush.call_count)"},{"line_number":988,"context_line":"            self.assertFalse(image.discard.called)"},{"line_number":989,"context_line":"            zeroes \u003d \u0027\\0\u0027 * self.service.chunk_size"},{"line_number":990,"context_line":"            image.write.assert_has_calls([mock.call(zeroes, 0),"},{"line_number":991,"context_line":"                                         mock.call(zeroes, self.chunk_size)])"},{"line_number":992,"context_line":"            self.assertNotEqual(threading.current_thread(),"},{"line_number":993,"context_line":"                                thread_dict[\u0027thread\u0027])"},{"line_number":994,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2d48046a_638d7c9f","line":991,"range":{"start_line":990,"start_character":0,"end_line":991,"end_character":77},"in_reply_to":"9526410b_e0a3a7b3","updated":"2024-05-21 04:34:52.000000000","message":"Done","commit_id":"bd2409648c403a9c1ce83cff90d4f5e6fbe74742"}]}