)]}'
{"api-ref/source/v3/volumes-v3-snapshots.inc":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff7d690764db45b76bbaf25bab3434c1d4ca8c5a","unresolved":true,"context_lines":[{"line_number":93,"context_line":"Response Example (v3.41)"},{"line_number":94,"context_line":"------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. literalinclude:: ./samples/snapshots/v3.41/snapshots-list-detailed-response.json"},{"line_number":97,"context_line":"   :language: javascript"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"2bd65a15_c052c812","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":46},"updated":"2021-08-26 10:18:52.000000000","message":"We had a discussion around this before, i don\u0027t exactly remember what was decided but i remember a point regarding the default API version being 3.0 and that is what users will usually see in API response.\nAlthough I don\u0027t have issues keeping it to the latest, it seems slightly misleading since it requires users to pass a microversion (and is not correct by default) but on the other hand users should also know which request/response are available with the latest microversion change.\nJust wanted to get my thoughts on this one since we will follow the same pattern for other APIs as well.","commit_id":"d29f12117e220eda6f2e8a3d4288701c7e98096f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2f18bacb0979a98fa5f53150d05518f91142d201","unresolved":true,"context_lines":[{"line_number":93,"context_line":"Response Example (v3.41)"},{"line_number":94,"context_line":"------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. literalinclude:: ./samples/snapshots/v3.41/snapshots-list-detailed-response.json"},{"line_number":97,"context_line":"   :language: javascript"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"a1a867db_f5e2928b","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":46},"in_reply_to":"2bd65a15_c052c812","updated":"2021-08-26 10:32:32.000000000","message":"I have a different opinion, documentation should show the latest one (iirc is also what you get in the client if you don\u0027t pin a specific microversion).\n\nLike with features, we list them all, even if you need a specific microversion. We are also properly documenting for each parameter when they are being added, so anyone reading the documentation should see the mention of microversion and take the hint that this requires something \"special\".\n\nIf we decide to do it differently we\u0027ll have to update the ones from my previous patch as well [1].\n\nWe could always add both, 3.0 and latest, and clearly label them (after all we have both samples available for the tests):\n\n  Response Example (base microversion 3.0)\n\n  Response Example (latest microversion 3.41)\n\n[1]: https://review.opendev.org/c/openstack/cinder/+/791239/4/api-ref/source/v3/volumes-v3-volumes.inc","commit_id":"d29f12117e220eda6f2e8a3d4288701c7e98096f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"620bf87e94f6bed96543704a4099057b7fb44ff4","unresolved":true,"context_lines":[{"line_number":93,"context_line":"Response Example (v3.41)"},{"line_number":94,"context_line":"------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. literalinclude:: ./samples/snapshots/v3.41/snapshots-list-detailed-response.json"},{"line_number":97,"context_line":"   :language: javascript"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"d3afb51e_c743c274","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":46},"in_reply_to":"a1a867db_f5e2928b","updated":"2021-08-26 10:38:51.000000000","message":"I really like the idea of keeping both, but if the team agree that keeping latest is sufficient then also i don\u0027t have issues.","commit_id":"d29f12117e220eda6f2e8a3d4288701c7e98096f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"48eea7506fab581b5daedee6e6be259f0bf0f0a5","unresolved":true,"context_lines":[{"line_number":93,"context_line":"Response Example (v3.41)"},{"line_number":94,"context_line":"------------------------"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":".. literalinclude:: ./samples/snapshots/v3.41/snapshots-list-detailed-response.json"},{"line_number":97,"context_line":"   :language: javascript"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":5,"id":"444d977f_cba9bc9a","line":96,"range":{"start_line":96,"start_character":39,"end_line":96,"end_character":46},"in_reply_to":"d3afb51e_c743c274","updated":"2021-08-26 10:52:51.000000000","message":"Realizing that this can be done as followup, including base 3.0 response along with current one, no point holding this anymore","commit_id":"d29f12117e220eda6f2e8a3d4288701c7e98096f"}]}