)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e61e724dbe141eed1a59423666e31f81b4c8b89d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"343d9f61_323457f9","updated":"2023-10-18 19:04:05.000000000","message":"needs rebase","commit_id":"8499de34cb963840c0e73522f934293c1a6287c3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"275abc4301ebb1786f0f0cf47c736655ae691273","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"c2d2ac95_6c23034f","in_reply_to":"343d9f61_323457f9","updated":"2023-10-30 07:08:42.000000000","message":"Thanks Eric, almost forgot about this","commit_id":"8499de34cb963840c0e73522f934293c1a6287c3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5bc346b812f3083a8a33805961ed551e5d7b9fad","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"0ea3de90_3fb70443","updated":"2024-05-20 16:58:04.000000000","message":"recheck lvm-lio-barbican job failed on snapshot integrity tests\n\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: Command: \u0027set -eu -o pipefail; PATH\u003d$PATH:/sbin:/usr/sbin; sudo mkfs -t ext4 /dev/vdb\u0027 executed on host \u0027172.24.5.21\u0027.","commit_id":"3782e76289be3c0b2b974428830b1142b4797031"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a2bda93b60b00134e90295f070ee5fc54f7d5fd1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"721ebe69_b7f84ea8","updated":"2024-06-24 05:09:21.000000000","message":"recheck for fresh logs","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e88c72e4cb4e593d6b333fa463cf6adf39f0360b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"985b00a0_7d766a1d","updated":"2024-05-21 05:15:24.000000000","message":"recheck lvm-lio-barbican job failed on incremental backup test\n\ntempest.lib.exceptions.TimeoutException: Request timed out\nDetails: None","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"16769935bd4637efa8699df61f5843707315ea17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"d375f850_f1932b45","updated":"2024-05-22 06:25:19.000000000","message":"recheck tempest slow py3 failed with live migration connectivity test\n\nTraceback (most recent call last):\n  File \"/opt/stack/tempest/tempest/common/utils/__init__.py\", line 70, in wrapper\n    return f(*func_args, **func_kwargs)\n  File \"/opt/stack/tempest/tempest/scenario/test_network_advanced_server_ops.py\", line 461, in test_server_connectivity_live_migration\n    self._test_server_connectivity_live_migration(\n  File \"/opt/stack/tempest/tempest/scenario/test_network_advanced_server_ops.py\", line 228, in _test_server_connectivity_live_migration\n    self.assertLessEqual(\n  File \"/usr/lib/python3.10/unittest/case.py\", line 1238, in assertLessEqual\n    self.fail(self._formatMessage(msg, standardMsg))\n  File \"/usr/lib/python3.10/unittest/case.py\", line 675, in fail\n    raise self.failureException(msg)\nAssertionError: 11.200000000000001 not less than or equal to 5.0 : Downtime of 11.200000000000001 seconds is higher than expected \u00275.0\u0027","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"34892fc181577571e076f7bdf35bf8143fc5261a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7274afd5_ba13f6de","updated":"2024-06-25 05:17:50.000000000","message":"recheck tempest-integrated-storage failed with server test failing to ssh in time","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"}],"cinder/tests/unit/volume/test_revert_to_snapshot_messages.py":[{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16506b8a2323c409dc80e80a5025779adb639dc5","unresolved":true,"context_lines":[{"line_number":45,"context_line":"        self.user_context \u003d context.RequestContext(user_id\u003dfake.USER_ID,"},{"line_number":46,"context_line":"                                                   project_id\u003dfake.PROJECT_ID)"},{"line_number":47,"context_line":"        elevated \u003d context.get_admin_context()"},{"line_number":48,"context_line":"        db.volume_type_create(elevated,"},{"line_number":49,"context_line":"                              v2_fakes.fake_default_type_get("},{"line_number":50,"context_line":"                                  id\u003dfake.VOLUME_TYPE2_ID))"},{"line_number":51,"context_line":"        self.vol_type \u003d db.volume_type_get_by_name(elevated, \u0027__DEFAULT__\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"c6b41d53_ec2d1f4d","line":48,"range":{"start_line":48,"start_character":8,"end_line":48,"end_character":29},"updated":"2024-06-25 08:47:38.000000000","message":"you can use tests_utils.create_volume_type that will also handle the cleaup","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16506b8a2323c409dc80e80a5025779adb639dc5","unresolved":true,"context_lines":[{"line_number":51,"context_line":"        self.vol_type \u003d db.volume_type_get_by_name(elevated, \u0027__DEFAULT__\u0027)"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"    def test_revert_to_snapshot_driver_error(self):"},{"line_number":54,"context_line":"        fake_volume \u003d tests_utils.create_volume(self.context,"},{"line_number":55,"context_line":"                                                status\u003d\u0027reverting\u0027,"},{"line_number":56,"context_line":"                                                project_id\u003d\u0027123\u0027,"},{"line_number":57,"context_line":"                                                size\u003d2)"},{"line_number":58,"context_line":"        fake_snapshot \u003d tests_utils.create_snapshot(self.context,"},{"line_number":59,"context_line":"                                                    fake_volume[\u0027id\u0027],"},{"line_number":60,"context_line":"                                                    status\u003d\u0027restoring\u0027,"},{"line_number":61,"context_line":"                                                    volume_size\u003d1)"},{"line_number":62,"context_line":"        with mock.patch.object(self.volume.driver,"},{"line_number":63,"context_line":"                               \u0027revert_to_snapshot\u0027) as _revert, \\"},{"line_number":64,"context_line":"            mock.patch.object(self.volume.driver,"},{"line_number":65,"context_line":"                              \u0027snapshot_revert_use_temp_snapshot\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"807c493a_bf386983","line":62,"range":{"start_line":54,"start_character":0,"end_line":62,"end_character":0},"updated":"2024-06-25 08:47:38.000000000","message":"IMO, creation of resources like volumes and snapshots should be in the setUp function as they are not part of the test itself","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"}],"cinder/volume/manager.py":[{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16506b8a2323c409dc80e80a5025779adb639dc5","unresolved":true,"context_lines":[{"line_number":2299,"context_line":"                remote\u003ddest_remote,"},{"line_number":2300,"context_line":"                attach_encryptor\u003dattach_encryptor)"},{"line_number":2301,"context_line":"        except Exception as ex:"},{"line_number":2302,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":2303,"context_line":"                self.message_api.create_from_request_context("},{"line_number":2304,"context_line":"                    ctxt,"},{"line_number":2305,"context_line":"                    exception\u003dex,"}],"source_content_type":"text/x-python","patch_set":14,"id":"c8a5f397_ee658af0","line":2302,"range":{"start_line":2302,"start_character":0,"end_line":2302,"end_character":55},"updated":"2024-06-25 08:47:38.000000000","message":"Missing message_created \u003d True ?","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16506b8a2323c409dc80e80a5025779adb639dc5","unresolved":true,"context_lines":[{"line_number":2318,"context_line":"                                    properties, remote\u003ddest_remote,"},{"line_number":2319,"context_line":"                                    attach_encryptor\u003dattach_encryptor,"},{"line_number":2320,"context_line":"                                    force\u003dTrue)"},{"line_number":2321,"context_line":"                self.message_api.create_from_request_context("},{"line_number":2322,"context_line":"                    ctxt,"},{"line_number":2323,"context_line":"                    exception\u003dex,"},{"line_number":2324,"context_line":"                    detail\u003dmessage_field.Detail.ATTACH_ERROR)"}],"source_content_type":"text/x-python","patch_set":14,"id":"15164ac8_c63833ad","line":2321,"range":{"start_line":2321,"start_character":0,"end_line":2321,"end_character":61},"updated":"2024-06-25 08:47:38.000000000","message":"Missing message_created \u003d True ?","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16506b8a2323c409dc80e80a5025779adb639dc5","unresolved":true,"context_lines":[{"line_number":2356,"context_line":"                                    attach_encryptor\u003dattach_encryptor)"},{"line_number":2357,"context_line":"            except Exception as ex:"},{"line_number":2358,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":2359,"context_line":"                    if not message_created:"},{"line_number":2360,"context_line":"                        message_created \u003d True"},{"line_number":2361,"context_line":"                        self.message_api.create_from_request_context("},{"line_number":2362,"context_line":"                            ctxt,"}],"source_content_type":"text/x-python","patch_set":14,"id":"05148796_feef68e8","line":2359,"range":{"start_line":2359,"start_character":0,"end_line":2359,"end_character":43},"updated":"2024-06-25 08:47:38.000000000","message":"If the message_created already set (let\u0027s say due to copy_error in line 2346), the message for detach will not get sent.","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"},{"author":{"_account_id":35834,"name":"Yosi Ben Shimon","display_name":"Yosi Ben Shimon","email":"ybenshim@redhat.com","username":"ybenshim"},"change_message_id":"16506b8a2323c409dc80e80a5025779adb639dc5","unresolved":true,"context_lines":[{"line_number":2370,"context_line":"                                        attach_encryptor\u003dattach_encryptor)"},{"line_number":2371,"context_line":"                except Exception as ex:"},{"line_number":2372,"context_line":"                    with excutils.save_and_reraise_exception():"},{"line_number":2373,"context_line":"                        if not message_created:"},{"line_number":2374,"context_line":"                            message_created \u003d True"},{"line_number":2375,"context_line":"                            self.message_api.create_from_request_context("},{"line_number":2376,"context_line":"                                ctxt,"}],"source_content_type":"text/x-python","patch_set":14,"id":"ae2d19ea_8608a088","line":2373,"range":{"start_line":2373,"start_character":0,"end_line":2373,"end_character":47},"updated":"2024-06-25 08:47:38.000000000","message":"same","commit_id":"bc0d8a6f550e6a06726d137c167551aefaaf47a2"}]}