)]}'
{"cinder/api/__init__.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"807853dde8ffe03b24f936f60a68c65b2d36c24e","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    if \u0027/v1\u0027 in local_conf:"},{"line_number":31,"context_line":"        LOG.warning(\u0027The v1 API has been removed and is no longer \u0027"},{"line_number":32,"context_line":"                    \u0027available. Client applications should be \u0027"},{"line_number":33,"context_line":"                    \u0027using v3. Ensure enable_v3_api\u003dtrue in your \u0027"},{"line_number":34,"context_line":"                    \u0027cinder.conf file.\u0027)"},{"line_number":35,"context_line":"        del local_conf[\u0027/v1\u0027]"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ebe09c3c_39ffbf89","line":33,"updated":"2021-07-09 13:02:48.000000000","message":"if v1 and v2 are gone, why do we even need a config option for enable_v3_api ?","commit_id":"e05b261af7dcd24096b229860df65dff1d385910"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"123ed2fd365d7d57b000c0661b8494d396128ced","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    if \u0027/v1\u0027 in local_conf:"},{"line_number":31,"context_line":"        LOG.warning(\u0027The v1 API has been removed and is no longer \u0027"},{"line_number":32,"context_line":"                    \u0027available. Client applications should be \u0027"},{"line_number":33,"context_line":"                    \u0027using v3. Ensure enable_v3_api\u003dtrue in your \u0027"},{"line_number":34,"context_line":"                    \u0027cinder.conf file.\u0027)"},{"line_number":35,"context_line":"        del local_conf[\u0027/v1\u0027]"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"cbb510db_42140e27","line":33,"in_reply_to":"775d2d07_cebd2409","updated":"2021-07-09 16:12:34.000000000","message":"Ack","commit_id":"e05b261af7dcd24096b229860df65dff1d385910"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"be0168c5cfe2955bdb0532bcd56542a5a054982a","unresolved":true,"context_lines":[{"line_number":30,"context_line":"    if \u0027/v1\u0027 in local_conf:"},{"line_number":31,"context_line":"        LOG.warning(\u0027The v1 API has been removed and is no longer \u0027"},{"line_number":32,"context_line":"                    \u0027available. Client applications should be \u0027"},{"line_number":33,"context_line":"                    \u0027using v3. Ensure enable_v3_api\u003dtrue in your \u0027"},{"line_number":34,"context_line":"                    \u0027cinder.conf file.\u0027)"},{"line_number":35,"context_line":"        del local_conf[\u0027/v1\u0027]"},{"line_number":36,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"775d2d07_cebd2409","line":33,"in_reply_to":"ebe09c3c_39ffbf89","updated":"2021-07-09 15:57:03.000000000","message":"Although enable_v2_api was deprecated a while back, it never occurred to us to also deprecate enable_v3_api (it\u0027s deprecated in cinder/common/config.py in this patch).  So technically, we can\u0027t remove it this cycle because cinder asserts the \u0027assert:follows-standard-deprecation\u0027 tag.\n\nOn the other hand, it seems dumb to keep it.  We discussed this at the midcycle [0] and decided to get some more info and if it\u0027s ok to remove it, do it in a follow-up patch.\n\n[0] https://wiki.openstack.org/wiki/CinderXenaMidCycleSummary#what_about_the_enable_v3_api_option.3F","commit_id":"e05b261af7dcd24096b229860df65dff1d385910"}],"cinder/api/contrib/admin_actions.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":204,"context_line":"    @wsgi.action(\u0027os-migrate_volume\u0027)"},{"line_number":205,"context_line":"    @validation.schema(admin_actions.migrate_volume, mv.V2_BASE_VERSION,"},{"line_number":206,"context_line":"                       mv.get_prior_version(mv.VOLUME_MIGRATE_CLUSTER))"},{"line_number":207,"context_line":"    @validation.schema(admin_actions.migrate_volume_v316,"},{"line_number":208,"context_line":"                       mv.VOLUME_MIGRATE_CLUSTER)"}],"source_content_type":"text/x-python","patch_set":4,"id":"e3a08a7a_4b8b252d","side":"PARENT","line":205,"range":{"start_line":205,"start_character":56,"end_line":205,"end_character":71},"updated":"2021-06-03 23:40:00.000000000","message":"change this to BASE_VERSION","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":202,"context_line":""},{"line_number":203,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":204,"context_line":"    @wsgi.action(\u0027os-migrate_volume\u0027)"},{"line_number":205,"context_line":"    @validation.schema(admin_actions.migrate_volume, mv.V2_BASE_VERSION,"},{"line_number":206,"context_line":"                       mv.get_prior_version(mv.VOLUME_MIGRATE_CLUSTER))"},{"line_number":207,"context_line":"    @validation.schema(admin_actions.migrate_volume_v316,"},{"line_number":208,"context_line":"                       mv.VOLUME_MIGRATE_CLUSTER)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a7329a7f_ee98241a","side":"PARENT","line":205,"range":{"start_line":205,"start_character":56,"end_line":205,"end_character":71},"in_reply_to":"e3a08a7a_4b8b252d","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"}],"cinder/api/contrib/backups.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":145,"context_line":"    #   immediately"},{"line_number":146,"context_line":"    # - maybe also do validation of swift container name"},{"line_number":147,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":148,"context_line":"    @validation.schema(backup.create, mv.V2_BASE_VERSION,"},{"line_number":149,"context_line":"                       mv.get_prior_version(mv.BACKUP_METADATA))"},{"line_number":150,"context_line":"    @validation.schema(backup.create_backup_v343, mv.BACKUP_METADATA,"},{"line_number":151,"context_line":"                       mv.get_prior_version(mv.BACKUP_AZ))"}],"source_content_type":"text/x-python","patch_set":4,"id":"1dbfa09d_c8d2c71b","side":"PARENT","line":148,"range":{"start_line":148,"start_character":41,"end_line":148,"end_character":56},"updated":"2021-06-03 23:40:00.000000000","message":"change this to BASE_VERSION","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":145,"context_line":"    #   immediately"},{"line_number":146,"context_line":"    # - maybe also do validation of swift container name"},{"line_number":147,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":148,"context_line":"    @validation.schema(backup.create, mv.V2_BASE_VERSION,"},{"line_number":149,"context_line":"                       mv.get_prior_version(mv.BACKUP_METADATA))"},{"line_number":150,"context_line":"    @validation.schema(backup.create_backup_v343, mv.BACKUP_METADATA,"},{"line_number":151,"context_line":"                       mv.get_prior_version(mv.BACKUP_AZ))"}],"source_content_type":"text/x-python","patch_set":4,"id":"77abf2ca_10dc0899","side":"PARENT","line":148,"range":{"start_line":148,"start_character":41,"end_line":148,"end_character":56},"in_reply_to":"1dbfa09d_c8d2c71b","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"}],"cinder/api/contrib/scheduler_hints.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        @validation.schema(scheduler_hints.create)"},{"line_number":26,"context_line":"        def _validate_scheduler_hints(req\u003dNone, body\u003dNone):"},{"line_number":27,"context_line":"            # TODO(pooja_jadhav): The scheduler hints schema validation"},{"line_number":28,"context_line":"            # should be moved to v3 volume schema directly and this module"},{"line_number":29,"context_line":"            # should be deleted at the time of deletion of v2 version code."},{"line_number":30,"context_line":"            pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        _validate_scheduler_hints(req\u003dreq, body\u003dscheduler_hints_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"c4076c0f_daf75371","line":29,"range":{"start_line":27,"start_character":12,"end_line":29,"end_character":75},"updated":"2021-06-03 23:40:00.000000000","message":"Given this comment, we should delete this module with v2 code removal","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5451f330eef1379d26511def3056b741d7e13d18","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        @validation.schema(scheduler_hints.create)"},{"line_number":26,"context_line":"        def _validate_scheduler_hints(req\u003dNone, body\u003dNone):"},{"line_number":27,"context_line":"            # TODO(pooja_jadhav): The scheduler hints schema validation"},{"line_number":28,"context_line":"            # should be moved to v3 volume schema directly and this module"},{"line_number":29,"context_line":"            # should be deleted at the time of deletion of v2 version code."},{"line_number":30,"context_line":"            pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        _validate_scheduler_hints(req\u003dreq, body\u003dscheduler_hints_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"6a0a7720_a88a180f","line":29,"range":{"start_line":27,"start_character":12,"end_line":29,"end_character":75},"in_reply_to":"31c37af4_c2a42d5a","updated":"2021-06-07 12:12:58.000000000","message":"Ack","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"        @validation.schema(scheduler_hints.create)"},{"line_number":26,"context_line":"        def _validate_scheduler_hints(req\u003dNone, body\u003dNone):"},{"line_number":27,"context_line":"            # TODO(pooja_jadhav): The scheduler hints schema validation"},{"line_number":28,"context_line":"            # should be moved to v3 volume schema directly and this module"},{"line_number":29,"context_line":"            # should be deleted at the time of deletion of v2 version code."},{"line_number":30,"context_line":"            pass"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"        _validate_scheduler_hints(req\u003dreq, body\u003dscheduler_hints_body)"}],"source_content_type":"text/x-python","patch_set":4,"id":"31c37af4_c2a42d5a","line":29,"range":{"start_line":27,"start_character":12,"end_line":29,"end_character":75},"in_reply_to":"c4076c0f_daf75371","updated":"2021-06-04 21:07:37.000000000","message":"I think we should do this as a followup, because we still need the action on line 33 to happen (see [0]), and I\u0027m not sure what it buys us to further complicate the volume-create schema.  But thanks for flagging this.\n\n[0] https://opendev.org/openstack/cinder/src/commit/d5f0e51879c03654db4bf89564695e01af593350/cinder/api/v3/volumes.py#L294-L299","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/api/contrib/volume_actions.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":194,"context_line":"    @wsgi.action(\u0027os-volume_upload_image\u0027)"},{"line_number":195,"context_line":"    @validation.schema(volume_action.volume_upload_image, mv.V2_BASE_VERSION,"},{"line_number":196,"context_line":"                       mv.get_prior_version(mv.UPLOAD_IMAGE_PARAMS))"},{"line_number":197,"context_line":"    @validation.schema(volume_action.volume_upload_image_v31,"},{"line_number":198,"context_line":"                       mv.UPLOAD_IMAGE_PARAMS)"}],"source_content_type":"text/x-python","patch_set":4,"id":"683da544_d07eb0ef","side":"PARENT","line":195,"range":{"start_line":195,"start_character":61,"end_line":195,"end_character":76},"updated":"2021-06-03 23:40:00.000000000","message":"change this to BASE_VERSION","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":192,"context_line":""},{"line_number":193,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":194,"context_line":"    @wsgi.action(\u0027os-volume_upload_image\u0027)"},{"line_number":195,"context_line":"    @validation.schema(volume_action.volume_upload_image, mv.V2_BASE_VERSION,"},{"line_number":196,"context_line":"                       mv.get_prior_version(mv.UPLOAD_IMAGE_PARAMS))"},{"line_number":197,"context_line":"    @validation.schema(volume_action.volume_upload_image_v31,"},{"line_number":198,"context_line":"                       mv.UPLOAD_IMAGE_PARAMS)"}],"source_content_type":"text/x-python","patch_set":4,"id":"a493bfa5_5dc8c37c","side":"PARENT","line":195,"range":{"start_line":195,"start_character":61,"end_line":195,"end_character":76},"in_reply_to":"683da544_d07eb0ef","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"}],"cinder/api/contrib/volume_manage.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":46,"context_line":"        self._list_manageable_view \u003d list_manageable_view.ViewBuilder()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":49,"context_line":"    @validation.schema(volume_manage.volume_manage_create, mv.V2_BASE_VERSION,"},{"line_number":50,"context_line":"                       mv.get_prior_version(mv.VOLUME_MIGRATE_CLUSTER))"},{"line_number":51,"context_line":"    @validation.schema(volume_manage.volume_manage_create_v316,"},{"line_number":52,"context_line":"                       mv.VOLUME_MIGRATE_CLUSTER)"}],"source_content_type":"text/x-python","patch_set":4,"id":"dda15e5f_1b0efce8","side":"PARENT","line":49,"range":{"start_line":49,"start_character":62,"end_line":49,"end_character":77},"updated":"2021-06-03 23:40:00.000000000","message":"change this to BASE_VERSION","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":46,"context_line":"        self._list_manageable_view \u003d list_manageable_view.ViewBuilder()"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":49,"context_line":"    @validation.schema(volume_manage.volume_manage_create, mv.V2_BASE_VERSION,"},{"line_number":50,"context_line":"                       mv.get_prior_version(mv.VOLUME_MIGRATE_CLUSTER))"},{"line_number":51,"context_line":"    @validation.schema(volume_manage.volume_manage_create_v316,"},{"line_number":52,"context_line":"                       mv.VOLUME_MIGRATE_CLUSTER)"}],"source_content_type":"text/x-python","patch_set":4,"id":"683c13a6_084772bc","side":"PARENT","line":49,"range":{"start_line":49,"start_character":62,"end_line":49,"end_character":77},"in_reply_to":"dda15e5f_1b0efce8","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"}],"cinder/api/microversions.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Add new constants here for each new microversion."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"V2_BASE_VERSION \u003d \u00272.0\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"BASE_VERSION \u003d \u00273.0\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d59ab9d5_a3c43ce3","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":23},"updated":"2021-06-03 23:40:00.000000000","message":"remove this (with the changes in other files using it)","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# Add new constants here for each new microversion."},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"V2_BASE_VERSION \u003d \u00272.0\u0027"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"BASE_VERSION \u003d \u00273.0\u0027"},{"line_number":43,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"88d4e23d_e816105e","line":40,"range":{"start_line":40,"start_character":0,"end_line":40,"end_character":23},"in_reply_to":"d59ab9d5_a3c43ce3","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/api/schemas/volumes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        \u0027volume\u0027: {"},{"line_number":86,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":87,"context_line":"            \u0027properties\u0027: {"},{"line_number":88,"context_line":"                # The \u0027name\u0027 and \u0027description\u0027 are required to be compatible"},{"line_number":89,"context_line":"                # with v2."},{"line_number":90,"context_line":"                \u0027name\u0027: {"},{"line_number":91,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":92,"context_line":"                    \u0027format\u0027: \u0027name_non_mandatory_remove_white_spaces\u0027},"},{"line_number":93,"context_line":"                \u0027description\u0027: {"},{"line_number":94,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":95,"context_line":"                    \u0027format\u0027:"},{"line_number":96,"context_line":"                        \u0027description_non_mandatory_remove_white_spaces\u0027},"},{"line_number":97,"context_line":"                \u0027display_name\u0027: {"},{"line_number":98,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":99,"context_line":"                    \u0027format\u0027: \u0027name_non_mandatory_remove_white_spaces\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"b04737c6_619c3c86","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":73},"updated":"2021-06-03 23:40:00.000000000","message":"can we remove these now?","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":85,"context_line":"        \u0027volume\u0027: {"},{"line_number":86,"context_line":"            \u0027type\u0027: \u0027object\u0027,"},{"line_number":87,"context_line":"            \u0027properties\u0027: {"},{"line_number":88,"context_line":"                # The \u0027name\u0027 and \u0027description\u0027 are required to be compatible"},{"line_number":89,"context_line":"                # with v2."},{"line_number":90,"context_line":"                \u0027name\u0027: {"},{"line_number":91,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":92,"context_line":"                    \u0027format\u0027: \u0027name_non_mandatory_remove_white_spaces\u0027},"},{"line_number":93,"context_line":"                \u0027description\u0027: {"},{"line_number":94,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":95,"context_line":"                    \u0027format\u0027:"},{"line_number":96,"context_line":"                        \u0027description_non_mandatory_remove_white_spaces\u0027},"},{"line_number":97,"context_line":"                \u0027display_name\u0027: {"},{"line_number":98,"context_line":"                    \u0027type\u0027: [\u0027string\u0027, \u0027null\u0027],"},{"line_number":99,"context_line":"                    \u0027format\u0027: \u0027name_non_mandatory_remove_white_spaces\u0027},"}],"source_content_type":"text/x-python","patch_set":4,"id":"0dc36dbc_8d0191aa","line":96,"range":{"start_line":88,"start_character":0,"end_line":96,"end_character":73},"in_reply_to":"b04737c6_619c3c86","updated":"2021-06-04 21:07:37.000000000","message":"That comment is really weird because v3 also uses \u0027name\u0027 and \u0027description\u0027.  I am pretty sure it was the v1 API that used display_name and display_description.  But that makes me wonder why lines 97-103 are in this schema, because schema validation was added for v3, so we\u0027d only be worried about compatibility with v2, not v1.  All I can think of is that the display_* were left in v2 for v1 compatibilty.  And if that\u0027s the case, we need to leave them here in order for v3.0 to be equal to v2.\n\nThanks for flagging this.  We will have to look into what to do about this as a follow up.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/api/v2/volumes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5451f330eef1379d26511def3056b741d7e13d18","unresolved":true,"context_lines":[{"line_number":177,"context_line":"                \"access requested image.\")"},{"line_number":178,"context_line":"        raise exc.HTTPBadRequest(explanation\u003dmsg)"},{"line_number":179,"context_line":""},{"line_number":180,"context_line":"    # NOTE: using mv.BASE_VERSION (which is 3.0) is a bit nonstandard,"},{"line_number":181,"context_line":"    # but this class is no longer consumed by the v2 API, though it is"},{"line_number":182,"context_line":"    # a superclass of cinder.api.v3.volumes.  Although create() is"},{"line_number":183,"context_line":"    # overridden in the subclass, I didn\u0027t want to remove it from"},{"line_number":184,"context_line":"    # here until we are sure that the v3 unit tests for create() test"},{"line_number":185,"context_line":"    # everything that the v2 unit tests covered."},{"line_number":186,"context_line":"    @wsgi.response(HTTPStatus.ACCEPTED)"},{"line_number":187,"context_line":"    @validation.schema(volumes.create, mv.BASE_VERSION)"},{"line_number":188,"context_line":"    def create(self, req, body):"}],"source_content_type":"text/x-python","patch_set":6,"id":"622d9bc5_5c893878","line":185,"range":{"start_line":180,"start_character":0,"end_line":185,"end_character":48},"updated":"2021-06-07 12:12:58.000000000","message":"i wasn\u0027t sure about this change when reviewing but with the comment explanation it makes sense. Thanks","commit_id":"e05b261af7dcd24096b229860df65dff1d385910"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        self._process_volume_filtering(context\u003dcontext, filters\u003dfilters,"},{"line_number":148,"context_line":"                                       req_version\u003dreq_version)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # NOTE(thingee): v2 API allows name instead of display_name"},{"line_number":151,"context_line":"        if \u0027name\u0027 in sort_keys:"},{"line_number":152,"context_line":"            sort_keys[sort_keys.index(\u0027name\u0027)] \u003d \u0027display_name\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        if \u0027name\u0027 in filters:"},{"line_number":155,"context_line":"            filters[\u0027display_name\u0027] \u003d filters.pop(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"163d770c_4bcf8cd5","line":152,"range":{"start_line":150,"start_character":0,"end_line":152,"end_character":63},"updated":"2021-06-03 23:40:00.000000000","message":"I\u0027m not entirely sure why we have this compatibility code in v3. I think it makes sense for contrib files but does this request gets passed to any v2 code?","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":147,"context_line":"        self._process_volume_filtering(context\u003dcontext, filters\u003dfilters,"},{"line_number":148,"context_line":"                                       req_version\u003dreq_version)"},{"line_number":149,"context_line":""},{"line_number":150,"context_line":"        # NOTE(thingee): v2 API allows name instead of display_name"},{"line_number":151,"context_line":"        if \u0027name\u0027 in sort_keys:"},{"line_number":152,"context_line":"            sort_keys[sort_keys.index(\u0027name\u0027)] \u003d \u0027display_name\u0027"},{"line_number":153,"context_line":""},{"line_number":154,"context_line":"        if \u0027name\u0027 in filters:"},{"line_number":155,"context_line":"            filters[\u0027display_name\u0027] \u003d filters.pop(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5935a3fa_d35e62d1","line":152,"range":{"start_line":150,"start_character":0,"end_line":152,"end_character":63},"in_reply_to":"163d770c_4bcf8cd5","updated":"2021-06-04 21:07:37.000000000","message":"We need to do this translation because it\u0027s \u0027name\u0027/\u0027description\u0027 in the REST API, but they are stored as \u0027display_name\u0027/\u0027display_description\u0027 in the database (see https://opendev.org/openstack/cinder/src/commit/d5f0e51879c03654db4bf89564695e01af593350/cinder/db/sqlalchemy/models.py#L282-L283).  I think this comment was copied over without careful thought from cinder/api/v2/volumes.py when the v3 classes were created.\n\nI\u0027ll update the comments, thanks for flagging this.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/api/versions.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":89,"context_line":"        return builder.build_versions(known_versions)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    # NOTE (cknight): Calling the versions API without"},{"line_number":92,"context_line":"    # /v2 or /v3 in the URL will lead to this unversioned"},{"line_number":93,"context_line":"    # method, which should always return info about all"},{"line_number":94,"context_line":"    # available versions."},{"line_number":95,"context_line":"    @wsgi.response(HTTPStatus.MULTIPLE_CHOICES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"fd96d078_710a36fb","line":92,"range":{"start_line":92,"start_character":6,"end_line":92,"end_character":12},"updated":"2021-06-03 23:40:00.000000000","message":"remove this","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        return builder.build_versions(known_versions)"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    # NOTE (cknight): Calling the versions API without"},{"line_number":92,"context_line":"    # /v2 or /v3 in the URL will lead to this unversioned"},{"line_number":93,"context_line":"    # method, which should always return info about all"},{"line_number":94,"context_line":"    # available versions."},{"line_number":95,"context_line":"    @wsgi.response(HTTPStatus.MULTIPLE_CHOICES)"}],"source_content_type":"text/x-python","patch_set":4,"id":"7d2e4e4f_d2286313","line":92,"range":{"start_line":92,"start_character":6,"end_line":92,"end_character":12},"in_reply_to":"fd96d078_710a36fb","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f375abb857db606d36ed8f6391e636d38b3c7276","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # FIXME: remove this in Y ... I suppose we should honor"},{"line_number":102,"context_line":"        # it in Xena, even though it doesn\u0027t make any sense"},{"line_number":103,"context_line":"        if not CONF.enable_v3_api:"},{"line_number":104,"context_line":"            known_versions.pop(\u0027v3.0\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        return builder.build_versions(known_versions)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9bb0f02a_e0c82521","line":103,"range":{"start_line":103,"start_character":15,"end_line":103,"end_character":33},"updated":"2021-06-02 14:10:43.000000000","message":"I understand the reason for keeping it because of the deprecation period but i don\u0027t mind removing it since this is by default True and if this is specifically set to false then we only have 3.0 in the known versions and versions response will be empty.\nAnyway this is also works for me.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":100,"context_line":""},{"line_number":101,"context_line":"        # FIXME: remove this in Y ... I suppose we should honor"},{"line_number":102,"context_line":"        # it in Xena, even though it doesn\u0027t make any sense"},{"line_number":103,"context_line":"        if not CONF.enable_v3_api:"},{"line_number":104,"context_line":"            known_versions.pop(\u0027v3.0\u0027)"},{"line_number":105,"context_line":""},{"line_number":106,"context_line":"        return builder.build_versions(known_versions)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0b20f7ee_3446b683","line":103,"range":{"start_line":103,"start_character":15,"end_line":103,"end_character":33},"in_reply_to":"9bb0f02a_e0c82521","updated":"2021-06-04 21:07:37.000000000","message":"Thanks for flagging this.  As discussed at the R-18 virtual midcycle, we\u0027ll figure out what to do about it as a follow-up patch.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/common/config.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"09d692cf99cd51445e8a3be5d50d52f38f905653","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":53,"context_line":"                deprecated_reason\u003d(\u0027This is the only API version available, \u0027"},{"line_number":54,"context_line":"                                   \u0027so disabling it is not an option.\u0027),"},{"line_number":55,"context_line":"                deprecated_since\u003d\"Xena\","},{"line_number":56,"context_line":"                help\u003d\"Deploy v3 of the Cinder API.\"),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027api_rate_limit\u0027,"},{"line_number":58,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"c5607452_ee1a903e","line":55,"range":{"start_line":55,"start_character":33,"end_line":55,"end_character":39},"updated":"2021-06-08 18:02:28.000000000","message":"We should probably use \"19.0.0\" here instead of the codename.\n\n    https://opendev.org/openstack/oslo.config/src/commit/1a7bd66a7179ca374e996e76f346def33787a21f/oslo_config/cfg.py#L454","commit_id":"e05b261af7dcd24096b229860df65dff1d385910"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6c9a5a6b28314372321cb5d7454af1546918da05","unresolved":true,"context_lines":[{"line_number":52,"context_line":"                deprecated_for_removal\u003dTrue,"},{"line_number":53,"context_line":"                deprecated_reason\u003d(\u0027This is the only API version available, \u0027"},{"line_number":54,"context_line":"                                   \u0027so disabling it is not an option.\u0027),"},{"line_number":55,"context_line":"                deprecated_since\u003d\"Xena\","},{"line_number":56,"context_line":"                help\u003d\"Deploy v3 of the Cinder API.\"),"},{"line_number":57,"context_line":"    cfg.BoolOpt(\u0027api_rate_limit\u0027,"},{"line_number":58,"context_line":"                default\u003dTrue,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a5002c6_ce32ec40","line":55,"range":{"start_line":55,"start_character":33,"end_line":55,"end_character":39},"in_reply_to":"c5607452_ee1a903e","updated":"2021-06-09 13:21:16.000000000","message":"We currently have it both ways in the cinder code.  Since oslo_config simply expects a string, I prefer using the release name since the deprecation period is tied more closely to development cycles than version numbers:\n\nhttps://governance.openstack.org/tc/reference/tags/assert_follows-standard-deprecation.html\n\nAlso, I think it\u0027s easier to spot these in the code and realize they should be removed when the release name is used.  But the other thing is that this option is still under discussion (one proposal is to simply remove it without deprecation because it doesn\u0027t do anything useful in Xena), so I\u0027d prefer to hold off on this for a followup:\n\nhttps://wiki.openstack.org/wiki/CinderXenaMidCycleSummary#what_about_the_enable_v3_api_option.3F","commit_id":"e05b261af7dcd24096b229860df65dff1d385910"}],"cinder/tests/unit/api/fakes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":27,"context_line":"from cinder.api.openstack import api_version_request as api_version"},{"line_number":28,"context_line":"from cinder.api.openstack import wsgi as os_wsgi"},{"line_number":29,"context_line":"from cinder.api import urlmap"},{"line_number":30,"context_line":"from cinder.api.v2 import limits"},{"line_number":31,"context_line":"from cinder.api.v3 import router as router_v3"},{"line_number":32,"context_line":"from cinder.api import versions"},{"line_number":33,"context_line":"from cinder import context"}],"source_content_type":"text/x-python","patch_set":4,"id":"a3bcb795_8fd2b1c3","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"updated":"2021-06-03 23:40:00.000000000","message":"I\u0027m not sure if this is left intentionally to be done in a followup but we should import from v3 limits (it\u0027s a subclass of v2 limits)","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":27,"context_line":"from cinder.api.openstack import api_version_request as api_version"},{"line_number":28,"context_line":"from cinder.api.openstack import wsgi as os_wsgi"},{"line_number":29,"context_line":"from cinder.api import urlmap"},{"line_number":30,"context_line":"from cinder.api.v2 import limits"},{"line_number":31,"context_line":"from cinder.api.v3 import router as router_v3"},{"line_number":32,"context_line":"from cinder.api import versions"},{"line_number":33,"context_line":"from cinder import context"}],"source_content_type":"text/x-python","patch_set":4,"id":"cc2cdeb8_aad19a85","line":30,"range":{"start_line":30,"start_character":0,"end_line":30,"end_character":32},"in_reply_to":"a3bcb795_8fd2b1c3","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def blank(cls, *args, **kwargs):"},{"line_number":113,"context_line":"        if args is not None:"},{"line_number":114,"context_line":"            if \u0027v1\u0027 in args[0]:"},{"line_number":115,"context_line":"                kwargs[\u0027base_url\u0027] \u003d \u0027http://localhost/v1\u0027"},{"line_number":116,"context_line":"            if \u0027v2\u0027 in args[0]:"},{"line_number":117,"context_line":"                kwargs[\u0027base_url\u0027] \u003d \u0027http://localhost/v2\u0027"},{"line_number":118,"context_line":"            if \u0027v3\u0027 in args[0]:"},{"line_number":119,"context_line":"                kwargs[\u0027base_url\u0027] \u003d \u0027http://localhost/v3\u0027"},{"line_number":120,"context_line":"        use_admin_context \u003d kwargs.pop(\u0027use_admin_context\u0027, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"423bac0e_1f6dc29f","line":117,"range":{"start_line":114,"start_character":0,"end_line":117,"end_character":58},"updated":"2021-06-03 23:40:00.000000000","message":"Not sure about v1 but I think v2 is kept to make the v2 tests working","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":111,"context_line":"    @classmethod"},{"line_number":112,"context_line":"    def blank(cls, *args, **kwargs):"},{"line_number":113,"context_line":"        if args is not None:"},{"line_number":114,"context_line":"            if \u0027v1\u0027 in args[0]:"},{"line_number":115,"context_line":"                kwargs[\u0027base_url\u0027] \u003d \u0027http://localhost/v1\u0027"},{"line_number":116,"context_line":"            if \u0027v2\u0027 in args[0]:"},{"line_number":117,"context_line":"                kwargs[\u0027base_url\u0027] \u003d \u0027http://localhost/v2\u0027"},{"line_number":118,"context_line":"            if \u0027v3\u0027 in args[0]:"},{"line_number":119,"context_line":"                kwargs[\u0027base_url\u0027] \u003d \u0027http://localhost/v3\u0027"},{"line_number":120,"context_line":"        use_admin_context \u003d kwargs.pop(\u0027use_admin_context\u0027, False)"}],"source_content_type":"text/x-python","patch_set":4,"id":"5acfdc77_bd55207a","line":117,"range":{"start_line":114,"start_character":0,"end_line":117,"end_character":58},"in_reply_to":"423bac0e_1f6dc29f","updated":"2021-06-04 21:07:37.000000000","message":"I think with /v2 removed from the mapper (line 84 above), if any tests are using v1 or v2 blanks, they should fail?  So this is sort of a safeguard to make sure the tests have been converted properly.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/tests/unit/api/test_common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":260,"context_line":"               \u0027http://cinder.example.com\u0027),"},{"line_number":261,"context_line":"              (\u0027http://cinder.example.com/v1.1/images/v10.5\u0027,"},{"line_number":262,"context_line":"               \u0027http://cinder.example.com/images/v10.5\u0027),"},{"line_number":263,"context_line":"              (\u0027http://cinder.example.com/cinder/v2\u0027,"},{"line_number":264,"context_line":"               \u0027http://cinder.example.com/cinder\u0027),"},{"line_number":265,"context_line":"              (\u0027http://cinder.example.com/volume/v2/123\u0027,"},{"line_number":266,"context_line":"               \u0027http://cinder.example.com/volume/123\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"39beea04_96bccb5b","line":263,"range":{"start_line":263,"start_character":15,"end_line":263,"end_character":53},"updated":"2021-06-03 23:40:00.000000000","message":"v2 example not needed?","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":260,"context_line":"               \u0027http://cinder.example.com\u0027),"},{"line_number":261,"context_line":"              (\u0027http://cinder.example.com/v1.1/images/v10.5\u0027,"},{"line_number":262,"context_line":"               \u0027http://cinder.example.com/images/v10.5\u0027),"},{"line_number":263,"context_line":"              (\u0027http://cinder.example.com/cinder/v2\u0027,"},{"line_number":264,"context_line":"               \u0027http://cinder.example.com/cinder\u0027),"},{"line_number":265,"context_line":"              (\u0027http://cinder.example.com/volume/v2/123\u0027,"},{"line_number":266,"context_line":"               \u0027http://cinder.example.com/volume/123\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"685bbaeb_da7f84a5","line":263,"range":{"start_line":263,"start_character":15,"end_line":263,"end_character":53},"in_reply_to":"39beea04_96bccb5b","updated":"2021-06-04 21:07:37.000000000","message":"These are just being used as syntax, so it doesn\u0027t really matter.  I guess as a followup we could change v1-\u003ev7 and v2-\u003ev8 so it would be more clear that we\u0027re not really testing anything about v1 or v2.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5451f330eef1379d26511def3056b741d7e13d18","unresolved":false,"context_lines":[{"line_number":260,"context_line":"               \u0027http://cinder.example.com\u0027),"},{"line_number":261,"context_line":"              (\u0027http://cinder.example.com/v1.1/images/v10.5\u0027,"},{"line_number":262,"context_line":"               \u0027http://cinder.example.com/images/v10.5\u0027),"},{"line_number":263,"context_line":"              (\u0027http://cinder.example.com/cinder/v2\u0027,"},{"line_number":264,"context_line":"               \u0027http://cinder.example.com/cinder\u0027),"},{"line_number":265,"context_line":"              (\u0027http://cinder.example.com/volume/v2/123\u0027,"},{"line_number":266,"context_line":"               \u0027http://cinder.example.com/volume/123\u0027))"}],"source_content_type":"text/x-python","patch_set":4,"id":"6e8c42e4_f9c42f99","line":263,"range":{"start_line":263,"start_character":15,"end_line":263,"end_character":53},"in_reply_to":"685bbaeb_da7f84a5","updated":"2021-06-07 12:12:58.000000000","message":"Ack","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":262,"context_line":"               \u0027http://cinder.example.com/images/v10.5\u0027),"},{"line_number":263,"context_line":"              (\u0027http://cinder.example.com/cinder/v2\u0027,"},{"line_number":264,"context_line":"               \u0027http://cinder.example.com/cinder\u0027),"},{"line_number":265,"context_line":"              (\u0027http://cinder.example.com/volume/v2/123\u0027,"},{"line_number":266,"context_line":"               \u0027http://cinder.example.com/volume/123\u0027))"},{"line_number":267,"context_line":"    @ddt.unpack"},{"line_number":268,"context_line":"    def test_remove_version_from_href(self, fixture, expected):"}],"source_content_type":"text/x-python","patch_set":4,"id":"35273dfa_5b22d722","line":265,"range":{"start_line":265,"start_character":15,"end_line":265,"end_character":57},"updated":"2021-06-03 23:40:00.000000000","message":"same","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":262,"context_line":"               \u0027http://cinder.example.com/images/v10.5\u0027),"},{"line_number":263,"context_line":"              (\u0027http://cinder.example.com/cinder/v2\u0027,"},{"line_number":264,"context_line":"               \u0027http://cinder.example.com/cinder\u0027),"},{"line_number":265,"context_line":"              (\u0027http://cinder.example.com/volume/v2/123\u0027,"},{"line_number":266,"context_line":"               \u0027http://cinder.example.com/volume/123\u0027))"},{"line_number":267,"context_line":"    @ddt.unpack"},{"line_number":268,"context_line":"    def test_remove_version_from_href(self, fixture, expected):"}],"source_content_type":"text/x-python","patch_set":4,"id":"291d33dd_b5447ef3","line":265,"range":{"start_line":265,"start_character":15,"end_line":265,"end_character":57},"in_reply_to":"35273dfa_5b22d722","updated":"2021-06-04 21:07:37.000000000","message":"right, same as above","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":547,"context_line":"        self.assertEqual(expected, result)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"class RequestUrlTest(test.TestCase):"},{"line_number":551,"context_line":"    def test_get_request_url_no_forward(self):"},{"line_number":552,"context_line":"        app_url \u003d \u0027http://127.0.0.1/v2;param?key\u003dvalue#frag\u0027"},{"line_number":553,"context_line":"        request \u003d type(\u0027\u0027, (), {"},{"line_number":554,"context_line":"            \u0027application_url\u0027: app_url,"},{"line_number":555,"context_line":"            \u0027headers\u0027: {}"},{"line_number":556,"context_line":"        })"},{"line_number":557,"context_line":"        result \u003d common.get_request_url(request)"},{"line_number":558,"context_line":"        self.assertEqual(app_url, result)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def test_get_request_url_forward(self):"},{"line_number":561,"context_line":"        request \u003d type(\u0027\u0027, (), {"},{"line_number":562,"context_line":"            \u0027application_url\u0027: \u0027http://127.0.0.1/v2;param?key\u003dvalue#frag\u0027,"},{"line_number":563,"context_line":"            \u0027headers\u0027: {\u0027X-Forwarded-Host\u0027: \u0027192.168.0.243:24\u0027}"},{"line_number":564,"context_line":"        })"},{"line_number":565,"context_line":"        result \u003d common.get_request_url(request)"},{"line_number":566,"context_line":"        self.assertEqual(\u0027http://192.168.0.243:24/v2;param?key\u003dvalue#frag\u0027,"},{"line_number":567,"context_line":"                         result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"d97154a8_28ecc04d","line":567,"range":{"start_line":550,"start_character":0,"end_line":567,"end_character":32},"updated":"2021-06-03 23:40:00.000000000","message":"Looks like this is testing v2 specifically","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":547,"context_line":"        self.assertEqual(expected, result)"},{"line_number":548,"context_line":""},{"line_number":549,"context_line":""},{"line_number":550,"context_line":"class RequestUrlTest(test.TestCase):"},{"line_number":551,"context_line":"    def test_get_request_url_no_forward(self):"},{"line_number":552,"context_line":"        app_url \u003d \u0027http://127.0.0.1/v2;param?key\u003dvalue#frag\u0027"},{"line_number":553,"context_line":"        request \u003d type(\u0027\u0027, (), {"},{"line_number":554,"context_line":"            \u0027application_url\u0027: app_url,"},{"line_number":555,"context_line":"            \u0027headers\u0027: {}"},{"line_number":556,"context_line":"        })"},{"line_number":557,"context_line":"        result \u003d common.get_request_url(request)"},{"line_number":558,"context_line":"        self.assertEqual(app_url, result)"},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"    def test_get_request_url_forward(self):"},{"line_number":561,"context_line":"        request \u003d type(\u0027\u0027, (), {"},{"line_number":562,"context_line":"            \u0027application_url\u0027: \u0027http://127.0.0.1/v2;param?key\u003dvalue#frag\u0027,"},{"line_number":563,"context_line":"            \u0027headers\u0027: {\u0027X-Forwarded-Host\u0027: \u0027192.168.0.243:24\u0027}"},{"line_number":564,"context_line":"        })"},{"line_number":565,"context_line":"        result \u003d common.get_request_url(request)"},{"line_number":566,"context_line":"        self.assertEqual(\u0027http://192.168.0.243:24/v2;param?key\u003dvalue#frag\u0027,"},{"line_number":567,"context_line":"                         result)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0196ecbd_5caca754","line":567,"range":{"start_line":550,"start_character":0,"end_line":567,"end_character":32},"in_reply_to":"d97154a8_28ecc04d","updated":"2021-06-04 21:07:37.000000000","message":"These are testing the function that handles a forwarded host header, so the v2 is really just a placeholder.  It can be changed in a followup if people think it\u0027s confusing.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"cinder/tests/unit/api/v3/test_snapshot_metadata.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f375abb857db606d36ed8f6391e636d38b3c7276","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"20d5bb10_b24e9d2a","side":"PARENT","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":62},"updated":"2021-06-02 14:10:43.000000000","message":"Interesting that we had v2 calls inside so many v3 tests","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"38861848_05dead13","side":"PARENT","line":316,"range":{"start_line":316,"start_character":8,"end_line":316,"end_character":62},"in_reply_to":"20d5bb10_b24e9d2a","updated":"2021-06-04 21:07:37.000000000","message":"Well, to be honest, this file was only present for v2 ... we didn\u0027t have any v3 coverage at all!","commit_id":"ba27068fc0cc8a70e2a2e2fcfe6ab9896dab1908"}],"doc/source/admin/blockstorage-get-capabilities.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":".. code-block:: console"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"   GET /v2/{tenant_id}/capabilities/{hostname}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Example of return value:"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ffc29a5d_d528017c","line":123,"range":{"start_line":123,"start_character":3,"end_line":123,"end_character":46},"updated":"2021-06-03 23:40:00.000000000","message":"should we keep this in documentation?","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":".. code-block:: console"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"   GET /v2/{tenant_id}/capabilities/{hostname}"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"Example of return value:"},{"line_number":126,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"6e5de394_baa00178","line":123,"range":{"start_line":123,"start_character":3,"end_line":123,"end_character":46},"in_reply_to":"ffc29a5d_d528017c","updated":"2021-06-04 21:07:37.000000000","message":"I think not, thanks for catching this.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/configuration/block-storage/drivers/dell-emc-unity-driver.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":441,"context_line":"The user could use `os-force_detach` action to detach a volume from all its"},{"line_number":442,"context_line":"attached hosts."},{"line_number":443,"context_line":"For more detail, please refer to"},{"line_number":444,"context_line":"https://docs.openstack.org/api-ref/block-storage/v2/?expanded\u003dforce-detach-volume-detail#force-detach-volume"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"Consistent group support"},{"line_number":447,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ff4b5a58_889fbebd","line":444,"range":{"start_line":444,"start_character":0,"end_line":444,"end_character":108},"updated":"2021-06-03 23:40:00.000000000","message":"not sure what\u0027s our take on driver documentation containing v2 references but IMO we should change this to v3","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":441,"context_line":"The user could use `os-force_detach` action to detach a volume from all its"},{"line_number":442,"context_line":"attached hosts."},{"line_number":443,"context_line":"For more detail, please refer to"},{"line_number":444,"context_line":"https://docs.openstack.org/api-ref/block-storage/v2/?expanded\u003dforce-detach-volume-detail#force-detach-volume"},{"line_number":445,"context_line":""},{"line_number":446,"context_line":"Consistent group support"},{"line_number":447,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":4,"id":"b99bd2bc_c9eb1173","line":444,"range":{"start_line":444,"start_character":0,"end_line":444,"end_character":108},"in_reply_to":"ff4b5a58_889fbebd","updated":"2021-06-04 21:07:37.000000000","message":"Agree, I just missed it these.  Thanks for catching them.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":620,"context_line":""},{"line_number":621,"context_line":"The user could use `os-force_detach` action to detach a volume from all its"},{"line_number":622,"context_line":"attached hosts. For more detail, please refer to"},{"line_number":623,"context_line":"https://docs.openstack.org/api-ref/block-storage/v2/?expanded\u003dforce-detach-volume-detail#force-detach-volume"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"Advanced features"}],"source_content_type":"text/x-rst","patch_set":4,"id":"56836c56_695d102c","line":623,"range":{"start_line":623,"start_character":49,"end_line":623,"end_character":51},"updated":"2021-06-03 23:40:00.000000000","message":"change this to v3 specific api-ref?","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":620,"context_line":""},{"line_number":621,"context_line":"The user could use `os-force_detach` action to detach a volume from all its"},{"line_number":622,"context_line":"attached hosts. For more detail, please refer to"},{"line_number":623,"context_line":"https://docs.openstack.org/api-ref/block-storage/v2/?expanded\u003dforce-detach-volume-detail#force-detach-volume"},{"line_number":624,"context_line":""},{"line_number":625,"context_line":""},{"line_number":626,"context_line":"Advanced features"}],"source_content_type":"text/x-rst","patch_set":4,"id":"e5c6d26f_785d8f22","line":623,"range":{"start_line":623,"start_character":49,"end_line":623,"end_character":51},"in_reply_to":"56836c56_695d102c","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/configuration/block-storage/policy-config-HOWTO.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":430,"context_line":"resource to refer to (for example, the call to get all volumes) or a POST call"},{"line_number":431,"context_line":"that creates a completely new resource (for example, the call to create a"},{"line_number":432,"context_line":"volume).  You don\u0027t see them much in the Cinder policy file because the code"},{"line_number":433,"context_line":"implementing the Block Storage API v2 and v3 always make sure there\u0027s a target"},{"line_number":434,"context_line":"object containing at least the ``project_id`` and ``user_id`` that can be used"},{"line_number":435,"context_line":"in evaluating whether the policy should allow the action or not."},{"line_number":436,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"54f81b98_d3fe7f08","line":433,"range":{"start_line":433,"start_character":35,"end_line":433,"end_character":41},"updated":"2021-06-03 23:40:00.000000000","message":"not very important but we can remove this","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":430,"context_line":"resource to refer to (for example, the call to get all volumes) or a POST call"},{"line_number":431,"context_line":"that creates a completely new resource (for example, the call to create a"},{"line_number":432,"context_line":"volume).  You don\u0027t see them much in the Cinder policy file because the code"},{"line_number":433,"context_line":"implementing the Block Storage API v2 and v3 always make sure there\u0027s a target"},{"line_number":434,"context_line":"object containing at least the ``project_id`` and ``user_id`` that can be used"},{"line_number":435,"context_line":"in evaluating whether the policy should allow the action or not."},{"line_number":436,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d5cde468_95212e97","line":433,"range":{"start_line":433,"start_character":35,"end_line":433,"end_character":41},"in_reply_to":"54f81b98_d3fe7f08","updated":"2021-06-04 21:07:37.000000000","message":"I\u0027m going to leave this for now because I think this entire file will be deleted when we complete the secure RBAC stuff.","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/contributor/addmethod.openstackapi.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":45,"context_line":"Controllers live in ``cinder/api/openstack``, and inherit from"},{"line_number":46,"context_line":"cinder.wsgi.Controller."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"See ``cinder/api/v2/volumes.py`` for an example."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Action methods take parameters that are sucked out of the URL by"},{"line_number":51,"context_line":"mapper.connect() or .resource().  The first two parameters are self and the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"25d11b58_869589a4","line":48,"range":{"start_line":48,"start_character":17,"end_line":48,"end_character":19},"updated":"2021-06-03 23:40:00.000000000","message":"change it to v3?","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Controllers live in ``cinder/api/openstack``, and inherit from"},{"line_number":46,"context_line":"cinder.wsgi.Controller."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"See ``cinder/api/v2/volumes.py`` for an example."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Action methods take parameters that are sucked out of the URL by"},{"line_number":51,"context_line":"mapper.connect() or .resource().  The first two parameters are self and the"}],"source_content_type":"text/x-rst","patch_set":4,"id":"ac48e471_5daa0d83","line":48,"range":{"start_line":48,"start_character":17,"end_line":48,"end_character":19},"in_reply_to":"25d11b58_869589a4","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/contributor/attach_detach_conventions_v2.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Volume Attach/Detach workflow - V2"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Previously there were six API calls associated with attach/detach of volumes in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"9e5da20d_27a6360e","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":34},"updated":"2021-06-03 23:40:00.000000000","message":"We might need to modify this file to remove/replace the v2 references.\nnova\u0027s legacy attachment code calls the volume actions in contrib folder so we should be fine v2 removal","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Volume Attach/Detach workflow - V2"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Previously there were six API calls associated with attach/detach of volumes in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"dae2d439_21cf5676","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":34},"in_reply_to":"9e5da20d_27a6360e","updated":"2021-06-04 21:07:37.000000000","message":"I think this is referring to version 2 of the attach/detach workflow, not version 2 of the REST API (see lines 36-37 below).  But I admit it is confusing!","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5451f330eef1379d26511def3056b741d7e13d18","unresolved":false,"context_lines":[{"line_number":12,"context_line":"      under the License."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":15,"context_line":"Volume Attach/Detach workflow - V2"},{"line_number":16,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Previously there were six API calls associated with attach/detach of volumes in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"602636bc_26d18927","line":15,"range":{"start_line":15,"start_character":0,"end_line":15,"end_character":34},"in_reply_to":"dae2d439_21cf5676","updated":"2021-06-07 12:12:58.000000000","message":"Ack","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/install/cinder-controller-install-obs.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"         This command provides no output."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"8a18039b_e528d97e","line":81,"range":{"start_line":81,"start_character":17,"end_line":81,"end_character":34},"updated":"2021-06-03 23:40:00.000000000","message":"we\u0027ve removed the v2 endpoint so we should remove this from docs too","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"         This command provides no output."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"0ce52415_9def661a","line":81,"range":{"start_line":81,"start_character":17,"end_line":81,"end_character":34},"in_reply_to":"8a18039b_e528d97e","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"         $ openstack service create --name cinderv2 \\"},{"line_number":86,"context_line":"          --description \"OpenStack Block Storage\" volumev2"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        +-------------+----------------------------------+"},{"line_number":89,"context_line":"        | Field       | Value                            |"},{"line_number":90,"context_line":"        +-------------+----------------------------------+"},{"line_number":91,"context_line":"        | description | OpenStack Block Storage          |"},{"line_number":92,"context_line":"        | enabled     | True                             |"},{"line_number":93,"context_line":"        | id          | eb9fd245bdbc414695952e93f29fe3ac |"},{"line_number":94,"context_line":"        | name        | cinderv2                         |"},{"line_number":95,"context_line":"        | type        | volumev2                         |"},{"line_number":96,"context_line":"        +-------------+----------------------------------+"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      .. code-block:: console"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"517f45d6_33f7898d","line":96,"range":{"start_line":83,"start_character":0,"end_line":96,"end_character":58},"updated":"2021-06-03 23:40:00.000000000","message":"remove this","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"         $ openstack service create --name cinderv2 \\"},{"line_number":86,"context_line":"          --description \"OpenStack Block Storage\" volumev2"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        +-------------+----------------------------------+"},{"line_number":89,"context_line":"        | Field       | Value                            |"},{"line_number":90,"context_line":"        +-------------+----------------------------------+"},{"line_number":91,"context_line":"        | description | OpenStack Block Storage          |"},{"line_number":92,"context_line":"        | enabled     | True                             |"},{"line_number":93,"context_line":"        | id          | eb9fd245bdbc414695952e93f29fe3ac |"},{"line_number":94,"context_line":"        | name        | cinderv2                         |"},{"line_number":95,"context_line":"        | type        | volumev2                         |"},{"line_number":96,"context_line":"        +-------------+----------------------------------+"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      .. code-block:: console"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"dff838a4_3df5def5","line":96,"range":{"start_line":83,"start_character":0,"end_line":96,"end_character":58},"in_reply_to":"517f45d6_33f7898d","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. Create the Block Storage service API endpoints:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   .. code-block:: console"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"        volumev2 public http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      +--------------+------------------------------------------+"},{"line_number":125,"context_line":"      | Field        | Value                                    |"},{"line_number":126,"context_line":"      +--------------+------------------------------------------+"},{"line_number":127,"context_line":"      | enabled      | True                                     |"},{"line_number":128,"context_line":"      | id           | 513e73819e14460fb904163f41ef3759         |"},{"line_number":129,"context_line":"      | interface    | public                                   |"},{"line_number":130,"context_line":"      | region       | RegionOne                                |"},{"line_number":131,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":132,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":133,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":134,"context_line":"      | service_type | volumev2                                 |"},{"line_number":135,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":136,"context_line":"      +--------------+------------------------------------------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":139,"context_line":"        volumev2 internal http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"      +--------------+------------------------------------------+"},{"line_number":142,"context_line":"      | Field        | Value                                    |"},{"line_number":143,"context_line":"      +--------------+------------------------------------------+"},{"line_number":144,"context_line":"      | enabled      | True                                     |"},{"line_number":145,"context_line":"      | id           | 6436a8a23d014cfdb69c586eff146a32         |"},{"line_number":146,"context_line":"      | interface    | internal                                 |"},{"line_number":147,"context_line":"      | region       | RegionOne                                |"},{"line_number":148,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":149,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":150,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":151,"context_line":"      | service_type | volumev2                                 |"},{"line_number":152,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":153,"context_line":"      +--------------+------------------------------------------+"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":156,"context_line":"        volumev2 admin http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      +--------------+------------------------------------------+"},{"line_number":159,"context_line":"      | Field        | Value                                    |"},{"line_number":160,"context_line":"      +--------------+------------------------------------------+"},{"line_number":161,"context_line":"      | enabled      | True                                     |"},{"line_number":162,"context_line":"      | id           | e652cf84dd334f359ae9b045a2c91d96         |"},{"line_number":163,"context_line":"      | interface    | admin                                    |"},{"line_number":164,"context_line":"      | region       | RegionOne                                |"},{"line_number":165,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":166,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":167,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":168,"context_line":"      | service_type | volumev2                                 |"},{"line_number":169,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":170,"context_line":"      +--------------+------------------------------------------+"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"   .. code-block:: console"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"50636fd9_d108e776","line":170,"range":{"start_line":119,"start_character":0,"end_line":170,"end_character":65},"updated":"2021-06-03 23:40:00.000000000","message":"remove this","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. Create the Block Storage service API endpoints:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   .. code-block:: console"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"        volumev2 public http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      +--------------+------------------------------------------+"},{"line_number":125,"context_line":"      | Field        | Value                                    |"},{"line_number":126,"context_line":"      +--------------+------------------------------------------+"},{"line_number":127,"context_line":"      | enabled      | True                                     |"},{"line_number":128,"context_line":"      | id           | 513e73819e14460fb904163f41ef3759         |"},{"line_number":129,"context_line":"      | interface    | public                                   |"},{"line_number":130,"context_line":"      | region       | RegionOne                                |"},{"line_number":131,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":132,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":133,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":134,"context_line":"      | service_type | volumev2                                 |"},{"line_number":135,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":136,"context_line":"      +--------------+------------------------------------------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":139,"context_line":"        volumev2 internal http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"      +--------------+------------------------------------------+"},{"line_number":142,"context_line":"      | Field        | Value                                    |"},{"line_number":143,"context_line":"      +--------------+------------------------------------------+"},{"line_number":144,"context_line":"      | enabled      | True                                     |"},{"line_number":145,"context_line":"      | id           | 6436a8a23d014cfdb69c586eff146a32         |"},{"line_number":146,"context_line":"      | interface    | internal                                 |"},{"line_number":147,"context_line":"      | region       | RegionOne                                |"},{"line_number":148,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":149,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":150,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":151,"context_line":"      | service_type | volumev2                                 |"},{"line_number":152,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":153,"context_line":"      +--------------+------------------------------------------+"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":156,"context_line":"        volumev2 admin http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      +--------------+------------------------------------------+"},{"line_number":159,"context_line":"      | Field        | Value                                    |"},{"line_number":160,"context_line":"      +--------------+------------------------------------------+"},{"line_number":161,"context_line":"      | enabled      | True                                     |"},{"line_number":162,"context_line":"      | id           | e652cf84dd334f359ae9b045a2c91d96         |"},{"line_number":163,"context_line":"      | interface    | admin                                    |"},{"line_number":164,"context_line":"      | region       | RegionOne                                |"},{"line_number":165,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":166,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":167,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":168,"context_line":"      | service_type | volumev2                                 |"},{"line_number":169,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":170,"context_line":"      +--------------+------------------------------------------+"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"   .. code-block:: console"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"d9c5860c_ff7448ea","line":170,"range":{"start_line":119,"start_character":0,"end_line":170,"end_character":65},"in_reply_to":"50636fd9_d108e776","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/install/cinder-controller-install-rdo.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"         This command provides no output."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"7d52953c_28513e40","line":81,"range":{"start_line":81,"start_character":17,"end_line":81,"end_character":34},"updated":"2021-06-03 23:40:00.000000000","message":"remove this","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"         This command provides no output."},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"bbd7f35a_e7317e3b","line":81,"range":{"start_line":81,"start_character":17,"end_line":81,"end_character":34},"in_reply_to":"7d52953c_28513e40","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"         $ openstack service create --name cinderv2 \\"},{"line_number":86,"context_line":"          --description \"OpenStack Block Storage\" volumev2"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        +-------------+----------------------------------+"},{"line_number":89,"context_line":"        | Field       | Value                            |"},{"line_number":90,"context_line":"        +-------------+----------------------------------+"},{"line_number":91,"context_line":"        | description | OpenStack Block Storage          |"},{"line_number":92,"context_line":"        | enabled     | True                             |"},{"line_number":93,"context_line":"        | id          | eb9fd245bdbc414695952e93f29fe3ac |"},{"line_number":94,"context_line":"        | name        | cinderv2                         |"},{"line_number":95,"context_line":"        | type        | volumev2                         |"},{"line_number":96,"context_line":"        +-------------+----------------------------------+"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      .. code-block:: console"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"ac0c3054_9c2e76c3","line":96,"range":{"start_line":83,"start_character":0,"end_line":96,"end_character":58},"updated":"2021-06-03 23:40:00.000000000","message":"same","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":82,"context_line":""},{"line_number":83,"context_line":"      .. code-block:: console"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"         $ openstack service create --name cinderv2 \\"},{"line_number":86,"context_line":"          --description \"OpenStack Block Storage\" volumev2"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"        +-------------+----------------------------------+"},{"line_number":89,"context_line":"        | Field       | Value                            |"},{"line_number":90,"context_line":"        +-------------+----------------------------------+"},{"line_number":91,"context_line":"        | description | OpenStack Block Storage          |"},{"line_number":92,"context_line":"        | enabled     | True                             |"},{"line_number":93,"context_line":"        | id          | eb9fd245bdbc414695952e93f29fe3ac |"},{"line_number":94,"context_line":"        | name        | cinderv2                         |"},{"line_number":95,"context_line":"        | type        | volumev2                         |"},{"line_number":96,"context_line":"        +-------------+----------------------------------+"},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"      .. code-block:: console"},{"line_number":99,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"93edbf0f_edf6a401","line":96,"range":{"start_line":83,"start_character":0,"end_line":96,"end_character":58},"in_reply_to":"ac0c3054_9c2e76c3","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. Create the Block Storage service API endpoints:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   .. code-block:: console"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"        volumev2 public http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      +--------------+------------------------------------------+"},{"line_number":125,"context_line":"      | Field        | Value                                    |"},{"line_number":126,"context_line":"      +--------------+------------------------------------------+"},{"line_number":127,"context_line":"      | enabled      | True                                     |"},{"line_number":128,"context_line":"      | id           | 513e73819e14460fb904163f41ef3759         |"},{"line_number":129,"context_line":"      | interface    | public                                   |"},{"line_number":130,"context_line":"      | region       | RegionOne                                |"},{"line_number":131,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":132,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":133,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":134,"context_line":"      | service_type | volumev2                                 |"},{"line_number":135,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":136,"context_line":"      +--------------+------------------------------------------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":139,"context_line":"        volumev2 internal http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"      +--------------+------------------------------------------+"},{"line_number":142,"context_line":"      | Field        | Value                                    |"},{"line_number":143,"context_line":"      +--------------+------------------------------------------+"},{"line_number":144,"context_line":"      | enabled      | True                                     |"},{"line_number":145,"context_line":"      | id           | 6436a8a23d014cfdb69c586eff146a32         |"},{"line_number":146,"context_line":"      | interface    | internal                                 |"},{"line_number":147,"context_line":"      | region       | RegionOne                                |"},{"line_number":148,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":149,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":150,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":151,"context_line":"      | service_type | volumev2                                 |"},{"line_number":152,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":153,"context_line":"      +--------------+------------------------------------------+"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":156,"context_line":"        volumev2 admin http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      +--------------+------------------------------------------+"},{"line_number":159,"context_line":"      | Field        | Value                                    |"},{"line_number":160,"context_line":"      +--------------+------------------------------------------+"},{"line_number":161,"context_line":"      | enabled      | True                                     |"},{"line_number":162,"context_line":"      | id           | e652cf84dd334f359ae9b045a2c91d96         |"},{"line_number":163,"context_line":"      | interface    | admin                                    |"},{"line_number":164,"context_line":"      | region       | RegionOne                                |"},{"line_number":165,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":166,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":167,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":168,"context_line":"      | service_type | volumev2                                 |"},{"line_number":169,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":170,"context_line":"      +--------------+------------------------------------------+"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"   .. code-block:: console"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3933d4bf_e68848ff","line":170,"range":{"start_line":119,"start_character":0,"end_line":170,"end_character":65},"updated":"2021-06-03 23:40:00.000000000","message":"same","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":116,"context_line":""},{"line_number":117,"context_line":"#. Create the Block Storage service API endpoints:"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"   .. code-block:: console"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":122,"context_line":"        volumev2 public http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":123,"context_line":""},{"line_number":124,"context_line":"      +--------------+------------------------------------------+"},{"line_number":125,"context_line":"      | Field        | Value                                    |"},{"line_number":126,"context_line":"      +--------------+------------------------------------------+"},{"line_number":127,"context_line":"      | enabled      | True                                     |"},{"line_number":128,"context_line":"      | id           | 513e73819e14460fb904163f41ef3759         |"},{"line_number":129,"context_line":"      | interface    | public                                   |"},{"line_number":130,"context_line":"      | region       | RegionOne                                |"},{"line_number":131,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":132,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":133,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":134,"context_line":"      | service_type | volumev2                                 |"},{"line_number":135,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":136,"context_line":"      +--------------+------------------------------------------+"},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":139,"context_line":"        volumev2 internal http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"      +--------------+------------------------------------------+"},{"line_number":142,"context_line":"      | Field        | Value                                    |"},{"line_number":143,"context_line":"      +--------------+------------------------------------------+"},{"line_number":144,"context_line":"      | enabled      | True                                     |"},{"line_number":145,"context_line":"      | id           | 6436a8a23d014cfdb69c586eff146a32         |"},{"line_number":146,"context_line":"      | interface    | internal                                 |"},{"line_number":147,"context_line":"      | region       | RegionOne                                |"},{"line_number":148,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":149,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":150,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":151,"context_line":"      | service_type | volumev2                                 |"},{"line_number":152,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":153,"context_line":"      +--------------+------------------------------------------+"},{"line_number":154,"context_line":""},{"line_number":155,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":156,"context_line":"        volumev2 admin http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"      +--------------+------------------------------------------+"},{"line_number":159,"context_line":"      | Field        | Value                                    |"},{"line_number":160,"context_line":"      +--------------+------------------------------------------+"},{"line_number":161,"context_line":"      | enabled      | True                                     |"},{"line_number":162,"context_line":"      | id           | e652cf84dd334f359ae9b045a2c91d96         |"},{"line_number":163,"context_line":"      | interface    | admin                                    |"},{"line_number":164,"context_line":"      | region       | RegionOne                                |"},{"line_number":165,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":166,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":167,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":168,"context_line":"      | service_type | volumev2                                 |"},{"line_number":169,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":170,"context_line":"      +--------------+------------------------------------------+"},{"line_number":171,"context_line":""},{"line_number":172,"context_line":"   .. code-block:: console"},{"line_number":173,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"de04b0c1_3e6984ef","line":170,"range":{"start_line":119,"start_character":0,"end_line":170,"end_character":65},"in_reply_to":"3933d4bf_e68848ff","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"doc/source/install/cinder-controller-install-ubuntu.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"         This command provides no output."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      .. code-block:: console"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"b971ffbb_b458e071","line":82,"range":{"start_line":82,"start_character":17,"end_line":82,"end_character":34},"updated":"2021-06-03 23:40:00.000000000","message":"remove this","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":79,"context_line":""},{"line_number":80,"context_line":"         This command provides no output."},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      .. code-block:: console"},{"line_number":85,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"233d50fd_8dec11c2","line":82,"range":{"start_line":82,"start_character":17,"end_line":82,"end_character":34},"in_reply_to":"b971ffbb_b458e071","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      .. code-block:: console"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"         $ openstack service create --name cinderv2 \\"},{"line_number":87,"context_line":"           --description \"OpenStack Block Storage\" volumev2"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"         +-------------+----------------------------------+"},{"line_number":90,"context_line":"         | Field       | Value                            |"},{"line_number":91,"context_line":"         +-------------+----------------------------------+"},{"line_number":92,"context_line":"         | description | OpenStack Block Storage          |"},{"line_number":93,"context_line":"         | enabled     | True                             |"},{"line_number":94,"context_line":"         | id          | eb9fd245bdbc414695952e93f29fe3ac |"},{"line_number":95,"context_line":"         | name        | cinderv2                         |"},{"line_number":96,"context_line":"         | type        | volumev2                         |"},{"line_number":97,"context_line":"         +-------------+----------------------------------+"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"      .. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"64da530f_eef7915d","line":97,"range":{"start_line":84,"start_character":0,"end_line":97,"end_character":59},"updated":"2021-06-03 23:40:00.000000000","message":"same","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":81,"context_line":""},{"line_number":82,"context_line":"   #. Create the ``cinderv2`` and ``cinderv3`` service entities:"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      .. code-block:: console"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"         $ openstack service create --name cinderv2 \\"},{"line_number":87,"context_line":"           --description \"OpenStack Block Storage\" volumev2"},{"line_number":88,"context_line":""},{"line_number":89,"context_line":"         +-------------+----------------------------------+"},{"line_number":90,"context_line":"         | Field       | Value                            |"},{"line_number":91,"context_line":"         +-------------+----------------------------------+"},{"line_number":92,"context_line":"         | description | OpenStack Block Storage          |"},{"line_number":93,"context_line":"         | enabled     | True                             |"},{"line_number":94,"context_line":"         | id          | eb9fd245bdbc414695952e93f29fe3ac |"},{"line_number":95,"context_line":"         | name        | cinderv2                         |"},{"line_number":96,"context_line":"         | type        | volumev2                         |"},{"line_number":97,"context_line":"         +-------------+----------------------------------+"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"      .. code-block:: console"},{"line_number":100,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"15379468_ac60f866","line":97,"range":{"start_line":84,"start_character":0,"end_line":97,"end_character":59},"in_reply_to":"64da530f_eef7915d","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"#. Create the Block Storage service API endpoints:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"   .. code-block:: console"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":123,"context_line":"        volumev2 public http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"      +--------------+------------------------------------------+"},{"line_number":126,"context_line":"      | Field        | Value                                    |"},{"line_number":127,"context_line":"      +--------------+------------------------------------------+"},{"line_number":128,"context_line":"      | enabled      | True                                     |"},{"line_number":129,"context_line":"      | id           | 513e73819e14460fb904163f41ef3759         |"},{"line_number":130,"context_line":"      | interface    | public                                   |"},{"line_number":131,"context_line":"      | region       | RegionOne                                |"},{"line_number":132,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":133,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":134,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":135,"context_line":"      | service_type | volumev2                                 |"},{"line_number":136,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":137,"context_line":"      +--------------+------------------------------------------+"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":140,"context_line":"        volumev2 internal http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      +--------------+------------------------------------------+"},{"line_number":143,"context_line":"      | Field        | Value                                    |"},{"line_number":144,"context_line":"      +--------------+------------------------------------------+"},{"line_number":145,"context_line":"      | enabled      | True                                     |"},{"line_number":146,"context_line":"      | id           | 6436a8a23d014cfdb69c586eff146a32         |"},{"line_number":147,"context_line":"      | interface    | internal                                 |"},{"line_number":148,"context_line":"      | region       | RegionOne                                |"},{"line_number":149,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":150,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":151,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":152,"context_line":"      | service_type | volumev2                                 |"},{"line_number":153,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":154,"context_line":"      +--------------+------------------------------------------+"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":157,"context_line":"        volumev2 admin http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      +--------------+------------------------------------------+"},{"line_number":160,"context_line":"      | Field        | Value                                    |"},{"line_number":161,"context_line":"      +--------------+------------------------------------------+"},{"line_number":162,"context_line":"      | enabled      | True                                     |"},{"line_number":163,"context_line":"      | id           | e652cf84dd334f359ae9b045a2c91d96         |"},{"line_number":164,"context_line":"      | interface    | admin                                    |"},{"line_number":165,"context_line":"      | region       | RegionOne                                |"},{"line_number":166,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":167,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":168,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":169,"context_line":"      | service_type | volumev2                                 |"},{"line_number":170,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":171,"context_line":"      +--------------+------------------------------------------+"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"   .. code-block:: console"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"9cd0d48f_211a2f95","line":171,"range":{"start_line":120,"start_character":0,"end_line":171,"end_character":65},"updated":"2021-06-03 23:40:00.000000000","message":"same","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":false,"context_lines":[{"line_number":117,"context_line":""},{"line_number":118,"context_line":"#. Create the Block Storage service API endpoints:"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"   .. code-block:: console"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":123,"context_line":"        volumev2 public http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"      +--------------+------------------------------------------+"},{"line_number":126,"context_line":"      | Field        | Value                                    |"},{"line_number":127,"context_line":"      +--------------+------------------------------------------+"},{"line_number":128,"context_line":"      | enabled      | True                                     |"},{"line_number":129,"context_line":"      | id           | 513e73819e14460fb904163f41ef3759         |"},{"line_number":130,"context_line":"      | interface    | public                                   |"},{"line_number":131,"context_line":"      | region       | RegionOne                                |"},{"line_number":132,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":133,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":134,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":135,"context_line":"      | service_type | volumev2                                 |"},{"line_number":136,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":137,"context_line":"      +--------------+------------------------------------------+"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":140,"context_line":"        volumev2 internal http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"      +--------------+------------------------------------------+"},{"line_number":143,"context_line":"      | Field        | Value                                    |"},{"line_number":144,"context_line":"      +--------------+------------------------------------------+"},{"line_number":145,"context_line":"      | enabled      | True                                     |"},{"line_number":146,"context_line":"      | id           | 6436a8a23d014cfdb69c586eff146a32         |"},{"line_number":147,"context_line":"      | interface    | internal                                 |"},{"line_number":148,"context_line":"      | region       | RegionOne                                |"},{"line_number":149,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":150,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":151,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":152,"context_line":"      | service_type | volumev2                                 |"},{"line_number":153,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":154,"context_line":"      +--------------+------------------------------------------+"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"      $ openstack endpoint create --region RegionOne \\"},{"line_number":157,"context_line":"        volumev2 admin http://controller:8776/v2/%\\(project_id\\)s"},{"line_number":158,"context_line":""},{"line_number":159,"context_line":"      +--------------+------------------------------------------+"},{"line_number":160,"context_line":"      | Field        | Value                                    |"},{"line_number":161,"context_line":"      +--------------+------------------------------------------+"},{"line_number":162,"context_line":"      | enabled      | True                                     |"},{"line_number":163,"context_line":"      | id           | e652cf84dd334f359ae9b045a2c91d96         |"},{"line_number":164,"context_line":"      | interface    | admin                                    |"},{"line_number":165,"context_line":"      | region       | RegionOne                                |"},{"line_number":166,"context_line":"      | region_id    | RegionOne                                |"},{"line_number":167,"context_line":"      | service_id   | eb9fd245bdbc414695952e93f29fe3ac         |"},{"line_number":168,"context_line":"      | service_name | cinderv2                                 |"},{"line_number":169,"context_line":"      | service_type | volumev2                                 |"},{"line_number":170,"context_line":"      | url          | http://controller:8776/v2/%(project_id)s |"},{"line_number":171,"context_line":"      +--------------+------------------------------------------+"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"   .. code-block:: console"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"6c8a322f_beb2fc36","line":171,"range":{"start_line":120,"start_character":0,"end_line":171,"end_character":65},"in_reply_to":"9cd0d48f_211a2f95","updated":"2021-06-04 21:07:37.000000000","message":"Done","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"}],"etc/cinder/api-paste.ini":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"2265fa8add0612081d7531971bd2d0507daa76c4","unresolved":true,"context_lines":[{"line_number":52,"context_line":"[filter:keystonecontext]"},{"line_number":53,"context_line":"paste.filter_factory \u003d cinder.api.middleware.auth:CinderKeystoneContext.factory"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"98a1a1d8_79c51c3e","line":55,"updated":"2021-05-27 14:18:47.000000000","message":"extra lines added here?","commit_id":"f79c7d2d1fb8962f2df08957c527598d042e4947"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"314ce1dce6d0361b598f16e25bf0eb8c3e117a29","unresolved":true,"context_lines":[{"line_number":52,"context_line":"[filter:keystonecontext]"},{"line_number":53,"context_line":"paste.filter_factory \u003d cinder.api.middleware.auth:CinderKeystoneContext.factory"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":""},{"line_number":57,"context_line":""},{"line_number":58,"context_line":""}],"source_content_type":"text/x-properties","patch_set":3,"id":"e2513f2a_7323e12d","line":55,"in_reply_to":"98a1a1d8_79c51c3e","updated":"2021-05-27 17:34:49.000000000","message":"Not sure what happened here, will fix.","commit_id":"f79c7d2d1fb8962f2df08957c527598d042e4947"}],"rally-jobs/cinder.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"66e83d91e218cccbe6708e81726850097ce1e58f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b1fc4793_d96d732a","updated":"2021-06-03 23:40:00.000000000","message":"The rally job scenarios are run against cinder v2 in this file\nI\u0027m not sure if we are certain rally is not using v2","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ace556dc27320f42ab6376770576a960a792bb7c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b306ea12_f300ce53","in_reply_to":"b1fc4793_d96d732a","updated":"2021-06-04 21:07:37.000000000","message":"Hopefully rally is configurable ... thanks for catching this.  I\u0027ll change this file and also put up a patch to change the parent job:\n\nhttps://review.opendev.org/c/openstack/rally-openstack/+/794891","commit_id":"722b2c50676ce9e40264e9976de74646069562bf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3325d2ab24054efbcaad85eb01a1002b5d2d42d8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"{% set image_name \u003d \"^(cirros.*-disk|TestVM)$\" %}"},{"line_number":2,"context_line":"---"},{"line_number":3,"context_line":"  version: 3"},{"line_number":4,"context_line":"  title: Rally task for cinder-rally-task check job (non-voting)"},{"line_number":5,"context_line":"  subtasks:"},{"line_number":6,"context_line":"    -"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f94e4bbb_be09878d","line":3,"updated":"2021-06-04 21:22:59.000000000","message":"turns out that this is the version of the Rally Task Schema, not the version of this particular task","commit_id":"4aff0406eb28d26ca2a0ea74c4e2be1e6db87aca"}]}