)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7ea1c67b30246f257c2c4b4319ea50378c0de4ac","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-20 13:36:58 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix minimum SDK version required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibab932d3536d44dd7414560768ed5bdeaa9e61e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"2bc12edf_3b002be2","line":7,"updated":"2021-05-20 18:18:18.000000000","message":"This should mention that this is about the Pure driver.","commit_id":"1e862b964c2795ad3d81e8df5a5c2923d64627b1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3d7ffacf08b130a2548183b45534f8b14b6d4d68","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Simon Dodsley \u003csimon@purestorage.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-05-20 13:36:58 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix minimum SDK version required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ibab932d3536d44dd7414560768ed5bdeaa9e61e1"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"b5ebf1c1_95a862b4","line":7,"in_reply_to":"2bc12edf_3b002be2","updated":"2021-05-20 20:23:15.000000000","message":"Done","commit_id":"1e862b964c2795ad3d81e8df5a5c2923d64627b1"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e48de0dd206843505f038858719c105ff29135ce","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[Pure Storage] Fix minimum SDK version required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change method to check supported REST versin on the backend."},{"line_number":10,"context_line":"This will mkae it easier to specify minimum REST versions for"},{"line_number":11,"context_line":"specific feature support."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"419ecbd0_34241cd9","line":9,"range":{"start_line":9,"start_character":38,"end_line":9,"end_character":44},"updated":"2021-06-17 19:18:46.000000000","message":"version","commit_id":"b44ba7bfe554176d4363ae9f70d28153203d5264"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c66609fa53972889e53b7a766bbf85dd1865e282","unresolved":true,"context_lines":[{"line_number":7,"context_line":"[Pure Storage] Fix minimum SDK version required"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change method to check supported REST version on the backend."},{"line_number":10,"context_line":"This will mkae it easier to specify minimum REST versions for"},{"line_number":11,"context_line":"specific feature support."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Closes-Bug: #1929219"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"a78c8b42_7988bf9d","line":10,"range":{"start_line":10,"start_character":10,"end_line":10,"end_character":14},"updated":"2021-06-30 16:49:30.000000000","message":"make","commit_id":"49848a7674b3a502e7cf6d610f0dc5d2dddbd642"}],"cinder/tests/unit/volume/drivers/test_pure.py":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"33f5a0de5e141752ccf446a315592e110c03f399","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    \"iqn\": [],"},{"line_number":115,"context_line":"    \"wwn\": [],"},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":"# REST_VERSION \u003d \"1.2\""},{"line_number":118,"context_line":"INITIATOR_IQN \u003d \"iqn.1993-08.org.debian:01:222\""},{"line_number":119,"context_line":"INITIATOR_WWN \u003d \"5001500150015081abc\""},{"line_number":120,"context_line":"ISCSI_CONNECTOR \u003d {\"initiator\": INITIATOR_IQN, \"host\": HOSTNAME}"}],"source_content_type":"text/x-python","patch_set":9,"id":"5e4a977f_7aaecf68","line":117,"updated":"2021-06-18 14:29:11.000000000","message":"Did you mean to leave this commented out? It should either have more comments with it explaining why it\u0027s here, or it should be removed.","commit_id":"3166900303fc95fea30ffe450af0fff5a2171c71"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1bbc50b7f03a83c47a05ec736f15a3a9419585fe","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    \"iqn\": [],"},{"line_number":115,"context_line":"    \"wwn\": [],"},{"line_number":116,"context_line":"}"},{"line_number":117,"context_line":"# REST_VERSION \u003d \"1.2\""},{"line_number":118,"context_line":"INITIATOR_IQN \u003d \"iqn.1993-08.org.debian:01:222\""},{"line_number":119,"context_line":"INITIATOR_WWN \u003d \"5001500150015081abc\""},{"line_number":120,"context_line":"ISCSI_CONNECTOR \u003d {\"initiator\": INITIATOR_IQN, \"host\": HOSTNAME}"}],"source_content_type":"text/x-python","patch_set":9,"id":"742ae05b_d8565174","line":117,"in_reply_to":"5e4a977f_7aaecf68","updated":"2021-06-18 15:50:45.000000000","message":"Done","commit_id":"3166900303fc95fea30ffe450af0fff5a2171c71"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"33f5a0de5e141752ccf446a315592e110c03f399","unresolved":true,"context_lines":[{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"PERF_INFO \u003d {"},{"line_number":208,"context_line":"    \"writes_per_sec\": 318,"},{"line_number":209,"context_line":"    \"usec_per_write_op\": 255,"},{"line_number":210,"context_line":"    \"output_per_sec\": 234240,"},{"line_number":211,"context_line":"    \"reads_per_sec\": 15,"}],"source_content_type":"text/x-python","patch_set":9,"id":"fd12ea4f_b889954e","line":208,"updated":"2021-06-18 14:29:11.000000000","message":"No reason to change these.","commit_id":"3166900303fc95fea30ffe450af0fff5a2171c71"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1bbc50b7f03a83c47a05ec736f15a3a9419585fe","unresolved":false,"context_lines":[{"line_number":205,"context_line":"}"},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"PERF_INFO \u003d {"},{"line_number":208,"context_line":"    \"writes_per_sec\": 318,"},{"line_number":209,"context_line":"    \"usec_per_write_op\": 255,"},{"line_number":210,"context_line":"    \"output_per_sec\": 234240,"},{"line_number":211,"context_line":"    \"reads_per_sec\": 15,"}],"source_content_type":"text/x-python","patch_set":9,"id":"bc31a76e_f8d01c61","line":208,"in_reply_to":"fd12ea4f_b889954e","updated":"2021-06-18 15:50:45.000000000","message":"style disagreements aside... let\u0027s discuss `black` offline","commit_id":"3166900303fc95fea30ffe450af0fff5a2171c71"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2ec94014d4e23041606a69f34a8911ecb41cff43","unresolved":true,"context_lines":[{"line_number":626,"context_line":"        self.driver._replication_pod_name \u003d \u0027cinder-pod\u0027"},{"line_number":627,"context_line":"        self.driver._replication_pg_name \u003d \u0027cinder-group\u0027"},{"line_number":628,"context_line":"        self.array._list_available_rest_versions.return_value \u003d ["},{"line_number":629,"context_line":"            \u00271.0\u0027, \u00271.1\u0027, \u00271.2\u0027, \u00271.3\u0027, \u00271.4\u0027, \u00271.5\u0027, \u00271.6\u0027, \u00271.7\u0027, \u00271.8\u0027,"},{"line_number":630,"context_line":"            \u00271.9\u0027, \u00271.10\u0027, \u00271.11\u0027, \u00271.12\u0027, \u00271.13\u0027, \u00271.14\u0027, \u00271.15\u0027, \u00271.16\u0027,"},{"line_number":631,"context_line":"            \u00271.17\u0027, \u00271.18\u0027, \u00271.19\u0027]"},{"line_number":632,"context_line":"        self.purestorage_module.FlashArray.side_effect \u003d None"}],"source_content_type":"text/x-python","patch_set":18,"id":"41672c72_a176e19e","line":629,"updated":"2021-06-24 14:24:04.000000000","message":"Just a comment for possible future clean up, but since this same assignment is duplicated so many times, it might be worth setting a constant and just assigning that in each case.","commit_id":"9ec8e1654c7ccbd1c48cd44d57aa36b202af06bd"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e48de0dd206843505f038858719c105ff29135ce","unresolved":true,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        # Raises PureDriverException if unable to connect and PureHTTPError"},{"line_number":444,"context_line":"        # if unable to authenticate."},{"line_number":445,"context_line":"        #       purestorage.FlashArray.supported_rest_versions \u003d \\"},{"line_number":446,"context_line":"        #           self.SUPPORTED_REST_API_VERSIONS"},{"line_number":447,"context_line":"        self._array \u003d self._get_flasharray("},{"line_number":448,"context_line":"            self.configuration.san_ip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"daa3ac5e_dab37899","line":445,"updated":"2021-06-17 19:18:46.000000000","message":"Commented out code should not be checked in.","commit_id":"b44ba7bfe554176d4363ae9f70d28153203d5264"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c4e3caf6a721ab903fbd3f7b08260710e4615bb8","unresolved":false,"context_lines":[{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        # Raises PureDriverException if unable to connect and PureHTTPError"},{"line_number":444,"context_line":"        # if unable to authenticate."},{"line_number":445,"context_line":"        #       purestorage.FlashArray.supported_rest_versions \u003d \\"},{"line_number":446,"context_line":"        #           self.SUPPORTED_REST_API_VERSIONS"},{"line_number":447,"context_line":"        self._array \u003d self._get_flasharray("},{"line_number":448,"context_line":"            self.configuration.san_ip,"}],"source_content_type":"text/x-python","patch_set":8,"id":"259c22ca_1aec8abb","line":445,"in_reply_to":"daa3ac5e_dab37899","updated":"2021-06-17 19:25:33.000000000","message":"Done","commit_id":"b44ba7bfe554176d4363ae9f70d28153203d5264"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"68656f115202e620c1ecd5e16361d61d4c6b3f6f","unresolved":true,"context_lines":[{"line_number":238,"context_line":"    \"\"\"Performs volume management on Pure Storage FlashArray.\"\"\""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    #    SUPPORTED_REST_API_VERSIONS \u003d [\u00271.2\u0027, \u00271.3\u0027, \u00271.4\u0027, \u00271.5\u0027,"},{"line_number":241,"context_line":"    #                                   \u00271.13\u0027, \u00271.14\u0027, \u00271.17\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":244,"context_line":"    PURE_QOS_KEYS \u003d [\"maxIOPS\", \"maxBWS\"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"13a95fe0_a3c3ad3c","line":241,"updated":"2021-06-18 15:30:08.000000000","message":"supposed to be entirely commented out?  If not needed, then just nuke it.","commit_id":"3166900303fc95fea30ffe450af0fff5a2171c71"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"1bbc50b7f03a83c47a05ec736f15a3a9419585fe","unresolved":false,"context_lines":[{"line_number":238,"context_line":"    \"\"\"Performs volume management on Pure Storage FlashArray.\"\"\""},{"line_number":239,"context_line":""},{"line_number":240,"context_line":"    #    SUPPORTED_REST_API_VERSIONS \u003d [\u00271.2\u0027, \u00271.3\u0027, \u00271.4\u0027, \u00271.5\u0027,"},{"line_number":241,"context_line":"    #                                   \u00271.13\u0027, \u00271.14\u0027, \u00271.17\u0027]"},{"line_number":242,"context_line":""},{"line_number":243,"context_line":"    SUPPORTS_ACTIVE_ACTIVE \u003d True"},{"line_number":244,"context_line":"    PURE_QOS_KEYS \u003d [\"maxIOPS\", \"maxBWS\"]"}],"source_content_type":"text/x-python","patch_set":9,"id":"054bd8ba_6a334312","line":241,"in_reply_to":"13a95fe0_a3c3ad3c","updated":"2021-06-18 15:50:45.000000000","message":"Done","commit_id":"3166900303fc95fea30ffe450af0fff5a2171c71"}],"driver-requirements.txt":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"7ea1c67b30246f257c2c4b4319ea50378c0de4ac","unresolved":true,"context_lines":[{"line_number":9,"context_line":"krest\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Pure Storage"},{"line_number":12,"context_line":"purestorage\u003e\u003d1.6.0 # BSD"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Dell EMC VMAX, IBM DS8K"},{"line_number":15,"context_line":"pyOpenSSL\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"f31748d9_3d054ec4","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":18},"updated":"2021-05-20 18:18:18.000000000","message":"Please bump the version number here in driver-requirements.txt too.","commit_id":"1e862b964c2795ad3d81e8df5a5c2923d64627b1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"3d7ffacf08b130a2548183b45534f8b14b6d4d68","unresolved":false,"context_lines":[{"line_number":9,"context_line":"krest\u003e\u003d1.3.0 # Apache-2.0"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"# Pure Storage"},{"line_number":12,"context_line":"purestorage\u003e\u003d1.6.0 # BSD"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Dell EMC VMAX, IBM DS8K"},{"line_number":15,"context_line":"pyOpenSSL\u003e\u003d1.0.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":1,"id":"521e2878_ef70cc71","line":12,"range":{"start_line":12,"start_character":0,"end_line":12,"end_character":18},"in_reply_to":"f31748d9_3d054ec4","updated":"2021-05-20 20:23:15.000000000","message":"Done","commit_id":"1e862b964c2795ad3d81e8df5a5c2923d64627b1"}],"releasenotes/notes/pure_sdk_version_checks-257cb8387ed6f5f8.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"2ec94014d4e23041606a69f34a8911ecb41cff43","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pure Storage FlashArray - change internal mechanism for checking REST API"},{"line_number":5,"context_line":"    support to ensure correct features and functionality are made available to"},{"line_number":6,"context_line":"    users. This has no external effect for users."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"9b7bf4ee_b670b067","line":6,"updated":"2021-06-24 14:24:04.000000000","message":"If this is an internal thing and has no impact on users, I\u0027m not so sure we need a release note for it.","commit_id":"9ec8e1654c7ccbd1c48cd44d57aa36b202af06bd"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"07335c1c27122b986163f8af8f78b12b73bf3350","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pure Storage FlashArray - change internal mechanism for checking REST API"},{"line_number":5,"context_line":"    support to ensure correct features and functionality are made available to"},{"line_number":6,"context_line":"    users. This has no external effect for users."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"1a92aa31_b928f5a5","line":6,"in_reply_to":"663b3ee7_49e3326d","updated":"2021-06-28 21:45:42.000000000","message":"Done","commit_id":"9ec8e1654c7ccbd1c48cd44d57aa36b202af06bd"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"969d7498e619412477cb6f5af6d313799266331e","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Pure Storage FlashArray - change internal mechanism for checking REST API"},{"line_number":5,"context_line":"    support to ensure correct features and functionality are made available to"},{"line_number":6,"context_line":"    users. This has no external effect for users."}],"source_content_type":"text/x-yaml","patch_set":18,"id":"663b3ee7_49e3326d","line":6,"in_reply_to":"9b7bf4ee_b670b067","updated":"2021-06-28 21:12:05.000000000","message":"From the bug report, it looks like you\u0027d a least see some weird stuff in the logs, so maybe it\u0027s worth mentioning.  If you do keep it, please use the standard release note format for a bugfix:\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers\n\nAlso, you should probably add an \"upgrade:\" section to the release note stating that the minimum supported Pure Storage REST API version is now 1.17.0.","commit_id":"9ec8e1654c7ccbd1c48cd44d57aa36b202af06bd"}],"setup.cfg":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"969d7498e619412477cb6f5af6d313799266331e","unresolved":true,"context_lines":[{"line_number":110,"context_line":"infinidat \u003d"},{"line_number":111,"context_line":"    infinisdk\u003e\u003d103.0.1 # BSD-3"},{"line_number":112,"context_line":"pure \u003d"},{"line_number":113,"context_line":"    purestorage\u003e\u003d1.6.0 # BSD"},{"line_number":114,"context_line":"rsd \u003d"},{"line_number":115,"context_line":"    rsd-lib\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":116,"context_line":"storpool \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"bc4689f8_579b5e54","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":28},"updated":"2021-06-28 21:12:05.000000000","message":"Need to update this to be compatible with driver-req.txt (also line 88)","commit_id":"9ec8e1654c7ccbd1c48cd44d57aa36b202af06bd"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"07335c1c27122b986163f8af8f78b12b73bf3350","unresolved":false,"context_lines":[{"line_number":110,"context_line":"infinidat \u003d"},{"line_number":111,"context_line":"    infinisdk\u003e\u003d103.0.1 # BSD-3"},{"line_number":112,"context_line":"pure \u003d"},{"line_number":113,"context_line":"    purestorage\u003e\u003d1.6.0 # BSD"},{"line_number":114,"context_line":"rsd \u003d"},{"line_number":115,"context_line":"    rsd-lib\u003e\u003d1.1.0 # Apache-2.0"},{"line_number":116,"context_line":"storpool \u003d"}],"source_content_type":"text/x-ttcn-cfg","patch_set":18,"id":"6a53d361_7c3cf8f5","line":113,"range":{"start_line":113,"start_character":4,"end_line":113,"end_character":28},"in_reply_to":"bc4689f8_579b5e54","updated":"2021-06-28 21:45:42.000000000","message":"Done","commit_id":"9ec8e1654c7ccbd1c48cd44d57aa36b202af06bd"}]}