)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0c5f3180db83a018928000dd4ae2f3a70bd99029","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c3267e66_329d1d57","updated":"2022-05-27 15:03:20.000000000","message":"LGTM","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3c3656f8b92e53fdd5bf115c2ee020f333aa59e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7a64810e_a990a95e","updated":"2022-05-27 15:12:55.000000000","message":"Thanks for reply! Upgrading my vote","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"}],"cinder/volume/manager.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"34cff8d0b62df60bceb37fdb2727a01af36c6081","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        # and the volume status updated."},{"line_number":1996,"context_line":"        utils.require_driver_initialized(self.driver)"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        volume_ref \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":1999,"context_line":"        try:"},{"line_number":2000,"context_line":"            self.driver.terminate_connection(volume_ref, connector,"},{"line_number":2001,"context_line":"                                             force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f242962d_a017edee","line":1998,"updated":"2021-06-18 15:26:23.000000000","message":"There are several other places in manager.py that fetch a DB objects instead of an OVO. I\u0027d like to hear from the core reviewers whether it\u0027s appropriate to update the other instances (all of them?). Is fetching an OVO generally \"better\" and fetching a DB object? Is there any downside to fetching an OVO?","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0c5f3180db83a018928000dd4ae2f3a70bd99029","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        # and the volume status updated."},{"line_number":1996,"context_line":"        utils.require_driver_initialized(self.driver)"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        volume_ref \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":1999,"context_line":"        try:"},{"line_number":2000,"context_line":"            self.driver.terminate_connection(volume_ref, connector,"},{"line_number":2001,"context_line":"                                             force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2089a1bd_e3963fc4","line":1998,"in_reply_to":"0c747a39_f81ffb30","updated":"2022-05-27 15:03:20.000000000","message":"+1, OVOs provide much more features than a python dict and the general goal is to move most if not all code to using OVOs.","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f2e9d3f2902f768bc46e1a75a93544692f55b3db","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        # and the volume status updated."},{"line_number":1996,"context_line":"        utils.require_driver_initialized(self.driver)"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        volume_ref \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":1999,"context_line":"        try:"},{"line_number":2000,"context_line":"            self.driver.terminate_connection(volume_ref, connector,"},{"line_number":2001,"context_line":"                                             force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0c747a39_f81ffb30","line":1998,"in_reply_to":"ad7ffb59_96f7cd13","updated":"2022-05-27 14:08:31.000000000","message":"This is the right approach to take in the code -- using dicts for Volumes is a compatibility measure, we should move to using OVOs.\n\nBut, I agree that the commit message probably could explain this change better.","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"c765090b7ccd55b875f50a5ee1ca2990b799a25a","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        # and the volume status updated."},{"line_number":1996,"context_line":"        utils.require_driver_initialized(self.driver)"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        volume_ref \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":1999,"context_line":"        try:"},{"line_number":2000,"context_line":"            self.driver.terminate_connection(volume_ref, connector,"},{"line_number":2001,"context_line":"                                             force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":1,"id":"f644f863_de0c001b","line":1998,"in_reply_to":"f242962d_a017edee","updated":"2021-06-18 15:35:48.000000000","message":"+1","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"8c811a00302133df17bf1950f9835df3e3a45b5e","unresolved":true,"context_lines":[{"line_number":1995,"context_line":"        # and the volume status updated."},{"line_number":1996,"context_line":"        utils.require_driver_initialized(self.driver)"},{"line_number":1997,"context_line":""},{"line_number":1998,"context_line":"        volume_ref \u003d objects.Volume.get_by_id(context, volume_id)"},{"line_number":1999,"context_line":"        try:"},{"line_number":2000,"context_line":"            self.driver.terminate_connection(volume_ref, connector,"},{"line_number":2001,"context_line":"                                             force\u003dforce)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ad7ffb59_96f7cd13","line":1998,"in_reply_to":"f644f863_de0c001b","updated":"2021-11-19 17:01:05.000000000","message":"+1 I think I had this discussion with Gorka a while ago. My assumption is that we should update everywhere but I\u0027d like to hear from him before.","commit_id":"049549eebc1c43666b1a395d8402592cad0e07f7"}]}