)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"151703e858e78292bbfb166e8a31eadb87f7200f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"54c9bbc2_04c1a59a","updated":"2022-02-22 08:59:17.000000000","message":"There are two patches 796170 and 829877 named \"Add GAD Volume Support\". What is the difference? If 796170 and 829877 are the same patch, why not just throw one of them away?","commit_id":"3f865636d014c43395ad58085c68c8d299e1d54b"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"9506ff95565b46b2ef3dbfefdb9c4036a89f665d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2c1f657d_fafa63e1","updated":"2022-02-22 00:35:56.000000000","message":"recheck","commit_id":"3f865636d014c43395ad58085c68c8d299e1d54b"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"2d22f862af1891c287365aed55a452090f41b2fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7a893acb_50ad4dd2","in_reply_to":"54c9bbc2_04c1a59a","updated":"2022-02-24 01:11:29.000000000","message":"Patch 829877 has been removed(abandon) because the patch might be opened by my mistake.I wanted to upload to 796170(this patch), but new change-id was added.\nThis patch will be updated from now on.","commit_id":"3f865636d014c43395ad58085c68c8d299e1d54b"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"78b114767107c0f826522dd4936eb3e878a9d013","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c213ee2b_10a76135","updated":"2022-03-10 12:49:55.000000000","message":"run-Hitachi VSP CI","commit_id":"4539acd9d1ac09415861eb216db3f1f525bbb089"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"16860f4354f989ea00cd55df51231fe9434ec2e5","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"fcea7e1e_f3ef90e5","updated":"2023-01-18 13:36:56.000000000","message":"Yes. using self.output_log() is correct.\nWe\u0027ve fixed utils.output_log() function to be able to print storage ID, by adding an argument, because the storage ID helps to know the message is by primary site or secondary site on GAD environment.\nThe fix is effective only on GAD environment. So, we add wrapper function for utils.output_log() into both(*) hbsd_common.py and hbsd_rest_api.py and replace caller code from utils.output_log() to self.output_log(), in order to print storage ID when running only on GAD environment. \n(*) How to know GAD or non-GAD is different between the modules. \n\nOther patches for Hitachi driver use utils.output_log() without fixing because printing storage ID is meaningless on them(excluding volume-replication patch).\nWe will replace output_log() caller from utils.output_log() to self.output_log() in other patches, if GAD is merged before merging them.\n","commit_id":"86f10941936374d5d1839e38d697cbe03ffb6c70"},{"author":{"_account_id":12988,"name":"Peter Penchev","email":"openstack-dev@storpool.com","username":"ppenchev"},"change_message_id":"d8cd3590a7394c45e0225fe300179c06533b69ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"d6caba74_ddb7338b","updated":"2023-01-17 14:43:05.000000000","message":"run-storpoolci","commit_id":"86f10941936374d5d1839e38d697cbe03ffb6c70"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"912e12ff466fd173f38018934b914d92963ac297","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"9565abd2_6e15c18c","updated":"2023-02-14 20:32:35.000000000","message":"Hello, Kazumasa. Hitachi CI is passing and the patch looks good to me. \n\nIn the coverage report[1], I noticed that the coverage could be improved for some methods, since they have less than 80% of coverage (for instance: hbsd_replication.py, hbsd_rest_iscsi.py, hbsd_rest_fc.py). \n\nAs most of the code is covered, I already gave a +1. \n\n[1] https://708c97d4f2ff88e6d41d-322e4fb38e7d387ba4b90f896c5d9204.ssl.cf5.rackcdn.com/796170/9/check/cinder-code-coverage/a2f7040/cover/ \n\n","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01b54cf5dd7dcfec784bfcdc8415bf59e964224e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"875ff993_3ad0d71b","updated":"2023-02-16 14:28:29.000000000","message":"Hitachi iSCSI and FC CI are passing. code and tests LGTM.\nFelipe\u0027s concern of testing should be addressed by the CI result.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"9bc4d12d2920561a55c28ce8338f2e9ee7f2a3c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0a6ce53f_26a98e22","updated":"2023-02-14 18:01:06.000000000","message":"Thank you, LGTM!","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bd5d86e959cb1967e0c807535d47c0abd25bf06e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"2752ca39_dca4c422","updated":"2023-02-14 18:44:14.000000000","message":"Thanks for the change. How did you test the new feature ? is there a CI test or something like that ?","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0c9f430ef3ea1c1fdb7e80136150884cecf321e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"86f2d41c_409e8e0c","updated":"2023-02-18 18:48:06.000000000","message":"The merge conflict should be fix ","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"aaf9e5f5dad0a21cf2c9576344a1cc9bb99b03f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"daafc529_8b61cef9","in_reply_to":"2752ca39_dca4c422","updated":"2023-02-15 07:45:38.000000000","message":"Thank you for reviewing.\nI\u0027ve tested this feature on Hitachi storage by manual operation and original integration test script. Additionally, I\u0027m running CI test and would submit the result by this weekend.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"5354b237132614782885af5f7aaa4eb164cad8de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"02c82381_9b661473","in_reply_to":"86f2d41c_409e8e0c","updated":"2023-02-20 06:14:06.000000000","message":"I\u0027ve uploaded patchset10 to solve merge conflict.\nPlease re-run workflow.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6aa438f3c84b3b66d138879a8dfea27a9b5facb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"098caf3a_a83b2605","in_reply_to":"875ff993_3ad0d71b","updated":"2023-02-17 00:29:27.000000000","message":"Thank you for reviewing!","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"aaf9e5f5dad0a21cf2c9576344a1cc9bb99b03f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"0215498f_5c2d2dc2","in_reply_to":"9565abd2_6e15c18c","updated":"2023-02-15 07:45:38.000000000","message":"Thank you for reviewing.\nFelipe also pointed out the matter.\nI\u0027ll upload unit test scripts as a follow up patch.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"79afaab8fe1bb2d13a82af67782f3a811b14c4c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4d2e1cd3_df4be9e7","in_reply_to":"daafc529_8b61cef9","updated":"2023-02-16 03:29:58.000000000","message":"I\u0027ve uploaded the CI result. Please check it.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"5354b237132614782885af5f7aaa4eb164cad8de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"65fddefa_2d6d5ec2","updated":"2023-02-20 06:14:06.000000000","message":"Patchset10 solve merge conflict in workflw","commit_id":"a92aa06e463f6322e8abdc2f570a801ea82dd1cb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"206f4b57ec6368e435905ff18beb7c3491baa961","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4afc2440_8fb4fae5","updated":"2023-02-20 13:03:33.000000000","message":"Previously approved and only resolved merge conflicts. Hitachi CI is passing. LGTM.","commit_id":"a92aa06e463f6322e8abdc2f570a801ea82dd1cb"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"208b855140e28099f434569a62db418a299bae9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"81063352_0b1746e4","updated":"2023-02-20 13:05:54.000000000","message":"merge conflict fixed","commit_id":"a92aa06e463f6322e8abdc2f570a801ea82dd1cb"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"bb7d8f44895f8cc06e77ae4c4934325632220c24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"7815a495_e322edf4","updated":"2023-02-20 09:33:18.000000000","message":"recheck cinder-grenade-mn-sub-volbak failed in setting up","commit_id":"a92aa06e463f6322e8abdc2f570a801ea82dd1cb"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"3bd45bfba1b70908334a0d3aa4fd56fa9cbbc2ba","unresolved":true,"context_lines":[{"line_number":504,"context_line":"            self.check_opts(self.conf, COMMON_PORT_OPTS)"},{"line_number":505,"context_line":"            if (self.conf.hitachi_port_scheduler and"},{"line_number":506,"context_line":"                    not self.conf.hitachi_group_create):"},{"line_number":507,"context_line":"                msg \u003d utils.output_log("},{"line_number":508,"context_line":"                    MSG.INVALID_PARAMETER,"},{"line_number":509,"context_line":"                    param\u003dself.driver_info[\u0027param_prefix\u0027] + \u0027_port_scheduler\u0027)"},{"line_number":510,"context_line":"                self.raise_error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"e54c5485_1988d619","line":507,"updated":"2022-12-27 10:30:48.000000000","message":"Would you not need to correct here to self.output_log?\nThere are other places that use utils.output_log.","commit_id":"fd0b62becb2a901c603aaf07ff9c441bc5753a53"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"8f3ea852a7501dd361d4f1dde366df620932f012","unresolved":false,"context_lines":[{"line_number":504,"context_line":"            self.check_opts(self.conf, COMMON_PORT_OPTS)"},{"line_number":505,"context_line":"            if (self.conf.hitachi_port_scheduler and"},{"line_number":506,"context_line":"                    not self.conf.hitachi_group_create):"},{"line_number":507,"context_line":"                msg \u003d utils.output_log("},{"line_number":508,"context_line":"                    MSG.INVALID_PARAMETER,"},{"line_number":509,"context_line":"                    param\u003dself.driver_info[\u0027param_prefix\u0027] + \u0027_port_scheduler\u0027)"},{"line_number":510,"context_line":"                self.raise_error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"576e7c1a_4e32f908","line":507,"in_reply_to":"57f5ba12_b68b620b","updated":"2023-01-19 10:05:01.000000000","message":"Thanks.","commit_id":"fd0b62becb2a901c603aaf07ff9c441bc5753a53"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"16860f4354f989ea00cd55df51231fe9434ec2e5","unresolved":true,"context_lines":[{"line_number":504,"context_line":"            self.check_opts(self.conf, COMMON_PORT_OPTS)"},{"line_number":505,"context_line":"            if (self.conf.hitachi_port_scheduler and"},{"line_number":506,"context_line":"                    not self.conf.hitachi_group_create):"},{"line_number":507,"context_line":"                msg \u003d utils.output_log("},{"line_number":508,"context_line":"                    MSG.INVALID_PARAMETER,"},{"line_number":509,"context_line":"                    param\u003dself.driver_info[\u0027param_prefix\u0027] + \u0027_port_scheduler\u0027)"},{"line_number":510,"context_line":"                self.raise_error(msg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"57f5ba12_b68b620b","line":507,"in_reply_to":"e54c5485_1988d619","updated":"2023-01-18 13:36:56.000000000","message":"Thank you for letting me know.\nI will fix it to call u as fixed patch","commit_id":"fd0b62becb2a901c603aaf07ff9c441bc5753a53"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"912e12ff466fd173f38018934b914d92963ac297","unresolved":true,"context_lines":[{"line_number":1029,"context_line":"                if getattr(self, \u0027is_primary\u0027, False) or ("},{"line_number":1030,"context_line":"                        hasattr(self, \u0027primary_storage_id\u0027) and not both):"},{"line_number":1031,"context_line":"                    return None if \u0027pldev\u0027 not in loc else int(loc[\u0027pldev\u0027])"},{"line_number":1032,"context_line":"                elif getattr(self, \u0027is_secondary\u0027, False):"},{"line_number":1033,"context_line":"                    return None if \u0027sldev\u0027 not in loc else int(loc[\u0027sldev\u0027])"},{"line_number":1034,"context_line":"                if hasattr(self, \u0027primary_storage_id\u0027):"},{"line_number":1035,"context_line":"                    return {key: loc.get(key) for key in [\u0027pldev\u0027, \u0027sldev\u0027]}"}],"source_content_type":"text/x-python","patch_set":9,"id":"93f9b99a_0d302132","line":1032,"range":{"start_line":1032,"start_character":16,"end_line":1032,"end_character":20},"updated":"2023-02-14 20:32:35.000000000","message":"nit: due to the return statement, you could also use an \u0027if\u0027 here, right?","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"aaf9e5f5dad0a21cf2c9576344a1cc9bb99b03f4","unresolved":false,"context_lines":[{"line_number":1029,"context_line":"                if getattr(self, \u0027is_primary\u0027, False) or ("},{"line_number":1030,"context_line":"                        hasattr(self, \u0027primary_storage_id\u0027) and not both):"},{"line_number":1031,"context_line":"                    return None if \u0027pldev\u0027 not in loc else int(loc[\u0027pldev\u0027])"},{"line_number":1032,"context_line":"                elif getattr(self, \u0027is_secondary\u0027, False):"},{"line_number":1033,"context_line":"                    return None if \u0027sldev\u0027 not in loc else int(loc[\u0027sldev\u0027])"},{"line_number":1034,"context_line":"                if hasattr(self, \u0027primary_storage_id\u0027):"},{"line_number":1035,"context_line":"                    return {key: loc.get(key) for key in [\u0027pldev\u0027, \u0027sldev\u0027]}"}],"source_content_type":"text/x-python","patch_set":9,"id":"10f0a420_9922fe70","line":1032,"range":{"start_line":1032,"start_character":16,"end_line":1032,"end_character":20},"in_reply_to":"93f9b99a_0d302132","updated":"2023-02-15 07:45:38.000000000","message":"It\u0027s a good point.\nYes, although I could use `if` instead of `elif` in this case, `elif` is not wrong.\nSo, please hold on this statement.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"}],"cinder/volume/drivers/hitachi/hbsd_replication.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"46f2140bb024128bffa1a69a88333c9dd2e452ec","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                default\u003dFalse,"},{"line_number":142,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":143,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(\u0027hitachi_mirror_ssl_cert_path\u0027,"},{"line_number":145,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":146,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":147,"context_line":"               \u0027trusted CAs, which will be used to validate the backend\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"09515b69_0c9b482b","line":144,"updated":"2022-02-18 08:56:35.000000000","message":"Shouldn\u0027t hitachi_mirror_ssl_cert_path need to define a default value?","commit_id":"d11f6472f476ac35708b3edf504e6daa25f7be81"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"7f532e89bb0c14287176482f479d3d159f29a9ec","unresolved":true,"context_lines":[{"line_number":141,"context_line":"                default\u003dFalse,"},{"line_number":142,"context_line":"                help\u003d\u0027If set to True the http client will validate the SSL \u0027"},{"line_number":143,"context_line":"                     \u0027certificate of the backend endpoint.\u0027),"},{"line_number":144,"context_line":"    cfg.StrOpt(\u0027hitachi_mirror_ssl_cert_path\u0027,"},{"line_number":145,"context_line":"               help\u003d\u0027Can be used to specify a non default path to a \u0027"},{"line_number":146,"context_line":"               \u0027CA_BUNDLE file or directory with certificates of \u0027"},{"line_number":147,"context_line":"               \u0027trusted CAs, which will be used to validate the backend\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d69fa55_2838821b","line":144,"in_reply_to":"09515b69_0c9b482b","updated":"2022-02-18 11:22:07.000000000","message":"Thank you for checking. This code is along:\n\n /opt/stack/cinder/cinder/volume/driver.py\n 194     cfg.BoolOpt(\u0027driver_ssl_cert_verify\u0027,\n 195                 default\u003dFalse,\n 196                 help\u003d\u0027If set to True the http client will validate the SSL \u0027\n 197                      \u0027certificate of the backend endpoint.\u0027),\n 198     cfg.StrOpt(\u0027driver_ssl_cert_path\u0027,\n 199                help\u003d\u0027Can be used to specify a non default path to a \u0027\n 200                \u0027CA_BUNDLE file or directory with certificates of \u0027\n 201                \u0027trusted CAs, which will be used to validate the backend\u0027),\n 202     cfg.ListOpt(\u0027trace_flags\u0027,\n\nShould we add \"default\u003dNone\" into /opt/stack/cinder/cinder/volume/driver.py before?","commit_id":"d11f6472f476ac35708b3edf504e6daa25f7be81"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"bd5d86e959cb1967e0c807535d47c0abd25bf06e","unresolved":true,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"\"\"\"replication module for Hitachi HBSD Driver.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"67d67200_d2cc1975","line":15,"updated":"2023-02-14 18:44:14.000000000","message":"this module has 70% of coverage [1]. It should be higher, but I\u0027m fine if you prefer to work on it with follow up patch.\n\n[1] https://708c97d4f2ff88e6d41d-322e4fb38e7d387ba4b90f896c5d9204.ssl.cf5.rackcdn.com/796170/9/check/cinder-code-coverage/a2f7040/cover/d_f29f70ddd7900583_hbsd_replication_py.html","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"aaf9e5f5dad0a21cf2c9576344a1cc9bb99b03f4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"\"\"\"replication module for Hitachi HBSD Driver.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"b9310275_3a9b4f6c","line":15,"in_reply_to":"67d67200_d2cc1975","updated":"2023-02-15 07:45:38.000000000","message":"I see. I will upload a follow up patch which contains unit test scripts to increase coverage.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"f9f1c064e9040638c5bd85e16b92c0ae9f8a6a12","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#    License for the specific language governing permissions and limitations"},{"line_number":13,"context_line":"#    under the License."},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"\"\"\"replication module for Hitachi HBSD Driver.\"\"\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"import json"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"2eaa9c4d_e94d21ee","line":15,"in_reply_to":"b9310275_3a9b4f6c","updated":"2023-02-17 14:32:48.000000000","message":"Hitachi iSCSI and FC CI are passing and the test coverage will be address in a follow up patch.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"}],"cinder/volume/drivers/hitachi/hbsd_rest_api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01b54cf5dd7dcfec784bfcdc8415bf59e964224e","unresolved":true,"context_lines":[{"line_number":97,"context_line":"                           is_remote\u003dFalse):"},{"line_number":98,"context_line":"    if remote_client is None and is_remote:"},{"line_number":99,"context_line":"        return _NOT_SPECIFIED"},{"line_number":100,"context_line":"    return copy_group_name + (\u0027S\u0027 if is_secondary ^ is_remote else \u0027P\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def _build_base_url(ip_addr, ip_port):"}],"source_content_type":"text/x-python","patch_set":9,"id":"8a6221e2_2dbfff58","line":100,"range":{"start_line":100,"start_character":50,"end_line":100,"end_character":51},"updated":"2023-02-16 14:28:29.000000000","message":"is this bitwise XOR intended?","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6aa438f3c84b3b66d138879a8dfea27a9b5facb9","unresolved":false,"context_lines":[{"line_number":97,"context_line":"                           is_remote\u003dFalse):"},{"line_number":98,"context_line":"    if remote_client is None and is_remote:"},{"line_number":99,"context_line":"        return _NOT_SPECIFIED"},{"line_number":100,"context_line":"    return copy_group_name + (\u0027S\u0027 if is_secondary ^ is_remote else \u0027P\u0027)"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def _build_base_url(ip_addr, ip_port):"}],"source_content_type":"text/x-python","patch_set":9,"id":"9515cf09_997100ab","line":100,"range":{"start_line":100,"start_character":50,"end_line":100,"end_character":51},"in_reply_to":"8a6221e2_2dbfff58","updated":"2023-02-17 00:29:27.000000000","message":"Yes.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"}],"cinder/volume/drivers/hitachi/hbsd_rest_iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"01b54cf5dd7dcfec784bfcdc8415bf59e964224e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020, 2022, Hitachi, Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"32dfc9cd_fc1b8858","line":1,"range":{"start_line":1,"start_character":25,"end_line":1,"end_character":26},"updated":"2023-02-16 14:28:29.000000000","message":"I don\u0027t understand this header update. Generally we don\u0027t need to update it but if we\u0027re doing it, we should be consistent. In the hbsd_utils.py file we\u0027re updating this to 2023. but it can be done in a followup.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"6aa438f3c84b3b66d138879a8dfea27a9b5facb9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (C) 2020, 2022, Hitachi, Ltd."},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"#    Licensed under the Apache License, Version 2.0 (the \"License\"); you may"},{"line_number":4,"context_line":"#    not use this file except in compliance with the License. You may obtain"}],"source_content_type":"text/x-python","patch_set":9,"id":"57cfaaab_fb3c4707","line":1,"range":{"start_line":1,"start_character":25,"end_line":1,"end_character":26},"in_reply_to":"32dfc9cd_fc1b8858","updated":"2023-02-17 00:29:27.000000000","message":"This fix was when I uploaded this patch for Yoga or Zed.\nI see that I\u0027ll update this as followup patch.","commit_id":"b3b45758a84feb14fe0aba88eb0e82c9c3176083"}]}