)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":21,"id":"18d6d7e0_c26f6e8a","updated":"2021-10-12 11:17:59.000000000","message":"\u003e Patch Set 18: Code-Review-1\n\u003e \n\u003e Hi Helen,\n\u003e \n\u003e For some of the newly added methods UT\u0027s are not added. Code changes looks good.\n\u003e \n\u003e Thanks,\n\u003e Girish\n\n","commit_id":"f547084e43983b9e09fa6955667952b5ff749529"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"ba5ff68afed5cc3d9fc4b641b8362c1b561975e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"feb31dbc_6420384c","updated":"2021-12-14 16:33:26.000000000","message":"LGTM. Run Powermax CI","commit_id":"eb3b976daf7cd15b7e8e43ca92e0c23738b5ef6d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8abc5023e24f29e77b5d1ef242aa95105bba27f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":23,"id":"779a3af0_4db9ed7f","updated":"2021-12-13 22:01:42.000000000","message":"recheck openstack-tox-py39 environment failed to build, not related to this patch","commit_id":"eb3b976daf7cd15b7e8e43ca92e0c23738b5ef6d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f165ca5305e106ad2888b2677e4bcef1e3722445","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"19d4657e_24539ce6","updated":"2022-05-26 22:14:56.000000000","message":"Code looks good, has test coverage, and the third-party CI is green.","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"40a48aa62eb9322c17329b060e0d0d86c2b811b3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"91d1afb6_c8823f2b","updated":"2022-03-22 10:47:14.000000000","message":"LGTM","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"5bd2feee07a9ab2b9a8d0138edb74738193f31fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"21e16e35_5744bff4","updated":"2022-06-15 14:57:19.000000000","message":"LGTM! ","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"da6707837cbecd6887871b23e34221b64e51d0ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"0b457914_e0817645","updated":"2022-04-18 09:26:17.000000000","message":"Re-run Powermax CI","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"4618e032de7ee0cc359aa40d8bdc60df7055746b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"15f19580_7be5e008","updated":"2022-04-18 09:28:43.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"3fcf7e3fcaf78a5fa228a6f26acd0ade0aabab05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"2567214d_012fbe0a","updated":"2022-04-18 14:57:39.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"da6707837cbecd6887871b23e34221b64e51d0ab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":24,"id":"75148f04_c2a11bb1","in_reply_to":"91d1afb6_c8823f2b","updated":"2022-04-18 09:26:17.000000000","message":"Re-run Powermax CI","commit_id":"e1f6de6f836e1d534d0196ba43e6642bc5e279c6"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/powermax_fake_objects.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"83137af0ad3b61da5b33fd10e1477a7f674e4e8a","unresolved":true,"context_lines":[{"line_number":150,"context_line":"                return_object \u003d self.data.volume_list[0]"},{"line_number":151,"context_line":"            elif \u00272\u0027 in params.values():"},{"line_number":152,"context_line":"                return_object \u003d self.data.volume_list[1]"},{"line_number":153,"context_line":"            elif \u0027volume_identifier\u0027 in params:"},{"line_number":154,"context_line":"                return_object \u003d self.data.volume_list[0]"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            for vol in self.data.volume_details:"}],"source_content_type":"text/x-python","patch_set":20,"id":"0811f3ad_43bf721a","line":153,"range":{"start_line":153,"start_character":12,"end_line":153,"end_character":47},"updated":"2021-08-05 20:19:00.000000000","message":"could it be an \u0027or\u0027 statement on first if (line 149)?","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[{"line_number":150,"context_line":"                return_object \u003d self.data.volume_list[0]"},{"line_number":151,"context_line":"            elif \u00272\u0027 in params.values():"},{"line_number":152,"context_line":"                return_object \u003d self.data.volume_list[1]"},{"line_number":153,"context_line":"            elif \u0027volume_identifier\u0027 in params:"},{"line_number":154,"context_line":"                return_object \u003d self.data.volume_list[0]"},{"line_number":155,"context_line":"        else:"},{"line_number":156,"context_line":"            for vol in self.data.volume_details:"}],"source_content_type":"text/x-python","patch_set":20,"id":"b354e76b_fcb2b626","line":153,"range":{"start_line":153,"start_character":12,"end_line":153,"end_character":47},"in_reply_to":"0811f3ad_43bf721a","updated":"2021-10-12 11:17:59.000000000","message":"Yes, that would work.  Thank you","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"83137af0ad3b61da5b33fd10e1477a7f674e4e8a","unresolved":true,"context_lines":[{"line_number":2087,"context_line":"                raise exception.VolumeBackendAPIException(_("},{"line_number":2088,"context_line":"                    \u0027Cannot delete device %s as it is currently a linked \u0027"},{"line_number":2089,"context_line":"                    \u0027target of snapshot %s. The source device of this link \u0027"},{"line_number":2090,"context_line":"                    \u0027is %s. Please try again once this snapshots is no longer \u0027"},{"line_number":2091,"context_line":"                    \u0027active.\u0027) % (device_id, snapshot_name, source_device))"},{"line_number":2092,"context_line":""},{"line_number":2093,"context_line":"    def _create_volume(self, volume, volume_name, volume_size, extra_specs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"14a1b3f7_d112f494","line":2090,"range":{"start_line":2090,"start_character":55,"end_line":2090,"end_character":64},"updated":"2021-08-05 20:19:00.000000000","message":"snapshot","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[{"line_number":2087,"context_line":"                raise exception.VolumeBackendAPIException(_("},{"line_number":2088,"context_line":"                    \u0027Cannot delete device %s as it is currently a linked \u0027"},{"line_number":2089,"context_line":"                    \u0027target of snapshot %s. The source device of this link \u0027"},{"line_number":2090,"context_line":"                    \u0027is %s. Please try again once this snapshots is no longer \u0027"},{"line_number":2091,"context_line":"                    \u0027active.\u0027) % (device_id, snapshot_name, source_device))"},{"line_number":2092,"context_line":""},{"line_number":2093,"context_line":"    def _create_volume(self, volume, volume_name, volume_size, extra_specs):"}],"source_content_type":"text/x-python","patch_set":20,"id":"2102e32f_473685eb","line":2090,"range":{"start_line":2090,"start_character":55,"end_line":2090,"end_character":64},"in_reply_to":"14a1b3f7_d112f494","updated":"2021-10-12 11:17:59.000000000","message":"Done","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"83137af0ad3b61da5b33fd10e1477a7f674e4e8a","unresolved":true,"context_lines":[{"line_number":2171,"context_line":"        dev_id_from_identifier \u003d self.rest.find_volume_device_id("},{"line_number":2172,"context_line":"            array, volume_name)"},{"line_number":2173,"context_line":"        if isinstance(dev_id_from_identifier, list):"},{"line_number":2174,"context_line":"            for dev_id in dev_id_from_identifier:"},{"line_number":2175,"context_line":"                if dev_id \u003d\u003d orig_device_id:"},{"line_number":2176,"context_line":"                    return dev_id"},{"line_number":2177,"context_line":"        else:"},{"line_number":2178,"context_line":"            if dev_id_from_identifier !\u003d orig_device_id:"},{"line_number":2179,"context_line":"                LOG.warning("}],"source_content_type":"text/x-python","patch_set":20,"id":"7b7bee66_61eba5aa","line":2176,"range":{"start_line":2174,"start_character":12,"end_line":2176,"end_character":33},"updated":"2021-08-05 20:19:00.000000000","message":"you could use:\n    if orig_device_id in dev_id_from_identifier:\n        return orig_device_id","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[{"line_number":2171,"context_line":"        dev_id_from_identifier \u003d self.rest.find_volume_device_id("},{"line_number":2172,"context_line":"            array, volume_name)"},{"line_number":2173,"context_line":"        if isinstance(dev_id_from_identifier, list):"},{"line_number":2174,"context_line":"            for dev_id in dev_id_from_identifier:"},{"line_number":2175,"context_line":"                if dev_id \u003d\u003d orig_device_id:"},{"line_number":2176,"context_line":"                    return dev_id"},{"line_number":2177,"context_line":"        else:"},{"line_number":2178,"context_line":"            if dev_id_from_identifier !\u003d orig_device_id:"},{"line_number":2179,"context_line":"                LOG.warning("}],"source_content_type":"text/x-python","patch_set":20,"id":"f42f7a48_34e16cc3","line":2176,"range":{"start_line":2174,"start_character":12,"end_line":2176,"end_character":33},"in_reply_to":"7b7bee66_61eba5aa","updated":"2021-10-12 11:17:59.000000000","message":"Done","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"83137af0ad3b61da5b33fd10e1477a7f674e4e8a","unresolved":true,"context_lines":[{"line_number":2547,"context_line":"        except Exception as e:"},{"line_number":2548,"context_line":"            error_message \u003d (_("},{"line_number":2549,"context_line":"                \"Failed to delete volume %(volume_name)s with device id \""},{"line_number":2550,"context_line":"                \"%(dev)s. Exception received: %(e)s\") %"},{"line_number":2551,"context_line":"                {\u0027volume_name\u0027: volume_name,"},{"line_number":2552,"context_line":"                 \u0027dev\u0027: device_id,"},{"line_number":2553,"context_line":"                 \u0027e\u0027: six.text_type(e)})"}],"source_content_type":"text/x-python","patch_set":20,"id":"c56f91ee_30a6fa4f","line":2550,"range":{"start_line":2550,"start_character":46,"end_line":2550,"end_character":51},"updated":"2021-08-05 20:19:00.000000000","message":"just a period at the end","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[{"line_number":2547,"context_line":"        except Exception as e:"},{"line_number":2548,"context_line":"            error_message \u003d (_("},{"line_number":2549,"context_line":"                \"Failed to delete volume %(volume_name)s with device id \""},{"line_number":2550,"context_line":"                \"%(dev)s. Exception received: %(e)s\") %"},{"line_number":2551,"context_line":"                {\u0027volume_name\u0027: volume_name,"},{"line_number":2552,"context_line":"                 \u0027dev\u0027: device_id,"},{"line_number":2553,"context_line":"                 \u0027e\u0027: six.text_type(e)})"}],"source_content_type":"text/x-python","patch_set":20,"id":"5d3d492d_6d43f604","line":2550,"range":{"start_line":2550,"start_character":46,"end_line":2550,"end_character":51},"in_reply_to":"c56f91ee_30a6fa4f","updated":"2021-10-12 11:17:59.000000000","message":"Done","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"}],"cinder/volume/drivers/dell_emc/powermax/masking.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"83137af0ad3b61da5b33fd10e1477a7f674e4e8a","unresolved":true,"context_lines":[{"line_number":95,"context_line":"                    serial_number, device_id, storagegroup_name,"},{"line_number":96,"context_line":"                    maskingview_name):"},{"line_number":97,"context_line":"                error_message \u003d (\"The attach validation for device \""},{"line_number":98,"context_line":"                                 \"%(dev)s was unsuccessful\")"},{"line_number":99,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":100,"context_line":"                    message\u003derror_message)"},{"line_number":101,"context_line":"            rollback_dict[\u0027portgroup_name\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":20,"id":"fec8f875_e3e74ac3","line":98,"range":{"start_line":98,"start_character":46,"end_line":98,"end_character":58},"updated":"2021-08-05 20:19:00.000000000","message":"just a period at the end","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[{"line_number":95,"context_line":"                    serial_number, device_id, storagegroup_name,"},{"line_number":96,"context_line":"                    maskingview_name):"},{"line_number":97,"context_line":"                error_message \u003d (\"The attach validation for device \""},{"line_number":98,"context_line":"                                 \"%(dev)s was unsuccessful\")"},{"line_number":99,"context_line":"                raise exception.VolumeBackendAPIException("},{"line_number":100,"context_line":"                    message\u003derror_message)"},{"line_number":101,"context_line":"            rollback_dict[\u0027portgroup_name\u0027] \u003d ("}],"source_content_type":"text/x-python","patch_set":20,"id":"a51934e9_70f1c367","line":98,"range":{"start_line":98,"start_character":46,"end_line":98,"end_character":58},"in_reply_to":"fec8f875_e3e74ac3","updated":"2021-10-12 11:17:59.000000000","message":"Done","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"83137af0ad3b61da5b33fd10e1477a7f674e4e8a","unresolved":true,"context_lines":[{"line_number":1709,"context_line":"            device_id \u003d device_list[0] if len(device_list) \u003d\u003d 1 else ("},{"line_number":1710,"context_line":"                device_list)"},{"line_number":1711,"context_line":"            if isinstance(device_id, list):"},{"line_number":1712,"context_line":"                LOG.warning(\"More than one devices returned for %(vol_name)s\","},{"line_number":1713,"context_line":"                            {\u0027vol_name\u0027: volume_name})"},{"line_number":1714,"context_line":"        return device_id"},{"line_number":1715,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"872492d1_2e51d5b3","line":1712,"range":{"start_line":1712,"start_character":64,"end_line":1712,"end_character":76},"updated":"2021-08-05 20:19:00.000000000","message":"just the period at the end","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"40925bf0bf1c03e04dd22f02b1b8bb4b47e4b420","unresolved":false,"context_lines":[{"line_number":1709,"context_line":"            device_id \u003d device_list[0] if len(device_list) \u003d\u003d 1 else ("},{"line_number":1710,"context_line":"                device_list)"},{"line_number":1711,"context_line":"            if isinstance(device_id, list):"},{"line_number":1712,"context_line":"                LOG.warning(\"More than one devices returned for %(vol_name)s\","},{"line_number":1713,"context_line":"                            {\u0027vol_name\u0027: volume_name})"},{"line_number":1714,"context_line":"        return device_id"},{"line_number":1715,"context_line":""}],"source_content_type":"text/x-python","patch_set":20,"id":"39be0e9d_9fe85f15","line":1712,"range":{"start_line":1712,"start_character":64,"end_line":1712,"end_character":76},"in_reply_to":"872492d1_2e51d5b3","updated":"2021-10-12 11:17:59.000000000","message":"Done","commit_id":"318438d28ed8b03adbe9e90d394e108e7d69b374"}]}