)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"051166c819d2df6cabbd661af446e9c5fffcffe7","unresolved":true,"context_lines":[{"line_number":16,"context_line":"the scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/796889"},{"line_number":19,"context_line":"Closes-Bug: #1932364"},{"line_number":20,"context_line":"Change-Id: I7c0f4d4ea7de635afede3c8514a5da9e85ad9b48"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"729f0998_70c8d6ee","line":19,"updated":"2021-06-17 21:27:24.000000000","message":"This should just close bug 1932188.","commit_id":"d193078b968e6566aa5c946973a0b8bcef082127"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8cd5c8f9edf9863314680836f23fa37b501725b","unresolved":true,"context_lines":[{"line_number":10,"context_line":""},{"line_number":11,"context_line":"LVM commands segfault occasionally, exiting with code 139."},{"line_number":12,"context_line":"Change I6824ba4f introduced a workaround to retry the command"},{"line_number":13,"context_line":"when code 139 is returned, which generally works.  This expands"},{"line_number":14,"context_line":"that retry to the case where thin pool space is queried, which"},{"line_number":15,"context_line":"currently results in the LVM driver reporting no free space to"},{"line_number":16,"context_line":"the scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/796889"},{"line_number":19,"context_line":"Partial-Bug: #1932188"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"9865a38a_fc371544","line":16,"range":{"start_line":13,"start_character":51,"end_line":16,"end_character":14},"updated":"2021-06-22 17:19:15.000000000","message":"This patch is about resolving other cases where lvm commands cause issues, not this one which was addressed in\n    https://review.opendev.org/c/openstack/cinder/+/796889","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8cd5c8f9edf9863314680836f23fa37b501725b","unresolved":true,"context_lines":[{"line_number":16,"context_line":"the scheduler."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Depends-On: https://review.opendev.org/c/openstack/cinder/+/796889"},{"line_number":19,"context_line":"Partial-Bug: #1932188"},{"line_number":20,"context_line":"Change-Id: I7c0f4d4ea7de635afede3c8514a5da9e85ad9b48"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"19a9977e_dfe488f4","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":11},"updated":"2021-06-22 17:19:15.000000000","message":"This should be Closes-Bug for 1932188, as the goal is to retry all the remaining relevant commands in this patch.","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"}],"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"051166c819d2df6cabbd661af446e9c5fffcffe7","unresolved":true,"context_lines":[{"line_number":625,"context_line":""},{"line_number":626,"context_line":"    def _lv_is_active(self, name):"},{"line_number":627,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":628,"context_line":"                                    \u0027Attr\u0027, \u0027--readonly\u0027,"},{"line_number":629,"context_line":"                                    \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":630,"context_line":"        out, _err \u003d self._run_lvm_command(cmd,"},{"line_number":631,"context_line":"                                          root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"29030f3b_3852b126","line":628,"updated":"2021-06-17 21:27:24.000000000","message":"See note below on lv_is_open.","commit_id":"d193078b968e6566aa5c946973a0b8bcef082127"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"051166c819d2df6cabbd661af446e9c5fffcffe7","unresolved":true,"context_lines":[{"line_number":801,"context_line":"    def lv_is_open(self, name):"},{"line_number":802,"context_line":"        \"\"\"Return True if LV is currently open, False otherwise.\"\"\""},{"line_number":803,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":804,"context_line":"                                    \u0027Attr\u0027, \u0027--readonly\u0027,"},{"line_number":805,"context_line":"                                    \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":806,"context_line":"        out, _err \u003d self._run_lvm_command(cmd,"},{"line_number":807,"context_line":"                                          root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":1,"id":"03d3b85f_92816343","line":804,"updated":"2021-06-17 21:27:24.000000000","message":"I think this doesn\u0027t work -- the lvdisplay man page indicates that --readonly can\u0027t tell whether LVs are actually in use.","commit_id":"d193078b968e6566aa5c946973a0b8bcef082127"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5926098e95a79ba25caedebe1737e540dfa0e2ca","unresolved":true,"context_lines":[{"line_number":530,"context_line":"        if not size_str:"},{"line_number":531,"context_line":"            size_str \u003d self._calculate_thin_pool_size()"},{"line_number":532,"context_line":""},{"line_number":533,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-L\u0027, size_str,"},{"line_number":534,"context_line":"                                    vg_pool_name]"},{"line_number":535,"context_line":"        LOG.debug(\"Creating thin pool \u0027%(pool)s\u0027 with size %(size)s of \""},{"line_number":536,"context_line":"                  \"total %(free)sg\", {\u0027pool\u0027: vg_pool_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"29180f9a_7d6cdd2a","line":533,"range":{"start_line":533,"start_character":36,"end_line":533,"end_character":46},"updated":"2021-06-22 17:51:47.000000000","message":"lvcreate should also be covered","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5926098e95a79ba25caedebe1737e540dfa0e2ca","unresolved":true,"context_lines":[{"line_number":556,"context_line":""},{"line_number":557,"context_line":"        if lv_type \u003d\u003d \u0027thin\u0027:"},{"line_number":558,"context_line":"            pool_path \u003d \u0027%s/%s\u0027 % (self.vg_name, self.vg_thin_pool)"},{"line_number":559,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-V\u0027, size_str, \u0027-n\u0027,"},{"line_number":560,"context_line":"                                        name, pool_path]"},{"line_number":561,"context_line":"        else:"},{"line_number":562,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-n\u0027, name, self.vg_name,"}],"source_content_type":"text/x-python","patch_set":3,"id":"1076ace9_36c6af3d","line":559,"range":{"start_line":559,"start_character":40,"end_line":559,"end_character":50},"updated":"2021-06-22 17:51:47.000000000","message":"lvcreate should also be covered","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5926098e95a79ba25caedebe1737e540dfa0e2ca","unresolved":true,"context_lines":[{"line_number":559,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-T\u0027, \u0027-V\u0027, size_str, \u0027-n\u0027,"},{"line_number":560,"context_line":"                                        name, pool_path]"},{"line_number":561,"context_line":"        else:"},{"line_number":562,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027-n\u0027, name, self.vg_name,"},{"line_number":563,"context_line":"                                        \u0027-L\u0027, size_str]"},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"        if mirror_count \u003e 0:"}],"source_content_type":"text/x-python","patch_set":3,"id":"577bcd8d_e17095f7","line":562,"range":{"start_line":562,"start_character":40,"end_line":562,"end_character":50},"updated":"2021-06-22 17:51:47.000000000","message":"lvcreate should also be covered","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"5926098e95a79ba25caedebe1737e540dfa0e2ca","unresolved":true,"context_lines":[{"line_number":599,"context_line":"            LOG.error(\"Trying to create snapshot by non-existent LV: %s\","},{"line_number":600,"context_line":"                      source_lv_name)"},{"line_number":601,"context_line":"            raise exception.VolumeDeviceNotFound(device\u003dsource_lv_name)"},{"line_number":602,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvcreate\u0027, \u0027--name\u0027, name, \u0027--snapshot\u0027,"},{"line_number":603,"context_line":"                                    \u0027%s/%s\u0027 % (self.vg_name, source_lv_name)]"},{"line_number":604,"context_line":"        if lv_type !\u003d \u0027thin\u0027:"},{"line_number":605,"context_line":"            size \u003d source_lvref[\u0027size\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"07559bb1_7bd0de58","line":602,"range":{"start_line":602,"start_character":36,"end_line":602,"end_character":46},"updated":"2021-06-22 17:51:47.000000000","message":"lvcreate should also be covered","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a60c7e5daf2538ffb019dd58071c0718b6ff0eed","unresolved":true,"context_lines":[{"line_number":627,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":628,"context_line":"                                    \u0027Attr\u0027, \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":629,"context_line":"        out, _err \u003d self._run_lvm_command(cmd,"},{"line_number":630,"context_line":"                                          root_helper\u003dself._root_helper,"},{"line_number":631,"context_line":"                                          run_as_root\u003dTrue)"},{"line_number":632,"context_line":"        if out:"},{"line_number":633,"context_line":"            out \u003d out.strip()"}],"source_content_type":"text/x-python","patch_set":3,"id":"d4c9fe34_442ec9a5","line":630,"updated":"2021-06-22 18:31:58.000000000","message":"from Gorka\u0027s comment: this should always be the case, so we could just set this in the _run_lvm_command method instead of passing it.\n\n https://review.opendev.org/c/openstack/cinder/+/796889/2/cinder/brick/local_dev/lvm.py#197","commit_id":"40312e78bbe42feb2ac5c235a125fc909370f326"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bbcf9e36f907bb2ba859c1357561bd9179ff9ee5","unresolved":true,"context_lines":[{"line_number":556,"context_line":"                                      \u0027free\u0027: self.vg_free_space})"},{"line_number":557,"context_line":""},{"line_number":558,"context_line":"        self._run_lvm_command(cmd,"},{"line_number":559,"context_line":"                              run_as_root\u003dTrue)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"        self.vg_thin_pool \u003d name"},{"line_number":562,"context_line":"        return size_str"}],"source_content_type":"text/x-python","patch_set":6,"id":"2d4c503b_3c05db20","line":559,"range":{"start_line":559,"start_character":30,"end_line":559,"end_character":46},"updated":"2021-06-23 15:16:38.000000000","message":"we can also remove this from all the calls since the default value is already true","commit_id":"8ae4a641851c8351d5d58e767002b84b6c699c34"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"3bc2963f8c9b9afa60e6980be59f6bdbb433f731","unresolved":true,"context_lines":[{"line_number":638,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":639,"context_line":"                                    \u0027Attr\u0027, \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":640,"context_line":"        out, _err \u003d self._run_lvm_command(cmd,"},{"line_number":641,"context_line":"                                          run_as_root\u003dTrue)"},{"line_number":642,"context_line":"        if out:"},{"line_number":643,"context_line":"            out \u003d out.strip()"},{"line_number":644,"context_line":"            if (out[4] \u003d\u003d \u0027a\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ac084746_1d90e663","line":641,"range":{"start_line":641,"start_character":42,"end_line":641,"end_character":58},"updated":"2021-06-24 03:37:16.000000000","message":"missed this one","commit_id":"c937a0dc382cd631ae6c9ed3dd78b6593b0d637e"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"19af147bb94ca0c75b656d5c039f894f729a265e","unresolved":false,"context_lines":[{"line_number":638,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":639,"context_line":"                                    \u0027Attr\u0027, \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":640,"context_line":"        out, _err \u003d self._run_lvm_command(cmd,"},{"line_number":641,"context_line":"                                          run_as_root\u003dTrue)"},{"line_number":642,"context_line":"        if out:"},{"line_number":643,"context_line":"            out \u003d out.strip()"},{"line_number":644,"context_line":"            if (out[4] \u003d\u003d \u0027a\u0027):"}],"source_content_type":"text/x-python","patch_set":7,"id":"0f827299_d282165a","line":641,"range":{"start_line":641,"start_character":42,"end_line":641,"end_character":58},"in_reply_to":"ac084746_1d90e663","updated":"2021-06-24 20:39:19.000000000","message":"Ack","commit_id":"c937a0dc382cd631ae6c9ed3dd78b6593b0d637e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b92ce43dc6de358413b074349e03a7ac960762a2","unresolved":true,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    def lv_has_snapshot(self, name):"},{"line_number":784,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":785,"context_line":"                                    \u0027Attr\u0027, \u0027--readonly\u0027,"},{"line_number":786,"context_line":"                                    \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":787,"context_line":"        out, _err \u003d self._execute(*cmd,"},{"line_number":788,"context_line":"                                  root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":7,"id":"b6142e8c_3b6955d0","line":785,"range":{"start_line":785,"start_character":45,"end_line":785,"end_character":55},"updated":"2021-06-24 00:22:26.000000000","message":"I guess our theory is that lvdisplay is less likely to crash when invoked with the readonly flag?","commit_id":"c937a0dc382cd631ae6c9ed3dd78b6593b0d637e"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"19af147bb94ca0c75b656d5c039f894f729a265e","unresolved":true,"context_lines":[{"line_number":782,"context_line":""},{"line_number":783,"context_line":"    def lv_has_snapshot(self, name):"},{"line_number":784,"context_line":"        cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvdisplay\u0027, \u0027--noheading\u0027, \u0027-C\u0027, \u0027-o\u0027,"},{"line_number":785,"context_line":"                                    \u0027Attr\u0027, \u0027--readonly\u0027,"},{"line_number":786,"context_line":"                                    \u0027%s/%s\u0027 % (self.vg_name, name)]"},{"line_number":787,"context_line":"        out, _err \u003d self._execute(*cmd,"},{"line_number":788,"context_line":"                                  root_helper\u003dself._root_helper,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5912d668_8de9fde0","line":785,"range":{"start_line":785,"start_character":45,"end_line":785,"end_character":55},"in_reply_to":"b6142e8c_3b6955d0","updated":"2021-06-24 20:39:19.000000000","message":"Nice catch, I\u0027ll update:\nlvdisplay is showing the segmentation error:\nhttp://logstash.openstack.org/#/dashboard/file/logstash.json?query\u003dmessage:%5C%22lvs%5C%22%20AND%20message:%5C%22segfault%5C%22%20AND%20filename:%5C%22controller%2Flogs%2Fsyslog.txt%5C%22\u0026from\u003d7d","commit_id":"c937a0dc382cd631ae6c9ed3dd78b6593b0d637e"}]}