)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"b604c400f4365fa02e80e72d8cc31e36f4857dfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":19,"id":"cfbce302_1b738b9f","updated":"2021-11-17 07:16:16.000000000","message":"WIP, need to rewrite to support copy offload operations","commit_id":"dfed14c0a8800d2dc27825d354e592d11345b3e7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95244b5db9845ec93e91ae700447f071336660d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"000abd72_979a27e5","updated":"2022-06-02 12:26:17.000000000","message":"You have defined CI_WIKI_NAME as \"DellEMC_PowerStore_NFS_CI\", but there is no corresponding wiki page:\nhttps://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerStore_NFS_CI\n\nPlease either correct the CI_WIKI_NAME or follow these instructions to add a page:\nhttps://wiki.openstack.org/wiki/ThirdPartySystems#Adding_a_New_System","commit_id":"186c8102763b3c18901b7faa232da04961257e2a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"734a0bffa1473fb601d9b6d61bde481eea251918","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":26,"id":"ad8b1d16_558a0369","in_reply_to":"000abd72_979a27e5","updated":"2022-06-02 15:11:51.000000000","message":"OK. SHould we create a new CI or can we use the existing powerstore one as it\u0027s the same platform but different protocols?","commit_id":"186c8102763b3c18901b7faa232da04961257e2a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"56065639a920c7b7e6ad0555b694eafc9fc59dc4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"08ceb9d6_998f96c4","updated":"2022-06-17 19:48:00.000000000","message":"@JP: sorry I didn\u0027t respond sooner.  Using the Dell PowerStore CI is fine; you just need to add the NFS job to its responses.  Is it running yet?  I haven\u0027t seen the NFS job on the PowerStore CI responses, but maybe I\u0027m not looking at the right reviews.","commit_id":"cdf573ef53e7a873638b4d757100357cc3c9c7a1"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c86a4845cc28f94374b7a81e43ef538d7cedb881","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"5731bd11_ed91261a","updated":"2022-06-17 07:55:33.000000000","message":"recheck","commit_id":"cdf573ef53e7a873638b4d757100357cc3c9c7a1"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"909e8dbba59f51a853d5a29d5b335f0ea01b42d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":33,"id":"51ad9a47_a49bd042","updated":"2022-06-16 06:07:59.000000000","message":"run-HPE Storage CI\n","commit_id":"cdf573ef53e7a873638b4d757100357cc3c9c7a1"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"13f4436d6f8b7ae97b74e655d4ea098064764f75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":38,"id":"1c937127_5d1a763a","updated":"2022-06-30 06:10:32.000000000","message":"Minor comments inline","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"cc6e1bd940ad63a6da6d2d7aa187be7c39c39041","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"682372a3_9caaf5de","updated":"2022-06-30 13:10:10.000000000","message":"run-DellEMC PowerStore CI","commit_id":"8f61fd0f1c9ed1f401dd93d6e61d44d6f5e1d044"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d6dac364fe4034e46a098340ce2f686e6808b22f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":39,"id":"d2422758_41f82a54","updated":"2022-06-30 13:44:34.000000000","message":"run-DellEMC PowerStore CI","commit_id":"8f61fd0f1c9ed1f401dd93d6e61d44d6f5e1d044"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"3a7be4d834d0bca3ab2164adbf9ad7a5517d4081","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":40,"id":"10b5ebe6_2ecccac7","updated":"2022-06-30 15:10:15.000000000","message":"run-DellEMC PowerStore CI","commit_id":"b9de297b9d55d15df18b0ba357029116af321e45"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"d84b744e827a552cfd24291f7bb3c06949fad34c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":43,"id":"549aff09_ec4f8bb3","updated":"2022-07-04 14:08:01.000000000","message":"Well done, though some minor changes required","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"5ef4890eae71570748255e25738600d35f0f2437","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":43,"id":"f9ee2c76_1c04d1d7","in_reply_to":"549aff09_ec4f8bb3","updated":"2022-07-04 16:03:00.000000000","message":"Thank you for comments!","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"ca0c0b446bbcf0976cc96e7896086d8084656158","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"92323542_21463b8b","updated":"2022-07-05 14:14:57.000000000","message":"run-DellEMC PowerStore CI","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"8736ad3da3352ab05f4b6c9175fb3ff1dacfba00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":48,"id":"93733711_050ff8cf","updated":"2022-07-05 14:13:44.000000000","message":"run-DellEMC PowerStore CI","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"96a84021bd3c18f4496cf29905d58c30c0ea5772","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":49,"id":"95a550ad_daa63393","updated":"2022-07-06 07:42:09.000000000","message":"run-DellEMC PowerStore CI","commit_id":"fffe0891843e165d1d9be35ac1eb211e841a4497"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"d1f8de13615317ff90274587d504a39e28d85c25","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":50,"id":"5f0c13fc_3c122099","updated":"2022-07-07 11:08:57.000000000","message":"run-DellEMC PowerStore CI","commit_id":"5f817e2f4a9662fe9c24ed68ac89c36b4069389f"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"0947115f5be92ce14d79dfdf3a4a0223cc411f16","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"0796081d_c4dc3dbf","updated":"2022-07-08 05:38:29.000000000","message":"run-DellEMC PowerStore CI","commit_id":"14c57293d0aa879884429ffa211c1032ac439240"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"6e3168b84a2d7a3ab13b9d5b005510f1dd4aa430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":51,"id":"6cb507c6_23bbf4a4","updated":"2022-07-07 15:53:53.000000000","message":"run-DellEMC PowerStore CI","commit_id":"14c57293d0aa879884429ffa211c1032ac439240"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"fa4871633d33de63cc7fc9482d1331e3119ef692","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"12b67528_9c42a75a","updated":"2022-07-11 02:45:39.000000000","message":"run-DellEMC PowerStore CI","commit_id":"18f935935e2fceb4ee98746fb29b86dc973083cd"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"ed5a16fc914f0e96260fa094a72b7adaf341c08b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"44daf0b1_6fec2920","updated":"2022-07-08 12:10:07.000000000","message":"run-DellEMC PowerStore CI","commit_id":"18f935935e2fceb4ee98746fb29b86dc973083cd"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"78fb41fec0f2e1409b198b70cf76664dc05b4d9b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":52,"id":"dc2934b3_339e2bbd","updated":"2022-07-08 14:37:00.000000000","message":"run-DellEMC PowerStore CI","commit_id":"18f935935e2fceb4ee98746fb29b86dc973083cd"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"1e9b2670c7a5dcf96f86be0cbdcc9476422e0fe6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"4b265f67_d083a3c3","updated":"2022-07-12 02:32:02.000000000","message":"run-DellEMC PowerStore CI","commit_id":"f9c59716d4ee0b6ce6039046a1e89fcb29dbf3b1"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"942df0a3c60b61f2ca7f3f13e99cc2d42148d459","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":53,"id":"e692fd8c_48d35037","updated":"2022-07-11 15:08:26.000000000","message":"run-DellEMC PowerStore CI","commit_id":"f9c59716d4ee0b6ce6039046a1e89fcb29dbf3b1"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"9a6a856b9f4e1d7473c57e7cae960591360d41c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":54,"id":"bb3fe259_4dbae397","updated":"2022-07-12 08:28:50.000000000","message":"run-DellEMC PowerStore CI","commit_id":"b2b5ff8c95de6611e5b169b35f6e42d64f417d93"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"1aafe87c7c78c10639aab5d65bf4339bd4a7c5a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"e48c9d3f_7217e1ae","updated":"2022-07-12 12:32:02.000000000","message":"recheck","commit_id":"d269bcbfb7fb7082fcf9ed34caf245b8dbd24364"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"db92b835f042a41f0a76d00d1e19f5d363bc9d0b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":55,"id":"4b4d8876_b1a54f37","updated":"2022-07-12 10:44:58.000000000","message":"run-DellEMC PowerStore CI","commit_id":"d269bcbfb7fb7082fcf9ed34caf245b8dbd24364"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d31056cc6ee60a9a2543a093dfa2371aef09ed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"b9cf1814_abd4804f","updated":"2022-07-13 00:37:24.000000000","message":"A few CI problems; please address the issues noted with \u0027x\u0027 or \u0027?\u0027:\n\n🗸 CI_WIKI_NAME correct in driver properties: DellEMC_PowerStore_CI\n🗸 CI wiki page is there: https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerStore_CI\n  🗸email ping to contact info on the wiki\n  🗸received pong\n🗸 checked recheck trigger\n  * trigger: \"run-DellEMC PowerStore CI\"\n? CI is responding on the new driver patch\n  (looks like it\u0027s being manually triggered)\n  * successful run comment link: https://review.opendev.org/c/openstack/cinder/+/797608/56#message-9b074ef5d778eb8f8bba77b969597db17ed7a2f6\n🗸 CI is responding on other patches\n  * https://review.opendev.org/q/reviewedby:dellemc.powerstore.ci%2540dell.com+project:openstack/cinder+-file:cinder/volume/drivers/dell_emc/powerstore/nfs.py\n  NFS: https://review.opendev.org/c/openstack/cinder/+/835384/15#message-1762263709d14cc61db248d97b269efc531490c9\nx CI is responding on os-brick patches\n  * https://review.opendev.org/q/reviewedby:dellemc.powerstore.ci%2540dell.com+project:openstack/os-brick\n  (see FC and iSCSI, but not NFS)\nx CI results\n  checked: https://review.opendev.org/c/openstack/cinder/+/797608/56#message-9b074ef5d778eb8f8bba77b969597db17ed7a2f6\n  logs: https://elab-os-logsrv.delllabs.net/08/797608/56/check/DellEMC_PowerStore_NFS/d001c5e/DellEMC_PowerStore_NFS/107\n  link doesn\u0027t seem to be to the correct logs, can\u0027t tell what\u0027s being tested\n\n","commit_id":"1ed7efe9b9fa17aaeaeb370bd6a35598d8185ca8"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"422c4aae8db47eccfa79b870389a9d14f1a4798a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"09a060da_dc168390","updated":"2022-07-13 06:57:13.000000000","message":"run-DellEMC PowerStore CI","commit_id":"1ed7efe9b9fa17aaeaeb370bd6a35598d8185ca8"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"f2518a7b5d06937468f0632ceb11efcf2c0d8e40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"befbcd28_71d86527","updated":"2022-07-12 17:00:21.000000000","message":"run-DellEMC PowerStore CI","commit_id":"1ed7efe9b9fa17aaeaeb370bd6a35598d8185ca8"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"9337f284c5d4c33ce92bef68eff8d5de06377a35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":56,"id":"cf433d6a_3250fd32","in_reply_to":"b9cf1814_abd4804f","updated":"2022-07-13 14:15:32.000000000","message":"Hi Brian! Thank you for comment!\n? CI is responding on the new driver patch, we fixed this and it works automatically\n\n x CI is responding on os-brick patches, we added nfs for os-brick\n\nx CI results, we added output","commit_id":"1ed7efe9b9fa17aaeaeb370bd6a35598d8185ca8"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"9050fbf49bdfc307e92fd239a658ac6295564373","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"cd149296_4463e3cd","updated":"2022-07-13 14:27:40.000000000","message":"LGTM","commit_id":"042c5d5912b48a46ddb50a693b1104914669d45a"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"9fa9885b0edb1b2a628409b464e4f47776e55943","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":57,"id":"5fce4c92_9ff23985","updated":"2022-07-13 14:32:02.000000000","message":"LGTM, CI passed, all comments fixed","commit_id":"042c5d5912b48a46ddb50a693b1104914669d45a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8b4e073e8668ba39831814b8eab9030e40f64eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":58,"id":"c6755986_3fd0e250","updated":"2022-07-20 20:02:00.000000000","message":"CI passed, code looks good","commit_id":"fb29d0392b245b9cf0225f18736611dec51621ce"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"f0d90b1b3a590add858abe263ffbb2a87063ef99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":59,"id":"b77a4a46_dcd5d65d","updated":"2022-07-25 02:42:29.000000000","message":"run-DellEMC PowerStore CI","commit_id":"c0bf1920976dfcd6af963b1d2a07ecce4645e5a9"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"c16b27c719dc71cce1ef428897a0be3b5278bc9d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":60,"id":"ec6bbffc_487cecf0","updated":"2022-07-25 08:38:49.000000000","message":"run-DellEMC PowerStore CI","commit_id":"b6ed49135d11bbc10e092f64723972ec8da7749c"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"89dafdafaa71f19c4c87787def9cfd3d07831eda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"2c37c920_0cc269a1","updated":"2022-07-25 15:53:30.000000000","message":"I see a few things that need to be addressed here.  Especially missing documentation.  Also CI is failing.","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"40ac6ddb1820789a42ec34338bed76c9bf1542ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":61,"id":"0a6e543e_a847413e","in_reply_to":"2c37c920_0cc269a1","updated":"2022-07-25 16:03:20.000000000","message":"Jay, thank you for comments! I will fix it.","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc78ee6af19244f7ae83e26cb6e3708352874aea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"3301e83c_57558a9e","updated":"2022-07-25 18:31:49.000000000","message":"run-DellEMC PowerStore CI","commit_id":"438a96570eff0289fcc4e74882bd1bb0413dfd24"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"d0b3984254b144f42693de0e850de4d779672784","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":62,"id":"eba91eaf_96e186ac","updated":"2022-07-25 18:35:07.000000000","message":"run-DellEMC PowerStore CI","commit_id":"438a96570eff0289fcc4e74882bd1bb0413dfd24"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"dd5222bb_a60908ca","updated":"2022-07-27 05:03:22.000000000","message":"Hi Ivan, I\u0027ve added a few comments for your consideration.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"81667378878719cc789b9065437dd77a4df36557","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"86d460d9_7c85414a","updated":"2022-07-26 08:58:14.000000000","message":"LGTM","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"80c33a395bd2dcf6a1337968658d92cd689e8615","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"1dab4443_f75fc472","updated":"2022-07-26 18:42:15.000000000","message":"Thanks for addressing my comments.  I have added two nits in the documentation update.  Those could be addressed with a follow-up patch if everyone feels this is good to go from a code standpoint.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"32665ee83cdff7d0270fb8f2536992a8d8c06a99","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"67badc95_43be4e8d","updated":"2022-07-25 21:40:32.000000000","message":"recheck","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"accbfdc6_5d2a1f91","in_reply_to":"1dab4443_f75fc472","updated":"2022-07-27 08:17:59.000000000","message":"I fixed your comments. Thank you for review.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":63,"id":"3475887a_648ef8ca","in_reply_to":"dd5222bb_a60908ca","updated":"2022-07-27 08:17:59.000000000","message":"Hi Fernando! Thank you for comments. Ivan doesn\u0027t work at Dell last year.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"18509fc040ed83502254bdf525a2c849662ddcbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":64,"id":"960112b2_b3553f7c","updated":"2022-07-27 11:49:30.000000000","message":"run-DellEMC PowerStore CI","commit_id":"88926a5f500ca01e5aee6443630b925caa59980d"}],"cinder/opts.py":[{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"0ec61aaf302c86cdcdc6b4309da64d4a815db83b","unresolved":true,"context_lines":[{"line_number":81,"context_line":"from cinder.volume.drivers.dell_emc.powerstore import driver as \\"},{"line_number":82,"context_line":"    cinder_volume_drivers_dell_emc_powerstore_driver"},{"line_number":83,"context_line":"from cinder.volume.drivers.dell_emc.powerstore import nfs as \\"},{"line_number":84,"context_line":"    cinder_volume_drivers_dell_emc_powerstore_nfs"},{"line_number":85,"context_line":"from cinder.volume.drivers.dell_emc.powervault import common as \\"},{"line_number":86,"context_line":"    cinder_volume_drivers_dell_emc_powervault_common"},{"line_number":87,"context_line":"from cinder.volume.drivers.dell_emc.sc import storagecenter_common as \\"}],"source_content_type":"text/x-python","patch_set":44,"id":"d0e8d2d5_0912e947","line":84,"updated":"2022-07-05 06:49:16.000000000","message":"One more comment, as this is new driver, please, rename to cinder_volume_drivers_dell_powerstore_nfs","commit_id":"bf6eff5ef5496091e2f36b4fde9a62f5ad8c7964"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"565498f88344ca9f2e9ae84ae87c34b0bc07af53","unresolved":false,"context_lines":[{"line_number":81,"context_line":"from cinder.volume.drivers.dell_emc.powerstore import driver as \\"},{"line_number":82,"context_line":"    cinder_volume_drivers_dell_emc_powerstore_driver"},{"line_number":83,"context_line":"from cinder.volume.drivers.dell_emc.powerstore import nfs as \\"},{"line_number":84,"context_line":"    cinder_volume_drivers_dell_emc_powerstore_nfs"},{"line_number":85,"context_line":"from cinder.volume.drivers.dell_emc.powervault import common as \\"},{"line_number":86,"context_line":"    cinder_volume_drivers_dell_emc_powervault_common"},{"line_number":87,"context_line":"from cinder.volume.drivers.dell_emc.sc import storagecenter_common as \\"}],"source_content_type":"text/x-python","patch_set":44,"id":"bee2b39b_2ef4e3a6","line":84,"in_reply_to":"5b7e66c6_678fb12b","updated":"2022-07-05 08:55:48.000000000","message":"Done","commit_id":"bf6eff5ef5496091e2f36b4fde9a62f5ad8c7964"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"125d8a3277b6ed94fc7204eed5f919e9341d1b73","unresolved":true,"context_lines":[{"line_number":81,"context_line":"from cinder.volume.drivers.dell_emc.powerstore import driver as \\"},{"line_number":82,"context_line":"    cinder_volume_drivers_dell_emc_powerstore_driver"},{"line_number":83,"context_line":"from cinder.volume.drivers.dell_emc.powerstore import nfs as \\"},{"line_number":84,"context_line":"    cinder_volume_drivers_dell_emc_powerstore_nfs"},{"line_number":85,"context_line":"from cinder.volume.drivers.dell_emc.powervault import common as \\"},{"line_number":86,"context_line":"    cinder_volume_drivers_dell_emc_powervault_common"},{"line_number":87,"context_line":"from cinder.volume.drivers.dell_emc.sc import storagecenter_common as \\"}],"source_content_type":"text/x-python","patch_set":44,"id":"5b7e66c6_678fb12b","line":84,"in_reply_to":"d0e8d2d5_0912e947","updated":"2022-07-05 07:57:41.000000000","message":"We shouldn\u0027t as there is no dell directory in the path.","commit_id":"bf6eff5ef5496091e2f36b4fde9a62f5ad8c7964"}],"cinder/tests/unit/volume/drivers/dell_emc/powerstore/test_nfs.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"@ddt.ddt"},{"line_number":72,"context_line":"class PowerStoreNFSDrvierInitializeTestCase(test.TestCase):"},{"line_number":73,"context_line":"    TEST_NFS_HOST \u003d \u0027nfs-host1\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":63,"id":"51768fc4_37b2f5c5","line":72,"updated":"2022-07-27 05:03:22.000000000","message":"\"Drvier\" mistype in class name","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"@ddt.ddt"},{"line_number":72,"context_line":"class PowerStoreNFSDrvierInitializeTestCase(test.TestCase):"},{"line_number":73,"context_line":"    TEST_NFS_HOST \u003d \u0027nfs-host1\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":63,"id":"3a77f887_02934a97","line":72,"in_reply_to":"51768fc4_37b2f5c5","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":73,"context_line":"    TEST_NFS_HOST \u003d \u0027nfs-host1\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def setUp(self):"},{"line_number":76,"context_line":"        super(PowerStoreNFSDrvierInitializeTestCase, self).setUp()"},{"line_number":77,"context_line":"        self.context \u003d mock.Mock()"},{"line_number":78,"context_line":"        self.create_configuration()"},{"line_number":79,"context_line":"        self.override_config(\u0027compute_api_class\u0027, \u0027unittest.mock.Mock\u0027)"}],"source_content_type":"text/x-python","patch_set":63,"id":"a13d40f7_086bc1a8","line":76,"updated":"2022-07-27 05:03:22.000000000","message":"mistype \"Drvier\"","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":73,"context_line":"    TEST_NFS_HOST \u003d \u0027nfs-host1\u0027"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    def setUp(self):"},{"line_number":76,"context_line":"        super(PowerStoreNFSDrvierInitializeTestCase, self).setUp()"},{"line_number":77,"context_line":"        self.context \u003d mock.Mock()"},{"line_number":78,"context_line":"        self.create_configuration()"},{"line_number":79,"context_line":"        self.override_config(\u0027compute_api_class\u0027, \u0027unittest.mock.Mock\u0027)"}],"source_content_type":"text/x-python","patch_set":63,"id":"1fc75376_0d6b02a3","line":76,"in_reply_to":"a13d40f7_086bc1a8","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":166,"context_line":"        package \u003d \u0027dellfcopy\u0027"},{"line_number":167,"context_line":"        drv._execute \u003d mock.Mock("},{"line_number":168,"context_line":"            side_effect\u003dOSError("},{"line_number":169,"context_line":"                errno.ENOENT, \u0027No such file or directory\u0027"},{"line_number":170,"context_line":"            )"},{"line_number":171,"context_line":"        )"},{"line_number":172,"context_line":"        self.assertRaises(exception.VolumeDriverException,"}],"source_content_type":"text/x-python","patch_set":63,"id":"3aa58d0f_36c7e8df","line":169,"updated":"2022-07-27 05:03:22.000000000","message":"Suggestion: Missing test case for when errno !\u003d errno.ENOENT. In such condition _check_package_is_installed will reraise OSError instead of VolumeDriverException.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        package \u003d \u0027dellfcopy\u0027"},{"line_number":167,"context_line":"        drv._execute \u003d mock.Mock("},{"line_number":168,"context_line":"            side_effect\u003dOSError("},{"line_number":169,"context_line":"                errno.ENOENT, \u0027No such file or directory\u0027"},{"line_number":170,"context_line":"            )"},{"line_number":171,"context_line":"        )"},{"line_number":172,"context_line":"        self.assertRaises(exception.VolumeDriverException,"}],"source_content_type":"text/x-python","patch_set":63,"id":"f87b58df_dcc90203","line":169,"in_reply_to":"3aa58d0f_36c7e8df","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":181,"context_line":"                drv, \u0027_check_package_is_installed\u0027"},{"line_number":182,"context_line":"        ) as mock_check_package_is_installed:"},{"line_number":183,"context_line":"            drv.check_for_setup_error()"},{"line_number":184,"context_line":"            self.assertEqual(mock_check_package_is_installed.call_count, 2)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def test_check_for_setup_error_not_passed(self):"},{"line_number":187,"context_line":"        drv \u003d self.drv"}],"source_content_type":"text/x-python","patch_set":63,"id":"0ec328a3_6ab71449","line":184,"updated":"2022-07-27 05:03:22.000000000","message":"A suggestion to improve this test is to check if _check_package_is_installed is called with the correct package names:\n\nmock_check_package_is_installed.assert_has_calls(\n[mock.call(\u0027mount.nfs\u0027), mock.call(\u0027dellfcopy\u0027)]\n)","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":181,"context_line":"                drv, \u0027_check_package_is_installed\u0027"},{"line_number":182,"context_line":"        ) as mock_check_package_is_installed:"},{"line_number":183,"context_line":"            drv.check_for_setup_error()"},{"line_number":184,"context_line":"            self.assertEqual(mock_check_package_is_installed.call_count, 2)"},{"line_number":185,"context_line":""},{"line_number":186,"context_line":"    def test_check_for_setup_error_not_passed(self):"},{"line_number":187,"context_line":"        drv \u003d self.drv"}],"source_content_type":"text/x-python","patch_set":63,"id":"bafa4786_4c362b93","line":184,"in_reply_to":"0ec328a3_6ab71449","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"}],"cinder/volume/drivers/dell_emc/powerstore/driver.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc5a36dfaea6c3b079a2c5adaed8d03e8fab6808","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"2dff61b9_50a8a9aa","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"updated":"2021-07-07 14:12:29.000000000","message":"What\u0027s the reasoning behind this?\n\nnfs_qcow2_volumes being true is not the only way to end up with a qcow2-formatted volume file -- you can start with a raw volume and end up with a qcow2-formatted volume by creating and deleting snapshots while attached.","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"32cef9c6894def9a91f59a3d2952674ad7460931","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"65b3b9ff_d3c4a170","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"2dff61b9_50a8a9aa","updated":"2021-07-07 14:19:31.000000000","message":"Also, online snapshots will not work if attached to multiple instances.","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"86b5d1643d81f5cfdab2c842518747455329e642","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"7be35c38_22313251","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"2dff61b9_50a8a9aa","updated":"2021-07-07 14:22:12.000000000","message":"the original idea was to add support of multiattach. Multiattach cannot work over NFS with qcow2 volumes.","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"28a8f1754ec009c898637670d566171441f4cdda","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"d7019d51_c50d9ad3","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"3078f475_3c6e9599","updated":"2021-07-15 12:54:35.000000000","message":"we talk about online snapshots, right? Would it be possible to snapshot shut instance disks while the latter are multi-attached to different hosts?","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"9c2d81f76e5f9353a30df70a70bd445ff6dc6ef0","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"e9bda3d0_5ac86f34","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"7be35c38_22313251","updated":"2021-07-07 16:19:40.000000000","message":"Raw volumes can be multiattached while qcow2 can\u0027t. I\u0027m aware that online snapshots will be created as qcow2 files. However, snapshots are disabled by default.","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"924b8bbb4a9c8a70f3bd6d0c5c30bb289909624c","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"3078f475_3c6e9599","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"bdeb5849_9587f2d3","updated":"2021-07-14 09:30:34.000000000","message":"Thanks for review.\nNow driver throws an exception when creating snapshot for volume with enabled multiattach.\nI\u0027ve also mentioned this in documentation.","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"2bdb021e4da6b59b7e40a9d91869e63735fb56cd","unresolved":false,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"07ba61a9_b6522b5c","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"d7019d51_c50d9ad3","updated":"2021-07-15 13:32:34.000000000","message":"\u003e we talk about online snapshots, right? Would it be possible to snapshot shut instance disks while the latter are multi-attached to different hosts?\n\nprobably does not make sense since raw disks become qcow2, as Eric mentioned earlier","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cf48bd9c207b1cfa63b442575e4681a8aafb5c86","unresolved":true,"context_lines":[{"line_number":286,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":287,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":288,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":289,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"}],"source_content_type":"text/x-python","patch_set":3,"id":"bdeb5849_9587f2d3","line":289,"range":{"start_line":289,"start_character":8,"end_line":289,"end_character":77},"in_reply_to":"e9bda3d0_5ac86f34","updated":"2021-07-13 21:23:05.000000000","message":"Snapshots are disabled by default, but what happens if an operator sets nfs_snapshot_support\u003dTrue ?  If you don\u0027t want snapshots under any circumstances (and it sounds like you don\u0027t, so that you can have multiattach), you should probably override create_snapshot() so that it raises an exception, instead of relying on _check_snapshot_support() in the nfs driver to raise depending on the value of the config option.","commit_id":"b25f99b7e2b3a697f83824503c2dae296d56bc5d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b239d7167a0ba517c08b1625f9d29118405164f","unresolved":true,"context_lines":[{"line_number":296,"context_line":"            msg \u003d _(\"Can not create snapshot for volume \""},{"line_number":297,"context_line":"                    \"with enabled multiattach support.\")"},{"line_number":298,"context_line":"            LOG.error(msg)"},{"line_number":299,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":300,"context_line":"        return super(PowerStoreNFSDriver, self)._create_snapshot(snapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"19bdaa4b_55218f4e","line":299,"updated":"2021-07-16 15:11:20.000000000","message":"I\u0027m trying to figure out if there\u0027s anything else we need to worry about.  We have this dynamic check when someone requests a snapshot that will not allow the request if the volume is of a multiattach-capable type.  So we won\u0027t go from raw-\u003eqcow2.\n\nIn the other direction, when we want to multiattach a volume, we are relying on if an operator has nfs_qcow2_volumes\u003dTrue, this driver will not report as multiattach capable, and so a request to build a multiattach capable volume will not land on this backend.  So we\u0027ll never be in the situation where an operator starts cinder with nfs_qcow2_volumes\u003dTrue, operates for a while, then switches nfs_qcow2_volumes\u003dFalse, and then someone tries to multiattach a qcow2.  Is that correct?","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"5449954d59c0f3696c937ddc6afd1503b9b694ea","unresolved":false,"context_lines":[{"line_number":296,"context_line":"            msg \u003d _(\"Can not create snapshot for volume \""},{"line_number":297,"context_line":"                    \"with enabled multiattach support.\")"},{"line_number":298,"context_line":"            LOG.error(msg)"},{"line_number":299,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":300,"context_line":"        return super(PowerStoreNFSDriver, self)._create_snapshot(snapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"597a57e0_d7650c4a","line":299,"in_reply_to":"0b554cd5_700fc74f","updated":"2022-07-01 12:57:58.000000000","message":"Right now we can create snapshot when multiattach is enabled.","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"59dec499bed584d2f1cc71a596cb101024a7c57c","unresolved":true,"context_lines":[{"line_number":296,"context_line":"            msg \u003d _(\"Can not create snapshot for volume \""},{"line_number":297,"context_line":"                    \"with enabled multiattach support.\")"},{"line_number":298,"context_line":"            LOG.error(msg)"},{"line_number":299,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":300,"context_line":"        return super(PowerStoreNFSDriver, self)._create_snapshot(snapshot)"}],"source_content_type":"text/x-python","patch_set":5,"id":"0b554cd5_700fc74f","line":299,"in_reply_to":"19bdaa4b_55218f4e","updated":"2021-07-16 22:08:00.000000000","message":"We rely on the fact that administrator or other person responsible for managing services know what they do.\nFor example, the backend may become broken if administrator changes storage password or storage IP address in the configuration file. After that all volumes become unavailable.\nAlso, I haven\u0027t found another way of how to restrict multiattach.","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d957765bf8c21b5083ba3a5d71129cdee473a4d","unresolved":true,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"@interface.volumedriver"},{"line_number":271,"context_line":"class PowerStoreNFSDriver(remotefs.RevertToSnapshotMixin, nfs.NfsDriver):"},{"line_number":272,"context_line":"    \"\"\"Dell EMC PowerStore NFS Driver."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    .. code-block:: none"}],"source_content_type":"text/x-python","patch_set":6,"id":"a84d800f_44384ed4","line":271,"updated":"2021-07-23 08:45:33.000000000","message":"-1: We have a problem here:\n\n- Configure driver to do raw volumes\n- Create volume with non multi-attach type\n- Create a snapshot -\u003e current backing file is qcow2\n- Retype volume to multi-attach type (same as the old type but just setting it to multi-attach)\n- Attach volume to multiple instances\n\nAnd we end up attaching a QCOW2 file to multiple instances.","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"8c348a058e3c53609be3ea617ff2a863781db4c5","unresolved":false,"context_lines":[{"line_number":268,"context_line":""},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"@interface.volumedriver"},{"line_number":271,"context_line":"class PowerStoreNFSDriver(remotefs.RevertToSnapshotMixin, nfs.NfsDriver):"},{"line_number":272,"context_line":"    \"\"\"Dell EMC PowerStore NFS Driver."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    .. code-block:: none"}],"source_content_type":"text/x-python","patch_set":6,"id":"93dbaebf_65f55bb9","line":271,"in_reply_to":"a84d800f_44384ed4","updated":"2021-07-26 12:58:40.000000000","message":"we will disable snapshot and qcow2 support in favor of future storage side copy/clone facility","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"744862bd8ad43faf02ff094fc549e451f0acedba","unresolved":true,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"@interface.volumedriver"},{"line_number":271,"context_line":"class PowerStoreNFSDriver(remotefs.RevertToSnapshotMixin, nfs.NfsDriver):"},{"line_number":272,"context_line":"    \"\"\"Dell EMC PowerStore NFS Driver."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    .. code-block:: none"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"d3ec4b12_028d31d1","line":272,"updated":"2021-07-23 09:21:31.000000000","message":"I understand that this wants to reuse generic nfs driver methods but i think it\u0027s still better to have some separation in terms of few config parameters that are dynamically determined by remotefs driver and similarly is implemented in other filesystem type drivers.\nThis will also help in a multibackend deployment when generic nfs and PowerStore NFS are both configured.\n(Taking quobyte driver examples)\n\n1) config params for sparsed volumes and qcow2 volumes[1] will is dynamically determined during volume create in remotefs driver[2]\n2) it\u0027s more preferable to have different directories for different driver mountpoints hence driver mount point base config[3] which will also require you to set self.base parameter during initialization[4] for nfs[5]\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/quobyte.py#L49-L55\n[2] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L315-L325\n[3] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/quobyte.py#L56-L59\n[4] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/quobyte.py#L263\n[5] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L104-L105","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"8c348a058e3c53609be3ea617ff2a863781db4c5","unresolved":false,"context_lines":[{"line_number":269,"context_line":""},{"line_number":270,"context_line":"@interface.volumedriver"},{"line_number":271,"context_line":"class PowerStoreNFSDriver(remotefs.RevertToSnapshotMixin, nfs.NfsDriver):"},{"line_number":272,"context_line":"    \"\"\"Dell EMC PowerStore NFS Driver."},{"line_number":273,"context_line":""},{"line_number":274,"context_line":"    .. code-block:: none"},{"line_number":275,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"c7153f24_7eccd289","line":272,"in_reply_to":"d3ec4b12_028d31d1","updated":"2021-07-26 12:58:40.000000000","message":"\u003e I understand that this wants to reuse generic nfs driver methods but i think it\u0027s still better to have some separation in terms of few config parameters that are dynamically determined by remotefs driver and similarly is implemented in other filesystem type drivers.\n\u003e This will also help in a multibackend deployment when generic nfs and PowerStore NFS are both configured.\n\u003e (Taking quobyte driver examples)\n\u003e \n\u003e 1) config params for sparsed volumes and qcow2 volumes[1] will is dynamically determined during volume create in remotefs driver[2]\n\u003e 2) it\u0027s more preferable to have different directories for different driver mountpoints hence driver mount point base config[3] which will also require you to set self.base parameter during initialization[4] for nfs[5]\n\u003e \n\u003e [1] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/quobyte.py#L49-L55\n\u003e [2] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/remotefs.py#L315-L325\n\u003e [3] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/quobyte.py#L56-L59\n\u003e [4] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/quobyte.py#L263\n\u003e [5] https://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L104-L105\n\nWe will disable support of snapshots and qcow2 disks in favor of future copy/clone offloading feature.\nI don\u0027t see problem having different nfs mount bases - each driver section can have different values for well known parameters, e.g.\n\n[generic-nfs]\nvolume_driver \u003d cinder.volume.drivers.nfs.NfsDriver\nvolume_backend_name \u003d generic-nfs\nnas_host \u003d 10.20.30.1\nnas_share_path \u003d /psopen\nnfs_mount_point_base \u003d $state_path/generic_mounts\nnfs_sparsed_volumes \u003d False\n\n[powerstore-nfs]\nvolume_driver \u003d cinder.volume.drivers.dell_emc.powerstore.driver.PowerStoreNFSDriver\nvolume_backend_name \u003d powerstore-nfs\nnas_host \u003d 10.20.30.2\nnas_share_path \u003d /psopen2\nnfs_mount_point_base \u003d $state_path/powerstore_mounts\nnfs_sparsed_volumes \u003d True\n\nThis perfectly places volumes of different types to different folders","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d957765bf8c21b5083ba3a5d71129cdee473a4d","unresolved":true,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _update_volume_stats(self):"},{"line_number":287,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":288,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":289,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":290,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _create_snapshot(self, snapshot):"},{"line_number":293,"context_line":"        if volume_utils.is_multiattach_spec("}],"source_content_type":"text/x-python","patch_set":6,"id":"d1f958f7_c07339b8","line":290,"range":{"start_line":288,"start_character":0,"end_line":290,"end_character":77},"updated":"2021-07-23 08:45:33.000000000","message":"nit:\n\n    self._stats.update(vendor_name\u003dself.VENDOR,\n                       online_extend_support\u003dFalse,\n                       multiattach\u003dnot self.configuration.nfs_qcow2_volumes)","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"8c348a058e3c53609be3ea617ff2a863781db4c5","unresolved":false,"context_lines":[{"line_number":285,"context_line":""},{"line_number":286,"context_line":"    def _update_volume_stats(self):"},{"line_number":287,"context_line":"        super(PowerStoreNFSDriver, self)._update_volume_stats()"},{"line_number":288,"context_line":"        self._stats[\u0027vendor_name\u0027] \u003d self.VENDOR"},{"line_number":289,"context_line":"        self._stats[\u0027online_extend_support\u0027] \u003d False"},{"line_number":290,"context_line":"        self._stats[\u0027multiattach\u0027] \u003d not self.configuration.nfs_qcow2_volumes"},{"line_number":291,"context_line":""},{"line_number":292,"context_line":"    def _create_snapshot(self, snapshot):"},{"line_number":293,"context_line":"        if volume_utils.is_multiattach_spec("}],"source_content_type":"text/x-python","patch_set":6,"id":"62ef8a6b_e98bff27","line":290,"range":{"start_line":288,"start_character":0,"end_line":290,"end_character":77},"in_reply_to":"d1f958f7_c07339b8","updated":"2021-07-26 12:58:40.000000000","message":"thanks!","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"}],"cinder/volume/drivers/dell_emc/powerstore/nfs.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"250586ce9cbd128472774e1779bfeb707850f05f","unresolved":true,"context_lines":[{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":42,"context_line":"\r"},{"line_number":43,"context_line":"nfs_opts \u003d [\r"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,\r"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,\r"},{"line_number":46,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),\r"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,\r"},{"line_number":48,"context_line":"                default\u003dTrue,\r"},{"line_number":49,"context_line":"                help\u003d\u0027Create volumes as sparsed files which take no space. \u0027\r"}],"source_content_type":"text/x-python","patch_set":27,"id":"514f3299_67ea80ad","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":68},"updated":"2022-06-02 15:12:17.000000000","message":"We\u0027ve been wanting to remove support for the nfs_shares_config file configuration method from the generic NFS driver -- please don\u0027t add it here.  Use nas_host/nas_share_path instead.","commit_id":"b1401f46ed3b2352e1588ddc69cafda4549c0c3d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"9ece02df73a0909c512824732f6cd62437e77264","unresolved":true,"context_lines":[{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":42,"context_line":"\r"},{"line_number":43,"context_line":"nfs_opts \u003d [\r"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,\r"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,\r"},{"line_number":46,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),\r"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,\r"},{"line_number":48,"context_line":"                default\u003dTrue,\r"},{"line_number":49,"context_line":"                help\u003d\u0027Create volumes as sparsed files which take no space. \u0027\r"}],"source_content_type":"text/x-python","patch_set":27,"id":"67f4f57a_bf49fc18","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":68},"in_reply_to":"514f3299_67ea80ad","updated":"2022-06-02 16:05:30.000000000","message":"A bit confused by your point\ndo_setup uses nas_host/nash_share_path.\n\nDo you want us to remove the cfg.StrOpt show here?","commit_id":"b1401f46ed3b2352e1588ddc69cafda4549c0c3d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"fc30ef806ed0fb5a2844f52655ee938ff9fc68d3","unresolved":false,"context_lines":[{"line_number":41,"context_line":"LOG \u003d logging.getLogger(__name__)\r"},{"line_number":42,"context_line":"\r"},{"line_number":43,"context_line":"nfs_opts \u003d [\r"},{"line_number":44,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,\r"},{"line_number":45,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,\r"},{"line_number":46,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),\r"},{"line_number":47,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,\r"},{"line_number":48,"context_line":"                default\u003dTrue,\r"},{"line_number":49,"context_line":"                help\u003d\u0027Create volumes as sparsed files which take no space. \u0027\r"}],"source_content_type":"text/x-python","patch_set":27,"id":"152082ba_e29c6ddd","line":46,"range":{"start_line":44,"start_character":0,"end_line":46,"end_character":68},"in_reply_to":"67f4f57a_bf49fc18","updated":"2022-06-27 10:30:03.000000000","message":"deleted nfs_shares_config, anyway we not use this conf when develop driver","commit_id":"b1401f46ed3b2352e1588ddc69cafda4549c0c3d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"13f4436d6f8b7ae97b74e655d4ea098064764f75","unresolved":true,"context_lines":[{"line_number":144,"context_line":"            config \u003d self.configuration.nfs_shares_config"},{"line_number":145,"context_line":"            if not config:"},{"line_number":146,"context_line":"                msg \u003d \"No NFS config file configured (%s) \"\\"},{"line_number":147,"context_line":"                    \" % \u0027nfs_shares_config\""},{"line_number":148,"context_line":"                LOG.warning(msg)"},{"line_number":149,"context_line":"                raise exception.NfsException(msg)"},{"line_number":150,"context_line":"            if not os.path.exists(config):"}],"source_content_type":"text/x-python","patch_set":38,"id":"89b279ba_abdcea75","line":147,"updated":"2022-06-30 06:10:32.000000000","message":"Please check single quotes/double quotes.","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"ba452dd0157b648dfa06b61b530d4337b5032eda","unresolved":false,"context_lines":[{"line_number":144,"context_line":"            config \u003d self.configuration.nfs_shares_config"},{"line_number":145,"context_line":"            if not config:"},{"line_number":146,"context_line":"                msg \u003d \"No NFS config file configured (%s) \"\\"},{"line_number":147,"context_line":"                    \" % \u0027nfs_shares_config\""},{"line_number":148,"context_line":"                LOG.warning(msg)"},{"line_number":149,"context_line":"                raise exception.NfsException(msg)"},{"line_number":150,"context_line":"            if not os.path.exists(config):"}],"source_content_type":"text/x-python","patch_set":38,"id":"61750041_d69df750","line":147,"in_reply_to":"89b279ba_abdcea75","updated":"2022-06-30 14:49:38.000000000","message":"Thank you for your comments, I checked quotes and updated them.","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"13f4436d6f8b7ae97b74e655d4ea098064764f75","unresolved":true,"context_lines":[{"line_number":424,"context_line":"        LOG.debug(\u0027NAS variable secure_file_permissions setting is: %s\u0027,"},{"line_number":425,"context_line":"                  self.configuration.nas_secure_file_permissions)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        if self.configuration.nas_secure_file_permissions \u003d\u003d \u0027false\u0027:"},{"line_number":428,"context_line":"            LOG.warning(\"The NAS file permissions mode will be 666 \""},{"line_number":429,"context_line":"                        \"(allowing other/world read \u0026 write access). \""},{"line_number":430,"context_line":"                        \"This is considered an insecure NAS environment. \""}],"source_content_type":"text/x-python","patch_set":38,"id":"7f777751_a5e37571","line":427,"range":{"start_line":427,"start_character":61,"end_line":427,"end_character":68},"updated":"2022-06-30 06:10:32.000000000","message":"Query: Would this be string \u0027false\u0027 or boolean False ?","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"ba452dd0157b648dfa06b61b530d4337b5032eda","unresolved":false,"context_lines":[{"line_number":424,"context_line":"        LOG.debug(\u0027NAS variable secure_file_permissions setting is: %s\u0027,"},{"line_number":425,"context_line":"                  self.configuration.nas_secure_file_permissions)"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"        if self.configuration.nas_secure_file_permissions \u003d\u003d \u0027false\u0027:"},{"line_number":428,"context_line":"            LOG.warning(\"The NAS file permissions mode will be 666 \""},{"line_number":429,"context_line":"                        \"(allowing other/world read \u0026 write access). \""},{"line_number":430,"context_line":"                        \"This is considered an insecure NAS environment. \""}],"source_content_type":"text/x-python","patch_set":38,"id":"77cf6364_4905d12b","line":427,"range":{"start_line":427,"start_character":61,"end_line":427,"end_character":68},"in_reply_to":"7f777751_a5e37571","updated":"2022-06-30 14:49:38.000000000","message":"This option must be string, because nas_secure_file_permission option can be not only true or false, but also an auto. If look at the file /cinder/volume/drivers/remotefs.py from which we inherit, we can see these parameters in nas_opts.","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"13f4436d6f8b7ae97b74e655d4ea098064764f75","unresolved":true,"context_lines":[{"line_number":437,"context_line":"                self.configuration.nas_secure_file_operations,"},{"line_number":438,"context_line":"                nfs_mount, is_new_cinder_install)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if self.configuration.nas_secure_file_operations \u003d\u003d \u0027true\u0027:"},{"line_number":441,"context_line":"            self._execute_as_root \u003d False"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        LOG.debug(\u0027NAS secure file operations setting is: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"eecc345a_c84f0011","line":440,"range":{"start_line":440,"start_character":60,"end_line":440,"end_character":66},"updated":"2022-06-30 06:10:32.000000000","message":"Same query as above","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"ba452dd0157b648dfa06b61b530d4337b5032eda","unresolved":false,"context_lines":[{"line_number":437,"context_line":"                self.configuration.nas_secure_file_operations,"},{"line_number":438,"context_line":"                nfs_mount, is_new_cinder_install)"},{"line_number":439,"context_line":""},{"line_number":440,"context_line":"        if self.configuration.nas_secure_file_operations \u003d\u003d \u0027true\u0027:"},{"line_number":441,"context_line":"            self._execute_as_root \u003d False"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":"        LOG.debug(\u0027NAS secure file operations setting is: %s\u0027,"}],"source_content_type":"text/x-python","patch_set":38,"id":"a023d0cc_b4a4084f","line":440,"range":{"start_line":440,"start_character":60,"end_line":440,"end_character":66},"in_reply_to":"eecc345a_c84f0011","updated":"2022-06-30 14:49:38.000000000","message":"same answer.","commit_id":"f223d1ea1ffb232daa19ce386a9e42ef7194bfb6"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c83fc9185c4687c3e7ff42687e2f3947928b7870","unresolved":true,"context_lines":[{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"nfs_opts \u003d ["},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"ed2f3eb4_194d59bc","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":34},"updated":"2022-07-05 14:30:34.000000000","message":"nfs_shares_config is deprecated and being removed from the regular NFS -- why add this here?","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d85321d51bfc1bf187e8be7a110d48cda0fed407","unresolved":false,"context_lines":[{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"nfs_opts \u003d ["},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"51bef090_f20f66f3","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":34},"in_reply_to":"89876b01_7aa9d788","updated":"2022-07-07 13:54:36.000000000","message":"Yes, thank you.","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"0881cb08ac9df0deeddb2087931e51f568c6f31b","unresolved":true,"context_lines":[{"line_number":42,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"nfs_opts \u003d ["},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,"}],"source_content_type":"text/x-python","patch_set":48,"id":"89876b01_7aa9d788","line":45,"range":{"start_line":45,"start_character":15,"end_line":45,"end_character":34},"in_reply_to":"ed2f3eb4_194d59bc","updated":"2022-07-05 15:28:23.000000000","message":"Thank you for comments. If nfs options will be imported from cinder.volume.drivers.nfs. Does it fix this comment?","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"c83fc9185c4687c3e7ff42687e2f3947928b7870","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Create volumes as sparsed files which take no space. \u0027"},{"line_number":51,"context_line":"                     \u0027If set to False volume is created as regular file. \u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"0e58074c_2fd4cc3c","line":48,"updated":"2022-07-05 14:30:34.000000000","message":"Why does this option need to be redefined here?  It can be imported from the cinder.volume.drivers.nfs file.","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"15a4853550f7a2f43ff5e0b32f7d59de245e0f05","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    cfg.StrOpt(\u0027nfs_shares_config\u0027,"},{"line_number":46,"context_line":"               default\u003d\u0027/etc/cinder/nfs_shares\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027File with the list of available NFS shares.\u0027),"},{"line_number":48,"context_line":"    cfg.BoolOpt(\u0027nfs_sparsed_volumes\u0027,"},{"line_number":49,"context_line":"                default\u003dTrue,"},{"line_number":50,"context_line":"                help\u003d\u0027Create volumes as sparsed files which take no space. \u0027"},{"line_number":51,"context_line":"                     \u0027If set to False volume is created as regular file. \u0027"}],"source_content_type":"text/x-python","patch_set":48,"id":"2b9ffbe8_2988357f","line":48,"in_reply_to":"0e58074c_2fd4cc3c","updated":"2022-07-07 14:58:42.000000000","message":"Done","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d85321d51bfc1bf187e8be7a110d48cda0fed407","unresolved":true,"context_lines":[{"line_number":156,"context_line":"                              \"%(count)d attempts.\",\r"},{"line_number":157,"context_line":"                              {\u0027share\u0027: nfs_share,\r"},{"line_number":158,"context_line":"                               \u0027count\u0027: num_attempts})\r"},{"line_number":159,"context_line":"                    raise exception.NfsException(six.text_type(e))\r"},{"line_number":160,"context_line":"                LOG.debug(\"Mount attempt %(attempt)d failed: %(exc)s. \"\r"},{"line_number":161,"context_line":"                          \"Retrying mount ...\",\r"},{"line_number":162,"context_line":"                          {\u0027attempt\u0027: attempt, \u0027exc\u0027: e})\r"}],"source_content_type":"text/x-python","patch_set":50,"id":"8475810a_1cb05d6e","line":159,"range":{"start_line":159,"start_character":49,"end_line":159,"end_character":62},"updated":"2022-07-07 13:54:36.000000000","message":"Just use str() here instead of six.text_type().","commit_id":"5f817e2f4a9662fe9c24ed68ac89c36b4069389f"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"27a174343bec567bcde7c8a630ca3a84339fa6a4","unresolved":false,"context_lines":[{"line_number":156,"context_line":"                              \"%(count)d attempts.\",\r"},{"line_number":157,"context_line":"                              {\u0027share\u0027: nfs_share,\r"},{"line_number":158,"context_line":"                               \u0027count\u0027: num_attempts})\r"},{"line_number":159,"context_line":"                    raise exception.NfsException(six.text_type(e))\r"},{"line_number":160,"context_line":"                LOG.debug(\"Mount attempt %(attempt)d failed: %(exc)s. \"\r"},{"line_number":161,"context_line":"                          \"Retrying mount ...\",\r"},{"line_number":162,"context_line":"                          {\u0027attempt\u0027: attempt, \u0027exc\u0027: e})\r"}],"source_content_type":"text/x-python","patch_set":50,"id":"b36531c3_84e9b00f","line":159,"range":{"start_line":159,"start_character":49,"end_line":159,"end_character":62},"in_reply_to":"8475810a_1cb05d6e","updated":"2022-07-07 15:55:14.000000000","message":"Done","commit_id":"5f817e2f4a9662fe9c24ed68ac89c36b4069389f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9f31254e9325d7340219a625041b5589e3b67b3d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries.\r"},{"line_number":2,"context_line":"# All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":57,"id":"05b3fd4e_5aa1375a","line":1,"updated":"2022-07-15 14:46:54.000000000","message":"Please convert this file from dos to unix endlines.","commit_id":"042c5d5912b48a46ddb50a693b1104914669d45a"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"ea6c1b0682aa4bb4596130b9463847f8a67ef694","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# Copyright (c) 2020 Dell Inc. or its subsidiaries.\r"},{"line_number":2,"context_line":"# All Rights Reserved.\r"},{"line_number":3,"context_line":"#\r"},{"line_number":4,"context_line":"# Licensed under the Apache License, Version 2.0 (the \"License\"); you may\r"}],"source_content_type":"text/x-python","patch_set":57,"id":"a7e7416a_6d7339ba","line":1,"in_reply_to":"05b3fd4e_5aa1375a","updated":"2022-07-18 13:36:04.000000000","message":"Done","commit_id":"042c5d5912b48a46ddb50a693b1104914669d45a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"89dafdafaa71f19c4c87787def9cfd3d07831eda","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not nas_host:"},{"line_number":68,"context_line":"            msg \u003d _(\"There\u0027s no \u0027nas_host\u0027\")"},{"line_number":69,"context_line":"            LOG.warning(msg)"},{"line_number":70,"context_line":"            raise exception.NfsException(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":61,"id":"5d2ed68f_12b95170","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":28},"updated":"2022-07-25 15:53:30.000000000","message":"It seems like this should be a LOG.error instead of warning.","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not nas_host:"},{"line_number":68,"context_line":"            msg \u003d _(\"There\u0027s no \u0027nas_host\u0027\")"},{"line_number":69,"context_line":"            LOG.warning(msg)"},{"line_number":70,"context_line":"            raise exception.NfsException(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":61,"id":"b488ac03_cffbf79a","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":28},"in_reply_to":"18b5be4b_f882711d","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f8edc56c0ba32ba5aaf86c547e87c15ec6c9496b","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not nas_host:"},{"line_number":68,"context_line":"            msg \u003d _(\"There\u0027s no \u0027nas_host\u0027\")"},{"line_number":69,"context_line":"            LOG.warning(msg)"},{"line_number":70,"context_line":"            raise exception.NfsException(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":61,"id":"f84e6234_b6965c32","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":28},"in_reply_to":"5d2ed68f_12b95170","updated":"2022-07-25 18:10:16.000000000","message":"The exception will be logged in _init_host from the volume manager that called do_setup anyway.  We don\u0027t need to log it as LOG.error here and as LOG.exception there, probably?","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not nas_host:"},{"line_number":68,"context_line":"            msg \u003d _(\"There\u0027s no \u0027nas_host\u0027\")"},{"line_number":69,"context_line":"            LOG.warning(msg)"},{"line_number":70,"context_line":"            raise exception.NfsException(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":61,"id":"18b5be4b_f882711d","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":28},"in_reply_to":"b930c653_94da55c8","updated":"2022-07-27 05:03:22.000000000","message":"\u0027nas_host\u0027 is already being checked in parent class NfsDriver\u0027s do_setup [1]. I believe you can just drop this check from your code if you call do_setup from .\n\n[1] https://github.com/openstack/cinder/blob/25043468d3921a23eadd31df47f3d98918465ebf/cinder/volume/drivers/nfs.py#L181","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"d5d0ddd94b3d29a96ae168942df19c5b28b1fb05","unresolved":true,"context_lines":[{"line_number":66,"context_line":""},{"line_number":67,"context_line":"        if not nas_host:"},{"line_number":68,"context_line":"            msg \u003d _(\"There\u0027s no \u0027nas_host\u0027\")"},{"line_number":69,"context_line":"            LOG.warning(msg)"},{"line_number":70,"context_line":"            raise exception.NfsException(msg)"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"}],"source_content_type":"text/x-python","patch_set":61,"id":"b930c653_94da55c8","line":69,"range":{"start_line":69,"start_character":12,"end_line":69,"end_character":28},"in_reply_to":"f84e6234_b6965c32","updated":"2022-07-25 18:23:34.000000000","message":"Should I keep LOG.warning ?","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"89dafdafaa71f19c4c87787def9cfd3d07831eda","unresolved":true,"context_lines":[{"line_number":98,"context_line":"        self.multiattach_support \u003d not self.configuration.nfs_qcow2_volumes"},{"line_number":99,"context_line":"        if not self.multiattach_support:"},{"line_number":100,"context_line":"            msg \u003d _(\"Multi-attach feature won\u0027t work \""},{"line_number":101,"context_line":"                    \"with enabled qcow2 volumes\")"},{"line_number":102,"context_line":"            LOG.warning(msg)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _check_package_is_installed(self, package):"}],"source_content_type":"text/x-python","patch_set":61,"id":"fc5d0205_767d4301","line":101,"range":{"start_line":101,"start_character":21,"end_line":101,"end_character":48},"updated":"2022-07-25 15:53:30.000000000","message":"nit:  I think this would be easier to understand if it said: \"with qcow2 volumes enabled for nfs\"","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc78ee6af19244f7ae83e26cb6e3708352874aea","unresolved":false,"context_lines":[{"line_number":98,"context_line":"        self.multiattach_support \u003d not self.configuration.nfs_qcow2_volumes"},{"line_number":99,"context_line":"        if not self.multiattach_support:"},{"line_number":100,"context_line":"            msg \u003d _(\"Multi-attach feature won\u0027t work \""},{"line_number":101,"context_line":"                    \"with enabled qcow2 volumes\")"},{"line_number":102,"context_line":"            LOG.warning(msg)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def _check_package_is_installed(self, package):"}],"source_content_type":"text/x-python","patch_set":61,"id":"55947a66_bc876662","line":101,"range":{"start_line":101,"start_character":21,"end_line":101,"end_character":48},"in_reply_to":"fc5d0205_767d4301","updated":"2022-07-25 18:31:49.000000000","message":"Done","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"89dafdafaa71f19c4c87787def9cfd3d07831eda","unresolved":true,"context_lines":[{"line_number":226,"context_line":"                       new_snap_path]"},{"line_number":227,"context_line":"            self._execute(*command, run_as_root\u003dself._execute_as_root)"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            raise NotImplementedError()"},{"line_number":230,"context_line":"        self._set_rw_permissions(new_snap_path)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _create_volume_from_snapshot(self, volume, snapshot):"}],"source_content_type":"text/x-python","patch_set":61,"id":"005c2daf_dc45d0ff","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":39},"updated":"2022-07-25 15:53:30.000000000","message":"It seems like there should be a message here to indicate what the error was.  The fact that volume is encrypted and that isn\u0027t supported?","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc78ee6af19244f7ae83e26cb6e3708352874aea","unresolved":false,"context_lines":[{"line_number":226,"context_line":"                       new_snap_path]"},{"line_number":227,"context_line":"            self._execute(*command, run_as_root\u003dself._execute_as_root)"},{"line_number":228,"context_line":"        else:"},{"line_number":229,"context_line":"            raise NotImplementedError()"},{"line_number":230,"context_line":"        self._set_rw_permissions(new_snap_path)"},{"line_number":231,"context_line":""},{"line_number":232,"context_line":"    def _create_volume_from_snapshot(self, volume, snapshot):"}],"source_content_type":"text/x-python","patch_set":61,"id":"292c2596_92f90a0e","line":229,"range":{"start_line":229,"start_character":12,"end_line":229,"end_character":39},"in_reply_to":"005c2daf_dc45d0ff","updated":"2022-07-25 18:31:49.000000000","message":"Done","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"89dafdafaa71f19c4c87787def9cfd3d07831eda","unresolved":true,"context_lines":[{"line_number":282,"context_line":"    def _create_cloned_volume(self, volume, src_vref, context):"},{"line_number":283,"context_line":"        \"\"\"Clone src volume to destination volume.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        LOG.info(\u0027Cloning volume %(src)s to volume %(dst)s\u0027,"},{"line_number":286,"context_line":"                 {\u0027src\u0027: src_vref.id,"},{"line_number":287,"context_line":"                  \u0027dst\u0027: volume.id})"},{"line_number":288,"context_line":"        acceptable_states \u003d [\u0027available\u0027, \u0027backing-up\u0027, \u0027downloading\u0027]"}],"source_content_type":"text/x-python","patch_set":61,"id":"4df0cc4e_298fb9be","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":16},"updated":"2022-07-25 15:53:30.000000000","message":"Why is this using LOG.info when the others are doing a LOG.debug?","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc78ee6af19244f7ae83e26cb6e3708352874aea","unresolved":false,"context_lines":[{"line_number":282,"context_line":"    def _create_cloned_volume(self, volume, src_vref, context):"},{"line_number":283,"context_line":"        \"\"\"Clone src volume to destination volume.\"\"\""},{"line_number":284,"context_line":""},{"line_number":285,"context_line":"        LOG.info(\u0027Cloning volume %(src)s to volume %(dst)s\u0027,"},{"line_number":286,"context_line":"                 {\u0027src\u0027: src_vref.id,"},{"line_number":287,"context_line":"                  \u0027dst\u0027: volume.id})"},{"line_number":288,"context_line":"        acceptable_states \u003d [\u0027available\u0027, \u0027backing-up\u0027, \u0027downloading\u0027]"}],"source_content_type":"text/x-python","patch_set":61,"id":"c49fb612_254c8034","line":285,"range":{"start_line":285,"start_character":8,"end_line":285,"end_character":16},"in_reply_to":"4df0cc4e_298fb9be","updated":"2022-07-25 18:31:49.000000000","message":"Done","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":59,"context_line":"        self.multiattach_support \u003d False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def do_setup(self, context):"},{"line_number":62,"context_line":"        super(NfsDriver, self).do_setup(context)"},{"line_number":63,"context_line":"        nas_host \u003d getattr(self.configuration,"},{"line_number":64,"context_line":"                           \u0027nas_host\u0027,"},{"line_number":65,"context_line":"                           None)"}],"source_content_type":"text/x-python","patch_set":63,"id":"72d9a6a1_d0118b8e","line":62,"updated":"2022-07-27 05:03:22.000000000","message":"Why do you skip NfsDriver\u0027s do_setup? Was it intentional?","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":59,"context_line":"        self.multiattach_support \u003d False"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"    def do_setup(self, context):"},{"line_number":62,"context_line":"        super(NfsDriver, self).do_setup(context)"},{"line_number":63,"context_line":"        nas_host \u003d getattr(self.configuration,"},{"line_number":64,"context_line":"                           \u0027nas_host\u0027,"},{"line_number":65,"context_line":"                           None)"}],"source_content_type":"text/x-python","patch_set":63,"id":"f4ceaeb7_31081ebb","line":62,"in_reply_to":"72d9a6a1_d0118b8e","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.set_nas_security_options(self._is_voldb_empty_at_startup)"},{"line_number":75,"context_line":"        self._check_snapshot_support(setup_checking\u003dTrue)"},{"line_number":76,"context_line":"        self._check_multiattach_support()"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"aff2a5e3_13a03973","line":74,"updated":"2022-07-27 05:03:22.000000000","message":"this is already done in parent class NfsDriver [1].\n\n[1] https://github.com/openstack/cinder/blob/25043468d3921a23eadd31df47f3d98918465ebf/cinder/volume/drivers/nfs.py#L212","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":"        self.shares \u003d {}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.set_nas_security_options(self._is_voldb_empty_at_startup)"},{"line_number":75,"context_line":"        self._check_snapshot_support(setup_checking\u003dTrue)"},{"line_number":76,"context_line":"        self._check_multiattach_support()"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"ecc4139e_a1b6fdda","line":74,"in_reply_to":"aff2a5e3_13a03973","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":72,"context_line":"        self.shares \u003d {}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.set_nas_security_options(self._is_voldb_empty_at_startup)"},{"line_number":75,"context_line":"        self._check_snapshot_support(setup_checking\u003dTrue)"},{"line_number":76,"context_line":"        self._check_multiattach_support()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _check_snapshot_support(self, setup_checking\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":63,"id":"74f97c76_9bdef938","line":75,"updated":"2022-07-27 05:03:22.000000000","message":"This is done in parent class NfsDriver [1].\n\n[1]\nhttps://github.com/openstack/cinder/blob/25043468d3921a23eadd31df47f3d98918465ebf/cinder/volume/drivers/nfs.py#L212","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":72,"context_line":"        self.shares \u003d {}"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"        self.set_nas_security_options(self._is_voldb_empty_at_startup)"},{"line_number":75,"context_line":"        self._check_snapshot_support(setup_checking\u003dTrue)"},{"line_number":76,"context_line":"        self._check_multiattach_support()"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"    def _check_snapshot_support(self, setup_checking\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":63,"id":"fa10367e_792c63e6","line":75,"in_reply_to":"74f97c76_9bdef938","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":78,"context_line":"    def _check_snapshot_support(self, setup_checking\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Ensure snapshot support is enabled in config.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if not (self.configuration.nfs_snapshot_support or setup_checking):"},{"line_number":82,"context_line":"            msg \u003d _(\"NFS driver snapshot support is disabled in cinder.conf.\")"},{"line_number":83,"context_line":"            LOG.error(msg)"},{"line_number":84,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":63,"id":"b85b6c27_d8d1fcdc","line":81,"updated":"2022-07-27 05:03:22.000000000","message":"I\u0027m not sure I got the purpose of setup_checking in this condition. Is the idea to check nfs_snapshot_support\u003d\u003dTrue configuration only during driver setup? If so, this doesn\u0027t seem to be following the method docstring that says the method ensures snapshot support is enabled in config. \n\nAlso I couldn\u0027t find other calls to this method so I believe setup_checking can be safely removed.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":78,"context_line":"    def _check_snapshot_support(self, setup_checking\u003dFalse):"},{"line_number":79,"context_line":"        \"\"\"Ensure snapshot support is enabled in config.\"\"\""},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        if not (self.configuration.nfs_snapshot_support or setup_checking):"},{"line_number":82,"context_line":"            msg \u003d _(\"NFS driver snapshot support is disabled in cinder.conf.\")"},{"line_number":83,"context_line":"            LOG.error(msg)"},{"line_number":84,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":63,"id":"54fd1470_da203ec0","line":81,"in_reply_to":"b85b6c27_d8d1fcdc","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":83,"context_line":"            LOG.error(msg)"},{"line_number":84,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if self.configuration.nas_secure_file_operations \u003d\u003d \u0027true\u0027 and \\"},{"line_number":87,"context_line":"                self.configuration.nfs_snapshot_support:"},{"line_number":88,"context_line":"            msg \u003d _(\"Snapshots are not supported with \""},{"line_number":89,"context_line":"                    \"nas_secure_file_operations enabled (\u0027true\u0027 or \u0027auto\u0027). \""}],"source_content_type":"text/x-python","patch_set":63,"id":"47d99bcb_cfe7b29c","line":86,"updated":"2022-07-27 05:03:22.000000000","message":"nit: Following the OpenStack coding style it\u0027s prefered to use parentheses for line continuation instead of backslashes.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":83,"context_line":"            LOG.error(msg)"},{"line_number":84,"context_line":"            raise exception.VolumeDriverException(message\u003dmsg)"},{"line_number":85,"context_line":""},{"line_number":86,"context_line":"        if self.configuration.nas_secure_file_operations \u003d\u003d \u0027true\u0027 and \\"},{"line_number":87,"context_line":"                self.configuration.nfs_snapshot_support:"},{"line_number":88,"context_line":"            msg \u003d _(\"Snapshots are not supported with \""},{"line_number":89,"context_line":"                    \"nas_secure_file_operations enabled (\u0027true\u0027 or \u0027auto\u0027). \""}],"source_content_type":"text/x-python","patch_set":63,"id":"d543fb45_126585e6","line":86,"in_reply_to":"47d99bcb_cfe7b29c","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":107,"context_line":"                          run_as_root\u003dFalse)"},{"line_number":108,"context_line":"        except OSError as exc:"},{"line_number":109,"context_line":"            if exc.errno \u003d\u003d errno.ENOENT:"},{"line_number":110,"context_line":"                msg \u003d _(\u0027%s is not installed\u0027) % package"},{"line_number":111,"context_line":"                raise exception.VolumeDriverException(msg)"},{"line_number":112,"context_line":"            else:"},{"line_number":113,"context_line":"                raise"}],"source_content_type":"text/x-python","patch_set":63,"id":"ed0c49d5_6699f47b","line":110,"updated":"2022-07-27 05:03:22.000000000","message":"nit: I would suggest to add a period at the end of the sentence since it is intended to be exception message.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def check_for_setup_error(self):"},{"line_number":116,"context_line":"        self._check_package_is_installed(\u0027mount.nfs\u0027)"},{"line_number":117,"context_line":"        self._check_package_is_installed(\u0027dellfcopy\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _update_volume_stats(self):"}],"source_content_type":"text/x-python","patch_set":63,"id":"7238afdf_d86d5d21","line":116,"updated":"2022-07-27 05:03:22.000000000","message":"Parent class NfsDriver already checks if mount.nfs is installed[1]. There is any special reason to do it here? \n\n[1] https://github.com/openstack/cinder/blob/25043468d3921a23eadd31df47f3d98918465ebf/cinder/volume/drivers/nfs.py#L199","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":113,"context_line":"                raise"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"    def check_for_setup_error(self):"},{"line_number":116,"context_line":"        self._check_package_is_installed(\u0027mount.nfs\u0027)"},{"line_number":117,"context_line":"        self._check_package_is_installed(\u0027dellfcopy\u0027)"},{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def _update_volume_stats(self):"}],"source_content_type":"text/x-python","patch_set":63,"id":"45d67279_e9c234e8","line":116,"in_reply_to":"7238afdf_d86d5d21","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"731f5d13fba3b68b433db6cd2baafe9a42ebf5a3","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        if not volume.provider_location:"},{"line_number":140,"context_line":"            LOG.warning(\"Volume %s does not have provider_location \""},{"line_number":141,"context_line":"                        \"specified, skipping\", volume.name)"},{"line_number":142,"context_line":"            return"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._ensure_share_mounted(volume.provider_location)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"2352e457_b3e80794","line":142,"updated":"2022-07-27 05:03:22.000000000","message":"I\u0027m not totally sure but I believe that if you just return here without a exception, the volume manager won\u0027t set the volume to \u0027error_deleting\u0027 state. This means the operator may think the volume was successfuly delete from the storage system but that might not be always the truth.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        if not volume.provider_location:"},{"line_number":140,"context_line":"            LOG.warning(\"Volume %s does not have provider_location \""},{"line_number":141,"context_line":"                        \"specified, skipping\", volume.name)"},{"line_number":142,"context_line":"            return"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._ensure_share_mounted(volume.provider_location)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"813df3e1_111edeea","line":142,"in_reply_to":"2352e457_b3e80794","updated":"2022-07-27 08:17:59.000000000","message":"same realization in NfsDriver","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"ae230c7e163d2766c76021d2ca53eeb584a6e3e3","unresolved":false,"context_lines":[{"line_number":139,"context_line":"        if not volume.provider_location:"},{"line_number":140,"context_line":"            LOG.warning(\"Volume %s does not have provider_location \""},{"line_number":141,"context_line":"                        \"specified, skipping\", volume.name)"},{"line_number":142,"context_line":"            return"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._ensure_share_mounted(volume.provider_location)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"bfe78a4b_62949bec","line":142,"in_reply_to":"4bbd5698_5d0afd01","updated":"2022-07-27 16:34:41.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"93c4b77e6174c8edd032e8f7eb160b085694df88","unresolved":true,"context_lines":[{"line_number":139,"context_line":"        if not volume.provider_location:"},{"line_number":140,"context_line":"            LOG.warning(\"Volume %s does not have provider_location \""},{"line_number":141,"context_line":"                        \"specified, skipping\", volume.name)"},{"line_number":142,"context_line":"            return"},{"line_number":143,"context_line":""},{"line_number":144,"context_line":"        self._ensure_share_mounted(volume.provider_location)"},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":63,"id":"4bbd5698_5d0afd01","line":142,"in_reply_to":"813df3e1_111edeea","updated":"2022-07-27 15:46:54.000000000","message":"If the volume doesn\u0027t have a provider_location, we assume that it failed creation before it was present on the backend storage system.  If it is there, we don\u0027t have a way to find it anyway without this info.\n\nSo, this is the right thing to do.","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0181a6e7299cb7736fe34eb62aba7027d7ee50d8","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        backing_fmt \u003d info.file_format"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if snapshot.volume.encryption_key_id is None:"},{"line_number":184,"context_line":"            self._do_fast_clone_file(volume_path, new_snap_path)"},{"line_number":185,"context_line":"            snap_info \u003d self._qemu_img_info(new_snap_path,"},{"line_number":186,"context_line":"                                            snapshot.volume.name)"},{"line_number":187,"context_line":"            if snap_info.file_format !\u003d \u0027qcow2\u0027:"}],"source_content_type":"text/x-python","patch_set":64,"id":"82759ef1_c7fe9c4b","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":36},"updated":"2022-07-27 15:51:35.000000000","message":"I don\u0027t understand what\u0027s happening here.\n\nIn the normal NFS driver, when creating a snapshot, we create a new qcow2 file with a backing file pointer pointing to the backing file.\n\nWhy is a clone done here?","commit_id":"88926a5f500ca01e5aee6443630b925caa59980d"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"cc13c4e71c3bd00f5461d35a185250dd719ef924","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        backing_fmt \u003d info.file_format"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if snapshot.volume.encryption_key_id is None:"},{"line_number":184,"context_line":"            self._do_fast_clone_file(volume_path, new_snap_path)"},{"line_number":185,"context_line":"            snap_info \u003d self._qemu_img_info(new_snap_path,"},{"line_number":186,"context_line":"                                            snapshot.volume.name)"},{"line_number":187,"context_line":"            if snap_info.file_format !\u003d \u0027qcow2\u0027:"}],"source_content_type":"text/x-python","patch_set":64,"id":"4945626a_3328234b","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":36},"in_reply_to":"40909033_59c44add","updated":"2022-07-27 16:39:50.000000000","message":"Ok, so it\u0027s not actually cloning the file?","commit_id":"88926a5f500ca01e5aee6443630b925caa59980d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"1cf0ed2e021aa87e5df9445c9b1ea7b9c6a1f000","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        backing_fmt \u003d info.file_format"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if snapshot.volume.encryption_key_id is None:"},{"line_number":184,"context_line":"            self._do_fast_clone_file(volume_path, new_snap_path)"},{"line_number":185,"context_line":"            snap_info \u003d self._qemu_img_info(new_snap_path,"},{"line_number":186,"context_line":"                                            snapshot.volume.name)"},{"line_number":187,"context_line":"            if snap_info.file_format !\u003d \u0027qcow2\u0027:"}],"source_content_type":"text/x-python","patch_set":64,"id":"ede35716_698ef174","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":36},"in_reply_to":"4945626a_3328234b","updated":"2022-07-27 16:48:14.000000000","message":"I understand what do you mean, i though what do create snapshot operation cloning volume to snapshot, and here it\u0027s creating snapshot from a volume. I can return operation back.\n\nAnd in the copy volume from snapshot we copy backing file (volume) to new volume?","commit_id":"88926a5f500ca01e5aee6443630b925caa59980d"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"ae230c7e163d2766c76021d2ca53eeb584a6e3e3","unresolved":true,"context_lines":[{"line_number":181,"context_line":"        backing_fmt \u003d info.file_format"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"        if snapshot.volume.encryption_key_id is None:"},{"line_number":184,"context_line":"            self._do_fast_clone_file(volume_path, new_snap_path)"},{"line_number":185,"context_line":"            snap_info \u003d self._qemu_img_info(new_snap_path,"},{"line_number":186,"context_line":"                                            snapshot.volume.name)"},{"line_number":187,"context_line":"            if snap_info.file_format !\u003d \u0027qcow2\u0027:"}],"source_content_type":"text/x-python","patch_set":64,"id":"40909033_59c44add","line":184,"range":{"start_line":184,"start_character":17,"end_line":184,"end_character":36},"in_reply_to":"82759ef1_c7fe9c4b","updated":"2022-07-27 16:34:41.000000000","message":"Here I am creating snapshot via dellfcopy tool instead qemu-img for fast creating snapshot. Here is also creating backing file pointer pointing to the backing file like in remotefs _do_create_snapshot.","commit_id":"88926a5f500ca01e5aee6443630b925caa59980d"}],"doc/source/configuration/block-storage/drivers/dell-emc-powerstore-nfs-driver.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9b239d7167a0ba517c08b1625f9d29118405164f","unresolved":true,"context_lines":[{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. note:: Volume multiattach is supported only for ``raw`` volumes."},{"line_number":47,"context_line":"          Snapshots are disabled for volumes with enabled multiattach support."}],"source_content_type":"text/x-rst","patch_set":5,"id":"1550f701_bb08fcf7","line":47,"updated":"2021-07-16 15:11:20.000000000","message":"You should probably add here that if ``nfs_qcow2_volumes`` is True in the config file (default is False), the driver will not report itself as multiattach-capable.","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"59dec499bed584d2f1cc71a596cb101024a7c57c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":".. note:: Volume multiattach is supported only for ``raw`` volumes."},{"line_number":47,"context_line":"          Snapshots are disabled for volumes with enabled multiattach support."}],"source_content_type":"text/x-rst","patch_set":5,"id":"07323b9e_b28ac4de","line":47,"in_reply_to":"1550f701_bb08fcf7","updated":"2021-07-16 22:08:00.000000000","message":"Done","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0d957765bf8c21b5083ba3a5d71129cdee473a4d","unresolved":true,"context_lines":[{"line_number":27,"context_line":".. code-block:: ini"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  [DEFAULT]"},{"line_number":30,"context_line":"  enabled_backends \u003d powerstore_nfs"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  [powerstore]"},{"line_number":33,"context_line":"  # Volume driver name"}],"source_content_type":"text/x-rst","patch_set":6,"id":"045bc8a1_cfc2c2ba","line":30,"range":{"start_line":30,"start_character":21,"end_line":30,"end_character":35},"updated":"2021-07-23 08:45:33.000000000","message":"-1: this doesn\u0027t match the name of the driver section below, which is [powerstore]","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"548c46db6dd12569b0b2ed924a912af23c5cf9fb","unresolved":false,"context_lines":[{"line_number":27,"context_line":".. code-block:: ini"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"  [DEFAULT]"},{"line_number":30,"context_line":"  enabled_backends \u003d powerstore_nfs"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  [powerstore]"},{"line_number":33,"context_line":"  # Volume driver name"}],"source_content_type":"text/x-rst","patch_set":6,"id":"082b48de_2db005b4","line":30,"range":{"start_line":30,"start_character":21,"end_line":30,"end_character":35},"in_reply_to":"045bc8a1_cfc2c2ba","updated":"2022-06-15 13:34:27.000000000","message":"Done","commit_id":"3aa3d30e380f2326a69cb0ffb145912cb756d4c5"}],"doc/source/configuration/block-storage/drivers/dell-emc-powerstore-nfs.rst":[{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"d84b744e827a552cfd24291f7bb3c06949fad34c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Dell EMC PowerStore NFS Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This section explains how to configure and connect the block"}],"source_content_type":"text/x-rst","patch_set":43,"id":"7b96a043_8f3b78c3","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":30},"updated":"2022-07-04 14:08:01.000000000","message":"change to \u0027Dell PowerStore NFS Driver\u0027","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"5ef4890eae71570748255e25738600d35f0f2437","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Dell EMC PowerStore NFS Driver"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This section explains how to configure and connect the block"}],"source_content_type":"text/x-rst","patch_set":43,"id":"491e0993_ac3748a9","line":2,"range":{"start_line":2,"start_character":0,"end_line":2,"end_character":30},"in_reply_to":"7b96a043_8f3b78c3","updated":"2022-07-04 16:03:00.000000000","message":"Done","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"4d2b31ef3d2d657cc40362bd225ed7595d2dcffb","unresolved":true,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This section explains how to configure and connect the block"},{"line_number":6,"context_line":"storage nodes to an PowerStore storage cluster."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Supported operations"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":56,"id":"692d0fcf_49174959","line":6,"updated":"2022-07-12 18:36:42.000000000","message":"nit: a PowerStore storage cluster.","commit_id":"1ed7efe9b9fa17aaeaeb370bd6a35598d8185ca8"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"22ece3e0925a7deab6da4151f62cf4acaa266442","unresolved":false,"context_lines":[{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"This section explains how to configure and connect the block"},{"line_number":6,"context_line":"storage nodes to an PowerStore storage cluster."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"Supported operations"},{"line_number":9,"context_line":"~~~~~~~~~~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":56,"id":"92020a8f_2cc72c6a","line":6,"in_reply_to":"692d0fcf_49174959","updated":"2022-07-13 09:18:01.000000000","message":"Done","commit_id":"1ed7efe9b9fa17aaeaeb370bd6a35598d8185ca8"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"89dafdafaa71f19c4c87787def9cfd3d07831eda","unresolved":true,"context_lines":[{"line_number":19,"context_line":"- Attach a volume to multiple servers simultaneously (multiattach)."},{"line_number":20,"context_line":"- Revert a volume to a snapshot."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Driver configuration"},{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Add the following content into ``/etc/cinder/cinder.conf``:"}],"source_content_type":"text/x-rst","patch_set":61,"id":"86babce9_f700b029","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":20},"updated":"2022-07-25 15:53:30.000000000","message":"Since there is a dependency upon dellfcopy to support more efficient operations it seems like there should be some indication of that here as well as what benefits come from having it installed and how it can be installed.","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc78ee6af19244f7ae83e26cb6e3708352874aea","unresolved":false,"context_lines":[{"line_number":19,"context_line":"- Attach a volume to multiple servers simultaneously (multiattach)."},{"line_number":20,"context_line":"- Revert a volume to a snapshot."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Driver configuration"},{"line_number":23,"context_line":"~~~~~~~~~~~~~~~~~~~~"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Add the following content into ``/etc/cinder/cinder.conf``:"}],"source_content_type":"text/x-rst","patch_set":61,"id":"eb0b405d_55835f51","line":22,"range":{"start_line":22,"start_character":0,"end_line":22,"end_character":20},"in_reply_to":"86babce9_f700b029","updated":"2022-07-25 18:31:49.000000000","message":"I added new block with information about dellfcopy tool.","commit_id":"d1dbfb94ad0f58f8cf7c10a04a893c685c64478e"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"80c33a395bd2dcf6a1337968658d92cd689e8615","unresolved":true,"context_lines":[{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"A feature for effective creation of a snapshot and creation of a volume from"},{"line_number":47,"context_line":"snapshot/volume was added in PowerStore NFS Driver. The dellfcopy provides"},{"line_number":48,"context_line":"the ability to copy a file very quickly on a Dell SDNAS filesystem"},{"line_number":49,"context_line":"mounted by a client. To download it, contact your local Dell representative."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":63,"id":"d4616ff1_e90ad63e","line":47,"range":{"start_line":47,"start_character":52,"end_line":47,"end_character":74},"updated":"2022-07-26 18:42:15.000000000","message":"\u0027The dellfcopy utility provides\u0027","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"A feature for effective creation of a snapshot and creation of a volume from"},{"line_number":47,"context_line":"snapshot/volume was added in PowerStore NFS Driver. The dellfcopy provides"},{"line_number":48,"context_line":"the ability to copy a file very quickly on a Dell SDNAS filesystem"},{"line_number":49,"context_line":"mounted by a client. To download it, contact your local Dell representative."},{"line_number":50,"context_line":""}],"source_content_type":"text/x-rst","patch_set":63,"id":"a9b53ddd_e9dcfd88","line":47,"range":{"start_line":47,"start_character":52,"end_line":47,"end_character":74},"in_reply_to":"d4616ff1_e90ad63e","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"80c33a395bd2dcf6a1337968658d92cd689e8615","unresolved":true,"context_lines":[{"line_number":54,"context_line":"- Create a volume from a snapshot."},{"line_number":55,"context_line":"- Clone a volume."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To use PowerStore NFS driver with this feature, you must install tool with the"},{"line_number":58,"context_line":"following command:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":63,"id":"1a355011_24afd0d7","line":57,"range":{"start_line":57,"start_character":51,"end_line":57,"end_character":69},"updated":"2022-07-26 18:42:15.000000000","message":"must install the tool","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"bc9ac59893c475c73e5e321f9834999bd584f0e0","unresolved":false,"context_lines":[{"line_number":54,"context_line":"- Create a volume from a snapshot."},{"line_number":55,"context_line":"- Clone a volume."},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"To use PowerStore NFS driver with this feature, you must install tool with the"},{"line_number":58,"context_line":"following command:"},{"line_number":59,"context_line":""},{"line_number":60,"context_line":".. code-block:: console"}],"source_content_type":"text/x-rst","patch_set":63,"id":"2be3fe6c_bd782a44","line":57,"range":{"start_line":57,"start_character":51,"end_line":57,"end_character":69},"in_reply_to":"1a355011_24afd0d7","updated":"2022-07-27 08:17:59.000000000","message":"Done","commit_id":"be203024332812a5752be21c7e4b6382fa8d7a25"}],"doc/source/drivers.rst":[{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"d84b744e827a552cfd24291f7bb3c06949fad34c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Available Drivers"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume Drivers"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Supported Drivers"}],"source_content_type":"text/x-rst","patch_set":43,"id":"1e909754_1590af40","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":0},"updated":"2022-07-04 14:08:01.000000000","message":"This file looks generated from .rst files and should not be committed","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"5ef4890eae71570748255e25738600d35f0f2437","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Available Drivers"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"Volume Drivers"},{"line_number":6,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":7,"context_line":"Supported Drivers"}],"source_content_type":"text/x-rst","patch_set":43,"id":"943511fb_2c61833d","line":4,"range":{"start_line":1,"start_character":0,"end_line":4,"end_character":0},"in_reply_to":"1e909754_1590af40","updated":"2022-07-04 16:03:00.000000000","message":"It\u0027s zuul answer. This file must be added.\nWarning:\n  Job openstack-tox-docs: unable to map line for file comments: \n  stderr: \u0027fatal: There is no path doc/source/drivers.rst in the commit\u0027\n  Comments left for invalid file doc/source/drivers.rst","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a0d92cba92b5309f5f90f63ec11a8e47d92210bc","unresolved":true,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Available Drivers"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":55,"id":"1d682842_1f9d7a06","line":1,"updated":"2022-07-12 14:26:52.000000000","message":"What is happening here?  This is a whole new file?","commit_id":"d269bcbfb7fb7082fcf9ed34caf245b8dbd24364"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"a6350d107797529e4409dbbaf4645da4067548ee","unresolved":false,"context_lines":[{"line_number":1,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":2,"context_line":"Available Drivers"},{"line_number":3,"context_line":"\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d\u003d"},{"line_number":4,"context_line":""}],"source_content_type":"text/x-rst","patch_set":55,"id":"33ce1360_dd2566e3","line":1,"in_reply_to":"1d682842_1f9d7a06","updated":"2022-07-12 15:34:39.000000000","message":"File deleted","commit_id":"d269bcbfb7fb7082fcf9ed34caf245b8dbd24364"}],"doc/source/reference/support-matrix.ini":[{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"31ddc68c200941ca15d1ad0c8bab3df57c49e42e","unresolved":true,"context_lines":[{"line_number":19,"context_line":"title\u003dDatera Storage Driver (iSCSI)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[driver.dell_emc_xtremio]"},{"line_number":22,"context_line":"title\u003dDell EMC XtremeIO Storage Driver (FC, iSCSI)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[driver.dell_emc_powermax]"},{"line_number":25,"context_line":"title\u003dDell EMC PowerMax (2000, 8000) Storage Driver (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":44,"id":"a802040f_88a71983","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":15},"updated":"2022-07-05 08:15:10.000000000","message":"Please, remove all \u0027EMC\u0027 from the storage\u0027s names","commit_id":"bf6eff5ef5496091e2f36b4fde9a62f5ad8c7964"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"881c2b6e4bc8b2ad3b69944ceb1f4d02c195ab92","unresolved":false,"context_lines":[{"line_number":19,"context_line":"title\u003dDatera Storage Driver (iSCSI)"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"[driver.dell_emc_xtremio]"},{"line_number":22,"context_line":"title\u003dDell EMC XtremeIO Storage Driver (FC, iSCSI)"},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"[driver.dell_emc_powermax]"},{"line_number":25,"context_line":"title\u003dDell EMC PowerMax (2000, 8000) Storage Driver (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":44,"id":"fcb067cd_f8e1e3cc","line":22,"range":{"start_line":22,"start_character":11,"end_line":22,"end_character":15},"in_reply_to":"a802040f_88a71983","updated":"2022-07-05 08:35:21.000000000","message":"removed","commit_id":"bf6eff5ef5496091e2f36b4fde9a62f5ad8c7964"}],"etc/cinder/rootwrap.d/volume.filters":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"07a2f3c940183edabec6067c525a03f5aeb452fe","unresolved":true,"context_lines":[{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user\r"},{"line_number":3,"context_line":"\r"},{"line_number":4,"context_line":"[Filters]\r"},{"line_number":5,"context_line":"# cinder/volume/targets/iscsi.py: target_helper \u0027--op\u0027 ...\r"},{"line_number":6,"context_line":"iscsictl: CommandFilter, iscsictl, root\r"},{"line_number":7,"context_line":"cinder-rtstool: CommandFilter, cinder-rtstool, root\r"},{"line_number":8,"context_line":"\r"}],"source_content_type":"application/octet-stream","patch_set":48,"id":"daa235fb_d983ca1f","line":5,"updated":"2022-07-05 14:32:18.000000000","message":"endlines have been changed in this file.  Please fix this.","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"6cc29b5bfa563cc2c00d92957b8e7e9ba59bed8c","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user\r"},{"line_number":3,"context_line":"\r"},{"line_number":4,"context_line":"[Filters]\r"},{"line_number":5,"context_line":"# cinder/volume/targets/iscsi.py: target_helper \u0027--op\u0027 ...\r"},{"line_number":6,"context_line":"iscsictl: CommandFilter, iscsictl, root\r"},{"line_number":7,"context_line":"cinder-rtstool: CommandFilter, cinder-rtstool, root\r"},{"line_number":8,"context_line":"\r"}],"source_content_type":"application/octet-stream","patch_set":48,"id":"2c6df6ef_90dab875","line":5,"in_reply_to":"daa235fb_d983ca1f","updated":"2022-07-07 14:37:38.000000000","message":"Done","commit_id":"42837a50d12e6b51b38f337685d40dad2da12183"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d85321d51bfc1bf187e8be7a110d48cda0fed407","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# cinder-rootwrap command filters for volume nodes"},{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"}],"source_content_type":"application/octet-stream","patch_set":50,"id":"da0feb0c_90398376","line":1,"updated":"2022-07-07 13:54:36.000000000","message":"Please fix unnecessary changes to this file.","commit_id":"5f817e2f4a9662fe9c24ed68ac89c36b4069389f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"37e62cd6eacdb3ea53c52388247993590093f40f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# cinder-rootwrap command filters for volume nodes"},{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"}],"source_content_type":"application/octet-stream","patch_set":50,"id":"8ceb3cfe_6be3f262","line":1,"in_reply_to":"8f0a23e8_ba5b72f9","updated":"2022-07-07 15:51:21.000000000","message":"Sorry, this has been done already.","commit_id":"5f817e2f4a9662fe9c24ed68ac89c36b4069389f"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"6cc29b5bfa563cc2c00d92957b8e7e9ba59bed8c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"# cinder-rootwrap command filters for volume nodes"},{"line_number":2,"context_line":"# This file should be owned by (and only-writeable by) the root user"},{"line_number":3,"context_line":""},{"line_number":4,"context_line":"[Filters]"}],"source_content_type":"application/octet-stream","patch_set":50,"id":"8f0a23e8_ba5b72f9","line":1,"in_reply_to":"da0feb0c_90398376","updated":"2022-07-07 14:37:38.000000000","message":"Sorry, I don\u0027t get it. Could you please explain comment?","commit_id":"5f817e2f4a9662fe9c24ed68ac89c36b4069389f"}],"releasenotes/notes/bp-powerstore-nfs-cinder-driver-b743a8a89acafa35.yaml":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"3745599a7d705e9fb6da02e1ac3ae4ac7789743b","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added Dell EMC PowerStore Storage Driver (NFS)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9870e543_0585cd38","line":4,"updated":"2021-07-16 15:16:49.000000000","message":":nit: From the documentation [1] _For release notes related to a specific driver -be it volume, backup, or zone manager- the release note line must start with \u003cdriver-name\u003e driver:._ I think the right format of the release note should be:\n```\nDell EMC PowerStore: Added NFS Storage Driver \n```\nor something like that. \n\n[1] https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":31016,"name":"Ivan Pchelintsev","email":"i.pchelintsev@yadro.com","username":"pcheli"},"change_message_id":"59dec499bed584d2f1cc71a596cb101024a7c57c","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added Dell EMC PowerStore Storage Driver (NFS)."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"2ef96eba_44a21236","line":4,"in_reply_to":"9870e543_0585cd38","updated":"2021-07-16 22:08:00.000000000","message":"Done","commit_id":"c7e562b21e139b49ceb4b9a8b215e934136828bc"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"d84b744e827a552cfd24291f7bb3c06949fad34c","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell EMC PowerStore: Added NFS storage driver."}],"source_content_type":"text/x-yaml","patch_set":43,"id":"cbf2edc8_7e2d74a5","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":13},"updated":"2022-07-04 14:08:01.000000000","message":"remove \u0027EMC\u0027","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"5ef4890eae71570748255e25738600d35f0f2437","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Dell EMC PowerStore: Added NFS storage driver."}],"source_content_type":"text/x-yaml","patch_set":43,"id":"e97fe7cf_84ca707c","line":4,"range":{"start_line":4,"start_character":9,"end_line":4,"end_character":13},"in_reply_to":"cbf2edc8_7e2d74a5","updated":"2022-07-04 16:03:00.000000000","message":"Done!","commit_id":"b332ea465cfed3befdeca4d757bd3794b97226ab"}]}