)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9d2df527dcf07e5c2d46a813ced0c5caf1c7657f","unresolved":true,"context_lines":[{"line_number":10,"context_line":"as its own parameter and as part of the extra_specs"},{"line_number":11,"context_line":"dict.  This fix checks both location to see if this"},{"line_number":12,"context_line":"force flag should be passed to the REST payload."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1981420"},{"line_number":15,"context_line":"Change-Id: I990b3e5d85054165281b7ed14cbfcc125365b20d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3286cfb0_3e14c2cc","line":13,"updated":"2022-08-11 03:01:57.000000000","message":"I think you should include a reference to https://review.opendev.org/c/openstack/cinder/+/746758 (or change I67d8b0dd4879db86a910f) in the commit message, because it makes this patch much more understandable.  Also, it would be good to say that this isn\u0027t an extra_spec that an operator can set; it\u0027s set internally by the driver based on other information.","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"ecf7f1b2fdfd66c3fd649736aaada469822e18a5","unresolved":false,"context_lines":[{"line_number":10,"context_line":"as its own parameter and as part of the extra_specs"},{"line_number":11,"context_line":"dict.  This fix checks both location to see if this"},{"line_number":12,"context_line":"force flag should be passed to the REST payload."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1981420"},{"line_number":15,"context_line":"Change-Id: I990b3e5d85054165281b7ed14cbfcc125365b20d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"0ab5bbc9_96743276","line":13,"in_reply_to":"3286cfb0_3e14c2cc","updated":"2022-08-11 10:58:45.000000000","message":"Done","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a8eefac8cc56a4ffa0e6ffc8c83edd049d9ae6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5faa5e4_85b3d68f","updated":"2022-05-24 22:28:30.000000000","message":"LGTM.","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"cb7780d68a004c0bf18cb4784c4ad72123ee923d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"add4c77a_eef08633","updated":"2021-11-03 05:29:39.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"a89ede20f78ea38c3688c7039fefc92209abefdf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4f5f8b8_add928e9","updated":"2021-10-21 03:03:50.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"64e60efd0c49de9affa1ae7a3cdf4c8d90fe0fac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fd2cb144_58c614bf","updated":"2021-11-01 07:33:57.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"129f14d156c5a38cc697637f87fba4d165672cf1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d5eda80c_b7e2aa9d","in_reply_to":"add4c77a_eef08633","updated":"2022-06-29 12:16:59.000000000","message":"Done","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"604930834a66bc99303b3478d76e0250377ca498","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ade5a834_15e650d3","updated":"2022-07-06 18:51:37.000000000","message":"Code and tests look fine.  Is there a bug filed for this?  It looks like something that users might notice, since the extra_specs were checked in some cases and not others, so a release note might also be a good idea.  (Or, if there aren\u0027t really user-facing consequences, you can explain that in the bug.)","commit_id":"435e65a38e4152560c68fdb0d43a0cd9563e8c7c"},{"author":{"_account_id":31981,"name":"Tarun Mathur","email":"tarun.mathur@dell.com"},"change_message_id":"972845b3e4134aac04b29726e360cacd80768980","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e7775a0_86fed48c","updated":"2022-07-07 05:51:31.000000000","message":"Oleg - The OPT for this change is 588176 with the summary as \"Creating synchronous volume in GVG fails\".","commit_id":"435e65a38e4152560c68fdb0d43a0cd9563e8c7c"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"4ee0c6be9ef8ae1a183c34c53fa4312ff64890e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5fa5432e_41ede651","updated":"2022-06-29 13:36:02.000000000","message":"recheck","commit_id":"435e65a38e4152560c68fdb0d43a0cd9563e8c7c"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"4c15728d774ae68c860fff06e44ab24700cc392d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"46ac86d4_1f777c05","updated":"2022-06-29 13:57:04.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"435e65a38e4152560c68fdb0d43a0cd9563e8c7c"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"6b38e0ba3a35577763241ca24ae2193876a0a38b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"8c56e67c_791aab38","updated":"2022-06-30 02:31:11.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"435e65a38e4152560c68fdb0d43a0cd9563e8c7c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"297928754e3025fea7b88dd45255692d2406e519","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"fdf71f30_f77bc31c","updated":"2022-08-08 13:42:04.000000000","message":"I have some questions about the code and test.  Also, how does an operator know how to use the extra_specs setting?","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"87b72a0e4b13f53226615fb95aea3ab2dea91bec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e058deb_6173d111","updated":"2022-07-16 01:55:12.000000000","message":"LGTM","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d81edab7972a5e4bc2fb5875b67e086c92f68732","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a5d0ede7_8cf267a1","updated":"2022-07-18 06:40:03.000000000","message":"LGTM","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"bde4ee890e866358ddad5516184bcf6509518d73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"97ce63a4_0625982d","updated":"2022-07-12 11:22:51.000000000","message":"Looks good, link to bug added, no need in release notes change as original code was incorrect and gets fixed with this patch","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"8d29909988ae10397503ac20be09569e598f0701","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a89431ac_a82c2151","updated":"2022-07-12 12:57:31.000000000","message":"recheck","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"1b5ddf1738485e8e1d618b8c00db6e0f3326ce3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"24d47371_08f51ec0","updated":"2022-08-01 15:28:32.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"b56531291e81bed6e9467227152965483130225a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"7ad5bf62_37516463","updated":"2022-08-02 08:08:12.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7951503529c8470a48958838a98587b53433820c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e40a68ee_a9ab188d","updated":"2022-07-20 21:12:17.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"f4d19c49a071fcd8e7c9b6715b1fadc499fb2144","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"eb38e978_d9f2f662","updated":"2022-07-25 13:08:26.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9d2df527dcf07e5c2d46a813ced0c5caf1c7657f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a462da79_084e22c0","updated":"2022-08-11 03:01:57.000000000","message":"Thanks for the reference to https://review.opendev.org/c/openstack/cinder/+/746758; now I understand what this patch is doing much better.  A few comments inline, but nothing major.","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"921664553e8d89d06bd803b29801b8ede6ae6650","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5c01089c_92b16eb2","updated":"2022-08-08 19:11:57.000000000","message":"recheck","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"4cded677a97b6af91b8b98f5073a1ad7babb16fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7ca9b3d9_0dd7f404","updated":"2022-08-09 14:03:29.000000000","message":"recheck","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"e898e032567e7fe091e9b38da4a6c71b46033b93","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9d095d9b_7dc8f6c3","updated":"2022-08-09 08:38:51.000000000","message":"recheck","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"6ad26d77b17cca27badb6345d4a9f601e27acbe9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8a67a10a_08f43a31","updated":"2022-08-09 07:46:19.000000000","message":"recheck ","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"cafcd16cbde81a1fdd4d77eb879805d72a0b114b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e270d9a5_058a804f","updated":"2022-08-09 10:54:36.000000000","message":"recheck - openstack-tox-py39 FAILURE","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"0ed98ab666404143bb887e3ed8832d2abda6bc1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"31280432_eb80230b","updated":"2022-08-09 08:54:41.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"e3cfaad7026de456e622db47aca50e0e17ae1bf7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"75a3c2f3_d4cb3a60","updated":"2022-08-09 10:15:34.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"baecd0112d249c4f421f9d8864b6f020ae3ea35d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a5d0ac00_f734288c","updated":"2022-08-09 08:17:17.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"c220dffb2f18595794fcd7c49d8a0c052eb02178","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b4d01200_f565220f","updated":"2022-08-11 02:21:52.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"ef05e2b1704b469fe2a31b3b3f2ddb7f149bd1e2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d7ee2a24_0430dc04","updated":"2022-08-10 02:11:39.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"7261d3fd6fcc2c518b17cfddf6e88b0b8cdb2b35"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9737060e94483436f7436426bb155e19ca61c05d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"93a74735_2c7dd62c","updated":"2022-08-17 20:33:50.000000000","message":"Apparently, forgot to vote when adding my comment saying that I forgot to vote.","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3ee6cda0ad4cb005478041b109ed48522e236cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f42f7c33_4663ba1c","updated":"2022-08-17 15:53:10.000000000","message":"Forgot to vote. -1 to give you a chance to look at the unit tests (see above comment).","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"b2fb7b50730d56d1cac40d74a1276456f2de79a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"997dd718_615aa095","updated":"2022-08-18 15:53:13.000000000","message":"Hi, please see this patch:\n    https://review.opendev.org/c/openstack/cinder/+/853679\n  \nThis demonstrates how the unit test failures are happening -- objects are being directly modified rather than using mocks, and those changes are leaking between tests.\n\nUsing mock instead of directly modifying these fields should get the unit tests for powermax passing reliably.","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e224dd158bb2f64acaab939d57fa03c710e81c21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"ed0e759f_d113a99b","updated":"2022-08-17 15:52:28.000000000","message":"I\u0027m concerned about all the rechecks on Patch Set 6.  There seems to be something nondeterministic in the unit tests.  PowerMaxRestTest.test_check_force failed twice in py39 (and that\u0027s a test changed in this patch), and PowerMaxMaskingTest.test_move_volume_between_storage_groups failed 3 times in py38.\n\nCould you take a look at those and see what you think?  Because these failures are in unit tests, they will be gate blockers for all cinder changes.\n\nHere\u0027s the list of failures on PS 6:\n\nhttps://review.opendev.org/c/openstack/cinder/+/797970/4..6#message-54f81e7bcb58fe1f931af40975d4247197fe22a6\nopenstack-tox-py38\nhttps://zuul.opendev.org/t/openstack/build/925e32b5934e4f79a7421f24ed33dde2\ncinder.tests.unit.volume.drivers.dell_emc.powermax.test_powermax_masking.PowerMaxMaskingTest.test_move_volume_between_storage_groups\n\nhttps://review.opendev.org/c/openstack/cinder/+/797970/4..6#message-d016f666d3523fbf9eb10b72abe4a8ee4921ed0e\nopenstack-tox-py39\nhttps://zuul.opendev.org/t/openstack/build/2a3ccbb36bdd48b789f4619b15068fa4\ncinder.tests.unit.volume.drivers.dell_emc.powermax.test_powermax_rest.PowerMaxRestTest.test_check_force\n\nhttps://review.opendev.org/c/openstack/cinder/+/797970/4..6#message-54f81e7bcb58fe1f931af40975d4247197fe22a6\nopenstack-tox-py38\nhttps://zuul.opendev.org/t/openstack/build/925e32b5934e4f79a7421f24ed33dde2\ncinder.tests.unit.volume.drivers.dell_emc.powermax.test_powermax_masking.PowerMaxMaskingTest.test_move_volume_between_storage_groups\n\nhttps://review.opendev.org/c/openstack/cinder/+/797970/4..6#message-a028de05b241598795de0cd1cebbd399879cf274\nopenstack-tox-py38\nhttps://zuul.opendev.org/t/openstack/build/27f7cdd4125c440a8318299f966eb4b8\ncinder.tests.unit.volume.drivers.dell_emc.powermax.test_powermax_masking.PowerMaxMaskingTest.test_move_volume_between_storage_groups\n\nhttps://review.opendev.org/c/openstack/cinder/+/797970/4..6#message-7a4341e8cf62a54a5b6ecb6df793591563b88ce8\nopenstack-tox-py39\nhttps://zuul.opendev.org/t/openstack/build/bf0244d077384a06a8bdf36ae0656616\ncinder.tests.unit.volume.drivers.dell_emc.powermax.test_powermax_rest.PowerMaxRestTest.test_check_force","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"2a2a207f365f486854ae942439ad903d33cf1368","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"729c9cd8_a6a251d2","updated":"2022-09-29 14:50:04.000000000","message":"Okay, this was not touched since August 8, 2022. What now? Suppose Oleg was re-assigned to another project, quit Dell, etc. What do we do to make this forward? Someone must address comments (esp. the test failures that Eric highlighted).","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93e04cb1d24922b4820f9ff6bcdb7a6d6e9a3b8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a69663df_b11cee3b","updated":"2022-08-17 15:46:53.000000000","message":"Revisions look good, thanks!","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"83da40c5eb3536b27e660e1aba5c57504d03c17b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"42a72cdd_38a30a4e","updated":"2022-08-11 13:20:50.000000000","message":"recheck","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7615dd3e85468e0f85b6439cfa7db0ee419190bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9b87abff_3e9476a0","updated":"2022-09-29 16:29:42.000000000","message":"recheck","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"c504078dc413feee7f8b156eb1c10699c848a29d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"9f8ef061_0f51f088","updated":"2022-08-12 08:50:07.000000000","message":"recheck","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"ff1800fa82a9ef2fc59bd62ecb73aae7f4dff1e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"258a74f6_24ae0cb1","updated":"2022-08-12 11:24:00.000000000","message":"recheck ","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"91dcaae05794009230419d4becb1b30dc923ee84","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"659f5071_ae85a82a","updated":"2022-08-11 18:28:03.000000000","message":"recheck ","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"250f67f0c0458f6f407d7a59611719a9cc724400","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e7ef97bb_b0c524d7","updated":"2022-08-11 15:19:05.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"474c1cfbc9c43af0b3a25389d4bd69fccca253b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4f695b28_5a234138","in_reply_to":"729c9cd8_a6a251d2","updated":"2022-09-29 14:56:08.000000000","message":"We lost our cinder developers from Russia, all pending are expected to be replan. I\u0027ll take care of some of those depending on the complexity. But our goal is to have everything addressed.\nThanks for your concern.","commit_id":"a51aa2f4915fc492d56cedc6e54293f9d10099f4"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"31c762eeeb66ec039e5964ac1f2d13d753701283","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4a77aff4_d9c46cca","updated":"2022-11-29 00:09:14.000000000","message":"The coverage is reduced, I think: some of the new cases are not covered by old tests. But personally I think it\u0027s okay for this sort of limited function.","commit_id":"befdced41d860ff31f567d599ce3ebe4759a66fe"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"0d293a6cc83d7c7c703ce2ccbe227dbe2d984c42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"eb3fe032_4dab9439","updated":"2022-10-27 08:48:37.000000000","message":"re-check","commit_id":"befdced41d860ff31f567d599ce3ebe4759a66fe"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"fb0195199fb815165ce13bc0edeccc066ad27a7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"e4615d3d_3f88eaf7","updated":"2022-10-27 08:48:59.000000000","message":"recheck","commit_id":"befdced41d860ff31f567d599ce3ebe4759a66fe"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"b0abcbee525ae6a5b8275b286b794a565053507b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"8e651d95_c60351a8","updated":"2022-09-30 07:19:09.000000000","message":"run-HPE Storage Primera CI","commit_id":"befdced41d860ff31f567d599ce3ebe4759a66fe"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"819732c7194d8f606073e76c838f39a1d58e89fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"49763f63_123dd5ad","updated":"2023-01-23 18:04:10.000000000","message":"I missed that \u0027u\u0027 thing but I still think this looks okay.","commit_id":"353d20d62942434897463f69c97406f70103c872"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"d34c8748a408cc419f027939ab96a2ed7151f996","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"752de784_1b015bdc","updated":"2023-02-15 15:43:34.000000000","message":"I don\u0027t like the unrelated tests thrown in, such as test_get_or_rename_storage_group_rep_exists.","commit_id":"ce12a5f47ec2d9b2a2034a632809dc091c9d9b1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"eaac6588e9438ee16e563f771a7df291dbccc6e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8eee2cb4_d2a31c60","updated":"2023-02-15 14:51:23.000000000","message":"recheck py38","commit_id":"ce12a5f47ec2d9b2a2034a632809dc091c9d9b1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"968f17adc8cbcc908eea957753d2c22db72d867b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a38daac7_64643d6a","in_reply_to":"3df1cb39_800b60c0","updated":"2023-02-15 19:22:13.000000000","message":"I\u0027m not the former owner of this patch, and I assume these test come from somewhere else and are not relevant here. I\u0027d suggest to remove it and keep the last one which is related to our patchset here.","commit_id":"ce12a5f47ec2d9b2a2034a632809dc091c9d9b1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"452ed6f9848274e7eabe9b62ecc97eb338b9f98c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"a8a0b88c_3aabf995","in_reply_to":"752de784_1b015bdc","updated":"2023-02-15 15:47:50.000000000","message":"I\u0027m not getting your point, can you elaborate?","commit_id":"ce12a5f47ec2d9b2a2034a632809dc091c9d9b1a"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"326e71a6f836c2de7b16d57f103b0bf892dfbebd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3df1cb39_800b60c0","in_reply_to":"a8a0b88c_3aabf995","updated":"2023-02-15 17:28:24.000000000","message":"Look:\n    \n    [zaitcev@lebethron-enet cinder-fetch]$ git review -d 797970\n    Downloading refs/changes/70/797970/9 from gerrit\n    Switched to branch \"review/helen_walsh/bug/1981420\"\n    [zaitcev@lebethron-enet cinder-fetch]$ git show | grep test_\n    diff --git a/cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py b/cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py\n    --- a/cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py\n    +++ b/cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py\n                     self.data.test_snapshot_snap_name)\n    +    def test_get_or_rename_storage_group_rep(\n    +    def test_get_or_rename_storage_group_rep_exists(\n    +    def test_get_or_rename_storage_group_rep_does_not_exist(\n    +    def test_check_force(self):\n    [zaitcev@lebethron-enet cinder-fetch]$","commit_id":"ce12a5f47ec2d9b2a2034a632809dc091c9d9b1a"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"70e9dae053d29e8714a8eb96cb7888d597ae618d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2cf0c04e_19264b16","updated":"2023-02-16 14:45:41.000000000","message":"Cleaned up the tests but not the code.","commit_id":"d12ec79372794faa0918663142a67ea07f9a4d8f"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"97bbe6096d50f1bb0e0535375fbab67f45b3ed44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"1e78546e_08ba1e54","updated":"2023-02-23 14:04:36.000000000","message":"LGTM ","commit_id":"54528abb9f30a237cf8775d622818e923c46377d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"18d876a2f7f9741be998f45bd6daa1826956a7ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f90c526d_a84b5604","updated":"2023-02-28 10:32:29.000000000","message":"Since this is a bugfix, please add a releasenote with fixes section mentioning the end user issue that is fixed.","commit_id":"54528abb9f30a237cf8775d622818e923c46377d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"adfb6f91faf21b274886a00dd0cb07a033bb2596","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f02f3c35_dd193d53","updated":"2023-02-22 10:23:44.000000000","message":"recheck","commit_id":"54528abb9f30a237cf8775d622818e923c46377d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"c7e8ae530cde8ad9246546772b19eb2db5551624","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"690d1d17_68b2da17","updated":"2023-02-21 16:29:02.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican failure","commit_id":"54528abb9f30a237cf8775d622818e923c46377d"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f20b8f5db4ba17a200ab5f2f9333f34aef522e28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"8623782a_222c5b52","in_reply_to":"f90c526d_a84b5604","updated":"2023-02-28 13:07:11.000000000","message":"Done. Thanks for bringing this up.","commit_id":"54528abb9f30a237cf8775d622818e923c46377d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"10ad3b2d02370fdb8f9e386a0ac3a3923a34f986","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bbe992eb_89195175","updated":"2023-03-01 14:51:55.000000000","message":"Looks like the comments have been addressed and DELL ci passed. ","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5dcf857bd7c06c94b3901c575b9801261aee0da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"206a44b0_68da6225","updated":"2023-03-02 11:25:28.000000000","message":"correction needed in releasenote, the current releasenote doesn\u0027t convey the actual issue faced by end users.","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"8fe14a0968c8026e9747cf8d027857eb40be12d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8aa7cb8f_62bd1c18","updated":"2023-02-28 19:02:07.000000000","message":"still okay, I think","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b372aba0433d9d92b0e14201c5ef2abd4164316d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a07e0387_41cd5f48","in_reply_to":"206a44b0_68da6225","updated":"2023-03-02 13:29:34.000000000","message":"Comments addressed. All Dell EMC storage platforms (formerly known as EMC) have been rebranded to Dell. \nThank you!","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"366034e53e75be1a791c1dd5cb000d398b3bc879","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"9c27a04a_4487bab5","updated":"2023-03-02 15:16:52.000000000","message":"My comments are addressed. will wait for Dell PowerMax CI to report, haven\u0027t seen it\non recent PS.","commit_id":"7cde17d31afc5d1bb084d0384c6d08ff32161ff2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7dcc5b9001ff80dd7d2b42e0785c085dc057409d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f4c05c64_98f3ad67","updated":"2023-03-15 11:17:35.000000000","message":"Dell powermax CI passing now, LGTM.","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"de036ac59fa5694607da48f0ccdda3f2576e1a50","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"aafb914a_b6af44bb","updated":"2023-03-02 15:30:44.000000000","message":"LGTM, will wait for Dell CI to report.","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"443c5d26aa8c916ecbb3624d9bff545c86db0cb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"af5a7469_07548cc9","updated":"2023-03-13 14:15:08.000000000","message":"Looks like a simple fix and CI passed","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"75cbfc2adc743c5ecfa5c54a1e810bcaf387c449","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"5087620a_1ce37d30","updated":"2023-03-06 10:24:19.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican failure","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"77264cf3ccf5700e930ce55cdd6c50003ea69a71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"f1e89465_19c68943","updated":"2023-03-03 08:10:02.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican neutron issue","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"936b00e586454f4daa21cb78a6a6edc53d4049c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"2431a3a1_f6c781bd","updated":"2023-03-10 10:40:25.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"511d672d31c7b0149a74658b35ec5cacc0a93d44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bda5c540_1e9ed9de","updated":"2023-03-03 08:10:36.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"04c142987fcf6102a16548bc74433dab225273c3"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0a8eefac8cc56a4ffa0e6ffc8c83edd049d9ae6d","unresolved":true,"context_lines":[{"line_number":2490,"context_line":"                extra_specs, force_flag\u003dFalse))"},{"line_number":2491,"context_line":"        self.assertEqual("},{"line_number":2492,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2493,"context_line":"                self.data.extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"fb6b47c5_e1783dcc","line":2493,"range":{"start_line":2493,"start_character":16,"end_line":2493,"end_character":37},"updated":"2022-05-24 22:28:30.000000000","message":"OK, these are missing the \u0027force_vol_edit\u0027 field.  (I thought you were missing a test case.)","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"31b9d0e8e496ad0c4455b2d3f2993ad00546f627","unresolved":false,"context_lines":[{"line_number":2490,"context_line":"                extra_specs, force_flag\u003dFalse))"},{"line_number":2491,"context_line":"        self.assertEqual("},{"line_number":2492,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2493,"context_line":"                self.data.extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":2,"id":"57ba0daf_94c9b35c","line":2493,"range":{"start_line":2493,"start_character":16,"end_line":2493,"end_character":37},"in_reply_to":"fb6b47c5_e1783dcc","updated":"2022-06-29 17:41:05.000000000","message":"Done","commit_id":"fc5e3cec51788b12bb1239810c15dbbb12c95287"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"297928754e3025fea7b88dd45255692d2406e519","unresolved":true,"context_lines":[{"line_number":2482,"context_line":"        self.assertEqual("},{"line_number":2483,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2484,"context_line":"                self.data.extra_specs, force_flag\u003dTrue))"},{"line_number":2485,"context_line":"        extra_specs[utils.FORCE_VOL_EDIT] \u003d True"},{"line_number":2486,"context_line":"        self.assertEqual("},{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"ce41650d_c00a1d02","line":2485,"range":{"start_line":2485,"start_character":8,"end_line":2485,"end_character":48},"updated":"2022-08-08 13:42:04.000000000","message":"Does your code do some pre-processing on the extra_specs somewhere?  Because if these are just \"normal\" extra_specs, shouldn\u0027t this be a string value (e.g., \"\u003cis\u003e True\")?  (And what happens if it\u0027s set to \"\u003cis\u003e False\"?)","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9d2df527dcf07e5c2d46a813ced0c5caf1c7657f","unresolved":false,"context_lines":[{"line_number":2482,"context_line":"        self.assertEqual("},{"line_number":2483,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2484,"context_line":"                self.data.extra_specs, force_flag\u003dTrue))"},{"line_number":2485,"context_line":"        extra_specs[utils.FORCE_VOL_EDIT] \u003d True"},{"line_number":2486,"context_line":"        self.assertEqual("},{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"5002d9a8_aed89bbd","line":2485,"range":{"start_line":2485,"start_character":8,"end_line":2485,"end_character":48},"in_reply_to":"3eeacfaf_d87e7007","updated":"2022-08-11 03:01:57.000000000","message":"Ack","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"2fb4645abd8e9d260d3797bffa654693ce7c5f03","unresolved":true,"context_lines":[{"line_number":2482,"context_line":"        self.assertEqual("},{"line_number":2483,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2484,"context_line":"                self.data.extra_specs, force_flag\u003dTrue))"},{"line_number":2485,"context_line":"        extra_specs[utils.FORCE_VOL_EDIT] \u003d True"},{"line_number":2486,"context_line":"        self.assertEqual("},{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("}],"source_content_type":"text/x-python","patch_set":4,"id":"3eeacfaf_d87e7007","line":2485,"range":{"start_line":2485,"start_character":8,"end_line":2485,"end_character":48},"in_reply_to":"ce41650d_c00a1d02","updated":"2022-08-08 16:01:57.000000000","message":"Yes, please look at this https://review.opendev.org/c/openstack/cinder/+/746758\nRegarding \"\u003cis\u003e False\" is answered in another comment.","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"297928754e3025fea7b88dd45255692d2406e519","unresolved":true,"context_lines":[{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("},{"line_number":2489,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2490,"context_line":"                extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"6b2c5603_688af4d7","line":2490,"updated":"2022-08-08 13:42:04.000000000","message":"You also need to check when force_flag\u003dFalse, because it\u0027s counterintuitive that a caller passes force_flag\u003dFalse and the result is still going to be \u0027true\u0027 based on the extra_specs.","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9d2df527dcf07e5c2d46a813ced0c5caf1c7657f","unresolved":true,"context_lines":[{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("},{"line_number":2489,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2490,"context_line":"                extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"7883c9a9_25c665c3","line":2490,"in_reply_to":"3b47c56e_133bb695","updated":"2022-08-11 03:01:57.000000000","message":"Right, but when you look at this from the point of view of someone calling the function, they have 3 options:\n\n1. pass force_flag\u003dTrue -\u003e expect that force will be used\n2. don\u0027t pass anything -\u003e expect that the extra_specs flag will determine whether force is used\n3. pass force_flag\u003dFalse -\u003e this one is ambiguous ... someone might think this overrides the extra_spec\n\nThe problem with #3 is that someone might refactor the function at some point and make the passed value override the extra_spec.  But if you have a test for this, their refactor will break the unit test and they\u0027ll realize that something is wrong.  Also, it serves as documentation for how you expect the function to behave.  So I really think you should add it.","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"a7d6f43da3ebfdbaa0a830d2dfc54ea304ad8030","unresolved":true,"context_lines":[{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("},{"line_number":2489,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2490,"context_line":"                extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"3b47c56e_133bb695","line":2490,"in_reply_to":"6b2c5603_688af4d7","updated":"2022-08-08 13:51:07.000000000","message":"The test before runs with the default value of the force_flag\u003dFalse","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"ecf7f1b2fdfd66c3fd649736aaada469822e18a5","unresolved":false,"context_lines":[{"line_number":2487,"context_line":"            \u0027true\u0027, self.rest._check_force(extra_specs))"},{"line_number":2488,"context_line":"        self.assertEqual("},{"line_number":2489,"context_line":"            \u0027true\u0027, self.rest._check_force("},{"line_number":2490,"context_line":"                extra_specs, force_flag\u003dTrue))"}],"source_content_type":"text/x-python","patch_set":4,"id":"8e98ee86_a4f96292","line":2490,"in_reply_to":"7883c9a9_25c665c3","updated":"2022-08-11 10:58:45.000000000","message":"Done","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"42b3c9cc651bb1d420e52c79f95a755d238a4c46","unresolved":true,"context_lines":[{"line_number":2612,"context_line":"        self.assertIsNone(rep_info)"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"    def test_check_force(self):"},{"line_number":2615,"context_line":"        extra_specs \u003d {\u0027pool_name\u0027: u\u0027Diamond+DSS+SRP_1+000197800123\u0027,"},{"line_number":2616,"context_line":"                       \u0027slo\u0027: \u0027Diamond\u0027,"},{"line_number":2617,"context_line":"                       \u0027srp\u0027: \u0027SRP_1\u0027,"},{"line_number":2618,"context_line":"                       \u0027array\u0027: \u0027000123456789\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a07b53f_2d13a794","line":2615,"range":{"start_line":2615,"start_character":36,"end_line":2615,"end_character":38},"updated":"2023-01-23 17:23:46.000000000","message":"u\u0027\u0027 is not needed here.","commit_id":"befdced41d860ff31f567d599ce3ebe4759a66fe"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"975f9c7faef40ef36039b7bacdf37d186ce46d36","unresolved":false,"context_lines":[{"line_number":2612,"context_line":"        self.assertIsNone(rep_info)"},{"line_number":2613,"context_line":""},{"line_number":2614,"context_line":"    def test_check_force(self):"},{"line_number":2615,"context_line":"        extra_specs \u003d {\u0027pool_name\u0027: u\u0027Diamond+DSS+SRP_1+000197800123\u0027,"},{"line_number":2616,"context_line":"                       \u0027slo\u0027: \u0027Diamond\u0027,"},{"line_number":2617,"context_line":"                       \u0027srp\u0027: \u0027SRP_1\u0027,"},{"line_number":2618,"context_line":"                       \u0027array\u0027: \u0027000123456789\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"b7ae93e5_6bc517bf","line":2615,"range":{"start_line":2615,"start_character":36,"end_line":2615,"end_character":38},"in_reply_to":"5a07b53f_2d13a794","updated":"2023-01-23 17:34:30.000000000","message":"Done","commit_id":"befdced41d860ff31f567d599ce3ebe4759a66fe"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"297928754e3025fea7b88dd45255692d2406e519","unresolved":true,"context_lines":[{"line_number":3430,"context_line":""},{"line_number":3431,"context_line":"    @staticmethod"},{"line_number":3432,"context_line":"    def _check_force(extra_specs, force_flag\u003dFalse):"},{"line_number":3433,"context_line":"        \"\"\"Check if force_flag is true"},{"line_number":3434,"context_line":""},{"line_number":3435,"context_line":"        :param extra_specs: extra specs dict"},{"line_number":3436,"context_line":"        :param force_flag: force flag boolean"}],"source_content_type":"text/x-python","patch_set":4,"id":"0de73ee3_71141ea1","line":3433,"range":{"start_line":3433,"start_character":11,"end_line":3433,"end_character":37},"updated":"2022-08-08 13:42:04.000000000","message":"this is a bit misleading, it\u0027s more like:\n\n  \"\"\"Determine whether force should be used\n\n  Returns \u0027true\u0027 if force_flag is True, but if force_flag is False or missing,\n  return value depends on whether FORCE_VOL_EDIT is set in extra_specs","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"2fb4645abd8e9d260d3797bffa654693ce7c5f03","unresolved":false,"context_lines":[{"line_number":3430,"context_line":""},{"line_number":3431,"context_line":"    @staticmethod"},{"line_number":3432,"context_line":"    def _check_force(extra_specs, force_flag\u003dFalse):"},{"line_number":3433,"context_line":"        \"\"\"Check if force_flag is true"},{"line_number":3434,"context_line":""},{"line_number":3435,"context_line":"        :param extra_specs: extra specs dict"},{"line_number":3436,"context_line":"        :param force_flag: force flag boolean"}],"source_content_type":"text/x-python","patch_set":4,"id":"e328eb5c_9c2e4487","line":3433,"range":{"start_line":3433,"start_character":11,"end_line":3433,"end_character":37},"in_reply_to":"0de73ee3_71141ea1","updated":"2022-08-08 16:01:57.000000000","message":"Reworked the wording.\n\nDone.","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"297928754e3025fea7b88dd45255692d2406e519","unresolved":true,"context_lines":[{"line_number":3438,"context_line":"        :returns: str (true or false)"},{"line_number":3439,"context_line":"        \"\"\""},{"line_number":3440,"context_line":"        return \"true\" if force_flag else ("},{"line_number":3441,"context_line":"            \"true\" if utils.FORCE_VOL_EDIT in extra_specs else \"false\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"a51fc783_76419cb6","line":3441,"range":{"start_line":3441,"start_character":12,"end_line":3441,"end_character":57},"updated":"2022-08-08 13:42:04.000000000","message":"What happens if the operator configures this as \"force_vol_edit\": \"\u003cis\u003e False\" ?  (See my comment in utils.py)","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9d2df527dcf07e5c2d46a813ced0c5caf1c7657f","unresolved":false,"context_lines":[{"line_number":3438,"context_line":"        :returns: str (true or false)"},{"line_number":3439,"context_line":"        \"\"\""},{"line_number":3440,"context_line":"        return \"true\" if force_flag else ("},{"line_number":3441,"context_line":"            \"true\" if utils.FORCE_VOL_EDIT in extra_specs else \"false\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"de4e06e0_2a902ee7","line":3441,"range":{"start_line":3441,"start_character":12,"end_line":3441,"end_character":57},"in_reply_to":"12cb5882_e3f1407f","updated":"2022-08-11 03:01:57.000000000","message":"Ack","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"2fb4645abd8e9d260d3797bffa654693ce7c5f03","unresolved":true,"context_lines":[{"line_number":3438,"context_line":"        :returns: str (true or false)"},{"line_number":3439,"context_line":"        \"\"\""},{"line_number":3440,"context_line":"        return \"true\" if force_flag else ("},{"line_number":3441,"context_line":"            \"true\" if utils.FORCE_VOL_EDIT in extra_specs else \"false\")"}],"source_content_type":"text/x-python","patch_set":4,"id":"12cb5882_e3f1407f","line":3441,"range":{"start_line":3441,"start_character":12,"end_line":3441,"end_character":57},"in_reply_to":"a51fc783_76419cb6","updated":"2022-08-08 16:01:57.000000000","message":"It will return \u0027true\u0027, but in our codebase we don\u0027t set this field to False directrly (see https://review.opendev.org/c/openstack/cinder/+/746758)","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"70e9dae053d29e8714a8eb96cb7888d597ae618d","unresolved":true,"context_lines":[{"line_number":3561,"context_line":"                self.ucode_minor_level \u003e\u003d utils.UCODE_5978_HICKORY) or ("},{"line_number":3562,"context_line":"                    self.ucode_major_level \u003e\u003d utils.UCODE_6079)"},{"line_number":3563,"context_line":""},{"line_number":3564,"context_line":"    def _rename_storage_group("},{"line_number":3565,"context_line":"            self, array, old_name, new_name, extra_specs):"},{"line_number":3566,"context_line":"        \"\"\"Rename the storage group."},{"line_number":3567,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"cecf9d65_e709e983","line":3564,"updated":"2023-02-16 14:45:41.000000000","message":"This is extraneous too, don\u0027t you agree?","commit_id":"d12ec79372794faa0918663142a67ea07f9a4d8f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"83bca8fc9a45976b7c53248f7594eb938f833d25","unresolved":false,"context_lines":[{"line_number":3561,"context_line":"                self.ucode_minor_level \u003e\u003d utils.UCODE_5978_HICKORY) or ("},{"line_number":3562,"context_line":"                    self.ucode_major_level \u003e\u003d utils.UCODE_6079)"},{"line_number":3563,"context_line":""},{"line_number":3564,"context_line":"    def _rename_storage_group("},{"line_number":3565,"context_line":"            self, array, old_name, new_name, extra_specs):"},{"line_number":3566,"context_line":"        \"\"\"Rename the storage group."},{"line_number":3567,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"579a665c_6945db45","line":3564,"in_reply_to":"700786f1_222d34f7","updated":"2023-02-16 15:11:49.000000000","message":"This code comes from https://review.opendev.org/c/openstack/cinder/+/801354 but it doesn\u0027t seem to be in master although it\u0027s been merged... Weird, huh","commit_id":"d12ec79372794faa0918663142a67ea07f9a4d8f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b14e2f047a45236816045b8de6fbc71577792ba7","unresolved":false,"context_lines":[{"line_number":3561,"context_line":"                self.ucode_minor_level \u003e\u003d utils.UCODE_5978_HICKORY) or ("},{"line_number":3562,"context_line":"                    self.ucode_major_level \u003e\u003d utils.UCODE_6079)"},{"line_number":3563,"context_line":""},{"line_number":3564,"context_line":"    def _rename_storage_group("},{"line_number":3565,"context_line":"            self, array, old_name, new_name, extra_specs):"},{"line_number":3566,"context_line":"        \"\"\"Rename the storage group."},{"line_number":3567,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"700786f1_222d34f7","line":3564,"in_reply_to":"cc767cc3_a9b00ca7","updated":"2023-02-16 15:07:19.000000000","message":"Ack","commit_id":"d12ec79372794faa0918663142a67ea07f9a4d8f"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"bb87da4a91961bb4c4ddb3f106e1a420c614daaa","unresolved":true,"context_lines":[{"line_number":3561,"context_line":"                self.ucode_minor_level \u003e\u003d utils.UCODE_5978_HICKORY) or ("},{"line_number":3562,"context_line":"                    self.ucode_major_level \u003e\u003d utils.UCODE_6079)"},{"line_number":3563,"context_line":""},{"line_number":3564,"context_line":"    def _rename_storage_group("},{"line_number":3565,"context_line":"            self, array, old_name, new_name, extra_specs):"},{"line_number":3566,"context_line":"        \"\"\"Rename the storage group."},{"line_number":3567,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"cc767cc3_a9b00ca7","line":3564,"in_reply_to":"cecf9d65_e709e983","updated":"2023-02-16 15:04:33.000000000","message":"i think this addition in the code comes from an incorrect rebase. Let me clean it up.","commit_id":"d12ec79372794faa0918663142a67ea07f9a4d8f"}],"cinder/volume/drivers/dell_emc/powermax/utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"297928754e3025fea7b88dd45255692d2406e519","unresolved":true,"context_lines":[{"line_number":105,"context_line":"USED_HOST_NAME \u003d \"used_host_name\""},{"line_number":106,"context_line":"RDF_SYNCED_STATES \u003d [RDF_SYNC_STATE, RDF_CONSISTENT_STATE,"},{"line_number":107,"context_line":"                     RDF_ACTIVEACTIVE, RDF_ACTIVEBIAS]"},{"line_number":108,"context_line":"FORCE_VOL_EDIT \u003d \u0027force_vol_edit\u0027"},{"line_number":109,"context_line":"PMAX_FAILOVER_START_ARRAY_PROMOTION \u003d \u0027pmax_failover_start_array_promotion\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Multiattach constants"}],"source_content_type":"text/x-python","patch_set":4,"id":"2ab58a2a_43ff2105","line":108,"range":{"start_line":108,"start_character":18,"end_line":108,"end_character":32},"updated":"2022-08-08 13:42:04.000000000","message":"This isn\u0027t mentioned in doc/source/configuration/block-storage/drivers/dell-emc-powermax-driver.rst ... how does the operator know how to configure it, and what exactly it does?  (See my comment in rest.py)","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"2fb4645abd8e9d260d3797bffa654693ce7c5f03","unresolved":true,"context_lines":[{"line_number":105,"context_line":"USED_HOST_NAME \u003d \"used_host_name\""},{"line_number":106,"context_line":"RDF_SYNCED_STATES \u003d [RDF_SYNC_STATE, RDF_CONSISTENT_STATE,"},{"line_number":107,"context_line":"                     RDF_ACTIVEACTIVE, RDF_ACTIVEBIAS]"},{"line_number":108,"context_line":"FORCE_VOL_EDIT \u003d \u0027force_vol_edit\u0027"},{"line_number":109,"context_line":"PMAX_FAILOVER_START_ARRAY_PROMOTION \u003d \u0027pmax_failover_start_array_promotion\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Multiattach constants"}],"source_content_type":"text/x-python","patch_set":4,"id":"a5317b9e_9a6b5d55","line":108,"range":{"start_line":108,"start_character":18,"end_line":108,"end_character":32},"in_reply_to":"2ab58a2a_43ff2105","updated":"2022-08-08 16:01:57.000000000","message":"Force flag is needed to add volumes to replication enabled storage\ngroups since U4P 91. Added this flag when adding volumes to\nreplication enabled volume groups.\n\nThe conditions for setting this value were also presented here.\n\nOriginal: https://review.opendev.org/c/openstack/cinder/+/746758","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"93e04cb1d24922b4820f9ff6bcdb7a6d6e9a3b8a","unresolved":false,"context_lines":[{"line_number":105,"context_line":"USED_HOST_NAME \u003d \"used_host_name\""},{"line_number":106,"context_line":"RDF_SYNCED_STATES \u003d [RDF_SYNC_STATE, RDF_CONSISTENT_STATE,"},{"line_number":107,"context_line":"                     RDF_ACTIVEACTIVE, RDF_ACTIVEBIAS]"},{"line_number":108,"context_line":"FORCE_VOL_EDIT \u003d \u0027force_vol_edit\u0027"},{"line_number":109,"context_line":"PMAX_FAILOVER_START_ARRAY_PROMOTION \u003d \u0027pmax_failover_start_array_promotion\u0027"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"# Multiattach constants"}],"source_content_type":"text/x-python","patch_set":4,"id":"f75fee3c_541bcc34","line":108,"range":{"start_line":108,"start_character":18,"end_line":108,"end_character":32},"in_reply_to":"a5317b9e_9a6b5d55","updated":"2022-08-17 15:46:53.000000000","message":"Ack","commit_id":"ede031632809fe9529f36608b8c997feac94a7bc"}],"releasenotes/notes/bug-1981420-dell-powermax-fix-for-force-flag-9320910dfbf998d2.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5dcf857bd7c06c94b3901c575b9801261aee0da7","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1981420 \u003chttps://bugs.launchpad.net/cinder/+bug/1981420\u003e`_:"},{"line_number":5,"context_line":"    The force flag can be passed to rest.py in 2 ways,"},{"line_number":6,"context_line":"    as its own parameter and as part of the internal extra_specs"},{"line_number":7,"context_line":"    dict that is set by the driver. This fix checks both location"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"27044f7e_e9bfb312","line":4,"updated":"2023-03-02 11:25:28.000000000","message":"nit: better to mention the driver name since this is a driver specific problem.\n\n`Dell EMC PowerMax Driver Bug #1981420 ...","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b372aba0433d9d92b0e14201c5ef2abd4164316d","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1981420 \u003chttps://bugs.launchpad.net/cinder/+bug/1981420\u003e`_:"},{"line_number":5,"context_line":"    The force flag can be passed to rest.py in 2 ways,"},{"line_number":6,"context_line":"    as its own parameter and as part of the internal extra_specs"},{"line_number":7,"context_line":"    dict that is set by the driver. This fix checks both location"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"d6ff506e_e5fb7ce8","line":4,"in_reply_to":"27044f7e_e9bfb312","updated":"2023-03-02 13:29:34.000000000","message":"Done","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5dcf857bd7c06c94b3901c575b9801261aee0da7","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1981420 \u003chttps://bugs.launchpad.net/cinder/+bug/1981420\u003e`_:"},{"line_number":5,"context_line":"    The force flag can be passed to rest.py in 2 ways,"},{"line_number":6,"context_line":"    as its own parameter and as part of the internal extra_specs"},{"line_number":7,"context_line":"    dict that is set by the driver. This fix checks both location"},{"line_number":8,"context_line":"    to see if this force flag should be passed to the REST payload."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"29394f33_aa7ddfc5","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":67},"updated":"2023-03-02 11:25:28.000000000","message":"releasenotes are mostly consumed by end users/operators so it\u0027s better to explain it in terms of end user impact. taking reference from the bug, you can write something like,\n\nFixed issue faced while creating synchronous volume which was caused by incorrect handling of the force flag. This is corrected by checking volume type extra specs for the value of `force_vol_edit` parameter along with the `force` parameter.","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b372aba0433d9d92b0e14201c5ef2abd4164316d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1981420 \u003chttps://bugs.launchpad.net/cinder/+bug/1981420\u003e`_:"},{"line_number":5,"context_line":"    The force flag can be passed to rest.py in 2 ways,"},{"line_number":6,"context_line":"    as its own parameter and as part of the internal extra_specs"},{"line_number":7,"context_line":"    dict that is set by the driver. This fix checks both location"},{"line_number":8,"context_line":"    to see if this force flag should be passed to the REST payload."}],"source_content_type":"text/x-yaml","patch_set":14,"id":"674d89bb_29c91750","line":8,"range":{"start_line":5,"start_character":4,"end_line":8,"end_character":67},"in_reply_to":"29394f33_aa7ddfc5","updated":"2023-03-02 13:29:34.000000000","message":"Done","commit_id":"c6ea586de49033e758a123e68cc406e042e16414"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"366034e53e75be1a791c1dd5cb000d398b3bc879","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    `Dell PowerMax Driver Bug #1981420 \u003chttps://bugs.launchpad.net/cinder/+bug/1981420\u003e`_:"},{"line_number":5,"context_line":"    Fixed issue faced while creating synchronous volume which was caused by"},{"line_number":6,"context_line":"    incorrect handling of the force flag. This is corrected by checking volume"},{"line_number":7,"context_line":"    type extra specs for the value of  force_vol_edit  parameter along with the"},{"line_number":8,"context_line":"    force  parameter."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"44458e82_f7815d70","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":53},"updated":"2023-03-02 15:16:52.000000000","message":"nit: single/double inverted quotes","commit_id":"7cde17d31afc5d1bb084d0384c6d08ff32161ff2"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"173636bae2573d29f2e1ed6a0358d4dc18e55fde","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    `Dell PowerMax Driver Bug #1981420 \u003chttps://bugs.launchpad.net/cinder/+bug/1981420\u003e`_:"},{"line_number":5,"context_line":"    Fixed issue faced while creating synchronous volume which was caused by"},{"line_number":6,"context_line":"    incorrect handling of the force flag. This is corrected by checking volume"},{"line_number":7,"context_line":"    type extra specs for the value of  force_vol_edit  parameter along with the"},{"line_number":8,"context_line":"    force  parameter."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"007b3cfb_28c17be7","line":7,"range":{"start_line":7,"start_character":39,"end_line":7,"end_character":53},"in_reply_to":"44458e82_f7815d70","updated":"2023-03-02 15:22:56.000000000","message":"Done","commit_id":"7cde17d31afc5d1bb084d0384c6d08ff32161ff2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"366034e53e75be1a791c1dd5cb000d398b3bc879","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    Fixed issue faced while creating synchronous volume which was caused by"},{"line_number":6,"context_line":"    incorrect handling of the force flag. This is corrected by checking volume"},{"line_number":7,"context_line":"    type extra specs for the value of  force_vol_edit  parameter along with the"},{"line_number":8,"context_line":"    force  parameter."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"a0369c93_d3bba2ea","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":9},"updated":"2023-03-02 15:16:52.000000000","message":"nit: same","commit_id":"7cde17d31afc5d1bb084d0384c6d08ff32161ff2"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"173636bae2573d29f2e1ed6a0358d4dc18e55fde","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    Fixed issue faced while creating synchronous volume which was caused by"},{"line_number":6,"context_line":"    incorrect handling of the force flag. This is corrected by checking volume"},{"line_number":7,"context_line":"    type extra specs for the value of  force_vol_edit  parameter along with the"},{"line_number":8,"context_line":"    force  parameter."}],"source_content_type":"text/x-yaml","patch_set":15,"id":"020e6a7c_b0a50c02","line":8,"range":{"start_line":8,"start_character":4,"end_line":8,"end_character":9},"in_reply_to":"a0369c93_d3bba2ea","updated":"2023-03-02 15:22:56.000000000","message":"Done","commit_id":"7cde17d31afc5d1bb084d0384c6d08ff32161ff2"}]}