)]}'
{"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"027b690e24cb3bcfd2895734a01518f7561d0fef","unresolved":true,"context_lines":[{"line_number":4115,"context_line":"            is_rep_enabled, backend_ids_differ, extra_specs):"},{"line_number":4116,"context_line":"        \"\"\"Preparation for replication to non-replicated."},{"line_number":4117,"context_line":""},{"line_number":4118,"context_line":"        :param array: the array serial number -- str"},{"line_number":4119,"context_line":"        :param device_id: device_id: the device id -- str"},{"line_number":4120,"context_line":"        :param volume_name: the volume name -- str"},{"line_number":4121,"context_line":"        :param volume: the volume object -- objects.Volume"}],"source_content_type":"text/x-python","patch_set":1,"id":"1eb4bb67_eecbf19a","line":4118,"range":{"start_line":4118,"start_character":46,"end_line":4118,"end_character":52},"updated":"2021-07-28 13:51:29.000000000","message":"the type should be specified with proper docstring syntax\n:type array: str\n\nsince this is a backport, please remember to do this refactoring in master","commit_id":"2903822b9a0f7638d9e4cbb98c9d463ac840a97e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"027b690e24cb3bcfd2895734a01518f7561d0fef","unresolved":true,"context_lines":[{"line_number":5659,"context_line":""},{"line_number":5660,"context_line":"        # If volumes are being deleted along with the group, ensure snapshot"},{"line_number":5661,"context_line":"        # cleanup completes before doing any replication/storage group cleanup."},{"line_number":5662,"context_line":"        remaining_device_snapshots \u003d list()"},{"line_number":5663,"context_line":"        remaining_snapvx_targets \u003d list()"},{"line_number":5664,"context_line":"        for vol in volumes:"},{"line_number":5665,"context_line":"            extra_specs \u003d self._initial_setup(vol)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e2e67ca1_c3a3ebcc","line":5662,"range":{"start_line":5662,"start_character":37,"end_line":5662,"end_character":43},"updated":"2021-07-28 13:51:29.000000000","message":"If you just see 3 lines above, the list variable deleted_volume_device_ids is initialized as []\nThis doesn\u0027t matter much with functionality but is better to keep consistent code which is more readable.","commit_id":"2903822b9a0f7638d9e4cbb98c9d463ac840a97e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"027b690e24cb3bcfd2895734a01518f7561d0fef","unresolved":true,"context_lines":[{"line_number":5668,"context_line":"            snapshots \u003d self.rest.get_volume_snapshot_list(array, device_id)"},{"line_number":5669,"context_line":"            __, snapvx_target_details \u003d self.rest.find_snap_vx_sessions("},{"line_number":5670,"context_line":"                array, device_id, tgt_only\u003dTrue)"},{"line_number":5671,"context_line":"            if snapshots:"},{"line_number":5672,"context_line":"                snapshot_names \u003d \u0027, \u0027.join("},{"line_number":5673,"context_line":"                    snap.get(\u0027snapshotName\u0027) for snap in snapshots)"},{"line_number":5674,"context_line":"                snap_details \u003d {"},{"line_number":5675,"context_line":"                    \u0027device_id\u0027: device_id, \u0027snapshot_names\u0027: snapshot_names}"},{"line_number":5676,"context_line":"                remaining_device_snapshots.append(snap_details)"},{"line_number":5677,"context_line":"            if snapvx_target_details:"},{"line_number":5678,"context_line":"                source_vol_id \u003d snapvx_target_details.get(\u0027source_vol_id\u0027)"},{"line_number":5679,"context_line":"                snap_name \u003d snapvx_target_details.get(\u0027snap_name\u0027)"},{"line_number":5680,"context_line":"                target_details \u003d {"},{"line_number":5681,"context_line":"                    \u0027device_id\u0027: device_id, \u0027source_vol_id\u0027: source_vol_id,"},{"line_number":5682,"context_line":"                    \u0027snapshot_name\u0027: snap_name}"},{"line_number":5683,"context_line":"                remaining_snapvx_targets.append(target_details)"},{"line_number":5684,"context_line":""},{"line_number":5685,"context_line":"        # Fail out if volumes to be deleted still have snapshots."},{"line_number":5686,"context_line":"        if remaining_device_snapshots:"}],"source_content_type":"text/x-python","patch_set":1,"id":"9572e88a_40c129cf","line":5683,"range":{"start_line":5671,"start_character":0,"end_line":5683,"end_character":63},"updated":"2021-07-28 13:51:29.000000000","message":"This code is repeated 2-3 times in this change, it will be better to make it into a function","commit_id":"2903822b9a0f7638d9e4cbb98c9d463ac840a97e"}]}