)]}'
{"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d10b16d71ffe58b5c585a41eeca2657021b39def","unresolved":true,"context_lines":[{"line_number":1251,"context_line":"            \u0027snapshotSrcs\u0027][0][\u0027linkedDevices\u0027][0][\u0027targetDevice\u0027]"},{"line_number":1252,"context_line":"        snap_name \u003d self.data.volume_snap_vx[\u0027snapshotSrcs\u0027][0][\u0027snapshotName\u0027]"},{"line_number":1253,"context_line":"        extra_specs \u003d self.data.extra_specs"},{"line_number":1254,"context_line":"        try:"},{"line_number":1255,"context_line":"            extra_specs.pop(utils.FORCE_VOL_EDIT)"},{"line_number":1256,"context_line":"        except KeyError:"},{"line_number":1257,"context_line":"            pass"},{"line_number":1258,"context_line":"        payload \u003d {\u0027deviceNameListSource\u0027: [{\u0027name\u0027: source_id}],"},{"line_number":1259,"context_line":"                   \u0027deviceNameListTarget\u0027: ["},{"line_number":1260,"context_line":"                       {\u0027name\u0027: target_id}],"}],"source_content_type":"text/x-python","patch_set":1,"id":"807114d0_5c522065","line":1257,"range":{"start_line":1254,"start_character":8,"end_line":1257,"end_character":16},"updated":"2021-08-02 04:07:59.000000000","message":"instead of using try except in tests, i would prefer this to be:\n    if extra_specs.get(utils.FORCE_VOL_EDIT):\n        del extra_specs[utils.FORCE_VOL_EDIT]","commit_id":"0043cacfe402afddb559d4aa7329608970f010cd"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d10b16d71ffe58b5c585a41eeca2657021b39def","unresolved":true,"context_lines":[{"line_number":5766,"context_line":"                    if device_id:"},{"line_number":5767,"context_line":"                        _delete_vol(device_id)"},{"line_number":5768,"context_line":"                if volume_device_ids !\u003d deleted_volume_device_ids:"},{"line_number":5769,"context_line":"                    new_list \u003d list(set(volume_device_ids).difference("},{"line_number":5770,"context_line":"                        deleted_volume_device_ids))"},{"line_number":5771,"context_line":"                    for device_id in new_list:"},{"line_number":5772,"context_line":"                        _delete_vol(device_id)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a2f8e983_fec2309e","line":5769,"range":{"start_line":5769,"start_character":20,"end_line":5769,"end_character":28},"updated":"2021-08-02 04:07:59.000000000","message":"new_list doesn\u0027t provide any knowledge about what it is used for, I would suggest to use a better name here","commit_id":"0043cacfe402afddb559d4aa7329608970f010cd"}]}