)]}'
{"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"869cd768e4752598229b51bb05fffe1b8963d48b","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2179,"context_line":"                if not attrs:"},{"line_number":2180,"context_line":"                    continue"},{"line_number":2181,"context_line":"                if \u0027yes\u0027 \u003d\u003d attrs.get(\u0027rc_controlled\u0027, None):"},{"line_number":2182,"context_line":"                    Rc_mapping_ids.append(map_id)"},{"line_number":2183,"context_line":"                    continue"},{"line_number":2184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bb609c6f_f3a4bd75","line":2181,"updated":"2021-06-28 11:49:37.000000000","message":"Assuming the \u0027yes\u0027 will always be lowercase. If not might be worth using .lower() on the contents of attrs.get(\u0027rc_controlled\u0027), if not None.","commit_id":"983d8b28eea863ecc72070323294d4699d3efeb1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7a6194e1b0923f7604ace99918acd41dc0988fc5","unresolved":true,"context_lines":[{"line_number":2178,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2179,"context_line":"                if not attrs:"},{"line_number":2180,"context_line":"                    continue"},{"line_number":2181,"context_line":"                if \u0027yes\u0027 \u003d\u003d attrs.get(\u0027rc_controlled\u0027, None):"},{"line_number":2182,"context_line":"                    Rc_mapping_ids.append(map_id)"},{"line_number":2183,"context_line":"                    continue"},{"line_number":2184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"40a27610_947f9ce7","line":2181,"range":{"start_line":2181,"start_character":19,"end_line":2181,"end_character":60},"updated":"2021-08-24 09:08:06.000000000","message":"It\u0027s more readable to write it like this,\nif attrs.get(\u0027rc_controlled\u0027, None) \u003d\u003d \u0027yes\u0027:","commit_id":"983d8b28eea863ecc72070323294d4699d3efeb1"},{"author":{"_account_id":32171,"name":"Girish Chilukuri","email":"girish.chilukuri@ibm.com","username":"GirishChilukuri"},"change_message_id":"3466c81d9706cf84e9e025eba34e9b4eebc88ed2","unresolved":false,"context_lines":[{"line_number":2178,"context_line":"                attrs \u003d self._get_flashcopy_mapping_attributes(map_id)"},{"line_number":2179,"context_line":"                if not attrs:"},{"line_number":2180,"context_line":"                    continue"},{"line_number":2181,"context_line":"                if \u0027yes\u0027 \u003d\u003d attrs.get(\u0027rc_controlled\u0027, None):"},{"line_number":2182,"context_line":"                    Rc_mapping_ids.append(map_id)"},{"line_number":2183,"context_line":"                    continue"},{"line_number":2184,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"4d5e3286_4cb3952d","line":2181,"in_reply_to":"bb609c6f_f3a4bd75","updated":"2021-06-29 04:33:30.000000000","message":"\u0027yes\u0027 from attrs.get(\u0027rc_controlled\u0027) will always be lowercase.","commit_id":"983d8b28eea863ecc72070323294d4699d3efeb1"}]}