)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"38b897c0246ffb8d992274da988c16b5cc0ce9ca","unresolved":true,"context_lines":[{"line_number":11,"context_line":"together. The sub-clone uses the `block-ranges` and is failing"},{"line_number":12,"context_line":"because of that restriction."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the `clone-create` operation by using either"},{"line_number":15,"context_line":"`block-ranges` or `space-reserve`."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I05d83d73de69c57d885e0c417e8a376f7cfb1e4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"955fbe30_ff3e433a","line":14,"range":{"start_line":14,"start_character":55,"end_line":14,"end_character":61},"updated":"2021-10-07 12:47:52.000000000","message":"nit: exactly one of","commit_id":"601d12a0bbd003940b6504734f62ec306d7c6023"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"8ead11f994b0b2b8c8a9b3f9c03b9b4554b78369","unresolved":false,"context_lines":[{"line_number":11,"context_line":"together. The sub-clone uses the `block-ranges` and is failing"},{"line_number":12,"context_line":"because of that restriction."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"This patch fixes the `clone-create` operation by using either"},{"line_number":15,"context_line":"`block-ranges` or `space-reserve`."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Change-Id: I05d83d73de69c57d885e0c417e8a376f7cfb1e4f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"95660966_0a859e3c","line":14,"range":{"start_line":14,"start_character":55,"end_line":14,"end_character":61},"in_reply_to":"955fbe30_ff3e433a","updated":"2021-10-07 13:55:37.000000000","message":"Done","commit_id":"601d12a0bbd003940b6504734f62ec306d7c6023"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d13dee17519671f46599c6a452eb38618f6cfb61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"54ce6611_eb520555","updated":"2021-11-19 17:19:46.000000000","message":"All my concerns about the patch have been addressed.  The CI is green, though its history on this patch is not very good.  (Just throwing that observation out there.)","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7764898f858b7eb8ef9fe7bfb85cd9b3fb1c6eeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"114f8da8_ebe1a7cd","updated":"2021-11-19 17:53:28.000000000","message":"LGTM","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"a926754e4f4ed703bef1fb1e18ba15cbd2f3832b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"dacfae52_00c9171f","updated":"2021-10-12 15:17:58.000000000","message":"LGTM","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"024f097f8a2faf6461ef6be9da613a8118a882ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9eddaaf4_58aaa885","updated":"2021-10-13 14:17:01.000000000","message":"Marking comments as Done","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"aca162d597c38cdba9aba4ce4f26b8d135f4bc40","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"08506b90_563a70da","updated":"2021-11-16 14:47:18.000000000","message":"run-NetApp CI","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"bb35f43da98f03821a077dfcbd6086681542deab","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d4fae053_faa3e87d","updated":"2021-11-19 13:13:23.000000000","message":"run-NetApp CI","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"2af0957f089ad611e6e83d2c43b49d73d1b49b71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"de9414ec_04aee1ec","updated":"2021-11-18 14:05:12.000000000","message":"run-NetApp CI","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"86e7e3993e9f97f9f6244cfb531deb582d9681a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e121b0a3_7a1318f8","updated":"2021-11-01 13:11:45.000000000","message":"run-NetApp CI","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"c9fb0f8cd9dd538987dc9bd36fa65e5232def6bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e48f6d20_5fcefae7","updated":"2021-11-16 16:57:44.000000000","message":"run-NetApp CI","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"3e27d8d57de551455bca1b762fab220c68377752","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"54eef31b_74011e40","in_reply_to":"54ce6611_eb520555","updated":"2021-11-19 17:23:25.000000000","message":"Our FCP test was with some issues due to an ontap device unhealthy, none was passing, but we got it fixed. Thank you","commit_id":"dd0b1076df936b9cb1111567f6b4c3b747744b72"}],"cinder/tests/unit/volume/drivers/netapp/dataontap/client/test_client_cmode.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2eec0cb92e7e6ad7134fb34d40f21aad3052aa4","unresolved":true,"context_lines":[{"line_number":836,"context_line":"        if not is_sub_clone:"},{"line_number":837,"context_line":"            clone_create_args[\u0027space-reserve\u0027] \u003d \u0027true\u0027"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        clone_create \u003d netapp_api.NaElement.create_node_with_children("},{"line_number":840,"context_line":"            \u0027clone-create\u0027, **clone_create_args)"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        if is_sub_clone:"}],"source_content_type":"text/x-python","patch_set":3,"id":"61ce1283_b7038a93","line":839,"updated":"2021-09-21 15:08:07.000000000","message":"It looks like this is where you are creating a \"test lun,\" which you then clone at L853.","commit_id":"b49a2ef2f38dff3912e727405acc80b5031e9ea6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a8b1a1ea12ad287b27529f90b18d5d63e3941925","unresolved":false,"context_lines":[{"line_number":836,"context_line":"        if not is_sub_clone:"},{"line_number":837,"context_line":"            clone_create_args[\u0027space-reserve\u0027] \u003d \u0027true\u0027"},{"line_number":838,"context_line":""},{"line_number":839,"context_line":"        clone_create \u003d netapp_api.NaElement.create_node_with_children("},{"line_number":840,"context_line":"            \u0027clone-create\u0027, **clone_create_args)"},{"line_number":841,"context_line":""},{"line_number":842,"context_line":"        if is_sub_clone:"}],"source_content_type":"text/x-python","patch_set":3,"id":"02e427e4_3b88d03a","line":839,"in_reply_to":"61ce1283_b7038a93","updated":"2021-09-23 18:08:00.000000000","message":"Ack","commit_id":"b49a2ef2f38dff3912e727405acc80b5031e9ea6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"f2eec0cb92e7e6ad7134fb34d40f21aad3052aa4","unresolved":true,"context_lines":[{"line_number":850,"context_line":"            block_ranges.add_child_elem(block_range)"},{"line_number":851,"context_line":"            clone_create.add_child_elem(block_ranges)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        self.client.clone_lun("},{"line_number":854,"context_line":"            \u0027volume\u0027, \u0027fakeLUN\u0027, \u0027newFakeLUN\u0027, block_count\u003dblock_count)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        self.connection.invoke_successfully.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"11840e8b_f1f478f7","line":853,"updated":"2021-09-21 15:08:07.000000000","message":"Maybe I\u0027m missing something due to not being familiar with the netapp test code, but I need help understanding how this unit test verifies the patch fixes the bug.\n\nThis is the function you\u0027re trying to test, but it\u0027s not clear to me how/where you are validating the change. I expected to see something that verified the \"zapi_args\" passed to the subsequent call to create_node_with_children() (the call made by clone_lun) would *NOT* include the \u0027space-reserve\u0027 arg when is_sub_clone is false.","commit_id":"b49a2ef2f38dff3912e727405acc80b5031e9ea6"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"d97337b8effd79d94d4ab793a65ee843030ff6fc","unresolved":true,"context_lines":[{"line_number":850,"context_line":"            block_ranges.add_child_elem(block_range)"},{"line_number":851,"context_line":"            clone_create.add_child_elem(block_ranges)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        self.client.clone_lun("},{"line_number":854,"context_line":"            \u0027volume\u0027, \u0027fakeLUN\u0027, \u0027newFakeLUN\u0027, block_count\u003dblock_count)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        self.connection.invoke_successfully.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"15a541f3_07bcf5f6","line":853,"in_reply_to":"11840e8b_f1f478f7","updated":"2021-09-23 15:16:39.000000000","message":"In fact, the validation is done by the `clone_create` variable. This variable is built with the expected XML. In case the block_count is 0 (no block count), in the L837, the XML contains the `space-reserve`. Otherwise, the block_count is passed down and the expected XML `clone_create` does not contain the `space-reserve`.\n\nFinally, we call the function `clone_lun`, passing the block_count (0 or 1). Then, check that the `invoke_successfully` was called with a XML matching the expected one (`clone_create`). \n\nAlthough the names and order are a bit confusing, the test is validating that the built XML has the expected values with space-reserve and block_count (the bug fix here).","commit_id":"b49a2ef2f38dff3912e727405acc80b5031e9ea6"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"fee1210a77e9f5b1defc17050fc480503abcc089","unresolved":true,"context_lines":[{"line_number":850,"context_line":"            block_ranges.add_child_elem(block_range)"},{"line_number":851,"context_line":"            clone_create.add_child_elem(block_ranges)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        self.client.clone_lun("},{"line_number":854,"context_line":"            \u0027volume\u0027, \u0027fakeLUN\u0027, \u0027newFakeLUN\u0027, block_count\u003dblock_count)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        self.connection.invoke_successfully.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"8322a6ad_94dd555e","line":853,"in_reply_to":"15a541f3_07bcf5f6","updated":"2021-09-23 17:19:34.000000000","message":"OK, now I understand. The clone_create variable represents the expected results, and you verify this is what\u0027s generated by the clone_lun() function (the one you\u0027re testing) by seeing if it generates that same XML that ultimately gets passed into invoke_successfully().\n\nI agree that a comment and renaming the clone_create variable would help the reader, but otherwise the code looks good.","commit_id":"b49a2ef2f38dff3912e727405acc80b5031e9ea6"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"a8b1a1ea12ad287b27529f90b18d5d63e3941925","unresolved":false,"context_lines":[{"line_number":850,"context_line":"            block_ranges.add_child_elem(block_range)"},{"line_number":851,"context_line":"            clone_create.add_child_elem(block_ranges)"},{"line_number":852,"context_line":""},{"line_number":853,"context_line":"        self.client.clone_lun("},{"line_number":854,"context_line":"            \u0027volume\u0027, \u0027fakeLUN\u0027, \u0027newFakeLUN\u0027, block_count\u003dblock_count)"},{"line_number":855,"context_line":""},{"line_number":856,"context_line":"        self.connection.invoke_successfully.assert_called_once_with("}],"source_content_type":"text/x-python","patch_set":3,"id":"65e55381_91ec012c","line":853,"in_reply_to":"8322a6ad_94dd555e","updated":"2021-09-23 18:08:00.000000000","message":"I agree that it would be good to rename the variable and add some comment to help the reader. I\u0027ll update the code. Thanks Alan and Felipe.","commit_id":"b49a2ef2f38dff3912e727405acc80b5031e9ea6"}],"releasenotes/notes/fix-sub-clone-operation-f42a84ab17930f24.yaml":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"fc78cd8c03f2518143bcf62fd305ce5b0c24608f","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4203bfad_ae458d2c","line":7,"updated":"2021-09-17 04:36:49.000000000","message":"To provide the reader with some context, please mention the vendor and driver name somewhere in the release note (the fix only applies to a specific driver).","commit_id":"0cba278d939d5a58944aed4baf6ad3c50b54a5b1"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"024f097f8a2faf6461ef6be9da613a8118a882ca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5de1ac6d_a0a13e41","line":7,"in_reply_to":"4203bfad_ae458d2c","updated":"2021-10-13 14:17:01.000000000","message":"Done","commit_id":"0cba278d939d5a58944aed4baf6ad3c50b54a5b1"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"38b897c0246ffb8d992274da988c16b5cc0ce9ca","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1924643 \u003chttps://bugs.launchpad.net/cinder/+bug/1924643\u003e`_: Fix"},{"line_number":5,"context_line":"    the the NetApp cinder driver sub-clone operation that might be used"},{"line_number":6,"context_line":"    by extend operation in case the extended size is greater than the max"},{"line_number":7,"context_line":"    LUN geometry."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"206107a9_95404dff","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":73},"updated":"2021-10-07 12:47:52.000000000","message":"should be \u0027Fixed\u0027","commit_id":"601d12a0bbd003940b6504734f62ec306d7c6023"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"8ead11f994b0b2b8c8a9b3f9c03b9b4554b78369","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1924643 \u003chttps://bugs.launchpad.net/cinder/+bug/1924643\u003e`_: Fix"},{"line_number":5,"context_line":"    the the NetApp cinder driver sub-clone operation that might be used"},{"line_number":6,"context_line":"    by extend operation in case the extended size is greater than the max"},{"line_number":7,"context_line":"    LUN geometry."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"5aa18da8_38e08009","line":4,"range":{"start_line":4,"start_character":70,"end_line":4,"end_character":73},"in_reply_to":"206107a9_95404dff","updated":"2021-10-07 13:55:37.000000000","message":"Done","commit_id":"601d12a0bbd003940b6504734f62ec306d7c6023"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"38b897c0246ffb8d992274da988c16b5cc0ce9ca","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1924643 \u003chttps://bugs.launchpad.net/cinder/+bug/1924643\u003e`_: Fix"},{"line_number":5,"context_line":"    the the NetApp cinder driver sub-clone operation that might be used"},{"line_number":6,"context_line":"    by extend operation in case the extended size is greater than the max"},{"line_number":7,"context_line":"    LUN geometry."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"e2c0623d_5c966829","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":11},"updated":"2021-10-07 12:47:52.000000000","message":"duplicate \u0027the\u0027","commit_id":"601d12a0bbd003940b6504734f62ec306d7c6023"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"8ead11f994b0b2b8c8a9b3f9c03b9b4554b78369","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1924643 \u003chttps://bugs.launchpad.net/cinder/+bug/1924643\u003e`_: Fix"},{"line_number":5,"context_line":"    the the NetApp cinder driver sub-clone operation that might be used"},{"line_number":6,"context_line":"    by extend operation in case the extended size is greater than the max"},{"line_number":7,"context_line":"    LUN geometry."}],"source_content_type":"text/x-yaml","patch_set":4,"id":"f190124b_c05ca51d","line":5,"range":{"start_line":5,"start_character":4,"end_line":5,"end_character":11},"in_reply_to":"e2c0623d_5c966829","updated":"2021-10-07 13:55:37.000000000","message":"Done","commit_id":"601d12a0bbd003940b6504734f62ec306d7c6023"}]}