)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebc0f179046a99a6f5ae9e976b897b205982ac5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d40f0e08_5853b079","updated":"2022-02-09 23:39:07.000000000","message":"Looks good, and the test info changes look correct to me.  Question inline about your change in create_volume.py.  The -1 is to get your attention, not that anything is necessarily incorrect.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f127b03d623346f7ccc834802ed1cc671e5f502","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"910c8af4_5e9f5ddf","updated":"2022-02-10 03:10:17.000000000","message":"LGTM!","commit_id":"ed18400ff3b9e80abce46482ef3b65147070672e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1022d5e65955e5db464429a6d40f173cc97da80","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9435ee6a_1c21d359","updated":"2022-02-12 18:25:49.000000000","message":"See comment inline.","commit_id":"ed18400ff3b9e80abce46482ef3b65147070672e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7c582fcb4b073af1478f50b6a459f3a284f96869","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"015e3ddc_95a5f150","updated":"2022-02-13 12:08:36.000000000","message":"recheck","commit_id":"b7052b2921f530aff3af67a4a41d844bcb5052a3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"16c77d95828f1fc14a0453b58207ea5412686111","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"64a8d06f_88df1b8a","updated":"2022-09-02 16:45:03.000000000","message":"@Walt: the bug mentioned in the comment is correct for explaining why we\u0027re doing that overkill check in the code.  See the discussion here:\nhttps://review.opendev.org/c/openstack/cinder/+/799663/6..11/cinder/volume/flows/manager/create_volume.py#557\n\nRaising the priority so we can get this closed out.","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"83b7c4eb6488675a77a803049f599fed0d7af418","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"10d359b4_9e98b944","updated":"2022-03-22 10:44:49.000000000","message":"LGTM","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a99a535898854baaa878def7489c3be714ba772e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"c3fc15cc_d5c9fc19","updated":"2022-09-02 17:46:06.000000000","message":"Looks like Eric caught an incorrect field in the test data.","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5d4ccf6cb04ab43c35bc1dac97990b5a45049709","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"548a985c_3d11484b","updated":"2022-03-28 13:28:17.000000000","message":"Sorry this has been sitting so long.  Revised patch LGTM.","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3c15f370b093469ab79adba08754cc242ad8d860","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"aca22422_eca5b39f","updated":"2022-02-13 22:35:18.000000000","message":"recheck tempest-integrated-storage : tempest.api.compute.servers.test_device_tagging.TaggedAttachmentsTest.test_tagged_attachment couldn\u0027t ssh into the instance","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"88348370e03975f96f94ac6d3503030f9804c107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4f84190c_cc4977b8","updated":"2022-02-14 10:01:26.000000000","message":"run-HPE Storage CI","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"04e6d54a376fb28b08737a24d9e8651dffde4378","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"654408ff_2f8214be","updated":"2022-02-15 06:55:21.000000000","message":"vmware-recheck-patch","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"35927a8cceb8c0d107ad36f0836527ee9f5cecef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"f5cfd407_d12f3812","updated":"2022-09-07 10:37:11.000000000","message":"Revision LGTM.","commit_id":"c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"5b85fb97afc62c50009b415fe489cd9ec04882bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"0eb2c244_ef393381","updated":"2022-09-07 12:25:34.000000000","message":"lgtm","commit_id":"c0d2e7ebd8b992d61a5f486baad3016d79e6a5d9"}],"cinder/image/image_utils.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"04340c0808cbc6396081cda075f9630ae24aa677","unresolved":true,"context_lines":[{"line_number":137,"context_line":"                    \"qemu-img does not support this parameter\")"},{"line_number":138,"context_line":"            LOG.warning(msg)"},{"line_number":139,"context_line":"    cmd.append(path)"},{"line_number":140,"context_line":"    cmd.append(\u0027--output\u003djson\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":143,"context_line":"        cmd \u003d cmd[2:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"4b7f4010_1f6b4d2e","line":140,"range":{"start_line":140,"start_character":15,"end_line":140,"end_character":30},"updated":"2021-08-19 13:57:35.000000000","message":"Can you add this to line 131 instead?","commit_id":"0399774d4ac0c4be518f77c8bed92d3dd3fd3ece"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"af1110f2c10167c73a94c9f448b9c1c1c8c968fa","unresolved":false,"context_lines":[{"line_number":137,"context_line":"                    \"qemu-img does not support this parameter\")"},{"line_number":138,"context_line":"            LOG.warning(msg)"},{"line_number":139,"context_line":"    cmd.append(path)"},{"line_number":140,"context_line":"    cmd.append(\u0027--output\u003djson\u0027)"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"    if os.name \u003d\u003d \u0027nt\u0027:"},{"line_number":143,"context_line":"        cmd \u003d cmd[2:]"}],"source_content_type":"text/x-python","patch_set":4,"id":"bef2d858_8add2425","line":140,"range":{"start_line":140,"start_character":15,"end_line":140,"end_character":30},"in_reply_to":"4b7f4010_1f6b4d2e","updated":"2021-08-19 14:06:17.000000000","message":"Done","commit_id":"0399774d4ac0c4be518f77c8bed92d3dd3fd3ece"}],"cinder/tests/unit/volume/drivers/test_nfs.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebc0f179046a99a6f5ae9e976b897b205982ac5d","unresolved":true,"context_lines":[{"line_number":380,"context_line":"    \"cluster-size\": 65536,"},{"line_number":381,"context_line":"    \"backing-filename\": \"volume-%(volid)s\","},{"line_number":382,"context_line":"    \"backing-filename-format\": \"raw\","},{"line_number":383,"context_line":"    \"format-specific\": {"},{"line_number":384,"context_line":"        \"compat\": \"1.1\","},{"line_number":385,"context_line":"        \"lazy-refcounts\": false,"},{"line_number":386,"context_line":"        \"refcount-bits\": 16,"},{"line_number":387,"context_line":"        \"corrupt\": false"},{"line_number":388,"context_line":"    }"},{"line_number":389,"context_line":"}\"\"\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"QEMU_IMG_INFO_OUT5 \u003d \"\"\"{"}],"source_content_type":"text/x-python","patch_set":6,"id":"c3e41cb7_09ecb861","line":388,"range":{"start_line":383,"start_character":0,"end_line":388,"end_character":5},"updated":"2022-02-09 23:39:07.000000000","message":"This isn\u0027t your problem, because you\u0027re converting the human format we already had to json, but I don\u0027t think a raw format file would have any format-specific info.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7616f8343c772ca5d7c389803ed401d740a944f3","unresolved":false,"context_lines":[{"line_number":380,"context_line":"    \"cluster-size\": 65536,"},{"line_number":381,"context_line":"    \"backing-filename\": \"volume-%(volid)s\","},{"line_number":382,"context_line":"    \"backing-filename-format\": \"raw\","},{"line_number":383,"context_line":"    \"format-specific\": {"},{"line_number":384,"context_line":"        \"compat\": \"1.1\","},{"line_number":385,"context_line":"        \"lazy-refcounts\": false,"},{"line_number":386,"context_line":"        \"refcount-bits\": 16,"},{"line_number":387,"context_line":"        \"corrupt\": false"},{"line_number":388,"context_line":"    }"},{"line_number":389,"context_line":"}\"\"\""},{"line_number":390,"context_line":""},{"line_number":391,"context_line":"QEMU_IMG_INFO_OUT5 \u003d \"\"\"{"}],"source_content_type":"text/x-python","patch_set":6,"id":"20462de3_656a7372","line":388,"range":{"start_line":383,"start_character":0,"end_line":388,"end_character":5},"in_reply_to":"c3e41cb7_09ecb861","updated":"2022-02-10 00:04:46.000000000","message":"Done. Indeed !","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"ad1b368b5728f59a1a3ee4bf0337a22ca11573a5","unresolved":true,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"QEMU_IMG_INFO_OUT5 \u003d \"\"\"{"},{"line_number":386,"context_line":"    \"filename\": \"volume-%(volid)s.%(snapid)s\","},{"line_number":387,"context_line":"    \"format\": \"luks\","},{"line_number":388,"context_line":"    \"virtual-size\": %(size_b)s,"},{"line_number":389,"context_line":"    \"actual-size\": 196000,"},{"line_number":390,"context_line":"    \"encrypted\": true,"}],"source_content_type":"text/x-python","patch_set":11,"id":"e6e3d005_1675a780","line":387,"range":{"start_line":387,"start_character":15,"end_line":387,"end_character":19},"updated":"2022-09-02 17:29:37.000000000","message":"This should be format \"qcow2\", since this output represented luks-inside-of-qcow2 before.  A raw luks format wouldn\u0027t have a backing file as specified below.","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"2c1dc84f220c4c23fc9ecff02de0e5a8e67b3153","unresolved":false,"context_lines":[{"line_number":384,"context_line":""},{"line_number":385,"context_line":"QEMU_IMG_INFO_OUT5 \u003d \"\"\"{"},{"line_number":386,"context_line":"    \"filename\": \"volume-%(volid)s.%(snapid)s\","},{"line_number":387,"context_line":"    \"format\": \"luks\","},{"line_number":388,"context_line":"    \"virtual-size\": %(size_b)s,"},{"line_number":389,"context_line":"    \"actual-size\": 196000,"},{"line_number":390,"context_line":"    \"encrypted\": true,"}],"source_content_type":"text/x-python","patch_set":11,"id":"2d613474_b494dbbf","line":387,"range":{"start_line":387,"start_character":15,"end_line":387,"end_character":19},"in_reply_to":"e6e3d005_1675a780","updated":"2022-09-03 03:08:39.000000000","message":"Done","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"1493cb571e773a7be8b63947ca41060a8c178ce8","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"85887057_728de14c","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"updated":"2021-09-04 15:23:36.000000000","message":"It seems format\u003d\u0027json\u0027 makes the encrypted attribute set to true/false instead of \u0027yes\u0027/None.\n\nI\u0027m waiting for feedback in the bug I reported for oslo.utils[1], but I think the current approach here, rather than checking the actual value, would be more simple but reliable.\n\n[1] https://bugs.launchpad.net/oslo.utils/+bug/1942682\n\nNote that this logic is still compatible even with human format, because qemu-img info doesn\u0027t show the \"encrypted\" like if the image is non-encrypted, which results in None.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ebc0f179046a99a6f5ae9e976b897b205982ac5d","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"5d8a0864_7a4e32a2","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"in_reply_to":"36aed639_970778e4","updated":"2022-02-09 23:39:07.000000000","message":"Thanks for the explanation.  I wonder if it would be better to make the condition:\n\n  if strutils.bool_from_string(image_info.encrypted):\n\nThat way, if someone refactors the QemuImgInfo object, we\u0027d be able to handle \u0027yes\u0027, \u0027no\u0027, None, True, False (even \u0027True\u0027, \u0027False\u0027) correctly.  I\u0027m just worried about the current condition being True when image_info.encrypted \u003d\u003d \u0027no\u0027.  What do you think?","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"7616f8343c772ca5d7c389803ed401d740a944f3","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"a6b28f31_ed27513e","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"in_reply_to":"5d8a0864_7a4e32a2","updated":"2022-02-10 00:04:46.000000000","message":"The possible patterns it can return is\n \u0027yes\u0027 / None  -\u003e format raw or format json with recent oslo.utils\n true  / false -\u003e format json, with older oslo.utils\nso there is not chance(at least until now).\nIt has never returned \u0027no\u0027 because of behavior of qemu-img and now because of the logic in oslo.utils.\n\nwe can implement something like\n\n  if strutils.bool_from_string(image_info.encrypted, False):\n\nbut I feel this is a bit redundant considering we never expect false strings.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e1fd0374e5a5de3c9230ecef1bd299cf4a2e6df6","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"36aed639_970778e4","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"in_reply_to":"85887057_728de14c","updated":"2022-02-09 15:14:46.000000000","message":"It was fixed in the latest oslo.utils but I tend to just leave this as it is to keep the logic more simple.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1f127b03d623346f7ccc834802ed1cc671e5f502","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"ab5b0512_2e86fa45","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"in_reply_to":"a6b28f31_ed27513e","updated":"2022-02-10 03:10:17.000000000","message":"OK, I looked at your patch that fixed this in oslo.utils, and it seems pretty clear from the commit message and release note that the contract for the encrypted field is that the values are either \u0027yes\u0027 or None.  So what you have here should be fine.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"d1022d5e65955e5db464429a6d40f173cc97da80","unresolved":true,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"cd21b0ad_8e26560f","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"in_reply_to":"ab5b0512_2e86fa45","updated":"2022-02-12 18:25:49.000000000","message":"I was thinking about this some more, and I think I want to insist on changing the condition to\n\n  # see Bug #1942682 and Change I949f07582a708 for why we do this\n  if strutils.bool_from_string(image_info.encrypted):\n\nit looks like overkill, but this way we\u0027re covered for all the obvious boolean and quasi-boolean values (including None) that might be in that field.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"aded7d0fbdee13f78ed2fc09cd35b95a60d90dfb","unresolved":false,"context_lines":[{"line_number":554,"context_line":"                volume,"},{"line_number":555,"context_line":"                encryption)"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"            if image_info.encrypted:"},{"line_number":558,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":559,"context_line":"                del source_pass"},{"line_number":560,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"4dbc583a_7af06031","line":557,"range":{"start_line":557,"start_character":12,"end_line":557,"end_character":36},"in_reply_to":"cd21b0ad_8e26560f","updated":"2022-02-12 19:02:10.000000000","message":"Thanks. Adding that note sound reasonable. Updated the patch accordingly. Note that bool_from_string doesn\u0027t accept None unless we define the default, and that\u0027s why the latest implementation is a bit different.","commit_id":"7503b40ac9d7850758ba179e118b730e0bab9d73"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"29dd2170403fcf7aa6218f1a3511fea413b9bee8","unresolved":true,"context_lines":[{"line_number":559,"context_line":"                encryption)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            # see Bug #1942682 and Change I949f07582a708 for why we do this"},{"line_number":562,"context_line":"            if strutils.bool_from_string(image_info.encrypted):"},{"line_number":563,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":564,"context_line":"                del source_pass"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"313320a7_116402db","line":562,"updated":"2022-06-29 18:16:52.000000000","message":"This looks like a bugfix for a different issue that shouldn\u0027t be apart of this patch.","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b2212b2b4604b1a19b709ceb57fcffaaf3c951e8","unresolved":true,"context_lines":[{"line_number":559,"context_line":"                encryption)"},{"line_number":560,"context_line":""},{"line_number":561,"context_line":"            # see Bug #1942682 and Change I949f07582a708 for why we do this"},{"line_number":562,"context_line":"            if strutils.bool_from_string(image_info.encrypted):"},{"line_number":563,"context_line":"                key_str \u003d source_pass + \"\\n\" + new_pass + \"\\n\""},{"line_number":564,"context_line":"                del source_pass"},{"line_number":565,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"b33e8d97_f8348d59","line":562,"in_reply_to":"313320a7_116402db","updated":"2022-06-30 04:20:10.000000000","message":"This is to workaround the issue with old oslo.utils, which was discovered by the switch to json format. (in old oslo.utils this returns true instead of \u0027yes\u0027 when json format is used.\n\nWe no longer need this change because the issue was fixed in recent oslo.utils, but I decided to add this as the safe guard as suggested by Brian earlier. Please check our discussions in patch set 7.","commit_id":"b7087a8bb0af6271fa3000655e305246156387ca"}]}