)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"940880a4a66b58b106d78f755aa6226e2ba5b54e","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The NFS snapshot creation for an attached volume requires interaction"},{"line_number":10,"context_line":"between Nova and Cinder, and a new qcow2 file is used after the"},{"line_number":11,"context_line":"attachment completes."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This means that the connection properties stored in the Attachment is no"},{"line_number":14,"context_line":"longer valid, as it is pointing to the old qcow2 file, so if Nova tries"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"100094a1_4f95feb3","line":11,"range":{"start_line":11,"start_character":0,"end_line":11,"end_character":10},"updated":"2021-07-22 12:30:04.000000000","message":"do you mean when the snapshot creation completes?","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f32931658542655135e4fb3b7dae71d64c6bdfc4","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A flow showing this issue is:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Attach NFS volume"},{"line_number":20,"context_line":"- Create snapshot"},{"line_number":21,"context_line":"- Hard reboot"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"After that the VM will start using the base image, breaking the qcow2"},{"line_number":24,"context_line":"chain."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7165fe66_4615d6cb","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":13},"updated":"2021-07-12 10:12:31.000000000","message":"supernit.\n  - Attach NFS based volume to an instance\n  - Create a volume snapshot\n  - Hard reboot the instance","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"39f21029499976944f4176a442ba2dc5f555ed2e","unresolved":true,"context_lines":[{"line_number":16,"context_line":""},{"line_number":17,"context_line":"A flow showing this issue is:"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"- Attach NFS volume"},{"line_number":20,"context_line":"- Create snapshot"},{"line_number":21,"context_line":"- Hard reboot"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"After that the VM will start using the base image, breaking the qcow2"},{"line_number":24,"context_line":"chain."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ea569a54_881a9e78","line":21,"range":{"start_line":19,"start_character":0,"end_line":21,"end_character":13},"in_reply_to":"7165fe66_4615d6cb","updated":"2021-07-14 09:57:00.000000000","message":"Will change if I send another patch.","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f32931658542655135e4fb3b7dae71d64c6bdfc4","unresolved":true,"context_lines":[{"line_number":23,"context_line":"After that the VM will start using the base image, breaking the qcow2"},{"line_number":24,"context_line":"chain."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"If we delete the snapshot in the meantime, then the VM will fail to"},{"line_number":27,"context_line":"reboot."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch fixes this inconsistency by updating the connection info"},{"line_number":30,"context_line":"field inside the remotefs driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6c0716fc_6a1e5516","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":7},"updated":"2021-07-12 10:12:31.000000000","message":"Might be worth highlighting that deleting the snapshot merges the snapshot file with the base and then deletes the original base file. IMHO this behaviour is super weird and we should just revert to the base.","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"39f21029499976944f4176a442ba2dc5f555ed2e","unresolved":true,"context_lines":[{"line_number":23,"context_line":"After that the VM will start using the base image, breaking the qcow2"},{"line_number":24,"context_line":"chain."},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"If we delete the snapshot in the meantime, then the VM will fail to"},{"line_number":27,"context_line":"reboot."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"This patch fixes this inconsistency by updating the connection info"},{"line_number":30,"context_line":"field inside the remotefs driver."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"c2bc525a_dcf9b25f","line":27,"range":{"start_line":26,"start_character":0,"end_line":27,"end_character":7},"in_reply_to":"6c0716fc_6a1e5516","updated":"2021-07-14 09:57:00.000000000","message":"I\u0027ll mention it if I send a new patch.\n\nI don\u0027t know enough of the QEMU side to know if this was implemented this way due to a limitation of the block commit, were it cannot do the block commit of an active file and change at the same time the disk file that will use.","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"940880a4a66b58b106d78f755aa6226e2ba5b54e","unresolved":true,"context_lines":[{"line_number":29,"context_line":"This patch fixes this inconsistency by updating the connection info"},{"line_number":30,"context_line":"field inside the remotefs driver."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"We usually prefer that drivers don\u0027t to touch the DB, directly or"},{"line_number":33,"context_line":"indirectly (using OVOs), but in this case we are using OVOs methods"},{"line_number":34,"context_line":"instead of the usual model update on the volume manager because there"},{"line_number":35,"context_line":"are cases in the driver where a snapshot is created (cloning via"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4032eebc_425fcc57","line":32,"range":{"start_line":32,"start_character":37,"end_line":32,"end_character":39},"updated":"2021-07-22 12:30:04.000000000","message":"nit: remove this","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"940880a4a66b58b106d78f755aa6226e2ba5b54e","unresolved":true,"context_lines":[{"line_number":47,"context_line":"- There are cases in the cinder volume manager where the model update"},{"line_number":48,"context_line":"  values returned by snapshot_create are not being applied."},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Snapshot deletion belonging to in-use volumes are not affected by this"},{"line_number":51,"context_line":"issue because we only do block commit when the snapshot file we are"},{"line_number":52,"context_line":"deleting is not the active file.  In _delete_snapshot_online:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if utils.paths_normcase_equal(info[\u0027active_file\u0027],"},{"line_number":55,"context_line":"                                      info[\u0027snapshot_file\u0027]):"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4f69d3e4_e45da67a","line":52,"range":{"start_line":50,"start_character":0,"end_line":52,"end_character":32},"updated":"2021-07-22 12:30:04.000000000","message":"Maybe this is easier to understand with the code snippet but we can also simply say this like, this problem only exists while deleting the latest snapshot (block rebase) and is not faced with other snapshot delete operations (block commit)\nit\u0027s just a suggestion and not a request to modify the existing wordings","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":10135,"name":"Lee Yarwood","display_name":"Lee Yarwood","email":"lyarwood@redhat.com","username":"lyarwood"},"change_message_id":"f32931658542655135e4fb3b7dae71d64c6bdfc4","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Snapshot deletion belonging to in-use volumes are not affected by this"},{"line_number":51,"context_line":"issue because we only do block commit when the snapshot file we are"},{"line_number":52,"context_line":"deleting is not the active file.  In _delete_snapshot_online:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if utils.paths_normcase_equal(info[\u0027active_file\u0027],"},{"line_number":55,"context_line":"                                      info[\u0027snapshot_file\u0027]):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Closes-Bug: #1860913"},{"line_number":58,"context_line":"Change-Id: I62fcef3169dcb9f4363a5344af4b2711edfef632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"d4195a27_87590be3","line":56,"range":{"start_line":52,"start_character":34,"end_line":56,"end_character":0},"updated":"2021-07-12 10:12:31.000000000","message":"supernit - replace this with a link","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"39f21029499976944f4176a442ba2dc5f555ed2e","unresolved":true,"context_lines":[{"line_number":49,"context_line":""},{"line_number":50,"context_line":"Snapshot deletion belonging to in-use volumes are not affected by this"},{"line_number":51,"context_line":"issue because we only do block commit when the snapshot file we are"},{"line_number":52,"context_line":"deleting is not the active file.  In _delete_snapshot_online:"},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"        if utils.paths_normcase_equal(info[\u0027active_file\u0027],"},{"line_number":55,"context_line":"                                      info[\u0027snapshot_file\u0027]):"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"Closes-Bug: #1860913"},{"line_number":58,"context_line":"Change-Id: I62fcef3169dcb9f4363a5344af4b2711edfef632"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1843e28a_a4a7b47f","line":56,"range":{"start_line":52,"start_character":34,"end_line":56,"end_character":0},"in_reply_to":"d4195a27_87590be3","updated":"2021-07-14 09:57:00.000000000","message":"I prefer to include relevant info in the commit message instead of linking to it.  That\u0027s also why I also duplicate data that is in the bug report.","commit_id":"25eb0a7d76922e3a1a289d26c36b96a91c4059db"}]}