)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"54aa0031515590330f1fa8f62538a466237e0987","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"41359551_a84b1c41","updated":"2021-11-09 02:33:19.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"e3348385039ead85ba66d050fe1f5dc52991db19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7996e525_92e56d59","updated":"2021-11-05 05:30:30.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"4b20ee2f576e806ea869af6e334cc800e222065e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ccb35858_6e4789e2","updated":"2021-11-04 01:35:59.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"148dfa01aad1a760cbd60752cc8a3f91cd67baf2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d58ac663_27ca9422","updated":"2021-11-09 01:47:46.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"ab2549258cbcb8ea144ff6ee3c23864cd29d95b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d6d949b9_1e3913fb","updated":"2021-11-08 00:49:43.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"123b7033b6eca21ec52cdb4f2a48d87f20684d9c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"204bd015_0dfc24ee","updated":"2021-11-04 02:04:37.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"1fab34779323ee0241aff3dee6685c98eb8857c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2fe368c5_acc07e59","updated":"2021-11-04 01:58:03.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"727c0b86ca90ebd2287db538c6ee9f73fb6da585","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b28477b8_b77cedba","updated":"2021-11-04 12:27:29.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"0e5d7e854099f7d4b44f0b9346e6c9e64d3afaad"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7be4c85c25957c844d645595c39ef09be64c78bb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"0ddc7d58_4ac2dc7f","updated":"2022-05-24 21:34:21.000000000","message":"Minor thing noted inline if you have to put up a new patch set.  Otherwise, code and tests look good.","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c86af68da481fd4bfe6b52649710a8997c605297","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"cd5c14d3_42f49d3c","updated":"2021-11-09 19:26:16.000000000","message":"recheck openstack-tox-py38","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"a9d75084ad67d2bad23e0eb1fa5fd029e42a61d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1916dd6a_6bb5a2f8","updated":"2021-11-15 12:13:39.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"5130f2e82b623d84f709cb10996e13f6fb70a6b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"517757cd_a824c7ad","updated":"2021-11-16 08:07:44.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"08ba4abdbcca087e7d14ad8587a45ba0d35ee048","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a963a91a_3fc5c957","updated":"2021-11-09 10:52:14.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"a8c749bacbc2e0513ec7dc50db452f76e2094046","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b783644c_b3bf3a73","updated":"2021-11-09 10:46:32.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"795764d463c73c8d5fcd3399ffb38c63a8574cf9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"beb5e6ff_43ce3588","updated":"2021-11-10 01:02:41.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"68adc04bf2d24fbb998a3d35830eb5cfc3e383a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"edaa2565_a5bd2a83","updated":"2021-11-16 03:35:41.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"5d386f7ad3425f56d0911d893da54fb7a532d214","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"ff0de88d_6640a865","updated":"2021-11-09 11:41:11.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fd49f59e1ac6a83a933de5e0335f7cd56f2797e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"43d2ea8f_7318c187","updated":"2022-09-05 09:54:59.000000000","message":"Few suggestions in tests but overall looks good.","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"2703f60cfd122170c42e1738cc74bc5b31110593","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"17ac3588_2bf17d5d","updated":"2022-07-18 06:32:14.000000000","message":"LGTM","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"8b37681a902733a5af644d863a1edf72db25fdbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b5a2154e_1e93e440","updated":"2022-06-29 12:43:52.000000000","message":"LGTM!","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"7f4b521984dda97e96936889a5c5089f11fc709c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04c4cb1e_5082f6d1","updated":"2022-06-14 06:40:42.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"4a2a55c8b80053214ab46ce62fc2b5b3f4edd5af","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"06e4e788_fd0aaafa","updated":"2022-06-14 06:34:45.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"9e2acc8f6e0b0c68dc3f5d79bafffe63527bab17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"469a30bb_a838bc44","updated":"2022-06-15 09:41:28.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"672df2626085a09981e97961ae1384de126395c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"4941805c_4e44da99","updated":"2022-06-14 06:56:35.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"9a921a9418a615f7fc1cf2abc5ec6bcecd7be2b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"920c66f9_ddba11d3","updated":"2022-06-14 07:04:50.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"f6196ddfb0aa9927a1b9a56b654e4987afa53f05","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d19ebf0a_072acef3","updated":"2022-06-13 15:23:35.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cab33579bdebf08b87c675d6271118e45f6aeb03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"218f118c_c8aeded7","updated":"2022-09-05 19:05:43.000000000","message":"pep8 failures","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"41b189e0af46081481ee3f0bb6f83bd9b39376c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"77d27f9a_57bed2f0","updated":"2022-09-05 13:38:24.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6721cd39b0ddf5015d961d094348b8001860e1d0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8290b43f_86b0d6d1","updated":"2022-09-13 11:17:46.000000000","message":"Added more comments to fix the tests properly","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfd105aa26736c1b7023b0abe43dc298b7bd3efa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f30f5b4c_85eee70f","updated":"2022-09-13 09:52:09.000000000","message":"Please check the zuul failures before rechecking. There is a legit failure in unit tests as noted inline.","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"2533309ac430bc41d70c67f6fff085ab01acb641","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e2bf8c93_98436612","updated":"2022-09-09 12:42:07.000000000","message":"recheck","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fd8719de3896efb5cff26f063dbcea44342f103b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b566f395_2e8f7969","updated":"2022-09-14 01:09:30.000000000","message":"Changes since my last review (PS4) look good.  Only a +1 because the Dell PowerMax CI has not yet responded on this patch set.","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f4bd1db86124c7ba1a20233b217bf1314b9bccc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bb1a1792_fca18472","updated":"2022-09-15 13:21:46.000000000","message":"My comments are addressed and CI is passing. LGTM.","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dec9fc322cc63b575b567bb2133ca5c19ceeb5b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"99f1efab_31a9788f","updated":"2022-09-15 13:23:44.000000000","message":"Was waiting for PowerMax CI to pass, which it has.","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"ab5b9be0f9bce1adab8fc361d12076a843375a2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"07e327a7_551ca413","updated":"2022-09-14 01:09:07.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"39063ba79aa000678587b14ce9a6be913b037c6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1668143f_c9b81a95","updated":"2022-09-14 13:35:25.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a5e8fbb67f34d20cdb959f4a0e605c48119c9d0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ecb90b07_9540147c","updated":"2022-09-14 01:09:36.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b59a2a27cc746447baa6a265308df55b3803fbef","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ad9ae4dc_4076df7c","in_reply_to":"b566f395_2e8f7969","updated":"2022-09-15 12:42:52.000000000","message":"PowerMax CI has passed now.","commit_id":"1ae4ac4486bf3915e2b619e334dfb479a91bfa54"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fd49f59e1ac6a83a933de5e0335f7cd56f2797e","unresolved":true,"context_lines":[{"line_number":2505,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once()"},{"line_number":2509,"context_line":"        mock_rename.assert_called_once()"},{"line_number":2510,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2511,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"3f6c878e_d8ef01c5","line":2508,"range":{"start_line":2508,"start_character":39,"end_line":2508,"end_character":41},"updated":"2022-09-05 09:54:59.000000000","message":"we should assert the parameters as well\n\n    mock_sg_list.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1248e9e8be062a2985ad4cc27e03a5e30cc1163e","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once()"},{"line_number":2509,"context_line":"        mock_rename.assert_called_once()"},{"line_number":2510,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2511,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"8b1ed49c_48d8c027","line":2508,"range":{"start_line":2508,"start_character":39,"end_line":2508,"end_character":41},"in_reply_to":"3f6c878e_d8ef01c5","updated":"2022-09-05 11:33:35.000000000","message":"Done","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fd49f59e1ac6a83a933de5e0335f7cd56f2797e","unresolved":true,"context_lines":[{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once()"},{"line_number":2509,"context_line":"        mock_rename.assert_called_once()"},{"line_number":2510,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":5,"id":"90a60467_e74f248b","line":2509,"range":{"start_line":2509,"start_character":38,"end_line":2509,"end_character":40},"updated":"2022-09-05 09:54:59.000000000","message":"same","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1248e9e8be062a2985ad4cc27e03a5e30cc1163e","unresolved":false,"context_lines":[{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once()"},{"line_number":2509,"context_line":"        mock_rename.assert_called_once()"},{"line_number":2510,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":5,"id":"0cc9837b_d2a01b32","line":2509,"range":{"start_line":2509,"start_character":38,"end_line":2509,"end_character":40},"in_reply_to":"90a60467_e74f248b","updated":"2022-09-05 11:33:35.000000000","message":"Done","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fd49f59e1ac6a83a933de5e0335f7cd56f2797e","unresolved":true,"context_lines":[{"line_number":2523,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2524,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2525,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2526,"context_line":"        mock_sg_list.assert_called_once()"},{"line_number":2527,"context_line":"        mock_rename.assert_not_called()"},{"line_number":2528,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"86a1684e_8098b75f","line":2527,"range":{"start_line":2526,"start_character":8,"end_line":2527,"end_character":39},"updated":"2022-09-05 09:54:59.000000000","message":"Add call parameters here as well.\nwe have tests that call same methods multiple times with different parameters, we don\u0027t have the case here but still it\u0027s good to be explicit about the arguments with which the function call was made.","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1248e9e8be062a2985ad4cc27e03a5e30cc1163e","unresolved":false,"context_lines":[{"line_number":2523,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2524,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2525,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2526,"context_line":"        mock_sg_list.assert_called_once()"},{"line_number":2527,"context_line":"        mock_rename.assert_not_called()"},{"line_number":2528,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":5,"id":"f4648bf3_e42e6208","line":2527,"range":{"start_line":2526,"start_character":8,"end_line":2527,"end_character":39},"in_reply_to":"86a1684e_8098b75f","updated":"2022-09-05 11:33:35.000000000","message":"Done","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cab33579bdebf08b87c675d6271118e45f6aeb03","unresolved":true,"context_lines":[{"line_number":2505,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2509,"context_line":"        mock_rename.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2510,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"    @mock.patch.object("},{"line_number":2513,"context_line":"        rest.PowerMaxRest, \u0027_rename_storage_group\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"05e3ed14_4a5c5976","line":2510,"range":{"start_line":2508,"start_character":8,"end_line":2510,"end_character":0},"updated":"2022-09-05 19:05:43.000000000","message":"pep8 failure","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"fa374fd50f0cf30e72a8e552c744b6d7dbea9aed","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2509,"context_line":"        mock_rename.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2510,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2511,"context_line":""},{"line_number":2512,"context_line":"    @mock.patch.object("},{"line_number":2513,"context_line":"        rest.PowerMaxRest, \u0027_rename_storage_group\u0027)"}],"source_content_type":"text/x-python","patch_set":7,"id":"d11646ca_72f53938","line":2510,"range":{"start_line":2508,"start_character":8,"end_line":2510,"end_character":0},"in_reply_to":"05e3ed14_4a5c5976","updated":"2022-09-07 13:53:29.000000000","message":"Done","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cab33579bdebf08b87c675d6271118e45f6aeb03","unresolved":true,"context_lines":[{"line_number":2523,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2524,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2525,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2526,"context_line":"        mock_sg_list.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2527,"context_line":"        mock_rename.assert_not_called(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2528,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"29190695_cabaa103","line":2527,"range":{"start_line":2526,"start_character":8,"end_line":2527,"end_character":85},"updated":"2022-09-05 19:05:43.000000000","message":"same","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"fa374fd50f0cf30e72a8e552c744b6d7dbea9aed","unresolved":false,"context_lines":[{"line_number":2523,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2524,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2525,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2526,"context_line":"        mock_sg_list.assert_called_once(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2527,"context_line":"        mock_rename.assert_not_called(self.data.array, {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2528,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":7,"id":"3a6e16b3_7baaa147","line":2527,"range":{"start_line":2526,"start_character":8,"end_line":2527,"end_character":85},"in_reply_to":"29190695_cabaa103","updated":"2022-09-07 13:53:29.000000000","message":"Done","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfd105aa26736c1b7023b0abe43dc298b7bd3efa","unresolved":true,"context_lines":[{"line_number":2505,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("}],"source_content_type":"text/x-python","patch_set":9,"id":"27642dda_c1adb079","line":2508,"range":{"start_line":2508,"start_character":21,"end_line":2508,"end_character":39},"updated":"2022-09-13 09:52:09.000000000","message":"this should be assert_called_once_with","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2505,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2506,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("}],"source_content_type":"text/x-python","patch_set":9,"id":"e25294f5_f1b631fe","line":2508,"range":{"start_line":2508,"start_character":21,"end_line":2508,"end_character":39},"in_reply_to":"27642dda_c1adb079","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6721cd39b0ddf5015d961d094348b8001860e1d0","unresolved":true,"context_lines":[{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("},{"line_number":2512,"context_line":"            self.data.array,"},{"line_number":2513,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"}],"source_content_type":"text/x-python","patch_set":9,"id":"c1a35b50_6dfe09a4","line":2510,"range":{"start_line":2510,"start_character":12,"end_line":2510,"end_character":41},"updated":"2022-09-13 11:17:46.000000000","message":"params\u003d{\u0027storageGroupId\u0027: sg_filter}","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2507,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("},{"line_number":2512,"context_line":"            self.data.array,"},{"line_number":2513,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"}],"source_content_type":"text/x-python","patch_set":9,"id":"b89480a2_a963ff57","line":2510,"range":{"start_line":2510,"start_character":12,"end_line":2510,"end_character":41},"in_reply_to":"c1a35b50_6dfe09a4","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfd105aa26736c1b7023b0abe43dc298b7bd3efa","unresolved":true,"context_lines":[{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("},{"line_number":2512,"context_line":"            self.data.array,"},{"line_number":2513,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2514,"context_line":"        self.assertIsNotNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"175527a1_82c0eade","line":2511,"range":{"start_line":2511,"start_character":20,"end_line":2511,"end_character":38},"updated":"2022-09-13 09:52:09.000000000","message":"same","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2508,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("},{"line_number":2512,"context_line":"            self.data.array,"},{"line_number":2513,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2514,"context_line":"        self.assertIsNotNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"8ed5e647_320b4415","line":2511,"range":{"start_line":2511,"start_character":20,"end_line":2511,"end_character":38},"in_reply_to":"175527a1_82c0eade","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6721cd39b0ddf5015d961d094348b8001860e1d0","unresolved":true,"context_lines":[{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("},{"line_number":2512,"context_line":"            self.data.array,"},{"line_number":2513,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2514,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":9,"id":"269bf2b9_1c773302","line":2513,"range":{"start_line":2512,"start_character":12,"end_line":2513,"end_character":41},"updated":"2022-09-13 11:17:46.000000000","message":"This doesn\u0027t accept these parameters, we need different parameters here\n\n        group_list_return \u003d {\u0027storageGroupId\u0027: [\u0027user-name+uuid\u0027]}\n        mock_rename.assert_called_once_with(\n            self.data.array,\n            group_list_return[\u0027storageGroupId\u0027][0],\n            self.data.storagegroup_name_f,\n            self.data.extra_specs)","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2509,"context_line":"            self.data.array,"},{"line_number":2510,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2511,"context_line":"        mock_rename.assert_called_once("},{"line_number":2512,"context_line":"            self.data.array,"},{"line_number":2513,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2514,"context_line":"        self.assertIsNotNone(rep_info)"},{"line_number":2515,"context_line":""},{"line_number":2516,"context_line":"    @mock.patch.object("}],"source_content_type":"text/x-python","patch_set":9,"id":"2b5b895b_0385d9ad","line":2513,"range":{"start_line":2512,"start_character":12,"end_line":2513,"end_character":41},"in_reply_to":"269bf2b9_1c773302","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfd105aa26736c1b7023b0abe43dc298b7bd3efa","unresolved":true,"context_lines":[{"line_number":2527,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2528,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2529,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("}],"source_content_type":"text/x-python","patch_set":9,"id":"d0d4eee7_ed875719","line":2530,"range":{"start_line":2530,"start_character":21,"end_line":2530,"end_character":39},"updated":"2022-09-13 09:52:09.000000000","message":"same","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2527,"context_line":"        rep_info \u003d self.rest.get_or_rename_storage_group_rep("},{"line_number":2528,"context_line":"            self.data.array, self.data.storagegroup_name_f,"},{"line_number":2529,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("}],"source_content_type":"text/x-python","patch_set":9,"id":"f206ab05_d4eb6e9d","line":2530,"range":{"start_line":2530,"start_character":21,"end_line":2530,"end_character":39},"in_reply_to":"d0d4eee7_ed875719","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6721cd39b0ddf5015d961d094348b8001860e1d0","unresolved":true,"context_lines":[{"line_number":2529,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("},{"line_number":2534,"context_line":"            self.data.array,"},{"line_number":2535,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"}],"source_content_type":"text/x-python","patch_set":9,"id":"b1ced2fc_11aca435","line":2532,"range":{"start_line":2532,"start_character":12,"end_line":2532,"end_character":41},"updated":"2022-09-13 11:17:46.000000000","message":"params\u003d{\u0027storageGroupId\u0027: sg_filter}","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2529,"context_line":"            self.data.extra_specs, sg_filter\u003dsg_filter)"},{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("},{"line_number":2534,"context_line":"            self.data.array,"},{"line_number":2535,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"}],"source_content_type":"text/x-python","patch_set":9,"id":"5069f923_ad777adf","line":2532,"range":{"start_line":2532,"start_character":12,"end_line":2532,"end_character":41},"in_reply_to":"b1ced2fc_11aca435","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bfd105aa26736c1b7023b0abe43dc298b7bd3efa","unresolved":true,"context_lines":[{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("},{"line_number":2534,"context_line":"            self.data.array,"},{"line_number":2535,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2536,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5f2ba963_8064ba10","line":2533,"range":{"start_line":2533,"start_character":20,"end_line":2533,"end_character":37},"updated":"2022-09-13 09:52:09.000000000","message":"same","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("},{"line_number":2534,"context_line":"            self.data.array,"},{"line_number":2535,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2536,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"6b2dae04_5aa8ac82","line":2533,"range":{"start_line":2533,"start_character":20,"end_line":2533,"end_character":37},"in_reply_to":"5f2ba963_8064ba10","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6721cd39b0ddf5015d961d094348b8001860e1d0","unresolved":true,"context_lines":[{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("},{"line_number":2534,"context_line":"            self.data.array,"},{"line_number":2535,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2536,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"cead5dac_53b07db7","line":2535,"range":{"start_line":2533,"start_character":0,"end_line":2535,"end_character":42},"updated":"2022-09-13 11:17:46.000000000","message":"mock_rename.assert_not_called()","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5ee13bf98f787bc6f6721b263dcb534671ebac36","unresolved":false,"context_lines":[{"line_number":2530,"context_line":"        mock_sg_list.assert_called_once("},{"line_number":2531,"context_line":"            self.data.array,"},{"line_number":2532,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2533,"context_line":"        mock_rename.assert_not_called("},{"line_number":2534,"context_line":"            self.data.array,"},{"line_number":2535,"context_line":"            {\u0027storageGroupId\u0027: sg_filter})"},{"line_number":2536,"context_line":"        self.assertIsNone(rep_info)"}],"source_content_type":"text/x-python","patch_set":9,"id":"5641ea39_6ec726dc","line":2535,"range":{"start_line":2533,"start_character":0,"end_line":2535,"end_character":42},"in_reply_to":"cead5dac_53b07db7","updated":"2022-09-13 12:12:31.000000000","message":"Done","commit_id":"28ffa70590b651b7b2ea955b1333ada3a91b5b05"}],"cinder/volume/drivers/dell_emc/powermax/rest.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7be4c85c25957c844d645595c39ef09be64c78bb","unresolved":true,"context_lines":[{"line_number":3105,"context_line":"                        rep_details \u003d self.get_storage_group_rep("},{"line_number":3106,"context_line":"                            array, storage_group_name)"},{"line_number":3107,"context_line":"                        LOG.warning("},{"line_number":3108,"context_line":"                            \"Volume group %(old)s has been renamed to %(new)s\""},{"line_number":3109,"context_line":"                            \"due to a rename operation in OpenStack.\","},{"line_number":3110,"context_line":"                            {\u0027old\u0027: sg_list[0], \u0027new\u0027: storage_group_name})"},{"line_number":3111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"6adb3927_515e1492","line":3108,"range":{"start_line":3108,"start_character":77,"end_line":3108,"end_character":78},"updated":"2022-05-24 21:34:21.000000000","message":"nit: need a space before this \"","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8b5fd2b28ae34107a7bef8f9ddf39bb715e308cc","unresolved":false,"context_lines":[{"line_number":3105,"context_line":"                        rep_details \u003d self.get_storage_group_rep("},{"line_number":3106,"context_line":"                            array, storage_group_name)"},{"line_number":3107,"context_line":"                        LOG.warning("},{"line_number":3108,"context_line":"                            \"Volume group %(old)s has been renamed to %(new)s\""},{"line_number":3109,"context_line":"                            \"due to a rename operation in OpenStack.\","},{"line_number":3110,"context_line":"                            {\u0027old\u0027: sg_list[0], \u0027new\u0027: storage_group_name})"},{"line_number":3111,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"d086d9e9_52e5afde","line":3108,"range":{"start_line":3108,"start_character":77,"end_line":3108,"end_character":78},"in_reply_to":"6adb3927_515e1492","updated":"2022-06-15 12:40:10.000000000","message":"Done","commit_id":"4499011ad1dfc72c2926a4ec34702cd60049aec2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0fd49f59e1ac6a83a933de5e0335f7cd56f2797e","unresolved":true,"context_lines":[{"line_number":3076,"context_line":"            self, array, storage_group_name, extra_specs, sg_filter\u003dNone):"},{"line_number":3077,"context_line":"        \"\"\"Get storage group rep info if it exist."},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        If a generic volume group has been renamed we need to"},{"line_number":3080,"context_line":"        also need to rename it on the array based on the uuid"},{"line_number":3081,"context_line":"        component. We check for uuid if we cannot find it based"},{"line_number":3082,"context_line":"        on its old name."},{"line_number":3083,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"81f6a17b_aa9da9e6","line":3080,"range":{"start_line":3079,"start_character":51,"end_line":3080,"end_character":17},"updated":"2022-09-05 09:54:59.000000000","message":"nit: we also need","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1248e9e8be062a2985ad4cc27e03a5e30cc1163e","unresolved":false,"context_lines":[{"line_number":3076,"context_line":"            self, array, storage_group_name, extra_specs, sg_filter\u003dNone):"},{"line_number":3077,"context_line":"        \"\"\"Get storage group rep info if it exist."},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        If a generic volume group has been renamed we need to"},{"line_number":3080,"context_line":"        also need to rename it on the array based on the uuid"},{"line_number":3081,"context_line":"        component. We check for uuid if we cannot find it based"},{"line_number":3082,"context_line":"        on its old name."},{"line_number":3083,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"60e045ee_1cd782e4","line":3080,"range":{"start_line":3079,"start_character":51,"end_line":3080,"end_character":17},"in_reply_to":"81f6a17b_aa9da9e6","updated":"2022-09-05 11:33:35.000000000","message":"Done","commit_id":"2f34b809412fda45bf485dc0c7d4c54df1803fd0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cab33579bdebf08b87c675d6271118e45f6aeb03","unresolved":true,"context_lines":[{"line_number":3076,"context_line":"            self, array, storage_group_name, extra_specs, sg_filter\u003dNone):"},{"line_number":3077,"context_line":"        \"\"\"Get storage group rep info if it exist."},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        If a generic volume group has been renamed we also need "},{"line_number":3080,"context_line":"        to rename it on the array based on the uuid component. "},{"line_number":3081,"context_line":"        We check for uuid if we cannot find it based on its old name."},{"line_number":3082,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"35dbd582_9381cfd4","line":3079,"range":{"start_line":3079,"start_character":63,"end_line":3079,"end_character":64},"updated":"2022-09-05 19:05:43.000000000","message":"remove extra space","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"fa374fd50f0cf30e72a8e552c744b6d7dbea9aed","unresolved":false,"context_lines":[{"line_number":3076,"context_line":"            self, array, storage_group_name, extra_specs, sg_filter\u003dNone):"},{"line_number":3077,"context_line":"        \"\"\"Get storage group rep info if it exist."},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        If a generic volume group has been renamed we also need "},{"line_number":3080,"context_line":"        to rename it on the array based on the uuid component. "},{"line_number":3081,"context_line":"        We check for uuid if we cannot find it based on its old name."},{"line_number":3082,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"d368c092_e97b54da","line":3079,"range":{"start_line":3079,"start_character":63,"end_line":3079,"end_character":64},"in_reply_to":"35dbd582_9381cfd4","updated":"2022-09-07 13:53:29.000000000","message":"Done","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cab33579bdebf08b87c675d6271118e45f6aeb03","unresolved":true,"context_lines":[{"line_number":3077,"context_line":"        \"\"\"Get storage group rep info if it exist."},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        If a generic volume group has been renamed we also need "},{"line_number":3080,"context_line":"        to rename it on the array based on the uuid component. "},{"line_number":3081,"context_line":"        We check for uuid if we cannot find it based on its old name."},{"line_number":3082,"context_line":""},{"line_number":3083,"context_line":"        :param array: the array serial number"}],"source_content_type":"text/x-python","patch_set":7,"id":"b224ed21_2e2fece3","line":3080,"range":{"start_line":3080,"start_character":62,"end_line":3080,"end_character":63},"updated":"2022-09-05 19:05:43.000000000","message":"same","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"fa374fd50f0cf30e72a8e552c744b6d7dbea9aed","unresolved":false,"context_lines":[{"line_number":3077,"context_line":"        \"\"\"Get storage group rep info if it exist."},{"line_number":3078,"context_line":""},{"line_number":3079,"context_line":"        If a generic volume group has been renamed we also need "},{"line_number":3080,"context_line":"        to rename it on the array based on the uuid component. "},{"line_number":3081,"context_line":"        We check for uuid if we cannot find it based on its old name."},{"line_number":3082,"context_line":""},{"line_number":3083,"context_line":"        :param array: the array serial number"}],"source_content_type":"text/x-python","patch_set":7,"id":"5961e44c_e04d839e","line":3080,"range":{"start_line":3080,"start_character":62,"end_line":3080,"end_character":63},"in_reply_to":"b224ed21_2e2fece3","updated":"2022-09-07 13:53:29.000000000","message":"Done","commit_id":"1612186fd1ee255b1c1edf7046630cf70242679c"}]}