)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"b8cd957c16f5256d35c81a071ea0e243e849b6a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"127a70bd_62c48ae5","updated":"2022-02-09 00:54:07.000000000","message":"Confirmed the error is not found even after rebase.","commit_id":"87eb6e760188b338222fffe0aa491fd48b05092a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"86bd3879eae78ac14aaa07376b6b3f75020c50a5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2eed6ae5_de0ea429","updated":"2022-02-09 03:22:20.000000000","message":"Suggestion inline for the snapshot files; the others look fine.","commit_id":"87eb6e760188b338222fffe0aa491fd48b05092a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2326c07c93761a7d3d4b62cc5dea46325d9e2d61","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"091dbb7e_6b568317","updated":"2022-02-09 03:28:44.000000000","message":"Thanks for doing this, by the way.  One day we were going to pull in a new oslo.vo and all these tests would be broken.","commit_id":"87eb6e760188b338222fffe0aa491fd48b05092a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edd7d66a8752800806eeb694e6c6942a2f18156f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f28125a5_67c9485f","in_reply_to":"091dbb7e_6b568317","updated":"2022-02-09 05:27:58.000000000","message":"my pleasure :-)","commit_id":"87eb6e760188b338222fffe0aa491fd48b05092a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"56f5aa95896f989918d288dbcb17faf0df3f7a27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0125151e_62b9883d","updated":"2022-02-14 13:12:56.000000000","message":"Revisions look good to me.  Thanks, Takashi!","commit_id":"12c2cde1976a5dfb314556312fef1ba784e65e08"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"e97341c5634f60bcbf563ac321a4ad1b512f5bc5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a9632a7a_e7a8350c","updated":"2022-02-09 09:03:44.000000000","message":"vmware-recheck-patch","commit_id":"12c2cde1976a5dfb314556312fef1ba784e65e08"}],"cinder/tests/unit/api/contrib/test_snapshot_manage.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"86bd3879eae78ac14aaa07376b6b3f75020c50a5","unresolved":true,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @mock.patch("},{"line_number":113,"context_line":"        \u0027cinder.scheduler.rpcapi.SchedulerAPI.manage_existing_snapshot\u0027)"},{"line_number":114,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.create_snapshot_in_db\u0027)"},{"line_number":115,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api.service_get\u0027)"},{"line_number":116,"context_line":"    def test_manage_snapshot_ok(self, mock_db,"},{"line_number":117,"context_line":"                                mock_create_snapshot, mock_rpcapi):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4d29607c_c51e54a1","line":114,"updated":"2022-02-09 03:22:20.000000000","message":"I think the tests would be less cluttered if you set the return value here, e.g.,\n\n    @mock.patch(\u0027cinder.volume.api.API.create_snapshot_in_db\u0027\n                return_value\u003dmock.MagicMock(id\u003dfake.SNAPSHOT_ID))\n\nSame thing in cinder/tests/unit/api/v3/test_snapshot_manage.py","commit_id":"87eb6e760188b338222fffe0aa491fd48b05092a"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"edd7d66a8752800806eeb694e6c6942a2f18156f","unresolved":false,"context_lines":[{"line_number":111,"context_line":""},{"line_number":112,"context_line":"    @mock.patch("},{"line_number":113,"context_line":"        \u0027cinder.scheduler.rpcapi.SchedulerAPI.manage_existing_snapshot\u0027)"},{"line_number":114,"context_line":"    @mock.patch(\u0027cinder.volume.api.API.create_snapshot_in_db\u0027)"},{"line_number":115,"context_line":"    @mock.patch(\u0027cinder.db.sqlalchemy.api.service_get\u0027)"},{"line_number":116,"context_line":"    def test_manage_snapshot_ok(self, mock_db,"},{"line_number":117,"context_line":"                                mock_create_snapshot, mock_rpcapi):"}],"source_content_type":"text/x-python","patch_set":5,"id":"4dddd09f_a7793560","line":114,"in_reply_to":"4d29607c_c51e54a1","updated":"2022-02-09 05:27:58.000000000","message":"Done","commit_id":"87eb6e760188b338222fffe0aa491fd48b05092a"}],"cinder/tests/unit/volume/drivers/netapp/fakes.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"6704dff242144f7e0c458d8c7d90d8b287ba1244","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                                  \u0027target_lun\u0027: ISCSI_FAKE_LUN_ID,"},{"line_number":70,"context_line":"                                  \u0027volume_id\u0027: ISCSI_FAKE_VOLUME[\u0027id\u0027]}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"VOLUME_NAME \u003d fake.VOLUME_NAME"},{"line_number":73,"context_line":"VOLUME_ID \u003d fake.VOLUME_ID"},{"line_number":74,"context_line":"VOLUME_TYPE_ID \u003d fake.VOLUME_TYPE_ID"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"2df24cf9_fae69d51","line":72,"updated":"2021-08-02 16:34:32.000000000","message":"This is already handled in\n    https://review.opendev.org/c/openstack/cinder/+/800490\n\nMaybe rebase this patch on top of that one.","commit_id":"1d89b8137a4a5e0df0098d6b601864bb5ba967b9"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4e53a7e47ed0819dff8443cfeb2a2049673b2451","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                                  \u0027target_lun\u0027: ISCSI_FAKE_LUN_ID,"},{"line_number":70,"context_line":"                                  \u0027volume_id\u0027: ISCSI_FAKE_VOLUME[\u0027id\u0027]}"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":"VOLUME_NAME \u003d fake.VOLUME_NAME"},{"line_number":73,"context_line":"VOLUME_ID \u003d fake.VOLUME_ID"},{"line_number":74,"context_line":"VOLUME_TYPE_ID \u003d fake.VOLUME_TYPE_ID"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c8878022_86424cb1","line":72,"in_reply_to":"2df24cf9_fae69d51","updated":"2021-08-02 16:51:29.000000000","message":"Done","commit_id":"1d89b8137a4a5e0df0098d6b601864bb5ba967b9"}]}
