)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"577dd77139010637c84bd2c8a8ad5892dfadb973","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Helen Walsh \u003chelen.walsh@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-17 15:37:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Allow for retype to _DEFAULT__ VT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the default volume type has no \u0027pool_name\u0027, random pool"},{"line_number":10,"context_line":"information is returned on a retype operation, which is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4f80c15e_14ea2bf6","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":39},"updated":"2021-08-27 10:37:20.000000000","message":"typo: two underscore(__) before DEFAULT","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d809662ce89fd761931ba7a1194a9a6fb003d328","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Helen Walsh \u003chelen.walsh@emc.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-17 15:37:55 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Allow for retype to _DEFAULT__ VT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the default volume type has no \u0027pool_name\u0027, random pool"},{"line_number":10,"context_line":"information is returned on a retype operation, which is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a4438b0c_5aeb0d48","line":7,"range":{"start_line":7,"start_character":37,"end_line":7,"end_character":39},"in_reply_to":"4f80c15e_14ea2bf6","updated":"2021-10-12 11:12:02.000000000","message":"Ack","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c71664790c0548dc7947df91ab4202ca190006e","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Allow for retype to _DEFAULT__ VT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the default volume type has no \u0027pool_name\u0027, random pool"},{"line_number":10,"context_line":"information is returned on a retype operation, which is"},{"line_number":11,"context_line":"not accurate. To rectify this we can get the service level"},{"line_number":12,"context_line":"from the derived extra specs so the volume can be moved to"},{"line_number":13,"context_line":"the correct storage group which is associated with Optimized"},{"line_number":14,"context_line":"service level."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"74a25ae2_e3c65f66","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":13},"updated":"2022-06-17 15:03:40.000000000","message":"I\u0027m not sure what the problem is here. The __DEFAULT__ type is a placeholder for volumes without a type. what i would like to understand is, in which case do we retype to a __DEFAULT__ type? Also if you\u0027re using the __DEFAULT__ type, you can modify it to add the \u0027pool_name\u0027 extra spec there.","commit_id":"28354f2aec78568dd30b48f003afe1658b6fe043"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b4b466644468559376493a17f1224c119afe4b51","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"PowerMax Driver - Allow for retype to _DEFAULT__ VT"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"As the default volume type has no \u0027pool_name\u0027, random pool"},{"line_number":10,"context_line":"information is returned on a retype operation, which is"},{"line_number":11,"context_line":"not accurate. To rectify this we can get the service level"},{"line_number":12,"context_line":"from the derived extra specs so the volume can be moved to"},{"line_number":13,"context_line":"the correct storage group which is associated with Optimized"},{"line_number":14,"context_line":"service level."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"416fa8b1_38e31e04","line":11,"range":{"start_line":9,"start_character":0,"end_line":11,"end_character":13},"in_reply_to":"74a25ae2_e3c65f66","updated":"2022-06-17 15:06:41.000000000","message":"Just to correct my words here, the __DEFAULT__ type WAS created to act as a placeholder for untyped volumes but it can be used as a normal volume type. you can  rename it or add/remove extra specs from it. If you really want to use the __DEFAULT__ type, then modify it\u0027s extra_specs accordingly.","commit_id":"28354f2aec78568dd30b48f003afe1658b6fe043"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d46c14cf46c883240df94519b0734dad025a568","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"e83ff750_26595637","updated":"2022-05-24 22:19:02.000000000","message":"Code and tests look good.","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"da5df3d0047205f304f02b1da4df258d71c31e4d","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b00a4ab3_572f93ec","updated":"2021-10-12 12:07:14.000000000","message":"Thanks Helen for explanation.\n","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"bb06abb80af715283361b2757c63ed89813ebe6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ab07de75_620c55a3","in_reply_to":"b00a4ab3_572f93ec","updated":"2022-01-19 13:13:33.000000000","message":"Ack","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"73814489be82db6975bbc3429753d5d1f2aae8eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"885f7839_a07538e6","updated":"2022-06-17 06:36:02.000000000","message":"recheck","commit_id":"66a017dc9dd242f0cfb84b8dee7714984890354a"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"cf03015cd5225d2bf8c3ad917905a8787409519f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"302287a0_4f8dc8f1","updated":"2022-06-16 15:26:40.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"66a017dc9dd242f0cfb84b8dee7714984890354a"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"921d4a66f14a4d48d63eb99bc6184008c0757981","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ad5b410d_713a4770","updated":"2022-06-15 09:44:52.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"66a017dc9dd242f0cfb84b8dee7714984890354a"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"0ec428ae4730b2cd9a2bb75b5852f6f47d436935","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"54c6cd1b_078158fd","updated":"2022-07-01 09:36:10.000000000","message":"Agree with Rajat, need to recover the problem causing that change","commit_id":"28354f2aec78568dd30b48f003afe1658b6fe043"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7c71664790c0548dc7947df91ab4202ca190006e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"44d21a38_ee6bdb58","updated":"2022-06-17 15:03:40.000000000","message":"One question inline. I\u0027m not able to understand why we need to handle this case in the driver. Just configure the volume type (either __DEFAULT__ or any other type) with the right extra_specs.","commit_id":"28354f2aec78568dd30b48f003afe1658b6fe043"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"9a6de1676a5f886385c40e64f128e51d3c8e2114","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"bc88d359_a6c3a531","in_reply_to":"44d21a38_ee6bdb58","updated":"2022-09-15 14:27:12.000000000","message":"Hey Rajat, I\u0027ve added the bug corresponding to this issue, hope that helps understand the background.","commit_id":"28354f2aec78568dd30b48f003afe1658b6fe043"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b07783abf23f3ef3bc0cb9fe842b5b20064c1847","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"902f0692_09fa5a4f","updated":"2024-09-16 14:43:57.000000000","message":"Is this still needed?  Sounds like Rajat\u0027s suggestion may have been in place of this code change.  Please abandon the patch if you don\u0027t want to pursue it.","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5f47129ac26da1a752659d452a863ab18e632cf6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"733f8291_c8444ab9","updated":"2022-09-16 18:36:02.000000000","message":"recheck","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"64d64629750989bc75d5906aaa131c9c7e22bd87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"943dc62c_60d5c3c8","updated":"2022-09-16 16:16:37.000000000","message":"recheck","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6a5540f443ce8da852e8c610c547cbf834b65cd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8ba33e4a_930fdb18","updated":"2022-10-17 14:02:45.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":37792,"name":"Dell Openstack CI","display_name":"Dell Openstack CI","email":"dellopenstackci@dell.com","username":"dellopenstackci"},"change_message_id":"f1a914c93abc836a1bd25dd8b023f58edc802e41","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"cd144a9b_2fd0eb76","updated":"2025-03-20 12:15:21.000000000","message":"run-DellEMC PowerMax CI","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"680c1a2e11e7ae5ba1e6e5761cf5c8a5223612aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"222d528b_bf279b9e","updated":"2025-01-09 15:46:34.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"20ea3f66d4d676663d13c72d59c14c72c172edca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b9e2764b_ad7b3508","updated":"2025-01-09 15:59:17.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2666ee6f480117144583b73049c40699e3d00861"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"09534491d3bd81852879a1e2908e1035cf951ae4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"db2a5eee_82a1c2af","updated":"2025-01-09 16:10:39.000000000","message":"run-DellEMC PowerStore CI","commit_id":"2666ee6f480117144583b73049c40699e3d00861"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_common.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"577dd77139010637c84bd2c8a8ad5892dfadb973","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"        device_id \u003d self.data.device_id"},{"line_number":2229,"context_line":"        volume_name \u003d self.data.test_volume.name"},{"line_number":2230,"context_line":"        volume \u003d self.data.test_volume"},{"line_number":2231,"context_line":"        new_type \u003d {\u0027extra_specs\u0027: {\u0027volume_backend_name\u0027: \u0027POWERMAX_BE\u0027},"},{"line_number":2232,"context_line":"                    \u0027id\u0027: self.data.test_id}"},{"line_number":2233,"context_line":"        host \u003d {\u0027host\u0027: self.data.new_host}"},{"line_number":2234,"context_line":"        optimized_host \u003d {\u0027host\u0027: self.data.optimized_host}"}],"source_content_type":"text/x-python","patch_set":2,"id":"eb78573a_d9b800d4","line":2231,"range":{"start_line":2231,"start_character":36,"end_line":2231,"end_character":57},"updated":"2021-08-27 10:37:20.000000000","message":"Didn\u0027t understand how volume_backend_name is being used in common.py (Line 3796 to 3813 i.e code changes in this patch).","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d809662ce89fd761931ba7a1194a9a6fb003d328","unresolved":false,"context_lines":[{"line_number":2228,"context_line":"        device_id \u003d self.data.device_id"},{"line_number":2229,"context_line":"        volume_name \u003d self.data.test_volume.name"},{"line_number":2230,"context_line":"        volume \u003d self.data.test_volume"},{"line_number":2231,"context_line":"        new_type \u003d {\u0027extra_specs\u0027: {\u0027volume_backend_name\u0027: \u0027POWERMAX_BE\u0027},"},{"line_number":2232,"context_line":"                    \u0027id\u0027: self.data.test_id}"},{"line_number":2233,"context_line":"        host \u003d {\u0027host\u0027: self.data.new_host}"},{"line_number":2234,"context_line":"        optimized_host \u003d {\u0027host\u0027: self.data.optimized_host}"}],"source_content_type":"text/x-python","patch_set":2,"id":"624983fa_da9490bf","line":2231,"range":{"start_line":2231,"start_character":36,"end_line":2231,"end_character":57},"in_reply_to":"de35ef78_2bb1ae5b","updated":"2021-10-12 11:12:02.000000000","message":"Ack","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"66abcd468a5d06097486e746bf5daaf320a6f4e7","unresolved":true,"context_lines":[{"line_number":2228,"context_line":"        device_id \u003d self.data.device_id"},{"line_number":2229,"context_line":"        volume_name \u003d self.data.test_volume.name"},{"line_number":2230,"context_line":"        volume \u003d self.data.test_volume"},{"line_number":2231,"context_line":"        new_type \u003d {\u0027extra_specs\u0027: {\u0027volume_backend_name\u0027: \u0027POWERMAX_BE\u0027},"},{"line_number":2232,"context_line":"                    \u0027id\u0027: self.data.test_id}"},{"line_number":2233,"context_line":"        host \u003d {\u0027host\u0027: self.data.new_host}"},{"line_number":2234,"context_line":"        optimized_host \u003d {\u0027host\u0027: self.data.optimized_host}"}],"source_content_type":"text/x-python","patch_set":2,"id":"de35ef78_2bb1ae5b","line":2231,"range":{"start_line":2231,"start_character":36,"end_line":2231,"end_character":57},"in_reply_to":"eb78573a_d9b800d4","updated":"2021-10-12 11:11:42.000000000","message":"Thank you for your feedback\n\n# Allow for volume type without a pool_name or  __DEFAULT__ volume type\nif (new_type[\u0027extra_specs\u0027] and not new_type[\u0027extra_specs\u0027].get(\n    \u0027pool_name\u0027)) or not new_type[\u0027extra_specs\u0027]:\n\nThe reason I added this was that the volume type has a \u0027volume_backend_name\u0027 but does not have a \u0027pool_name\u0027 which satisfies the first part of this condition\n\nif (new_type[\u0027extra_specs\u0027] and not new_type[\u0027extra_specs\u0027].get(\n    \u0027pool_name\u0027))\n\nI guess for the purposes of this test I could have put in anything but in reality it would probably be \u0027volume_backend_name\u0027 in PowerMax scenario\n\nPlease let me know if this is not clear.","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"}],"cinder/volume/drivers/dell_emc/powermax/common.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8d46c14cf46c883240df94519b0734dad025a568","unresolved":true,"context_lines":[{"line_number":3794,"context_line":"                extra_specs, rep_config)"},{"line_number":3795,"context_line":""},{"line_number":3796,"context_line":"        # Allow for volume type without a pool_name or  __DEFAULT__ volume type"},{"line_number":3797,"context_line":"        if (new_type[\u0027extra_specs\u0027] and not new_type[\u0027extra_specs\u0027].get("},{"line_number":3798,"context_line":"                \u0027pool_name\u0027)) or not new_type[\u0027extra_specs\u0027]:"},{"line_number":3799,"context_line":"            new_type[\u0027extra_specs\u0027] \u003d self._initial_setup("},{"line_number":3800,"context_line":"                volume, new_type[\u0027id\u0027])"},{"line_number":3801,"context_line":"            host_info \u003d host[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"4cde684c_fcb25513","line":3798,"range":{"start_line":3797,"start_character":8,"end_line":3798,"end_character":61},"updated":"2022-05-24 22:19:02.000000000","message":"This could be simplified if you need to put up a new patch set:\n\n    if (not new_type[\u0027extra_specs\u0027]\n        or not new_type[\u0027extra_specs\u0027].get(\u0027pool_name\u0027)):","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"af7ef1e3ea080643636f37132bb7a481375efd25","unresolved":false,"context_lines":[{"line_number":3794,"context_line":"                extra_specs, rep_config)"},{"line_number":3795,"context_line":""},{"line_number":3796,"context_line":"        # Allow for volume type without a pool_name or  __DEFAULT__ volume type"},{"line_number":3797,"context_line":"        if (new_type[\u0027extra_specs\u0027] and not new_type[\u0027extra_specs\u0027].get("},{"line_number":3798,"context_line":"                \u0027pool_name\u0027)) or not new_type[\u0027extra_specs\u0027]:"},{"line_number":3799,"context_line":"            new_type[\u0027extra_specs\u0027] \u003d self._initial_setup("},{"line_number":3800,"context_line":"                volume, new_type[\u0027id\u0027])"},{"line_number":3801,"context_line":"            host_info \u003d host[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"89fab939_eb490af0","line":3798,"range":{"start_line":3797,"start_character":8,"end_line":3798,"end_character":61},"in_reply_to":"22d3156e_6a0d0133","updated":"2022-06-17 07:28:37.000000000","message":"Done","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"706b0caf13b3a33310b0b92d32082dc42c14e538","unresolved":true,"context_lines":[{"line_number":3794,"context_line":"                extra_specs, rep_config)"},{"line_number":3795,"context_line":""},{"line_number":3796,"context_line":"        # Allow for volume type without a pool_name or  __DEFAULT__ volume type"},{"line_number":3797,"context_line":"        if (new_type[\u0027extra_specs\u0027] and not new_type[\u0027extra_specs\u0027].get("},{"line_number":3798,"context_line":"                \u0027pool_name\u0027)) or not new_type[\u0027extra_specs\u0027]:"},{"line_number":3799,"context_line":"            new_type[\u0027extra_specs\u0027] \u003d self._initial_setup("},{"line_number":3800,"context_line":"                volume, new_type[\u0027id\u0027])"},{"line_number":3801,"context_line":"            host_info \u003d host[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":2,"id":"22d3156e_6a0d0133","line":3798,"range":{"start_line":3797,"start_character":8,"end_line":3798,"end_character":61},"in_reply_to":"4cde684c_fcb25513","updated":"2022-06-17 07:28:14.000000000","message":"Done","commit_id":"5bf2851a1634c1eb213e97294cbb22959630b3ef"}]}