)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"38b90e1066706b51e4f3006834c579444ae54e6f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ee80d33_20d864a4","updated":"2022-05-24 22:42:36.000000000","message":"Code and tests LGTM.","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"2ac34de1d1ce5b0d98306fd095321a1974fb62e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"301c6c96_c50810f7","updated":"2022-06-29 12:55:12.000000000","message":"LGTM","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"f8e63a002b68932b466afecb48e660c47cda4a47","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4d8d0fb9_93c8b812","updated":"2022-06-17 15:36:43.000000000","message":"LGTM","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"be986fba3255969bd4dc69ebf7bfb621b8a05326","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"ddcc1871_8378b751","updated":"2022-06-17 15:34:08.000000000","message":"LGTM","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"2dea9440d5eded35ede9f83dde1913da446fa28e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0ae999bb_c7f0c4a8","updated":"2022-06-30 07:02:48.000000000","message":"recheck","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"7dda4eee81a5c505f378139003edd91cbb1a5595","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"190626c6_58d2e1a0","updated":"2022-06-29 20:09:02.000000000","message":"recheck","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":31981,"name":"Tarun Mathur","email":"tarun.mathur@dell.com"},"change_message_id":"9b55dd9f2a9630b7166056c3b7fcc2d562c8c4d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b0a8a86_03d66bfb","updated":"2022-06-30 17:13:00.000000000","message":"recheck","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"38b765ea36914da52e6fbda9087ac634ebe98e0c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"311f6fec_8422fe0c","updated":"2022-06-30 09:03:52.000000000","message":"rechek","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"0ee972523db60a4a8bc3b9a21f5f6ecf6f4beca0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"0e7b24f3_c6cf2ab7","updated":"2022-06-30 09:23:52.000000000","message":"regate","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"}],"cinder/tests/unit/volume/drivers/dell_emc/powermax/test_powermax_metadata.py":[{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"53f3ed35e828cf3634feed33f8b88544d84be416","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        metadata.PowerMaxVolumeMetadata, \u0027update_volume_info_metadata\u0027,"},{"line_number":116,"context_line":"        return_value\u003d{})"},{"line_number":117,"context_line":"    @mock.patch(\u0027time.time\u0027, mock_time)"},{"line_number":118,"context_line":"    def test_capture_manage_existing_no_backup_id(self, mock_uvim):"},{"line_number":119,"context_line":"        manage_existing_metadata \u003d ("},{"line_number":120,"context_line":"            {\u00271e5177e7-95e5-4a0f-b170-e45f4b469f6a\u0027: {"},{"line_number":121,"context_line":"                \u0027volume_id\u0027: \u00271e5177e7-95e5-4a0f-b170-e45f4b469f6a\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"1e78a104_f427694d","line":118,"updated":"2021-09-13 16:03:34.000000000","message":"I thought the unit test is not verifying the None values are updated in metadata. Am I missing anything?","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d77664c390ba61be50e2f1b366a4333da5fee2b6","unresolved":true,"context_lines":[{"line_number":115,"context_line":"        metadata.PowerMaxVolumeMetadata, \u0027update_volume_info_metadata\u0027,"},{"line_number":116,"context_line":"        return_value\u003d{})"},{"line_number":117,"context_line":"    @mock.patch(\u0027time.time\u0027, mock_time)"},{"line_number":118,"context_line":"    def test_capture_manage_existing_no_backup_id(self, mock_uvim):"},{"line_number":119,"context_line":"        manage_existing_metadata \u003d ("},{"line_number":120,"context_line":"            {\u00271e5177e7-95e5-4a0f-b170-e45f4b469f6a\u0027: {"},{"line_number":121,"context_line":"                \u0027volume_id\u0027: \u00271e5177e7-95e5-4a0f-b170-e45f4b469f6a\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"2dd4ea72_4746d660","line":118,"in_reply_to":"1e78a104_f427694d","updated":"2021-10-12 11:01:17.000000000","message":"Thanks for your feedback. Yes, it is not very clear.  I believe the original bug was that a backend_id could be None and threw an exception when it was rep_info_dict[\u0027backend_id\u0027].\nOf course this can the the case for any values from lines https://review.opendev.org/c/openstack/cinder/+/803785/1/cinder/volume/drivers/dell_emc/powermax/metadata.py#609 to https://review.opendev.org/c/openstack/cinder/+/803785/1/cinder/volume/drivers/dell_emc/powermax/metadata.py#616.\n\nThis test is specifically for a missing backend_id which is why I wrote the unit test specifically for this.  Perhaps I should change the commit message to be a little clearer?","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"38b90e1066706b51e4f3006834c579444ae54e6f","unresolved":true,"context_lines":[{"line_number":132,"context_line":"                \u0027volume_updated_time\u0027: \u00271970-01-01 00:00:00\u0027}})"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"        self.volume_metadata.capture_manage_existing("},{"line_number":135,"context_line":"            self.data.test_volume, self.data.rep_info_dict,"},{"line_number":136,"context_line":"            self.data.device_id,"},{"line_number":137,"context_line":"            self.data.extra_specs_no_workload)"},{"line_number":138,"context_line":"        mock_uvim.assert_called_with(manage_existing_metadata, {})"}],"source_content_type":"text/x-python","patch_set":1,"id":"7619701f_27cd7fc0","line":135,"range":{"start_line":135,"start_character":35,"end_line":135,"end_character":58},"updated":"2022-05-24 22:42:36.000000000","message":"this is missing \u0027backend_id\u0027, so it should raise a KeyError on the unfixed code","commit_id":"52dfbcb3e28e39076f3f1497408af1f2e9b63544"}]}