)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3a7ddc20185db7f2d3c5fbc98b75240b0b83e04","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"69f24272_24b862d9","updated":"2025-02-05 15:12:05.000000000","message":"I am on the fence about this one.  On the one hand, glance has been setting virtual_size on uploaded images since Victoria [0], so we should be catching this problem early enough to return a 400.  On the other hand, virtual_size is in bytes, whereas min_disk is in GB, so maybe also setting min_disk is more user-friendly, since it should be more obvious to a user what volume size to use?\n\nI don\u0027t see any downside to adding the image property, but maybe I\u0027m missing something.\n\n[0] https://review.opendev.org/c/openstack/glance/+/744234","commit_id":"26c8c32fc0a3c099c6df576b56680a073ef3bdcf"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1db56a4c1d06a231f79e272ac49c359c02e6923f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6e5746e0_4faaf831","updated":"2025-02-05 17:31:34.000000000","message":"Is there an issue when Glance is configured to use Cinder as its backend?  You can configure cinder to use an optimized data transfer path that bypasses glance, which would mean that the virtual_size isn\u0027t being computed/set.  But I\u0027m not sure if you\u0027d only have raw volumes in that case anyway?  Probably worth looking into before we decide to abandon this.","commit_id":"26c8c32fc0a3c099c6df576b56680a073ef3bdcf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a2e9ac20ef177da144d64e5facd8c1a38df861f2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4ff7a8ac_7740c9ab","updated":"2024-09-24 01:08:04.000000000","message":"recheck is this error seen consistently ?\n\nRBD read-only image (error creating snapshot b\u0027nova-resize\u0027 from b\u00273ccc9a3b-6d6f-4ed0-9a26-5a1e677a9181_disk\u0027)","commit_id":"26c8c32fc0a3c099c6df576b56680a073ef3bdcf"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"24297ec9461eacfc73d1078b2924bae3e2ede395","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"26fe9832_6f32f9fb","in_reply_to":"69f24272_24b862d9","updated":"2025-02-05 15:21:01.000000000","message":"Ah. That\u0027s very good information. Thanks !\n\nI implemented this after I had to debug an issue in train-based OpenStack, which eventually revealed that a user created an image from 10GiB volume but was trying to create a 5GiB volume from that image (size values are not actual ones but I believe this explains the scenario). If this wrong usage is properly detected in recent releases by any other mechanism then I think we can abandon this (and close the bug)","commit_id":"26c8c32fc0a3c099c6df576b56680a073ef3bdcf"}],"cinder/image/image_utils.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e3a7ddc20185db7f2d3c5fbc98b75240b0b83e04","unresolved":true,"context_lines":[{"line_number":1173,"context_line":"                  \u0027volume_size\u0027: volume_size}"},{"line_number":1174,"context_line":"        reason \u003d _(\"Image virtual size is %(image_size)dGB\""},{"line_number":1175,"context_line":"                   \" and doesn\u0027t fit in a volume of size\""},{"line_number":1176,"context_line":"                   \" %(volume_size)dGB.\") % params"},{"line_number":1177,"context_line":"        raise exception.ImageUnacceptable(image_id\u003dimage_id,"},{"line_number":1178,"context_line":"                                          reason\u003dreason)"},{"line_number":1179,"context_line":"    return virtual_size"}],"source_content_type":"text/x-python","patch_set":10,"id":"ec40a72a_b51b6789","line":1176,"updated":"2025-02-05 15:12:05.000000000","message":"We report the error in GB, so this does make it clear what size volume you need to specify on your next request.","commit_id":"26c8c32fc0a3c099c6df576b56680a073ef3bdcf"}],"releasenotes/notes/bug-1939972-f6f95b1ed3166a93.yaml":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"d99b66cf4a56822b0197c42a3024665ba8c6132f","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1939972 \u003chttps://bugs.launchpad.net/cinder/+bug/1922408\u003e`_:"},{"line_number":5,"context_line":"    Now a image created from a volume gets the min_size property set according"},{"line_number":6,"context_line":"    to size of the source volume. This prevents creating a smaller volume from"},{"line_number":7,"context_line":"    the image, which results in error."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"76c9fc24_d51b7f80","line":5,"updated":"2021-08-16 08:41:52.000000000","message":"Might be just me but I was a little confused by this first line.  Perhaps:\n\"This fix sets the min_size property on the image created from a volume to the size of the source volume.\"","commit_id":"4479d59a6b7f81d9d1d865113f2cf2f970dc6b78"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"94f075e2b012aff355c2863437a3bb43d14ea219","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1939972 \u003chttps://bugs.launchpad.net/cinder/+bug/1922408\u003e`_:"},{"line_number":5,"context_line":"    Now a image created from a volume gets the min_size property set according"},{"line_number":6,"context_line":"    to size of the source volume. This prevents creating a smaller volume from"},{"line_number":7,"context_line":"    the image, which results in error."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":7,"id":"c97b6cf4_3f2e4202","line":5,"in_reply_to":"76c9fc24_d51b7f80","updated":"2021-08-16 08:50:26.000000000","message":"That sounds much better. Thanks.","commit_id":"4479d59a6b7f81d9d1d865113f2cf2f970dc6b78"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"d522ee888b97afdb64a88ce2934f0009e3166f47","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1939972 \u003chttps://bugs.launchpad.net/cinder/+bug/1922408\u003e`_:"},{"line_number":5,"context_line":"    This fix sets the min_size property on the image created from a volume"},{"line_number":6,"context_line":"    to the size of the source volume. This prevents creating a smaller volume"},{"line_number":7,"context_line":"    from the image, which results in error."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ff33568_745f4748","line":5,"range":{"start_line":5,"start_character":22,"end_line":5,"end_character":30},"updated":"2021-08-16 11:22:56.000000000","message":"Updating the property as \u0027min_disk\u0027 in volume_actions.py and UT, which is different from \u0027min_size\u0027 mentioned in releasenotes. Ensure using the same property name.","commit_id":"fd199f1fe289c79a4970b7d00436d57c41becf9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"e10220b00e8450ecbfd3b7ac103bd56891a1d819","unresolved":false,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1939972 \u003chttps://bugs.launchpad.net/cinder/+bug/1922408\u003e`_:"},{"line_number":5,"context_line":"    This fix sets the min_size property on the image created from a volume"},{"line_number":6,"context_line":"    to the size of the source volume. This prevents creating a smaller volume"},{"line_number":7,"context_line":"    from the image, which results in error."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"a6482d6d_dcb8bfba","line":5,"range":{"start_line":5,"start_character":22,"end_line":5,"end_character":30},"in_reply_to":"1ab10085_7d54e888","updated":"2024-09-20 14:57:30.000000000","message":"Done","commit_id":"fd199f1fe289c79a4970b7d00436d57c41becf9e"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"d21c0602e667bc9d33a00cc158dcfe47142e9933","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1939972 \u003chttps://bugs.launchpad.net/cinder/+bug/1922408\u003e`_:"},{"line_number":5,"context_line":"    This fix sets the min_size property on the image created from a volume"},{"line_number":6,"context_line":"    to the size of the source volume. This prevents creating a smaller volume"},{"line_number":7,"context_line":"    from the image, which results in error."},{"line_number":8,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":8,"id":"1ab10085_7d54e888","line":5,"range":{"start_line":5,"start_character":22,"end_line":5,"end_character":30},"in_reply_to":"1ff33568_745f4748","updated":"2021-08-16 13:37:45.000000000","message":"Thanks for pointing this. min_disk is the correct one and I updated the release note and the commit message to mention the correct one.","commit_id":"fd199f1fe289c79a4970b7d00436d57c41becf9e"}]}