)]}'
{"cinder/brick/local_dev/lvm.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9207ffdc6ca6858bd4757960a3c2705cb6166265","unresolved":true,"context_lines":[{"line_number":733,"context_line":"        LVM_CONFIG \u003d \u0027activation { retry_deactivation \u003d 1} \u0027"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"        try:"},{"line_number":736,"context_line":"            self._execute("},{"line_number":737,"context_line":"                \u0027lvremove\u0027,"},{"line_number":738,"context_line":"                \u0027--config\u0027, LVM_CONFIG,"},{"line_number":739,"context_line":"                \u0027-f\u0027,"},{"line_number":740,"context_line":"                \u0027%s/%s\u0027 % (self.vg_name, name),"},{"line_number":741,"context_line":"                root_helper\u003dself._root_helper, run_as_root\u003dTrue)"},{"line_number":742,"context_line":"        except putils.ProcessExecutionError as err:"},{"line_number":743,"context_line":"            LOG.debug(\u0027Error reported running lvremove: CMD: %(command)s, \u0027"},{"line_number":744,"context_line":"                      \u0027RESPONSE: %(response)s\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ab9ac74_89a10784","line":741,"range":{"start_line":736,"start_character":0,"end_line":741,"end_character":64},"updated":"2021-08-18 15:46:59.000000000","message":"I\u0027m not totally sure about which commands we should retry but this seems inconsistent with our approach and also other commands (above) like lvchange for active/deactivate","commit_id":"fa10a9ed132dfe858254a4d79bd78b7c826a3821"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9207ffdc6ca6858bd4757960a3c2705cb6166265","unresolved":true,"context_lines":[{"line_number":832,"context_line":"        try:"},{"line_number":833,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvextend\u0027, \u0027-L\u0027, new_size,"},{"line_number":834,"context_line":"                                        \u0027%s/%s\u0027 % (self.vg_name, lv_name)]"},{"line_number":835,"context_line":"            (out, _err) \u003d self._run_lvm_command(cmd)"},{"line_number":836,"context_line":"        except putils.ProcessExecutionError as err:"},{"line_number":837,"context_line":"            LOG.exception(\u0027Error extending Volume\u0027)"},{"line_number":838,"context_line":"            LOG.error(\u0027Cmd     :%s\u0027, err.cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a70d7cc1_0c280b3d","line":835,"range":{"start_line":835,"start_character":12,"end_line":835,"end_character":26},"updated":"2021-08-18 15:46:59.000000000","message":"i think we don\u0027t need these variables since we\u0027re not using them anywhere?","commit_id":"fa10a9ed132dfe858254a4d79bd78b7c826a3821"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e5cf1df122ee4e26b83d977c2c96073b0c6c4891","unresolved":true,"context_lines":[{"line_number":832,"context_line":"        try:"},{"line_number":833,"context_line":"            cmd \u003d LVM.LVM_CMD_PREFIX + [\u0027lvextend\u0027, \u0027-L\u0027, new_size,"},{"line_number":834,"context_line":"                                        \u0027%s/%s\u0027 % (self.vg_name, lv_name)]"},{"line_number":835,"context_line":"            (out, _err) \u003d self._run_lvm_command(cmd)"},{"line_number":836,"context_line":"        except putils.ProcessExecutionError as err:"},{"line_number":837,"context_line":"            LOG.exception(\u0027Error extending Volume\u0027)"},{"line_number":838,"context_line":"            LOG.error(\u0027Cmd     :%s\u0027, err.cmd)"}],"source_content_type":"text/x-python","patch_set":1,"id":"d99b88f1_92ade61e","line":835,"range":{"start_line":835,"start_character":12,"end_line":835,"end_character":26},"in_reply_to":"a70d7cc1_0c280b3d","updated":"2021-08-18 16:27:49.000000000","message":"Correct, I didn\u0027t intend to add these.","commit_id":"fa10a9ed132dfe858254a4d79bd78b7c826a3821"}]}