)]}'
{"cinder/volume/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dd314bb720d9ef223a44ed6cc0f75d3880b7c39e","unresolved":true,"context_lines":[{"line_number":482,"context_line":"                                        _(\u0027status must be %s and\u0027))"},{"line_number":483,"context_line":"            msg \u003d (_(\u0027Volume %(status)s must not be migrating, attached, \u0027"},{"line_number":484,"context_line":"                     \u0027belong to a group, have snapshots or be disassociated \u0027"},{"line_number":485,"context_line":"                     \u0027from snapshots after volume transfer. Current status: \u0027"},{"line_number":486,"context_line":"                     \u0027%(vol_status)s\u0027) % {\u0027status\u0027: status,"},{"line_number":487,"context_line":"                                          \u0027vol_status\u0027: volume.status})"},{"line_number":488,"context_line":"            LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5980940c_72b2bade","line":485,"range":{"start_line":485,"start_character":60,"end_line":485,"end_character":74},"updated":"2021-08-20 16:07:22.000000000","message":"Maybe something like \u0027Status at the moment when we checked was:\u0027 would be better.  And if we do add it, it should only be to the log message (see comment at line 489).","commit_id":"3fa6e6c3d13520a5246ad52551bb0ea9340d334b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"27f7140dd047ee236886310c8c989565ea9d34be","unresolved":true,"context_lines":[{"line_number":482,"context_line":"                                        _(\u0027status must be %s and\u0027))"},{"line_number":483,"context_line":"            msg \u003d (_(\u0027Volume %(status)s must not be migrating, attached, \u0027"},{"line_number":484,"context_line":"                     \u0027belong to a group, have snapshots or be disassociated \u0027"},{"line_number":485,"context_line":"                     \u0027from snapshots after volume transfer. Current status: \u0027"},{"line_number":486,"context_line":"                     \u0027%(vol_status)s\u0027) % {\u0027status\u0027: status,"},{"line_number":487,"context_line":"                                          \u0027vol_status\u0027: volume.status})"},{"line_number":488,"context_line":"            LOG.info(msg)"}],"source_content_type":"text/x-python","patch_set":2,"id":"b572d110_a5b46ccc","line":485,"range":{"start_line":485,"start_character":60,"end_line":485,"end_character":74},"in_reply_to":"5980940c_72b2bade","updated":"2021-08-23 12:48:29.000000000","message":"If I understand correctly, your proposed revision would be to change the wording + adding it in the logs (and not in the user facing trace).\n\nIf yes, this isn\u0027t the goal of my patch: as a user I want to know the state of my volume at the time it\u0027s trying to be removed and it failed.","commit_id":"3fa6e6c3d13520a5246ad52551bb0ea9340d334b"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dd314bb720d9ef223a44ed6cc0f75d3880b7c39e","unresolved":true,"context_lines":[{"line_number":486,"context_line":"                     \u0027%(vol_status)s\u0027) % {\u0027status\u0027: status,"},{"line_number":487,"context_line":"                                          \u0027vol_status\u0027: volume.status})"},{"line_number":488,"context_line":"            LOG.info(msg)"},{"line_number":489,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        if cascade:"},{"line_number":492,"context_line":"            values \u003d {\u0027status\u0027: \u0027deleting\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"de5c3183_6fe51389","line":489,"range":{"start_line":489,"start_character":49,"end_line":489,"end_character":52},"updated":"2021-08-20 16:07:22.000000000","message":"I think this actually is user-visible, so we don\u0027t want to include current status here if there\u0027s no way to guarantee that it\u0027s correct.","commit_id":"3fa6e6c3d13520a5246ad52551bb0ea9340d334b"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"0d2a60b82747fe81d389561c9088c610232d4bf0","unresolved":true,"context_lines":[{"line_number":486,"context_line":"                     \u0027%(vol_status)s\u0027) % {\u0027status\u0027: status,"},{"line_number":487,"context_line":"                                          \u0027vol_status\u0027: volume.status})"},{"line_number":488,"context_line":"            LOG.info(msg)"},{"line_number":489,"context_line":"            raise exception.InvalidVolume(reason\u003dmsg)"},{"line_number":490,"context_line":""},{"line_number":491,"context_line":"        if cascade:"},{"line_number":492,"context_line":"            values \u003d {\u0027status\u0027: \u0027deleting\u0027}"}],"source_content_type":"text/x-python","patch_set":2,"id":"44cb9362_146d34b1","line":489,"range":{"start_line":489,"start_character":49,"end_line":489,"end_character":52},"in_reply_to":"de5c3183_6fe51389","updated":"2021-08-23 12:46:43.000000000","message":"That was exactly what I was trying to do, to make it user visible.\nI think users don\u0027t necessarily care if the state is not guaranteed when printed during an error, at least that can give them an hint of why a volume failed to be deleted (which would be better that we have now - no hint).","commit_id":"3fa6e6c3d13520a5246ad52551bb0ea9340d334b"}]}