)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"398ed709bbf956dcf48894f790053383f1ae6023","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We added retries in order 2nd volume creation could wait"},{"line_number":19,"context_line":"1st volume creation."},{"line_number":20,"context_line":"Bug in RHOSP: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1886013"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: 1940466"},{"line_number":23,"context_line":"Change-Id: I53417dddbfadd1636b10fa31af305d2f58753237"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"4ff86140_4f55158f","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":65},"updated":"2021-08-18 18:36:45.000000000","message":"This line is not needed here.","commit_id":"ef9a89eb4a64e884fba179ab294d20c5d5cbe62c"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"987fb2fc059b68d1ae4132dc274435fb9761f4e2","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We added retries in order 2nd volume creation could wait"},{"line_number":19,"context_line":"1st volume creation."},{"line_number":20,"context_line":"Bug in RHOSP: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1886013"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: 1940466"},{"line_number":23,"context_line":"Change-Id: I53417dddbfadd1636b10fa31af305d2f58753237"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"5d02f727_9a0b4e57","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":65},"in_reply_to":"4ff86140_4f55158f","updated":"2021-08-18 18:40:19.000000000","message":"done","commit_id":"ef9a89eb4a64e884fba179ab294d20c5d5cbe62c"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"0160217c96087eae447232bb0c1c21f50e2fd5d5","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We added retries in order 2nd volume creation could wait"},{"line_number":19,"context_line":"1st volume creation."},{"line_number":20,"context_line":"Bug in RHOSP: https://bugzilla.redhat.com/show_bug.cgi?id\u003d1886013"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Closes-Bug: 1940466"},{"line_number":23,"context_line":"Change-Id: I53417dddbfadd1636b10fa31af305d2f58753237"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"6002eec9_77bacb30","line":20,"range":{"start_line":20,"start_character":0,"end_line":20,"end_character":65},"in_reply_to":"5d02f727_9a0b4e57","updated":"2022-01-31 09:39:24.000000000","message":"Done","commit_id":"ef9a89eb4a64e884fba179ab294d20c5d5cbe62c"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"984c37e3adea7d78c926982f4a1429ca20b39d05","unresolved":true,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We added status \"attaching\" in valid statuses to reserve"},{"line_number":19,"context_line":"volume in multiattach mode."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1940466"},{"line_number":22,"context_line":"Change-Id: I53417dddbfadd1636b10fa31af305d2f58753237"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"76cb226a_612ba085","line":20,"updated":"2021-08-25 14:34:57.000000000","message":"Does this only happen when using the Cinder store for Glance?  If so please add details about this to the commit message.","commit_id":"354f28c2de8efc7269854a1949b42a6f5b72a69e"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"8db04eea8326f0d99feab74ee2a7d06151c6b89a","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"We added status \"attaching\" in valid statuses to reserve"},{"line_number":19,"context_line":"volume in multiattach mode."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Closes-Bug: 1940466"},{"line_number":22,"context_line":"Change-Id: I53417dddbfadd1636b10fa31af305d2f58753237"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7395b270_64a00350","line":20,"in_reply_to":"76cb226a_612ba085","updated":"2021-08-30 06:21:02.000000000","message":"Done","commit_id":"354f28c2de8efc7269854a1949b42a6f5b72a69e"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"9f0e0c2c35c66f28def7961ec3aef11237af92c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"97f046b3_cc973856","updated":"2021-11-19 14:42:59.000000000","message":"Good job, this is a small and clear change, but you might need to update the test cases for reserve_volume.\nTake a look on https://codesearch.opendev.org/?q\u003ddef%20test_reserve_volume\u0026i\u003dnope\u0026literal\u003dnope\u0026files\u003d\u0026excludeFiles\u003d\u0026repos\u003dopenstack/cinder","commit_id":"d40e53e6033dbb0a95d16e0e1d06d97207fc82f2"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"c97e516ab52b26623ca9842e940de66f80352bfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"86b515df_26d48b4f","updated":"2021-10-11 06:21:17.000000000","message":"Hello,\n\nmore one month no activity.\nPlease review the patch.\n","commit_id":"d40e53e6033dbb0a95d16e0e1d06d97207fc82f2"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"689f9c75f2c6b0dc97a70c01f4e33a98ed8e02cc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"04b3cbc8_5475f507","in_reply_to":"97f046b3_cc973856","updated":"2021-11-23 06:41:14.000000000","message":"done","commit_id":"d40e53e6033dbb0a95d16e0e1d06d97207fc82f2"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"b521979a63d3b36cb3e21332de0e1cfa2ccbff15","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4336beda_b23b4bb7","updated":"2022-01-10 07:48:19.000000000","message":"No activity more 1 month.\nPlease review.\n","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"35b9e194b54af1ca9734324a35cb0786b6b5d560","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f4180c1f_f278d060","updated":"2022-01-20 20:09:53.000000000","message":"Thank you for the fix on the unit test.\nI added a minor improvement for you there, but feel free to only fix it if you need to do more changes in the future.","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"415685bfcc103e7cc909046938a188406a6b9936","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"13d811a1_44d93e62","updated":"2021-11-23 04:46:09.000000000","message":"recheck","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"3efeaaaf088aa551fa2689da394efe6c4e138fbf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f5b3f88b_d64cb03a","updated":"2021-11-23 09:31:55.000000000","message":"still looks good to me","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"eebcaebdb0786516def6ad7df30ce250bd932fb5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"628905a7_f052777b","in_reply_to":"f4180c1f_f278d060","updated":"2022-01-24 09:38:09.000000000","message":"done","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"2b09d2b3dadd8101ab95186d0613bcce007f815e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0b4a485c_fc00aaa2","updated":"2022-01-24 13:14:16.000000000","message":"LGTM. Thank you!","commit_id":"07e9e8c29f7d7e5eaa92cc8b705b218dd3ae9095"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"bac931a70228b0db316945e740bec39456ed6455","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aa76ffa6_799fa2a6","updated":"2022-03-09 07:47:45.000000000","message":"No activity more 1 month.\nPlease review.","commit_id":"07e9e8c29f7d7e5eaa92cc8b705b218dd3ae9095"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"15122734549d874059f95a6ec94d17009c1c62a2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f3e170cc_6a53e7a2","updated":"2022-03-24 10:22:57.000000000","message":"LGTM","commit_id":"15ebd02095ffdc3db9715bae026c480ccda8b97e"},{"author":{"_account_id":15554,"name":"Bence Romsics","email":"bence.romsics@gmail.com","username":"ebenrom","status":"working for Ericsson, UTC+1 (+DST)"},"change_message_id":"5c3cdda99be8ae8b07b080a5ea154aa4301240ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"34ca1ef3_435840de","updated":"2022-04-19 12:49:15.000000000","message":"Mitya, please have a look at:\nhttps://bugs.launchpad.net/glance-store/+bug/1969373\nhttps://review.opendev.org/c/openstack/glance_store/+/838326","commit_id":"15ebd02095ffdc3db9715bae026c480ccda8b97e"}],"cinder/tests/unit/volume/test_volume.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"35b9e194b54af1ca9734324a35cb0786b6b5d560","unresolved":true,"context_lines":[{"line_number":2049,"context_line":"                          volume)"},{"line_number":2050,"context_line":"        db.volume_destroy(self.context, volume.id)"},{"line_number":2051,"context_line":""},{"line_number":2052,"context_line":"    def test_successful_reserve_volume_in_attaching_with_multi_attach(self):"},{"line_number":2053,"context_line":"        self._test_successful_reserve_volume_with_multi_attach_in_status("},{"line_number":2054,"context_line":"            \u0027attaching\u0027)"},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"    def test_successful_reserve_volume_in_detaching_with_multi_attach(self):"},{"line_number":2057,"context_line":"        self._test_successful_reserve_volume_with_multi_attach_in_status("},{"line_number":2058,"context_line":"            \u0027detaching\u0027)"},{"line_number":2059,"context_line":""},{"line_number":2060,"context_line":"    def _test_successful_reserve_volume_with_multi_attach_in_status(self,"},{"line_number":2061,"context_line":"                                                                    status):"}],"source_content_type":"text/x-python","patch_set":6,"id":"6e08c4d7_69da28db","line":2058,"range":{"start_line":2052,"start_character":4,"end_line":2058,"end_character":24},"updated":"2022-01-20 20:09:53.000000000","message":"you could use a ddt statement over the \u0027def _test_successful_reserve_volume_with_multi_attach_in_status\u0027 to avoid this duplicate\n@ddt.data(\u0027attaching\u0027, \u0027detaching\u0027)","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"eebcaebdb0786516def6ad7df30ce250bd932fb5","unresolved":false,"context_lines":[{"line_number":2049,"context_line":"                          volume)"},{"line_number":2050,"context_line":"        db.volume_destroy(self.context, volume.id)"},{"line_number":2051,"context_line":""},{"line_number":2052,"context_line":"    def test_successful_reserve_volume_in_attaching_with_multi_attach(self):"},{"line_number":2053,"context_line":"        self._test_successful_reserve_volume_with_multi_attach_in_status("},{"line_number":2054,"context_line":"            \u0027attaching\u0027)"},{"line_number":2055,"context_line":""},{"line_number":2056,"context_line":"    def test_successful_reserve_volume_in_detaching_with_multi_attach(self):"},{"line_number":2057,"context_line":"        self._test_successful_reserve_volume_with_multi_attach_in_status("},{"line_number":2058,"context_line":"            \u0027detaching\u0027)"},{"line_number":2059,"context_line":""},{"line_number":2060,"context_line":"    def _test_successful_reserve_volume_with_multi_attach_in_status(self,"},{"line_number":2061,"context_line":"                                                                    status):"}],"source_content_type":"text/x-python","patch_set":6,"id":"eac69a7c_0c6c7cee","line":2058,"range":{"start_line":2052,"start_character":4,"end_line":2058,"end_character":24},"in_reply_to":"6e08c4d7_69da28db","updated":"2022-01-24 09:38:09.000000000","message":"Done","commit_id":"5343f83b57cb2510bfd7cc3be3e11542aacfac6d"}],"cinder/volume/api.py":[{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"ce6c4171094290f2d86eb02465b8c86277a0bbab","unresolved":true,"context_lines":[{"line_number":694,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":695,"context_line":"        expected \u003d {\"multiattach\": volume.multiattach, \"status\": [\"available\"]}"},{"line_number":696,"context_line":"        if volume.multiattach:"},{"line_number":697,"context_line":"            expected[\"status\"].extend([\"attaching\", \"in-use\", \"detaching\"])"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"184da6cf_6a65c707","line":697,"updated":"2021-10-26 14:02:07.000000000","message":"if this is a multiattach volume then I guess it is OK to reserve it twice in parallel.","commit_id":"d40e53e6033dbb0a95d16e0e1d06d97207fc82f2"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"42e146453e543852b752089f1c8b8a3c87c3ee38","unresolved":true,"context_lines":[{"line_number":694,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":695,"context_line":"        expected \u003d {\"multiattach\": volume.multiattach, \"status\": [\"available\"]}"},{"line_number":696,"context_line":"        if volume.multiattach:"},{"line_number":697,"context_line":"            expected[\"status\"].extend([\"attaching\", \"in-use\", \"detaching\"])"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"50d2f6ea_a482b9fa","line":697,"in_reply_to":"184da6cf_6a65c707","updated":"2021-10-27 04:54:48.000000000","message":"Yes, true.\nThe point of multi-attachment is simultaneous volume attachment and connections (reservation) can be simultaneous too. It works OK.","commit_id":"d40e53e6033dbb0a95d16e0e1d06d97207fc82f2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"af83f0d593f8593883306adf2a07a25da815ffdd","unresolved":false,"context_lines":[{"line_number":694,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":695,"context_line":"        expected \u003d {\"multiattach\": volume.multiattach, \"status\": [\"available\"]}"},{"line_number":696,"context_line":"        if volume.multiattach:"},{"line_number":697,"context_line":"            expected[\"status\"].extend([\"attaching\", \"in-use\", \"detaching\"])"},{"line_number":698,"context_line":""},{"line_number":699,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"},{"line_number":700,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"557a24db_b5a5b88a","line":697,"in_reply_to":"50d2f6ea_a482b9fa","updated":"2021-10-28 09:49:23.000000000","message":"Ack","commit_id":"d40e53e6033dbb0a95d16e0e1d06d97207fc82f2"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"05f14129d0b2935d3304e467bb1b121928437bec","unresolved":true,"context_lines":[{"line_number":751,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":752,"context_line":"        expected \u003d {\"multiattach\": volume.multiattach, \"status\": [\"available\"]}"},{"line_number":753,"context_line":"        if volume.multiattach:"},{"line_number":754,"context_line":"            expected[\"status\"].extend([\"attaching\", \"in-use\", \"detaching\"])"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"},{"line_number":757,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"cabd5df0_e0a98de2","line":754,"updated":"2022-03-20 13:03:43.000000000","message":"probably we can allow the \u0027reserved\u0027 state as well.","commit_id":"07e9e8c29f7d7e5eaa92cc8b705b218dd3ae9095"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"4d500e53abb088d44266957c9c418c99d1075f7d","unresolved":false,"context_lines":[{"line_number":751,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":752,"context_line":"        expected \u003d {\"multiattach\": volume.multiattach, \"status\": [\"available\"]}"},{"line_number":753,"context_line":"        if volume.multiattach:"},{"line_number":754,"context_line":"            expected[\"status\"].extend([\"attaching\", \"in-use\", \"detaching\"])"},{"line_number":755,"context_line":""},{"line_number":756,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"},{"line_number":757,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"4ca1f281_49511cbb","line":754,"in_reply_to":"cabd5df0_e0a98de2","updated":"2022-03-23 07:48:40.000000000","message":"Done","commit_id":"07e9e8c29f7d7e5eaa92cc8b705b218dd3ae9095"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"05f14129d0b2935d3304e467bb1b121928437bec","unresolved":true,"context_lines":[{"line_number":2360,"context_line":"        # determine if we\u0027re attaching to the Cinder host for some work or if"},{"line_number":2361,"context_line":"        # we\u0027re being used by the outside world."},{"line_number":2362,"context_line":"        expected \u003d {\u0027multiattach\u0027: vref.multiattach,"},{"line_number":2363,"context_line":"                    \u0027status\u0027: ((\u0027available\u0027, \u0027in-use\u0027, \u0027downloading\u0027)"},{"line_number":2364,"context_line":"                               if vref.multiattach"},{"line_number":2365,"context_line":"                               else (\u0027available\u0027, \u0027downloading\u0027))}"},{"line_number":2366,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"8148f786_70a27465","line":2363,"updated":"2022-03-20 13:03:43.000000000","message":"This needs the same change as above to support parallel attaching the same volume (holding the image) from glance.","commit_id":"07e9e8c29f7d7e5eaa92cc8b705b218dd3ae9095"},{"author":{"_account_id":32927,"name":"mitya-eremeev-2","display_name":"Mitya Eremeev","email":"mitossvyaz@mail.ru","username":"mitya-eremeev-2"},"change_message_id":"4d500e53abb088d44266957c9c418c99d1075f7d","unresolved":false,"context_lines":[{"line_number":2360,"context_line":"        # determine if we\u0027re attaching to the Cinder host for some work or if"},{"line_number":2361,"context_line":"        # we\u0027re being used by the outside world."},{"line_number":2362,"context_line":"        expected \u003d {\u0027multiattach\u0027: vref.multiattach,"},{"line_number":2363,"context_line":"                    \u0027status\u0027: ((\u0027available\u0027, \u0027in-use\u0027, \u0027downloading\u0027)"},{"line_number":2364,"context_line":"                               if vref.multiattach"},{"line_number":2365,"context_line":"                               else (\u0027available\u0027, \u0027downloading\u0027))}"},{"line_number":2366,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"6ad1289e_20bdde30","line":2363,"in_reply_to":"8148f786_70a27465","updated":"2022-03-23 07:48:40.000000000","message":"Done","commit_id":"07e9e8c29f7d7e5eaa92cc8b705b218dd3ae9095"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"d4d6214d5e731d74835438da2381f8706cee9e6e","unresolved":true,"context_lines":[{"line_number":752,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":753,"context_line":"        expected \u003d {\u0027multiattach\u0027: volume.multiattach, \u0027status\u0027: [\u0027available\u0027]}"},{"line_number":754,"context_line":"        if volume.multiattach:"},{"line_number":755,"context_line":"            expected[\u0027status\u0027].extend([\u0027reserved\u0027, \u0027attaching\u0027, \u0027in-use\u0027,"},{"line_number":756,"context_line":"                                       \u0027detaching\u0027])"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"}],"source_content_type":"text/x-python","patch_set":11,"id":"a60da3f6_9c1ee39c","line":755,"range":{"start_line":755,"start_character":39,"end_line":755,"end_character":49},"updated":"2022-04-08 16:12:42.000000000","message":"Per discussion at the PTG: it is not safe to allow a volume already in reserved to succeed when reserve is called, it should fail and the caller should retry.","commit_id":"15ebd02095ffdc3db9715bae026c480ccda8b97e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"45250fd1afe7f0f3124ac9d21c2a56d1f8bb468c","unresolved":true,"context_lines":[{"line_number":752,"context_line":"        context.authorize(vol_action_policy.RESERVE_POLICY, target_obj\u003dvolume)"},{"line_number":753,"context_line":"        expected \u003d {\u0027multiattach\u0027: volume.multiattach, \u0027status\u0027: [\u0027available\u0027]}"},{"line_number":754,"context_line":"        if volume.multiattach:"},{"line_number":755,"context_line":"            expected[\u0027status\u0027].extend([\u0027reserved\u0027, \u0027attaching\u0027, \u0027in-use\u0027,"},{"line_number":756,"context_line":"                                       \u0027detaching\u0027])"},{"line_number":757,"context_line":""},{"line_number":758,"context_line":"        result \u003d volume.conditional_update({\u0027status\u0027: \u0027attaching\u0027}, expected)"}],"source_content_type":"text/x-python","patch_set":11,"id":"c73c3046_41896ab5","line":755,"updated":"2022-04-19 08:09:10.000000000","message":"While retrying is a valid option it means all the clients needs to be adapted. I think there is another bug[1] where the client of cinder is not glance but nova but hitting the same transitional states. \n\nIf the cinder team push for the client side change instead then it would be nice to i) add a change to the cinder binding of the python-cinderclient that automates the retry ii) document in which case and state the client should retry.\n\n[1] https://bugs.launchpad.net/cinder/+bug/1940466","commit_id":"15ebd02095ffdc3db9715bae026c480ccda8b97e"},{"author":{"_account_id":9708,"name":"Balazs Gibizer","display_name":"gibi","email":"gibizer@gmail.com","username":"gibi"},"change_message_id":"4c2175ed842e568f61d0691a486611c1c04594a6","unresolved":true,"context_lines":[{"line_number":2355,"context_line":"        expected \u003d {\u0027multiattach\u0027: vref.multiattach,"},{"line_number":2356,"context_line":"                    \u0027status\u0027: [\u0027available\u0027, \u0027downloading\u0027]}"},{"line_number":2357,"context_line":"        if vref.multiattach:"},{"line_number":2358,"context_line":"            expected[\"status\"].extend([\"attaching\", \"in-use\", \"detaching\"])"},{"line_number":2359,"context_line":""},{"line_number":2360,"context_line":"        result \u003d vref.conditional_update({\u0027status\u0027: \u0027reserved\u0027}, expected)"},{"line_number":2361,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"741c0b27_3050467d","line":2358,"updated":"2022-04-05 09:30:19.000000000","message":"here we need to allow reserved state too","commit_id":"15ebd02095ffdc3db9715bae026c480ccda8b97e"}]}