)]}'
{"cinder/volume/drivers/dell_emc/powermax/provision.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"386f13afb220dc18b100f11f7fcbf1f6a7a07510","unresolved":true,"context_lines":[{"line_number":668,"context_line":"                except exception.VolumeBackendAPIException:"},{"line_number":669,"context_line":"                    self.rest.delete_storagegroup_snap("},{"line_number":670,"context_line":"                        array, source_group_name, snap_name, snap_id,"},{"line_number":671,"context_line":"                        force\u003dTrue)"},{"line_number":672,"context_line":"        else:"},{"line_number":673,"context_line":"            LOG.debug(\"Unable to get snap ids for: %(srcGroup)s.\","},{"line_number":674,"context_line":"                      {\u0027srcGroup\u0027: source_group_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec1f7501_26bf6f67","line":671,"updated":"2021-09-15 16:12:33.000000000","message":"Are there possible bad consequences to using \u0027force\u0027?  What I mean is, why not simply always make this call with force\u003dTrue?  The other thing is that if calling with \u0027force\u0027 is not ideal, maybe log a message to say you\u0027re doing it, in case an operator needs to track this down.  (Unless there\u0027s sufficient logging on the backend already.)","commit_id":"45b0a91e8a37286f433b1f0ef64f8b16b132c287"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"0bb24ef3092acbab40efffc7b62a84ffa0edb6f6","unresolved":true,"context_lines":[{"line_number":668,"context_line":"                except exception.VolumeBackendAPIException:"},{"line_number":669,"context_line":"                    self.rest.delete_storagegroup_snap("},{"line_number":670,"context_line":"                        array, source_group_name, snap_name, snap_id,"},{"line_number":671,"context_line":"                        force\u003dTrue)"},{"line_number":672,"context_line":"        else:"},{"line_number":673,"context_line":"            LOG.debug(\"Unable to get snap ids for: %(srcGroup)s.\","},{"line_number":674,"context_line":"                      {\u0027srcGroup\u0027: source_group_name})"}],"source_content_type":"text/x-python","patch_set":1,"id":"6995b5df_afa18db1","line":671,"in_reply_to":"ec1f7501_26bf6f67","updated":"2021-09-15 16:37:38.000000000","message":"Good question, the force flag is a safety net, as the snapshot is the last copy of what the storage group used to be before the volume membership was changed.  I think because the driver has ownership of the whole process then the force flag should be supplied regardless. It certainly simplifies things.","commit_id":"45b0a91e8a37286f433b1f0ef64f8b16b132c287"}]}