)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7440933dd3ad9a2a9c53f3701afde36049b8426e","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     andrei.perepiolkin \u003candrei.perepiolkin@open-e.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-08-26 09:54:08 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix iscsi target recovery for ensure-export"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ensure_target_volume does not convert volume name to a proper form,"},{"line_number":10,"context_line":"causing faiulure."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"33890a8b_6ec1e9d8","line":7,"updated":"2021-08-26 17:08:05.000000000","message":"As this is driver specific you could add the driver\u0027s to the commit message.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"}],"cinder/tests/unit/volume/drivers/open_e/test_iscsi.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7440933dd3ad9a2a9c53f3701afde36049b8426e","unresolved":true,"context_lines":[{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        self.stop_patches(patches)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"        self.assertEqual(\u0027provider_location\u0027, ret[\u0027provider_location\u0027])"},{"line_number":1241,"context_line":""},{"line_number":1242,"context_line":"    def test_ensure_export(self):"},{"line_number":1243,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"5bbc830d_58621de6","line":1240,"updated":"2021-08-26 17:08:05.000000000","message":"This kind of change looks more aesthetic and isn\u0027t related to the fix you are proposing and should be avoided.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"1209430e1d1e861461ae5767f97b7bb201f1205a","unresolved":false,"context_lines":[{"line_number":1237,"context_line":""},{"line_number":1238,"context_line":"        self.stop_patches(patches)"},{"line_number":1239,"context_line":""},{"line_number":1240,"context_line":"        self.assertEqual(\u0027provider_location\u0027, ret[\u0027provider_location\u0027])"},{"line_number":1241,"context_line":""},{"line_number":1242,"context_line":"    def test_ensure_export(self):"},{"line_number":1243,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bf61213b_64bbae16","line":1240,"in_reply_to":"5bbc830d_58621de6","updated":"2021-08-26 18:19:23.000000000","message":"yes","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7440933dd3ad9a2a9c53f3701afde36049b8426e","unresolved":true,"context_lines":[{"line_number":1435,"context_line":"        vol \u003d fake_volume.fake_volume_obj(ctx)"},{"line_number":1436,"context_line":"        vol.id \u003d UUID_1"},{"line_number":1437,"context_line":"        vname \u003d jcom.vname(UUID_1)"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"        target_name \u003d CONFIG_OK[\u0027target_prefix\u0027] + UUID_1"},{"line_number":1440,"context_line":"        vol.provider_auth \u003d \u0027chap user_name 123456789012\u0027"},{"line_number":1441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fd840580_b8b8338a","line":1438,"updated":"2021-08-26 17:08:05.000000000","message":"Avoid making aesthetic changes that are not related to the goal of this patch. This line can be removed.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"1209430e1d1e861461ae5767f97b7bb201f1205a","unresolved":false,"context_lines":[{"line_number":1435,"context_line":"        vol \u003d fake_volume.fake_volume_obj(ctx)"},{"line_number":1436,"context_line":"        vol.id \u003d UUID_1"},{"line_number":1437,"context_line":"        vname \u003d jcom.vname(UUID_1)"},{"line_number":1438,"context_line":""},{"line_number":1439,"context_line":"        target_name \u003d CONFIG_OK[\u0027target_prefix\u0027] + UUID_1"},{"line_number":1440,"context_line":"        vol.provider_auth \u003d \u0027chap user_name 123456789012\u0027"},{"line_number":1441,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2496e366_d75cb83c","line":1438,"in_reply_to":"fd840580_b8b8338a","updated":"2021-08-26 18:19:23.000000000","message":"Oh, thanks for pointing out!","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"f7c5d7cc3c0e00945bc27ecb0eadd47e54a1a3b1","unresolved":true,"context_lines":[{"line_number":1214,"context_line":"            pass_len\u003d16)"},{"line_number":1215,"context_line":"        self.assertIsNotNone(re.match(cred_format, auth))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def test_create_export(self):"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        jdssd, ctx \u003d self.get_driver(CONFIG_OK)"},{"line_number":1220,"context_line":"        vol \u003d fake_volume.fake_volume_obj(ctx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"81c0d007_4cdf4934","line":1217,"updated":"2021-08-31 14:37:24.000000000","message":"Please update the function name.","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"6ceab903ab85e54dc3df1b36c0f1b39670501d67","unresolved":true,"context_lines":[{"line_number":1214,"context_line":"            pass_len\u003d16)"},{"line_number":1215,"context_line":"        self.assertIsNotNone(re.match(cred_format, auth))"},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"    def test_create_export(self):"},{"line_number":1218,"context_line":""},{"line_number":1219,"context_line":"        jdssd, ctx \u003d self.get_driver(CONFIG_OK)"},{"line_number":1220,"context_line":"        vol \u003d fake_volume.fake_volume_obj(ctx)"}],"source_content_type":"text/x-python","patch_set":5,"id":"b7074279_b036a7ff","line":1217,"in_reply_to":"81c0d007_4cdf4934","updated":"2021-08-31 16:50:33.000000000","message":"hm, since it is a test for create_export function and \ncreate_export under the hood uses _ensure_export I think namin is correct.\n\nOr Im missing something? Can you please give more details?","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"}],"cinder/volume/drivers/open_e/iscsi.py":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"36e76120c144556d71c596b81905cd0707666f35","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@interface.volumedriver"},{"line_number":38,"context_line":"class JovianISCSIDriver(driver.ISCSIDriver):"},{"line_number":39,"context_line":"    \"\"\"Executes volume driver commands on Open-E JovianDSS."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Version history:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"2322e9f1_f30fd294","line":39,"updated":"2021-08-26 16:40:15.000000000","message":"I recommend you to remove these naming chances from your patch since they aren\u0027t related to the bug itself and it is going to be more difficult to get a approval to backport this later.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"1209430e1d1e861461ae5767f97b7bb201f1205a","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@interface.volumedriver"},{"line_number":38,"context_line":"class JovianISCSIDriver(driver.ISCSIDriver):"},{"line_number":39,"context_line":"    \"\"\"Executes volume driver commands on Open-E JovianDSS."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Version history:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bdafb6db_b6ad8a16","line":39,"in_reply_to":"2322e9f1_f30fd294","updated":"2021-08-26 18:19:23.000000000","message":"Yes, I understand. But if it is possible may be this can pass to backport.\nAs this naming is incorect for the product. And represent \u0027fixing\u0027 of documentation typo.\nAnd should not affect operation.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"96b31e2ed32362e1a539d7d4d3c67b02e7b0d92b","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        backend_name \u003d None"},{"line_number":71,"context_line":"        if self.configuration:"},{"line_number":72,"context_line":"            backend_name \u003d self.configuration.get(\u0027volume_backend_name\u0027,"},{"line_number":73,"context_line":"                                                  \u0027Open-EJovianDSS\u0027)"},{"line_number":74,"context_line":"        if not backend_name:"},{"line_number":75,"context_line":"            backend_name \u003d self.__class__.__name__"},{"line_number":76,"context_line":"        return backend_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"355db2f6_502af5eb","line":73,"updated":"2021-08-26 17:24:21.000000000","message":"Changing the default backend_name from JovianDSS may impact users that upgrade their clouds to this version as they can have volume types expecting the old name convention. I would recommend  to make sure if this is really necessary, since product still have the same name.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"7440933dd3ad9a2a9c53f3701afde36049b8426e","unresolved":true,"context_lines":[{"line_number":70,"context_line":"        backend_name \u003d None"},{"line_number":71,"context_line":"        if self.configuration:"},{"line_number":72,"context_line":"            backend_name \u003d self.configuration.get(\u0027volume_backend_name\u0027,"},{"line_number":73,"context_line":"                                                  \u0027Open-EJovianDSS\u0027)"},{"line_number":74,"context_line":"        if not backend_name:"},{"line_number":75,"context_line":"            backend_name \u003d self.__class__.__name__"},{"line_number":76,"context_line":"        return backend_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"4999289c_be8df34b","line":73,"updated":"2021-08-26 17:08:05.000000000","message":"Is this related to bug https://bugs.launchpad.net/cinder/+bug/1941746? If not I recommend to remove this change to make it suitable for backports.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":22312,"name":"Andrei","email":"andrei.perepiolkin@open-e.com","username":"andrei.perepiolkin"},"change_message_id":"1209430e1d1e861461ae5767f97b7bb201f1205a","unresolved":false,"context_lines":[{"line_number":70,"context_line":"        backend_name \u003d None"},{"line_number":71,"context_line":"        if self.configuration:"},{"line_number":72,"context_line":"            backend_name \u003d self.configuration.get(\u0027volume_backend_name\u0027,"},{"line_number":73,"context_line":"                                                  \u0027Open-EJovianDSS\u0027)"},{"line_number":74,"context_line":"        if not backend_name:"},{"line_number":75,"context_line":"            backend_name \u003d self.__class__.__name__"},{"line_number":76,"context_line":"        return backend_name"}],"source_content_type":"text/x-python","patch_set":1,"id":"51f1ef86_f4029f19","line":73,"in_reply_to":"355db2f6_502af5eb","updated":"2021-08-26 18:19:23.000000000","message":"Yes, will change it in through other patch.","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"53abd40dd0bb754b8ccdd7a9726bce50f4b7caaa","unresolved":true,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"@interface.volumedriver"},{"line_number":38,"context_line":"class JovianISCSIDriver(driver.ISCSIDriver):"},{"line_number":39,"context_line":"    \"\"\"Executes volume driver commands on Open-E JovianDSS."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    Version history:"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d0df12a3_a1d8bbfb","line":39,"updated":"2021-09-02 14:45:35.000000000","message":"Why don\u0027t you move this to your naming and code style changes patch? I know this is a bit annoying but it is very important and a community standard to keep patch cohesion.\nhttps://review.opendev.org/c/openstack/cinder/+/806559/5/cinder/volume/drivers/open_e/iscsi.py","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"da5f3661aaf153ccea36ccedfdcff25ce6ad77c5","unresolved":true,"context_lines":[{"line_number":44,"context_line":""},{"line_number":45,"context_line":"        1.0.0 - Open-E JovianDSS driver with basic functionality"},{"line_number":46,"context_line":"        1.0.1 - Added certificate support"},{"line_number":47,"context_line":"                Added revert to snapshot support"},{"line_number":48,"context_line":"    \"\"\""},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"    # ThirdPartySystems wiki page"}],"source_content_type":"text/x-python","patch_set":5,"id":"1575714a_c4380197","line":47,"updated":"2021-09-02 14:53:50.000000000","message":"This fix might worth a bump in your history since it has a reno.","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"53abd40dd0bb754b8ccdd7a9726bce50f4b7caaa","unresolved":true,"context_lines":[{"line_number":52,"context_line":"    VERSION \u003d \"1.0.1\""},{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def __init__(self, *args, **kwargs):"},{"line_number":55,"context_line":"        super().__init__(*args, **kwargs)"},{"line_number":56,"context_line":""},{"line_number":57,"context_line":"        self._stats \u003d None"},{"line_number":58,"context_line":"        self.jovian_iscsi_target_portal_port \u003d \"3260\""}],"source_content_type":"text/x-python","patch_set":5,"id":"331b7ca0_2b340bd6","line":55,"updated":"2021-09-02 14:45:35.000000000","message":"This was already changed in patch https://review.opendev.org/c/openstack/cinder/+/806559/5/cinder/volume/drivers/open_e/iscsi.py\n\nI believe the other patch is the correct place to make the change since it clearly states the purpose of the patch is to make changes to naming and code style issues. The main goal of this patch should be fixing the iscsi target recovery function and this will make much easier for you to backport it later.","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"53abd40dd0bb754b8ccdd7a9726bce50f4b7caaa","unresolved":true,"context_lines":[{"line_number":400,"context_line":"        try:"},{"line_number":401,"context_line":"            self.ra.extend_lun(jcom.vname(volume.id),"},{"line_number":402,"context_line":"                               new_size * o_units.Gi)"},{"line_number":403,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":404,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":405,"context_line":"                (_(\u0027Failed to extend volume %s.\u0027), volume.id)) from jerr"},{"line_number":406,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"e6ed1308_92a1d125","line":403,"updated":"2021-09-02 14:45:35.000000000","message":"Is this change related to fix: \"fix iscsi target recovery function\"? If not, this is also something you could move to patch https://review.opendev.org/c/openstack/cinder/+/806559/5/cinder/volume/drivers/open_e/iscsi.py","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"53abd40dd0bb754b8ccdd7a9726bce50f4b7caaa","unresolved":true,"context_lines":[{"line_number":402,"context_line":"                               new_size * o_units.Gi)"},{"line_number":403,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":404,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":405,"context_line":"                (_(\u0027Failed to extend volume %s.\u0027), volume.id)) from jerr"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def revert_to_snapshot(self, context, volume, snapshot):"},{"line_number":408,"context_line":"        \"\"\"Revert volume to snapshot."}],"source_content_type":"text/x-python","patch_set":5,"id":"f5824448_72510bcc","line":405,"updated":"2021-09-02 14:45:35.000000000","message":"same","commit_id":"35c023a38fd8805308d26bd4f2d17f7f966145cd"}],"releasenotes/notes/fix-ensure-export-3cccf107a82b35a0.yaml":[{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"36e76120c144556d71c596b81905cd0707666f35","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1941746 \u003chttps://bugs.launchpad.net/cinder/+bug/1941746\u003e`_: Fixed"},{"line_number":5,"context_line":"    Fix ensure_export function failure in case of partial target recovery."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"3c8cb916_4d4de712","line":4,"updated":"2021-08-26 16:40:15.000000000","message":"Since this is a driver-specific error, you should mention the driver name before the bug, see this doc for reference: https://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"aae7e2107843151eaf30c85369f116e849a0a5a0"}]}