)]}'
{"cinder/volume/drivers/open_e/iscsi.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0718714b81e68f298c672dd98c185d97897318b2","unresolved":true,"context_lines":[{"line_number":171,"context_line":"        rename \u003d {\u0027name\u0027: jcom.hidden(vname)}"},{"line_number":172,"context_line":"        try:"},{"line_number":173,"context_line":"            self.ra.modify_lun(vname, rename)"},{"line_number":174,"context_line":"        except jexc.JDSSException as err:"},{"line_number":175,"context_line":"            emsg \u003d _(\u0027Failure in hidding %(object)s, err: %(error)s,\u0027"},{"line_number":176,"context_line":"                     \u0027 object have to be removed manually\u0027) % {\u0027object\u0027: vname,"},{"line_number":177,"context_line":"                                                               \u0027error\u0027: err}"}],"source_content_type":"text/x-python","patch_set":3,"id":"6e84a3a1_52d505fb","line":174,"updated":"2021-08-31 05:33:34.000000000","message":"Small suggestion: To maintain consistency, all JDSSException can be named as \u0027jerr\u0027; like in lines 223, 389, etc","commit_id":"7ce5e47f9266fa81ea43478acca0fb9eb6ca597f"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0718714b81e68f298c672dd98c185d97897318b2","unresolved":true,"context_lines":[{"line_number":495,"context_line":"                                        recursively_dependents\u003dTrue,"},{"line_number":496,"context_line":"                                        force_umount\u003dTrue)"},{"line_number":497,"context_line":"            except jexc.JDSSException as terr:"},{"line_number":498,"context_line":"                LOG.warning(\"Because of %s phisical snapshot %s of volume\""},{"line_number":499,"context_line":"                            \" %s have to be removed manually\","},{"line_number":500,"context_line":"                            terr,"},{"line_number":501,"context_line":"                            coname,"}],"source_content_type":"text/x-python","patch_set":3,"id":"5046aa89_b2634476","line":498,"range":{"start_line":498,"start_character":43,"end_line":498,"end_character":51},"updated":"2021-08-31 05:33:34.000000000","message":"typo: physical","commit_id":"7ce5e47f9266fa81ea43478acca0fb9eb6ca597f"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0718714b81e68f298c672dd98c185d97897318b2","unresolved":true,"context_lines":[{"line_number":542,"context_line":"            try:"},{"line_number":543,"context_line":"                self._delete_back_recursively(cvname, cvname)"},{"line_number":544,"context_line":"            except exception.VolumeBackendAPIException as err:"},{"line_number":545,"context_line":"                LOG.warning(\"Because of %s phisical snapshot %s of volume\""},{"line_number":546,"context_line":"                            \" %s have to be removed manually\","},{"line_number":547,"context_line":"                            err,"},{"line_number":548,"context_line":"                            cvname,"}],"source_content_type":"text/x-python","patch_set":3,"id":"4ba6c3ff_9c8247b4","line":545,"range":{"start_line":545,"start_character":43,"end_line":545,"end_character":51},"updated":"2021-08-31 05:33:34.000000000","message":"same as line 498","commit_id":"7ce5e47f9266fa81ea43478acca0fb9eb6ca597f"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"233f87a737b96ba46c95ad7bcdd33ae2d08a9393","unresolved":true,"context_lines":[{"line_number":317,"context_line":""},{"line_number":318,"context_line":"        Checks if source volume for this snapshot is hidden:"},{"line_number":319,"context_line":"        If it is hidden and have no other descenents, it calls itself on its"},{"line_number":320,"context_line":"            source snapshot if such exists, or deletes it"},{"line_number":321,"context_line":"        If it is not hidden, trigers delete for snapshot"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        :param ovname: origin physical volume name"}],"source_content_type":"text/x-python","patch_set":4,"id":"73f952ea_683933d3","line":320,"updated":"2021-08-31 09:14:58.000000000","message":"nit.  Is there a reason for the indent?","commit_id":"0feffdc670c033164f3d00d556b30e7a2aaf5976"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"233f87a737b96ba46c95ad7bcdd33ae2d08a9393","unresolved":true,"context_lines":[{"line_number":321,"context_line":"        If it is not hidden, trigers delete for snapshot"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"        :param ovname: origin physical volume name"},{"line_number":324,"context_line":"        :param osname: origin physical snapshot name"},{"line_number":325,"context_line":"        \"\"\""},{"line_number":326,"context_line":""},{"line_number":327,"context_line":"        if jcom.is_hidden(opvname):"}],"source_content_type":"text/x-python","patch_set":4,"id":"2c27013c_24cd0acc","line":324,"updated":"2021-08-31 09:14:58.000000000","message":"Should this be\n:param opvname:\n:param opsname:","commit_id":"0feffdc670c033164f3d00d556b30e7a2aaf5976"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"233f87a737b96ba46c95ad7bcdd33ae2d08a9393","unresolved":true,"context_lines":[{"line_number":933,"context_line":"                                     \u0027err\u0027: jerrrnf.args[0]})"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":936,"context_line":"            LOG.debug(\u0027Failed to Terminate_connection for target %(targ)s\u0027"},{"line_number":937,"context_line":"                      \u0027because of: %(err)s\u0027, {"},{"line_number":938,"context_line":"                          \u0027targ\u0027: target_name,"},{"line_number":939,"context_line":"                          \u0027err\u0027: jerr.args[0]})"}],"source_content_type":"text/x-python","patch_set":4,"id":"0f2fe1d8_b277aad7","line":936,"updated":"2021-08-31 09:14:58.000000000","message":"nit. Needs a space after %(targ)s","commit_id":"0feffdc670c033164f3d00d556b30e7a2aaf5976"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0901a248d98a5d8cd49d5c495843f4cbcf75326a","unresolved":true,"context_lines":[{"line_number":150,"context_line":"                               sparse\u003dself.jovian_sparse,"},{"line_number":151,"context_line":"                               block_size\u003dself.block_size)"},{"line_number":152,"context_line":""},{"line_number":153,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":154,"context_line":"            LOG.error(\"Create volume error. Because %(err)s\","},{"line_number":155,"context_line":"                      {\"err\": jerr})"},{"line_number":156,"context_line":"            raise exception.VolumeBackendAPIException("}],"source_content_type":"text/x-python","patch_set":5,"id":"d3d34eb2_ac94265e","line":153,"range":{"start_line":153,"start_character":37,"end_line":153,"end_character":41},"updated":"2021-09-01 14:50:29.000000000","message":"nice error-style-naming","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"0901a248d98a5d8cd49d5c495843f4cbcf75326a","unresolved":true,"context_lines":[{"line_number":154,"context_line":"            LOG.error(\"Create volume error. Because %(err)s\","},{"line_number":155,"context_line":"                      {\"err\": jerr})"},{"line_number":156,"context_line":"            raise exception.VolumeBackendAPIException("},{"line_number":157,"context_line":"                _(\u0027Failed to create volume %s.\u0027) % volume.id) from jerr"},{"line_number":158,"context_line":"        ret \u003d {}"},{"line_number":159,"context_line":"        if provider_auth is not None:"},{"line_number":160,"context_line":"            ret[\u0027provider_auth\u0027] \u003d provider_auth"}],"source_content_type":"text/x-python","patch_set":5,"id":"75084649_d628e0f9","line":157,"range":{"start_line":157,"start_character":62,"end_line":157,"end_character":71},"updated":"2021-09-01 14:50:29.000000000","message":"cool, first time I review a patch with this.","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3256015f45c85b4329c0788a213639f838606820","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        try:"},{"line_number":173,"context_line":"            self.ra.modify_lun(vname, rename)"},{"line_number":174,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":175,"context_line":"            emsg \u003d _(\u0027Failure in hidding %(object)s, err: %(error)s,\u0027"},{"line_number":176,"context_line":"                     \u0027 object have to be removed manually\u0027) % {\u0027object\u0027: vname,"},{"line_number":177,"context_line":"                                                               \u0027error\u0027: jerr}"},{"line_number":178,"context_line":"            LOG.warning(emsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"ce860d8d_dea5ef63","line":175,"range":{"start_line":175,"start_character":33,"end_line":175,"end_character":40},"updated":"2021-09-02 23:36:46.000000000","message":"hiding","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3256015f45c85b4329c0788a213639f838606820","unresolved":true,"context_lines":[{"line_number":173,"context_line":"            self.ra.modify_lun(vname, rename)"},{"line_number":174,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":175,"context_line":"            emsg \u003d _(\u0027Failure in hidding %(object)s, err: %(error)s,\u0027"},{"line_number":176,"context_line":"                     \u0027 object have to be removed manually\u0027) % {\u0027object\u0027: vname,"},{"line_number":177,"context_line":"                                                               \u0027error\u0027: jerr}"},{"line_number":178,"context_line":"            LOG.warning(emsg)"},{"line_number":179,"context_line":"            raise exception.VolumeBackendAPIException(emsg)"}],"source_content_type":"text/x-python","patch_set":5,"id":"9690eb3e_f4772ed6","line":176,"range":{"start_line":176,"start_character":30,"end_line":176,"end_character":34},"updated":"2021-09-02 23:36:46.000000000","message":"has","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3256015f45c85b4329c0788a213639f838606820","unresolved":true,"context_lines":[{"line_number":913,"context_line":"        try:"},{"line_number":914,"context_line":"            self.ra.detach_target_vol(target_name, jcom.vname(volume.id))"},{"line_number":915,"context_line":"        except jexc.JDSSResourceNotFoundException as jerrrnf:"},{"line_number":916,"context_line":"            LOG.debug(\u0027failed to remove resource %(t)s because of %(err)s\u0027, {"},{"line_number":917,"context_line":"                \u0027t\u0027: target_name,"},{"line_number":918,"context_line":"                \u0027err\u0027: jerrrnf.args[0]})"},{"line_number":919,"context_line":"        except jexc.JDSSException as jerr:"}],"source_content_type":"text/x-python","patch_set":5,"id":"4e1526d4_89f6a8e5","line":916,"range":{"start_line":916,"start_character":23,"end_line":916,"end_character":74},"updated":"2021-09-02 23:36:46.000000000","message":"is this the kind of thing an operator should be aware of (so it can be cleaned up manually)?  Just wondering if this should be logged at error level.","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3256015f45c85b4329c0788a213639f838606820","unresolved":true,"context_lines":[{"line_number":933,"context_line":"                                     \u0027err\u0027: jerrrnf.args[0]})"},{"line_number":934,"context_line":""},{"line_number":935,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":936,"context_line":"            LOG.debug(\u0027Failed to Terminate_connection for target %(targ)s\u0027"},{"line_number":937,"context_line":"                      \u0027because of: %(err)s \u0027, {"},{"line_number":938,"context_line":"                          \u0027targ\u0027: target_name,"},{"line_number":939,"context_line":"                          \u0027err\u0027: jerr.args[0]})"}],"source_content_type":"text/x-python","patch_set":5,"id":"508ca5d2_80abeb7c","line":936,"range":{"start_line":936,"start_character":73,"end_line":936,"end_character":74},"updated":"2021-09-02 23:36:46.000000000","message":"probably want a space before the \u0027 (same thing at line 920)","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2f6d9d2984620d5c129f9bfd6571db4404399066","unresolved":false,"context_lines":[{"line_number":174,"context_line":"        except jexc.JDSSException as jerr:"},{"line_number":175,"context_line":"            emsg \u003d _(\u0027Failure in hiding %(object)s, err: %(error)s,\u0027"},{"line_number":176,"context_line":"                     \u0027 object has to be removed manually\u0027) % {\u0027object\u0027: vname,"},{"line_number":177,"context_line":"                                                               \u0027error\u0027: jerr}"},{"line_number":178,"context_line":"            LOG.warning(emsg)"},{"line_number":179,"context_line":"            raise exception.VolumeBackendAPIException(emsg)"},{"line_number":180,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"48e91ef6_fe4f3d88","line":177,"updated":"2021-09-03 15:06:01.000000000","message":"Just need to remove one space on line 177 to move \u0027error\u0027 to the left 1 column.","commit_id":"e5ce08f448d0b10e5ee547f3cb306badf859bc2b"}],"cinder/volume/drivers/open_e/jovian_common/rest.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0718714b81e68f298c672dd98c185d97897318b2","unresolved":true,"context_lines":[{"line_number":14,"context_line":"#    under the License."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"\"\"\"REST cmd interoperation class for JovianDSS driver.\"\"\""},{"line_number":18,"context_line":"import re"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"from oslo_log import log as logging"}],"source_content_type":"text/x-python","patch_set":3,"id":"3b6a0e5b_cc2151b9","line":17,"range":{"start_line":17,"start_character":37,"end_line":17,"end_character":46},"updated":"2021-08-31 05:33:34.000000000","message":"nit: Open-E JovianDSS","commit_id":"7ce5e47f9266fa81ea43478acca0fb9eb6ca597f"}],"doc/source/configuration/block-storage/drivers/open-e-joviandss-driver.rst":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0718714b81e68f298c672dd98c185d97897318b2","unresolved":true,"context_lines":[{"line_number":177,"context_line":"::"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    [open-e-jdss-2]"},{"line_number":180,"context_line":"    backend_name \u003d jdss-2"},{"line_number":181,"context_line":"    chap_password_len \u003d 14"},{"line_number":182,"context_line":"    driver_use_ssl \u003d True"},{"line_number":183,"context_line":"    driver_ssl_cert_verify \u003d False"}],"source_content_type":"text/x-rst","patch_set":3,"id":"9729afd2_433abfc3","line":180,"updated":"2021-08-31 05:33:34.000000000","message":"backend_name \u003d open-e-jdss-2","commit_id":"7ce5e47f9266fa81ea43478acca0fb9eb6ca597f"}],"releasenotes/notes/bp-jdss-add-cert-and-snapshot-revert-b34f352754ad07de.yaml":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b4590af61883e10fecc28bac1305ecf215772060","unresolved":true,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added support of authenticity verification through self-signed certificates"},{"line_number":5,"context_line":"    for Open-E JovianDSS data storage."},{"line_number":6,"context_line":"    Added support of revert to snapshot functionality."},{"line_number":7,"context_line":"    Expands unit-test coverage for Open-E JovianDSS driver."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"fa400890_941cd8b8","line":5,"updated":"2021-09-01 14:51:31.000000000","message":"I think you have a comment somewhere in the release notes about the actual name change occurring, not just changing all reference to the old name","commit_id":"99ea770daa9c187542a4e3c1ba612eef3dffab44"}],"releasenotes/notes/open-e-fix-code-style-62dbe02b10864afa.yaml":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"9520466e088e5c63d4855dab3479bd77f13113ce","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Code style and product name changes for Open-E JovinDSS driver"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"a163cc15_90b4cf9f","line":2,"updated":"2021-08-30 14:42:03.000000000","message":"Please drop this release note. The changes in this patch are internal details that do not have an impact on the end user, so there is no need to call them out in the release notes.","commit_id":"1f5c12df0d6d5a0ebfbe42f58fa3de493b4c70b1"}]}