)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"900166c2f473899f0bdf8edb592ef86b3ee8e101","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1adfac47_d1760314","updated":"2022-03-03 08:26:44.000000000","message":"recheck","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"67ab6c8fb043e89939606442571d2b7d00bfff86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"57a2b3a1_9ed2ac86","updated":"2022-06-17 08:53:03.000000000","message":"recheck","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"86b492f7763ddf9b2af1de70f62804ab9482a1fa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"73f6d61a_0bb0e49c","updated":"2022-06-21 09:16:16.000000000","message":"recheck","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"9c95d762ccc905d029980ad35bace686f064e332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"c567dd82_088b230a","updated":"2022-06-21 15:53:21.000000000","message":"run Pure Storage CI","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"8bf6da75ca3d87403f6aa9b3f6cf0079c164e3f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"96640846_9e87829f","updated":"2022-06-16 12:41:57.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1ef303b7cbbd0be5ee5a464ea53f43b6917b1b85","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9f33a0f6_5b6547c2","updated":"2022-06-15 09:18:50.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b59c9bcb3de8717d7b27ec1908d322e6b91fcac0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"563d983b_12e1703b","updated":"2022-08-26 06:04:51.000000000","message":"Code and UT look good. DellEMC_PowerFlex_CI and Zuul have passed.\n\nHowever, need to update bug number [mentioned in release notes].\n\n","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"6eb3dbe1e6325ba87c79142a9aee3dcd4f2e7875","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e91f414d_46504217","updated":"2022-08-05 09:37:09.000000000","message":"LGTM! zuul and CI pass","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"7c0174a1547a8f052a9b231f483571e0d0a4d841","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"83741380_3f0b0b1b","updated":"2022-08-11 14:00:33.000000000","message":"Looks good","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"594be6615e46e3936f10ae665d4a9fe364e83f29","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d2729f53_a0fee782","updated":"2022-07-06 16:03:46.000000000","message":"done","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":34988,"name":"Andrey Pakhomov","email":"a.pakhomov@dell.com"},"change_message_id":"cf048c5365993add8b62a77ba09a1c32fea60861","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"2e3bdbbc_704d9e5d","updated":"2022-07-12 12:06:09.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5af2a0bf0ee0afcd05c8f271fd79568137706655","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"493091e4_c7060ac2","in_reply_to":"563d983b_12e1703b","updated":"2022-08-26 06:55:01.000000000","message":"Typo fixed, thanks.","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"409084af63e9216f041dd8ceb0897226d58808ba","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"07b734f1_045dfe6e","in_reply_to":"e91f414d_46504217","updated":"2022-08-05 09:41:10.000000000","message":"driver version 1.2.1 is correct","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"cd759cee368321823e9c6482fb7834a055813e38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"18f041dc_1bdfa964","updated":"2022-09-15 18:13:09.000000000","message":"Code and tests look correct to fix the bug.","commit_id":"05de32ece711eb101041efd153852121cb2e5fd8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4f1da6f32560db837827eb0a08dab7c88b6f77e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ff7679af_4f6e1546","updated":"2022-09-05 10:11:21.000000000","message":"Confirmed the behavior with our image cache code[1]. LGTM.\n\n[1] https://github.com/openstack/cinder/blob/f0dded4d8ed0e47ecd75ffe800824e709a80f0d4/cinder/volume/flows/manager/create_volume.py#L847-L854","commit_id":"05de32ece711eb101041efd153852121cb2e5fd8"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3b436f27cd8c870e85e73a51f0b440335a8a3ea0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a98631f5_e49950ab","updated":"2022-08-26 09:16:15.000000000","message":"Thanks","commit_id":"05de32ece711eb101041efd153852121cb2e5fd8"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"f38f03ce9c5cdff269ea833d7fed5568476b43b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2c27cdcb_40d863b4","updated":"2022-09-15 14:08:20.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"05de32ece711eb101041efd153852121cb2e5fd8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ed3d041fff4fc02513f203787c98bb4c630cd50f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"bc06691c_b80cd948","updated":"2022-09-15 13:23:27.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"05de32ece711eb101041efd153852121cb2e5fd8"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"1fe87aadcb776425a773c20e0abf01c046cb7337","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d0ce1ffd_6e19a65c","updated":"2022-09-14 12:22:08.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"05de32ece711eb101041efd153852121cb2e5fd8"}],"cinder/tests/unit/volume/drivers/dell_emc/powerflex/__init__.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ede46b08626095f48ddb22bd44674a2dcd0643e","unresolved":true,"context_lines":[{"line_number":68,"context_line":"        Valid\u003d\u00270\u0027,"},{"line_number":69,"context_line":"        Invalid\u003d\u00271\u0027,"},{"line_number":70,"context_line":"        BadStatus\u003d\u00272\u0027,"},{"line_number":71,"context_line":"        BadStatusWithDetails\u003d\u00273\u0027,"},{"line_number":72,"context_line":"        ValidVariant\u003d\u00274\u0027,"},{"line_number":73,"context_line":"    ))"},{"line_number":74,"context_line":"    __RESPONSE_MODE_NAMES \u003d {"},{"line_number":75,"context_line":"        \u00270\u0027: \u0027Valid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"c5456728_be81aa00","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":25},"updated":"2022-07-06 15:41:07.000000000","message":"I don\u0027t know the implications, but this looks wrong to me...  You are changing the value of \"ValidVariant\" from \u00273\u0027, to \u00274\u0027.\nWhy not just add the new one as \u00274\u0027?","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"bc82c76ab5680b67f18c65f1fb733e77c6fdf070","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        Valid\u003d\u00270\u0027,"},{"line_number":69,"context_line":"        Invalid\u003d\u00271\u0027,"},{"line_number":70,"context_line":"        BadStatus\u003d\u00272\u0027,"},{"line_number":71,"context_line":"        BadStatusWithDetails\u003d\u00273\u0027,"},{"line_number":72,"context_line":"        ValidVariant\u003d\u00274\u0027,"},{"line_number":73,"context_line":"    ))"},{"line_number":74,"context_line":"    __RESPONSE_MODE_NAMES \u003d {"},{"line_number":75,"context_line":"        \u00270\u0027: \u0027Valid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"3bc02938_478b9865","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":25},"in_reply_to":"0d8e5d4b_ea6c9b58","updated":"2022-07-06 16:05:03.000000000","message":"thanks Gorka!","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"594be6615e46e3936f10ae665d4a9fe364e83f29","unresolved":false,"context_lines":[{"line_number":68,"context_line":"        Valid\u003d\u00270\u0027,"},{"line_number":69,"context_line":"        Invalid\u003d\u00271\u0027,"},{"line_number":70,"context_line":"        BadStatus\u003d\u00272\u0027,"},{"line_number":71,"context_line":"        BadStatusWithDetails\u003d\u00273\u0027,"},{"line_number":72,"context_line":"        ValidVariant\u003d\u00274\u0027,"},{"line_number":73,"context_line":"    ))"},{"line_number":74,"context_line":"    __RESPONSE_MODE_NAMES \u003d {"},{"line_number":75,"context_line":"        \u00270\u0027: \u0027Valid\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"0d8e5d4b_ea6c9b58","line":72,"range":{"start_line":71,"start_character":0,"end_line":72,"end_character":25},"in_reply_to":"c5456728_be81aa00","updated":"2022-07-06 16:03:46.000000000","message":"Done","commit_id":"4133608e15a82494a454b622e87695fe58a29444"}],"cinder/volume/drivers/dell_emc/powerflex/rest_client.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3ede46b08626095f48ddb22bd44674a2dcd0643e","unresolved":true,"context_lines":[{"line_number":35,"context_line":"VOLUME_MIGRATION_ALREADY_ON_DESTINATION_POOL_ERROR \u003d 718"},{"line_number":36,"context_line":"VOLUME_NOT_FOUND_ERROR \u003d 79"},{"line_number":37,"context_line":"OLD_VOLUME_NOT_FOUND_ERROR \u003d 78"},{"line_number":38,"context_line":"TOO_MANY_SNAPS_IN_VTREE \u003d 182"},{"line_number":39,"context_line":"ILLEGAL_SYNTAX \u003d 0"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"MAX_SNAPS_IN_VTREE \u003d 126"}],"source_content_type":"text/x-python","patch_set":4,"id":"4a1e87d4_16ef1d1f","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":23},"updated":"2022-07-06 15:41:07.000000000","message":"-1: We should be consistent with the naming. All other errors end in _ERROR\n\n TOO_MANY_SNAPS_IN_VTREE_ERROR","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"594be6615e46e3936f10ae665d4a9fe364e83f29","unresolved":false,"context_lines":[{"line_number":35,"context_line":"VOLUME_MIGRATION_ALREADY_ON_DESTINATION_POOL_ERROR \u003d 718"},{"line_number":36,"context_line":"VOLUME_NOT_FOUND_ERROR \u003d 79"},{"line_number":37,"context_line":"OLD_VOLUME_NOT_FOUND_ERROR \u003d 78"},{"line_number":38,"context_line":"TOO_MANY_SNAPS_IN_VTREE \u003d 182"},{"line_number":39,"context_line":"ILLEGAL_SYNTAX \u003d 0"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"MAX_SNAPS_IN_VTREE \u003d 126"}],"source_content_type":"text/x-python","patch_set":4,"id":"5b837648_93449ef8","line":38,"range":{"start_line":38,"start_character":0,"end_line":38,"end_character":23},"in_reply_to":"4a1e87d4_16ef1d1f","updated":"2022-07-06 16:03:46.000000000","message":"Done","commit_id":"4133608e15a82494a454b622e87695fe58a29444"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"dab7b0aa742fb631db40e92652ebd7b317473247","unresolved":true,"context_lines":[{"line_number":220,"context_line":"            # check if the volume reached snapshot limit"},{"line_number":221,"context_line":"            if (\"details\" in response and"},{"line_number":222,"context_line":"                    response[\"details\"][0][\"rc\"] \u003d\u003d TOO_MANY_SNAPS_ERROR):"},{"line_number":223,"context_line":"                raise exception.SnapshotLimitReached("},{"line_number":224,"context_line":"                    set_limit\u003dMAX_SNAPS_IN_VTREE)"},{"line_number":225,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":226,"context_line":"        return response[\"volumeIdList\"][0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"7ef63781_00045a1c","line":223,"range":{"start_line":223,"start_character":32,"end_line":223,"end_character":52},"updated":"2022-07-06 16:41:42.000000000","message":"-1: Sorry I missed it in my previous review, and I could be wrong, but who catches this to invalidate the cache?\n\nBecause it looks like this will be propagated all the way to the Cinder volume manager since there\u0027s nothing catching it in \"powerflex/driver.py\" methods (\"create_snapshot\" or \"_create_volume_from_source\").","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"74841f3ebdb33184311d8ac4bede84d1832b66af","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            # check if the volume reached snapshot limit"},{"line_number":221,"context_line":"            if (\"details\" in response and"},{"line_number":222,"context_line":"                    response[\"details\"][0][\"rc\"] \u003d\u003d TOO_MANY_SNAPS_ERROR):"},{"line_number":223,"context_line":"                raise exception.SnapshotLimitReached("},{"line_number":224,"context_line":"                    set_limit\u003dMAX_SNAPS_IN_VTREE)"},{"line_number":225,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":226,"context_line":"        return response[\"volumeIdList\"][0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"c9c72dcd_8ec9ab45","line":223,"range":{"start_line":223,"start_character":32,"end_line":223,"end_character":52},"in_reply_to":"7ef63781_00045a1c","updated":"2022-07-07 08:22:14.000000000","message":"no problem, this exception is an indicator from the driver that a new \u0027golden\u0027 volume has to be created, relevant code:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L847\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/flows/manager/create_volume.py#L949","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"c5d927d362c8539f56281baff54452b8e43fc407","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            # check if the volume reached snapshot limit"},{"line_number":221,"context_line":"            if (\"details\" in response and"},{"line_number":222,"context_line":"                    response[\"details\"][0][\"rc\"] \u003d\u003d TOO_MANY_SNAPS_ERROR):"},{"line_number":223,"context_line":"                raise exception.SnapshotLimitReached("},{"line_number":224,"context_line":"                    set_limit\u003dMAX_SNAPS_IN_VTREE)"},{"line_number":225,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":226,"context_line":"        return response[\"volumeIdList\"][0]"}],"source_content_type":"text/x-python","patch_set":6,"id":"749f0cd2_8a9c8d73","line":223,"range":{"start_line":223,"start_character":32,"end_line":223,"end_character":52},"in_reply_to":"c9c72dcd_8ec9ab45","updated":"2022-08-05 09:10:05.000000000","message":"Thank you for the detailed explanation.","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"}],"releasenotes/notes/fix-powerflex-volume-cache-da3fa1769ef78ae8.yaml":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b59c9bcb3de8717d7b27ec1908d322e6b91fcac0","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #942095"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1942095\u003e`_: Fixed Cinder"},{"line_number":6,"context_line":"    volume caching mechanism for the driver. Now the driver"},{"line_number":7,"context_line":"    correctly raises ``exception.SnapshotLimitReached`` when maximum"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"133da05c_4fa511f4","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":33},"updated":"2022-08-26 06:04:51.000000000","message":"Typo: #1942095","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"5af2a0bf0ee0afcd05c8f271fd79568137706655","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    PowerFlex driver `bug #942095"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1942095\u003e`_: Fixed Cinder"},{"line_number":6,"context_line":"    volume caching mechanism for the driver. Now the driver"},{"line_number":7,"context_line":"    correctly raises ``exception.SnapshotLimitReached`` when maximum"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"cdff7f70_3a22b930","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":33},"in_reply_to":"133da05c_4fa511f4","updated":"2022-08-26 06:55:01.000000000","message":"Done","commit_id":"c151140ec0c461fdb6fcdac80eb9294286cceb13"}]}