)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6dbecc148cd6d99f2a71e3d135091d89e5e7c59b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8a992e83_a757cf1c","updated":"2024-01-26 11:17:28.000000000","message":"Please resolve conflict and resubmit a new patchset.","commit_id":"8b9779b50f6623837468b915f18aaab6ee896bd0"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"352f116400b07a3823bc4cf7dbd5cae442471d17","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e3ade68_d69f0f4b","updated":"2024-01-24 12:17:26.000000000","message":"This looks valid as it\u0027s quite possible to create backups from a (volume) snapshot.\nSo resetting their status as well makes total sense.\n\nThis change then needs to receive the same improvements that https://review.opendev.org/c/openstack/cinder/+/886584 introduces as well.\nA deleted snapshot must not cause issues.","commit_id":"8b9779b50f6623837468b915f18aaab6ee896bd0"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"7d5b5f3e007cfe81c4e39529c5449a88987afb27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"abf1efdb_b7c81fb1","updated":"2024-01-30 06:32:50.000000000","message":"@Happystacker DONE. PTAL","commit_id":"d514d21f71c3809eaf1c5ea286540e48ce934e5a"},{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"a2d61058207146660a1cbb25a71288f6254fa327","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6903632a_43332c04","updated":"2024-03-06 04:02:38.000000000","message":"Is there a test anywhere for the case when the snapshot exists? The new test only tests the case when an exception is thrown.","commit_id":"d514d21f71c3809eaf1c5ea286540e48ce934e5a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"b239a51120d9619432fa2e37fb7d7e8118772148","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7c90d0d6_511b430a","updated":"2024-02-21 12:33:57.000000000","message":"LGTM","commit_id":"d514d21f71c3809eaf1c5ea286540e48ce934e5a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ad2f0c673aa127c1563e0ae44695b17166982072","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"65ee9997_5a2dcfaa","updated":"2024-04-12 14:24:16.000000000","message":"-1: Missing release notes","commit_id":"7befaeae0d7e11e807280913045e256ec0abe152"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"5af10c5d5acff3d434b6268df29f197e0c0075f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f8f0b625_96e477fc","updated":"2024-03-06 15:42:37.000000000","message":"I added a test for the default case of cleaning up a snapshot that is \u0027backing-up\u0027. Such a test never existed before.\n\nBTW, the return values of \u0027_create_snapshot_db_entry\u0027 vs \u0027_create_volume_db_entry\u0027 is REALLY confusing ;-)\n\n\nPTAL, so we can land this little bit of cleanup in master.","commit_id":"7befaeae0d7e11e807280913045e256ec0abe152"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"054e83c6c535b361b690d026aa5df9c4a8e54bfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d8ff0947_a749e75f","updated":"2024-03-20 14:03:50.000000000","message":"Pete, could we maybe find someone to review (+2) and merge this one?","commit_id":"7befaeae0d7e11e807280913045e256ec0abe152"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9412edc0a81af96f6b3880172d95c0f2109fff8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d4ea3dda_0c0f82c2","updated":"2024-04-12 14:43:50.000000000","message":"LGTM","commit_id":"56da614bbbd03d7ce5ba25d8eb3d5ab0a1cbc0e2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ee862f1a957fc0ac9ef4d71ae0faeb3c56335713","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9528d07c_bfdc3fe6","updated":"2024-04-12 15:02:56.000000000","message":"LGTM thanks!","commit_id":"7f819854d26f103bc6358c7a27010a60588ec7c5"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"87051b92f61a2f756119ab1f7c6c2b9dd1f77fed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c7e8839e_2dcfb848","updated":"2024-04-15 15:31:25.000000000","message":"recheck","commit_id":"7f819854d26f103bc6358c7a27010a60588ec7c5"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"4c289cce4bffc969fe38626871a73ed30b84186b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"34f4ba80_d3afca79","updated":"2024-04-13 05:21:14.000000000","message":"recheck probably slow vm ?\n\n```\n2024-04-12 16:20:38,744 99467 DEBUG    [tempest.scenario.manager] TestVolumeBackupRestore:test_volume_backup_restore begins to ping 172.24.5.156 in 120 sec and the expected result is reachable\n2024-04-12 16:22:39,023 99467 DEBUG    [tempest.lib.common.utils.test_utils] Call ping returns false in 120.000000 seconds\n```","commit_id":"7f819854d26f103bc6358c7a27010a60588ec7c5"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"baa67c91c4b75b66cfda391279e7f82c10d8a4d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"83ffe85e_fa3ec60a","updated":"2024-04-14 17:52:12.000000000","message":"recheck tempest-slow-py3","commit_id":"7f819854d26f103bc6358c7a27010a60588ec7c5"}],"cinder/backup/manager.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"ad2f0c673aa127c1563e0ae44695b17166982072","unresolved":true,"context_lines":[{"line_number":245,"context_line":"                     \u0027status %(status)s (was backing-up).\u0027,"},{"line_number":246,"context_line":"                     {\u0027snap_id\u0027: snapshot[\u0027id\u0027],"},{"line_number":247,"context_line":"                      \u0027status\u0027: fields.SnapshotStatus.AVAILABLE})"},{"line_number":248,"context_line":"            self.db.snapshot_update("},{"line_number":249,"context_line":"                ctxt,"},{"line_number":250,"context_line":"                snapshot[\u0027id\u0027],"},{"line_number":251,"context_line":"                {\u0027status\u0027: fields.SnapshotStatus.AVAILABLE})"}],"source_content_type":"text/x-python","patch_set":3,"id":"ac0e6ddb_5d9aec58","line":248,"updated":"2024-04-12 14:24:16.000000000","message":"-1: Please use the `snapshot` OVO you already got from the DB\n\n```\nsnapshot.status \u003d fields.SnapshotStatus.AVAILABLE\nsnapshot.save()\n```","commit_id":"7befaeae0d7e11e807280913045e256ec0abe152"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"baa67c91c4b75b66cfda391279e7f82c10d8a4d3","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                     \u0027status %(status)s (was backing-up).\u0027,"},{"line_number":246,"context_line":"                     {\u0027snap_id\u0027: snapshot[\u0027id\u0027],"},{"line_number":247,"context_line":"                      \u0027status\u0027: fields.SnapshotStatus.AVAILABLE})"},{"line_number":248,"context_line":"            self.db.snapshot_update("},{"line_number":249,"context_line":"                ctxt,"},{"line_number":250,"context_line":"                snapshot[\u0027id\u0027],"},{"line_number":251,"context_line":"                {\u0027status\u0027: fields.SnapshotStatus.AVAILABLE})"}],"source_content_type":"text/x-python","patch_set":3,"id":"8c6b9c61_19630714","line":248,"in_reply_to":"ac0e6ddb_5d9aec58","updated":"2024-04-14 17:52:12.000000000","message":"Acknowledged","commit_id":"7befaeae0d7e11e807280913045e256ec0abe152"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9412edc0a81af96f6b3880172d95c0f2109fff8","unresolved":false,"context_lines":[{"line_number":245,"context_line":"                     \u0027status %(status)s (was backing-up).\u0027,"},{"line_number":246,"context_line":"                     {\u0027snap_id\u0027: snapshot[\u0027id\u0027],"},{"line_number":247,"context_line":"                      \u0027status\u0027: fields.SnapshotStatus.AVAILABLE})"},{"line_number":248,"context_line":"            self.db.snapshot_update("},{"line_number":249,"context_line":"                ctxt,"},{"line_number":250,"context_line":"                snapshot[\u0027id\u0027],"},{"line_number":251,"context_line":"                {\u0027status\u0027: fields.SnapshotStatus.AVAILABLE})"}],"source_content_type":"text/x-python","patch_set":3,"id":"2832d770_05fa47db","line":248,"in_reply_to":"ac0e6ddb_5d9aec58","updated":"2024-04-12 14:43:50.000000000","message":"Done","commit_id":"7befaeae0d7e11e807280913045e256ec0abe152"}],"releasenotes/notes/bug1938488-a528893c103c03af.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9412edc0a81af96f6b3880172d95c0f2109fff8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When cleaning up a failed backup, clean up the snapshot status when the backup source is a snapshot"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"094227c5_53a28b89","line":4,"range":{"start_line":4,"start_character":102,"end_line":4,"end_character":103},"updated":"2024-04-12 14:43:50.000000000","message":"nit: full stop at the end.","commit_id":"56da614bbbd03d7ce5ba25d8eb3d5ab0a1cbc0e2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"f9412edc0a81af96f6b3880172d95c0f2109fff8","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When cleaning up a failed backup, clean up the snapshot status when the backup source is a snapshot"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"ddf5c965_88417881","line":4,"updated":"2024-04-12 14:43:50.000000000","message":"nit: should\u0027ve been in a new line after 80 chars","commit_id":"56da614bbbd03d7ce5ba25d8eb3d5ab0a1cbc0e2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ee862f1a957fc0ac9ef4d71ae0faeb3c56335713","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    When cleaning up a failed backup, clean up the snapshot status when the backup source is a snapshot"}],"source_content_type":"text/x-yaml","patch_set":4,"id":"811d1952_037cdf31","line":4,"in_reply_to":"ddf5c965_88417881","updated":"2024-04-12 15:02:56.000000000","message":"Done","commit_id":"56da614bbbd03d7ce5ba25d8eb3d5ab0a1cbc0e2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8b37062b0f6f3b107714c2303040dd9e162f0074","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    `Bug #1938488 \u003chttps://bugs.launchpad.net/cinder/+bug/1938488\u003e`_:"},{"line_number":5,"context_line":"    When cleaning up a failed backup, clean up the snapshot status when the"},{"line_number":6,"context_line":"    backup source is a snapshot"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"99ed6708_fa901757","line":6,"range":{"start_line":6,"start_character":23,"end_line":6,"end_character":31},"updated":"2024-04-12 15:02:18.000000000","message":"nit: missing EOL period.","commit_id":"7f819854d26f103bc6358c7a27010a60588ec7c5"}]}